Add support for OpenBlocks A7
cover Add support for OpenBlocks A7
Dear Marvell EBU maintainers,
The small set of patches that follow add the support for the new OpenBlocks A7 platform designed and sold by Plathome.
Best regards,
Thomas
Thomas Petazzoni (2):
ARM: kirkwood: add support for OpenBlocks A7 platform
ARM: kirkwood: enable HIGHMEM in defconfig
arch/arm/boot/dts/Makefile | 3 +- arch/arm/boot/dts/kirkwood-openblocks_a7.dts | 223 +++++++++++++++++++++++++++ arch/arm/configs/kirkwood_defconfig | 1 + 3 files changed, 226 insertions(+), 1 deletion(-) create mode 100644 arch/arm/boot/dts/kirkwood-openblocks_a7.dts
Signature · 1 line
1.8.1.2
PATCH 1/2 ARM: kirkwood: add support for OpenBlocks A7 platform
The OpenBlocks A7 board is designed and sold by PlatHome, and based on a Kirkwood 6283 Marvell SoC. It is quite similar to the OpenBlocks A6 already supported in the kernel, with the following main differences:
- The A6 uses a RTC on I2C, while the A7 uses the internal SoC RTC.
- The A6 has one Ethernet port, while the A7 has two Ethernet ports
- The A6 has only one USB port, while the A7 integrates a USB hub, which provides two front-side USB port, and an internal USB port as well.
- The A6 has 512 MB of RAM, while the A7 has 1 GB of RAM.
- Slightly different GPIOs for some functions.
--- arch/arm/boot/dts/Makefile | 3 +- arch/arm/boot/dts/kirkwood-openblocks_a7.dts | 223 +++++++++++++++++++++++++++ 2 files changed, 225 insertions(+), 1 deletion(-) create mode 100644 arch/arm/boot/dts/kirkwood-openblocks_a7.dts
arch/arm/boot/dts/Makefile +2 -1
@@ -101,7 +101,8 @@ dtb-$(CONFIG_ARCH_KIRKWOOD) += kirkwood-cloudbox.dtb \ kirkwood-topkick.dtb \ kirkwood-ts219-6281.dtb \ kirkwood-ts219-6282.dtb \ - kirkwood-openblocks_a6.dtb + kirkwood-openblocks_a6.dtb \ + kirkwood-openblocks_a7.dtb dtb-$(CONFIG_ARCH_MARCO) += marco-evb.dtb dtb-$(CONFIG_ARCH_MSM) += msm8660-surf.dtb \ msm8960-cdp.dtb
arch/arm/boot/dts/kirkwood-openblocks_a7.dts new file +223 -0
223 lines not on this page · raw message
Signature · 1 line
1.8.1.2
PATCH 1/2 ARM: kirkwood: add support for OpenBlocks A7 platform
Quoted 28 lines · Thomas Petazzoni
The OpenBlocks A7 board is designed and sold by PlatHome, and based on a Kirkwood 6283 Marvell SoC. It is quite similar to the OpenBlocks A6 already supported in the kernel, with the following main differences:
- The A6 uses a RTC on I2C, while the A7 uses the internal SoC RTC.
- The A6 has one Ethernet port, while the A7 has two Ethernet ports
- The A6 has only one USB port, while the A7 integrates a USB hub, which provides two front-side USB port, and an internal USB port as well.
- The A6 has 512 MB of RAM, while the A7 has 1 GB of RAM.
- Slightly different GPIOs for some functions.
Signed-off-by Thomas Petazzoni <[email protected]>--- arch/arm/boot/dts/Makefile | 3 +- arch/arm/boot/dts/kirkwood-openblocks_a7.dts | 223 +++++++++++++++++++++++++++ 2 files changed, 225 insertions(+), 1 deletion(-) create mode 100644 arch/arm/boot/dts/kirkwood-openblocks_a7.dtsarch/arm/boot/dts/Makefile +0
-0
arch/arm/boot/dts/Makefile dtb-$(CONFIG_ARCH_KIRKWOOD) += kirkwood-cloudbox.dtb \ · line 105
Quoted 6 lines
arch/arm/boot/dts/Makefile +2
-1@@ -101,7 +101,8 @@ dtb-$(CONFIG_ARCH_KIRKWOOD) += kirkwood-cloudbox.dtb \ kirkwood-topkick.dtb \ kirkwood-ts219-6281.dtb \ kirkwood-ts219-6282.dtb \ - kirkwood-openblocks_a6.dtb + kirkwood-openblocks_a6.dtb \ + kirkwood-openblocks_a7.dtb
Hi Thomas
Could you fix the ordering here? It is wrong to start with that the a6 is at the end. Could you move it, and add your new one, after nsa31a.
Apart from that, it looks good.
Thanks
Andrew
Quoted 235 lines
arch/arm/boot/dts/Makefile +0
-0dtb-$(CONFIG_ARCH_MARCO) += marco-evb.dtb dtb-$(CONFIG_ARCH_MSM) += msm8660-surf.dtb \ msm8960-cdp.dtbarch/arm/boot/dts/kirkwood-openblocks_a7.dts new file +223
-0@@ -0,0 +1,223 @@ +/* + * Device Tree file for OpenBlocks A7 board + * + * Copyright (C) 2013 Free Electrons + * + * Thomas Petazzoni <[email protected]> + * + * This file is licensed under the terms of the GNU General Public + * License version 2. This program is licensed "as is" without any + * warranty of any kind, whether express or implied. + */ + +/dts-v1/; + +#include "kirkwood.dtsi" +#include "kirkwood-6282.dtsi" + +/ { + model = "Plat'Home OpenBlocksA7"; + compatible = "plathome,openblocks-a7", "marvell,kirkwood-88f6283", "marvell,kirkwood"; + + memory { + device_type = "memory"; + reg = <0x00000000 0x40000000>; /* 1 GB */ + }; + + chosen { + bootargs = "console=ttyS0,115200n8 earlyprintk"; + }; + + ocp at f1000000 { + serial at 12000 { + status = "ok"; + pinctrl-0 = <&pmx_uart0>; + pinctrl-names = "default"; + }; + + serial at 12100 { + status = "ok"; + pinctrl-0 = <&pmx_uart1>; + pinctrl-names = "default"; + }; + + nand at 3000000 { + chip-delay = <25>; + status = "okay"; + pinctrl-0 = <&pmx_nand>; + pinctrl-names = "default"; + + partition at 0 { + label = "uboot"; + reg = <0x0 0x1c0000>; + }; + + partition at 90000 { + label = "env"; + reg = <0x1c0000 0x2c0000>; + }; + + partition at d4000 { + label = "test"; + reg = <0x480000 0x160000>; + }; + + partition at f4000 { + label = "conf"; + reg = <0x5e0000 0x540000>; + }; + + partition at 4f4000 { + label = "linux"; + reg = <0xb20000 0x3d40000>; + }; + + partition at 2214000 { + label = "user"; + reg = <0x4860000 0xb7a0000>; + }; + }; + + sata at 80000 { + nr-ports = <1>; + status = "okay"; + }; + + i2c at 11100 { + status = "okay"; + pinctrl-0 = <&pmx_twsi1>; + pinctrl-names = "default"; + + s24c02: s24c02 at 50 { + compatible = "24c02"; + reg = <0x50>; + }; + }; + + pinctrl: pinctrl at 10000 { + pinctrl-0 = <&pmx_dip_switches &pmx_gpio_header>; + pinctrl-names = "default"; + + pmx_uart0: pmx-uart0 { + marvell,pins = "mpp10", "mpp11", "mpp15", + "mpp16"; + marvell,function = "uart0"; + }; + + pmx_uart1: pmx-uart1 { + marvell,pins = "mpp13", "mpp14", "mpp8", + "mpp9"; + marvell,function = "uart1"; + }; + + pmx_sysrst: pmx-sysrst { + marvell,pins = "mpp6"; + marvell,function = "sysrst"; + }; + + pmx_dip_switches: pmx-dip-switches { + marvell,pins = "mpp44", "mpp45", "mpp46", "mpp47"; + marvell,function = "gpio"; + }; + + /* + * Accessible on connector J202. The MPP + * listed below are pin 1-7, pin 8 is unused, + * pin 9 is external reset input and pin 10 is + * ground. + */ + pmx_gpio_header: pmx-gpio-header { + marvell,pins = "mpp17", "mpp7", "mpp29", "mpp28", + "mpp35", "mpp34", "mpp40"; + marvell,function = "gpio"; + }; + + pmx_gpio_init: pmx-init { + marvell,pins = "mpp38"; + marvell,function = "gpio"; + }; + + pmx_usb_oc: pmx-usb-oc { + marvell,pins = "mpp39"; + marvell,function = "gpio"; + }; + + pmx_leds: pmx-leds { + marvell,pins = "mpp41", "mpp42", "mpp43"; + marvell,function = "gpio"; + }; + + pmx_ge1: pmx-ge1 { + marvell,pins = "mpp20", "mpp21", "mpp22", "mpp23", + "mpp24", "mpp25", "mpp26", "mpp27", + "mpp30", "mpp31", "mpp32", "mpp33"; + marvell,function = "ge1"; + }; + }; + }; + + gpio-leds { + compatible = "gpio-leds"; + pinctrl-0 = <&pmx_leds>; + pinctrl-names = "default"; + + led-red { + label = "obsa7:red:stat"; + gpios = <&gpio1 9 1>; + }; + + led-green { + label = "obsa7:green:stat"; + gpios = <&gpio1 10 1>; + }; + + led-yellow { + label = "obsa7:yellow:stat"; + gpios = <&gpio1 11 1>; + }; + }; + + gpio_keys { + compatible = "gpio-keys"; + pinctrl-0 = <&pmx_gpio_init>; + pinctrl-names = "default"; + #address-cells = <1>; + #size-cells = <0>; + + button at 1 { + label = "Init Button"; + linux,code = <116>; + gpios = <&gpio1 6 0>; + }; + }; +}; + +&mdio { + status = "okay"; + + ethphy0: ethernet-phy at 0 { + device_type = "ethernet-phy"; + reg = <0>; + }; + + ethphy1: ethernet-phy at 1 { + device_type = "ethernet-phy"; + reg = <1>; + }; +}; + +ð0 { + status = "okay"; + ethernet0-port at 0 { + phy-handle = <ðphy0>; + }; +}; + +ð1 { + status = "okay"; + pinctrl-0 = <&pmx_ge1>; + pinctrl-names = "default"; + ethernet1-port at 0 { + phy-handle = <ðphy1>; + }; +};Signature · 1 line
1.8.1.2
PATCH 1/2 ARM: kirkwood: add support for OpenBlocks A7 platform
In reply to Thomas PetazzoniQuoted 12 lines · Thomas Petazzoni
The OpenBlocks A7 board is designed and sold by PlatHome, and based on a Kirkwood 6283 Marvell SoC. It is quite similar to the OpenBlocks A6 already supported in the kernel, with the following main differences:
- The A6 uses a RTC on I2C, while the A7 uses the internal SoC RTC.
- The A6 has one Ethernet port, while the A7 has two Ethernet ports
- The A6 has only one USB port, while the A7 integrates a USB hub, which provides two front-side USB port, and an internal USB port as well.
Quoted 5 lines
- The A6 has 512 MB of RAM, while the A7 has 1 GB of RAM.
- Slightly different GPIOs for some functions.
Signed-off-by Thomas Petazzoni <[email protected]>
Quoted 250 lines
--- arch/arm/boot/dts/Makefile | 3 +- arch/arm/boot/dts/kirkwood-openblocks_a7.dts | 223 +++++++++++++++++++++++++++ 2 files changed, 225 insertions(+), 1 deletion(-) create mode 100644 arch/arm/boot/dts/kirkwood-openblocks_a7.dtsarch/arm/boot/dts/Makefile +2
-1@@ -101,7 +101,8 @@ dtb-$(CONFIG_ARCH_KIRKWOOD) += kirkwood-cloudbox.dtb \ kirkwood-topkick.dtb \ kirkwood-ts219-6281.dtb \ kirkwood-ts219-6282.dtb \ - kirkwood-openblocks_a6.dtb + kirkwood-openblocks_a6.dtb \ + kirkwood-openblocks_a7.dtb dtb-$(CONFIG_ARCH_MARCO) += marco-evb.dtb dtb-$(CONFIG_ARCH_MSM) += msm8660-surf.dtb \ msm8960-cdp.dtbarch/arm/boot/dts/kirkwood-openblocks_a7.dts new file +223
-0@@ -0,0 +1,223 @@ +/* + * Device Tree file for OpenBlocks A7 board + * + * Copyright (C) 2013 Free Electrons + * + * Thomas Petazzoni <[email protected]> + * + * This file is licensed under the terms of the GNU General Public + * License version 2. This program is licensed "as is" without any + * warranty of any kind, whether express or implied. + */ + +/dts-v1/; + +#include "kirkwood.dtsi" +#include "kirkwood-6282.dtsi" + +/ { + model = "Plat'Home OpenBlocksA7"; + compatible = "plathome,openblocks-a7", "marvell,kirkwood-88f6283", "marvell,kirkwood"; + + memory { + device_type = "memory"; + reg = <0x00000000 0x40000000>; /* 1 GB */ + }; + + chosen { + bootargs = "console=ttyS0,115200n8 earlyprintk"; + }; + + ocp at f1000000 { + serial at 12000 { + status = "ok"; + pinctrl-0 = <&pmx_uart0>; + pinctrl-names = "default"; + }; + + serial at 12100 { + status = "ok"; + pinctrl-0 = <&pmx_uart1>; + pinctrl-names = "default"; + }; + + nand at 3000000 { + chip-delay = <25>; + status = "okay"; + pinctrl-0 = <&pmx_nand>; + pinctrl-names = "default"; + + partition at 0 { + label = "uboot"; + reg = <0x0 0x1c0000>; + }; + + partition at 90000 { + label = "env"; + reg = <0x1c0000 0x2c0000>; + }; + + partition at d4000 { + label = "test"; + reg = <0x480000 0x160000>; + }; + + partition at f4000 { + label = "conf"; + reg = <0x5e0000 0x540000>; + }; + + partition at 4f4000 { + label = "linux"; + reg = <0xb20000 0x3d40000>; + }; + + partition at 2214000 { + label = "user"; + reg = <0x4860000 0xb7a0000>; + }; + }; + + sata at 80000 { + nr-ports = <1>; + status = "okay"; + }; + + i2c at 11100 { + status = "okay"; + pinctrl-0 = <&pmx_twsi1>; + pinctrl-names = "default"; + + s24c02: s24c02 at 50 { + compatible = "24c02"; + reg = <0x50>; + }; + }; + + pinctrl: pinctrl at 10000 { + pinctrl-0 = <&pmx_dip_switches &pmx_gpio_header>; + pinctrl-names = "default"; + + pmx_uart0: pmx-uart0 { + marvell,pins = "mpp10", "mpp11", "mpp15", + "mpp16"; + marvell,function = "uart0"; + }; + + pmx_uart1: pmx-uart1 { + marvell,pins = "mpp13", "mpp14", "mpp8", + "mpp9"; + marvell,function = "uart1"; + }; + + pmx_sysrst: pmx-sysrst { + marvell,pins = "mpp6"; + marvell,function = "sysrst"; + }; + + pmx_dip_switches: pmx-dip-switches { + marvell,pins = "mpp44", "mpp45", "mpp46", "mpp47"; + marvell,function = "gpio"; + }; + + /* + * Accessible on connector J202. The MPP + * listed below are pin 1-7, pin 8 is unused, + * pin 9 is external reset input and pin 10 is + * ground. + */ + pmx_gpio_header: pmx-gpio-header { + marvell,pins = "mpp17", "mpp7", "mpp29", "mpp28", + "mpp35", "mpp34", "mpp40"; + marvell,function = "gpio"; + }; + + pmx_gpio_init: pmx-init { + marvell,pins = "mpp38"; + marvell,function = "gpio"; + }; + + pmx_usb_oc: pmx-usb-oc { + marvell,pins = "mpp39"; + marvell,function = "gpio"; + }; + + pmx_leds: pmx-leds { + marvell,pins = "mpp41", "mpp42", "mpp43"; + marvell,function = "gpio"; + }; + + pmx_ge1: pmx-ge1 { + marvell,pins = "mpp20", "mpp21", "mpp22", "mpp23", + "mpp24", "mpp25", "mpp26", "mpp27", + "mpp30", "mpp31", "mpp32", "mpp33"; + marvell,function = "ge1"; + }; + }; + }; + + gpio-leds { + compatible = "gpio-leds"; + pinctrl-0 = <&pmx_leds>; + pinctrl-names = "default"; + + led-red { + label = "obsa7:red:stat"; + gpios = <&gpio1 9 1>; + }; + + led-green { + label = "obsa7:green:stat"; + gpios = <&gpio1 10 1>; + }; + + led-yellow { + label = "obsa7:yellow:stat"; + gpios = <&gpio1 11 1>; + }; + }; + + gpio_keys { + compatible = "gpio-keys"; + pinctrl-0 = <&pmx_gpio_init>; + pinctrl-names = "default"; + #address-cells = <1>; + #size-cells = <0>; + + button at 1 { + label = "Init Button"; + linux,code = <116>; + gpios = <&gpio1 6 0>; + }; + }; +}; + +&mdio { + status = "okay"; + + ethphy0: ethernet-phy at 0 { + device_type = "ethernet-phy"; + reg = <0>; + }; + + ethphy1: ethernet-phy at 1 { + device_type = "ethernet-phy"; + reg = <1>; + }; +}; + +ð0 { + status = "okay"; + ethernet0-port at 0 { + phy-handle = <ðphy0>; + }; +}; + +ð1 { + status = "okay"; + pinctrl-0 = <&pmx_ge1>; + pinctrl-names = "default"; + ethernet1-port at 0 { + phy-handle = <ðphy1>; + }; +};
Signature · 4 lines
Gregory Clement, Free Electrons Kernel, drivers, real-time and embedded Linux development, consulting, training and support. http://free-electrons.com
A message that is not in the archive (sent off-list or not yet received): [email protected]
acked
Gregory,
I like the idea, and if you perhaps do '[PATCH X/Y] Acked' it should make it through the filters. (they currently whitelist 'GIT PULL' and 'PATCH' subjects).
Sure would make things easier when going through the threads...
thx,
Jason.
Quoted 280 lines · Gregory CLEMENT
Quoted 12 lines · Thomas Petazzoni
The OpenBlocks A7 board is designed and sold by PlatHome, and based on a Kirkwood 6283 Marvell SoC. It is quite similar to the OpenBlocks A6 already supported in the kernel, with the following main differences:
- The A6 uses a RTC on I2C, while the A7 uses the internal SoC RTC.
- The A6 has one Ethernet port, while the A7 has two Ethernet ports
- The A6 has only one USB port, while the A7 integrates a USB hub, which provides two front-side USB port, and an internal USB port as well.
Quoted 5 lines
- The A6 has 512 MB of RAM, while the A7 has 1 GB of RAM.
- Slightly different GPIOs for some functions.
Signed-off-by Thomas Petazzoni <[email protected]>Acked-by Gregory CLEMENT <[email protected]>Quoted 250 lines
--- arch/arm/boot/dts/Makefile | 3 +- arch/arm/boot/dts/kirkwood-openblocks_a7.dts | 223 +++++++++++++++++++++++++++ 2 files changed, 225 insertions(+), 1 deletion(-) create mode 100644 arch/arm/boot/dts/kirkwood-openblocks_a7.dtsarch/arm/boot/dts/Makefile +2
-1@@ -101,7 +101,8 @@ dtb-$(CONFIG_ARCH_KIRKWOOD) += kirkwood-cloudbox.dtb \ kirkwood-topkick.dtb \ kirkwood-ts219-6281.dtb \ kirkwood-ts219-6282.dtb \ - kirkwood-openblocks_a6.dtb + kirkwood-openblocks_a6.dtb \ + kirkwood-openblocks_a7.dtb dtb-$(CONFIG_ARCH_MARCO) += marco-evb.dtb dtb-$(CONFIG_ARCH_MSM) += msm8660-surf.dtb \ msm8960-cdp.dtbarch/arm/boot/dts/kirkwood-openblocks_a7.dts new file +223
-0@@ -0,0 +1,223 @@ +/* + * Device Tree file for OpenBlocks A7 board + * + * Copyright (C) 2013 Free Electrons + * + * Thomas Petazzoni <[email protected]> + * + * This file is licensed under the terms of the GNU General Public + * License version 2. This program is licensed "as is" without any + * warranty of any kind, whether express or implied. + */ + +/dts-v1/; + +#include "kirkwood.dtsi" +#include "kirkwood-6282.dtsi" + +/ { + model = "Plat'Home OpenBlocksA7"; + compatible = "plathome,openblocks-a7", "marvell,kirkwood-88f6283", "marvell,kirkwood"; + + memory { + device_type = "memory"; + reg = <0x00000000 0x40000000>; /* 1 GB */ + }; + + chosen { + bootargs = "console=ttyS0,115200n8 earlyprintk"; + }; + + ocp at f1000000 { + serial at 12000 { + status = "ok"; + pinctrl-0 = <&pmx_uart0>; + pinctrl-names = "default"; + }; + + serial at 12100 { + status = "ok"; + pinctrl-0 = <&pmx_uart1>; + pinctrl-names = "default"; + }; + + nand at 3000000 { + chip-delay = <25>; + status = "okay"; + pinctrl-0 = <&pmx_nand>; + pinctrl-names = "default"; + + partition at 0 { + label = "uboot"; + reg = <0x0 0x1c0000>; + }; + + partition at 90000 { + label = "env"; + reg = <0x1c0000 0x2c0000>; + }; + + partition at d4000 { + label = "test"; + reg = <0x480000 0x160000>; + }; + + partition at f4000 { + label = "conf"; + reg = <0x5e0000 0x540000>; + }; + + partition at 4f4000 { + label = "linux"; + reg = <0xb20000 0x3d40000>; + }; + + partition at 2214000 { + label = "user"; + reg = <0x4860000 0xb7a0000>; + }; + }; + + sata at 80000 { + nr-ports = <1>; + status = "okay"; + }; + + i2c at 11100 { + status = "okay"; + pinctrl-0 = <&pmx_twsi1>; + pinctrl-names = "default"; + + s24c02: s24c02 at 50 { + compatible = "24c02"; + reg = <0x50>; + }; + }; + + pinctrl: pinctrl at 10000 { + pinctrl-0 = <&pmx_dip_switches &pmx_gpio_header>; + pinctrl-names = "default"; + + pmx_uart0: pmx-uart0 { + marvell,pins = "mpp10", "mpp11", "mpp15", + "mpp16"; + marvell,function = "uart0"; + }; + + pmx_uart1: pmx-uart1 { + marvell,pins = "mpp13", "mpp14", "mpp8", + "mpp9"; + marvell,function = "uart1"; + }; + + pmx_sysrst: pmx-sysrst { + marvell,pins = "mpp6"; + marvell,function = "sysrst"; + }; + + pmx_dip_switches: pmx-dip-switches { + marvell,pins = "mpp44", "mpp45", "mpp46", "mpp47"; + marvell,function = "gpio"; + }; + + /* + * Accessible on connector J202. The MPP + * listed below are pin 1-7, pin 8 is unused, + * pin 9 is external reset input and pin 10 is + * ground. + */ + pmx_gpio_header: pmx-gpio-header { + marvell,pins = "mpp17", "mpp7", "mpp29", "mpp28", + "mpp35", "mpp34", "mpp40"; + marvell,function = "gpio"; + }; + + pmx_gpio_init: pmx-init { + marvell,pins = "mpp38"; + marvell,function = "gpio"; + }; + + pmx_usb_oc: pmx-usb-oc { + marvell,pins = "mpp39"; + marvell,function = "gpio"; + }; + + pmx_leds: pmx-leds { + marvell,pins = "mpp41", "mpp42", "mpp43"; + marvell,function = "gpio"; + }; + + pmx_ge1: pmx-ge1 { + marvell,pins = "mpp20", "mpp21", "mpp22", "mpp23", + "mpp24", "mpp25", "mpp26", "mpp27", + "mpp30", "mpp31", "mpp32", "mpp33"; + marvell,function = "ge1"; + }; + }; + }; + + gpio-leds { + compatible = "gpio-leds"; + pinctrl-0 = <&pmx_leds>; + pinctrl-names = "default"; + + led-red { + label = "obsa7:red:stat"; + gpios = <&gpio1 9 1>; + }; + + led-green { + label = "obsa7:green:stat"; + gpios = <&gpio1 10 1>; + }; + + led-yellow { + label = "obsa7:yellow:stat"; + gpios = <&gpio1 11 1>; + }; + }; + + gpio_keys { + compatible = "gpio-keys"; + pinctrl-0 = <&pmx_gpio_init>; + pinctrl-names = "default"; + #address-cells = <1>; + #size-cells = <0>; + + button at 1 { + label = "Init Button"; + linux,code = <116>; + gpios = <&gpio1 6 0>; + }; + }; +}; + +&mdio { + status = "okay"; + + ethphy0: ethernet-phy at 0 { + device_type = "ethernet-phy"; + reg = <0>; + }; + + ethphy1: ethernet-phy at 1 { + device_type = "ethernet-phy"; + reg = <1>; + }; +}; + +ð0 { + status = "okay"; + ethernet0-port at 0 { + phy-handle = <ðphy0>; + }; +}; + +ð1 { + status = "okay"; + pinctrl-0 = <&pmx_ge1>; + pinctrl-names = "default"; + ethernet1-port at 0 { + phy-handle = <ðphy1>; + }; +};Signature · 4 lines
Gregory Clement, Free Electrons Kernel, drivers, real-time and embedded Linux development, consulting, training and support. http://free-electrons.com
acked
Quoted 7 lines · Jason Cooper
Gregory,
I like the idea, and if you perhaps do '[PATCH X/Y] Acked' it should make it through the filters. (they currently whitelist 'GIT PULL' and 'PATCH' subjects).
Sure would make things easier when going through the threads...
NAK. :)
The reason being that some mailing list archivers will break threads with a subject line change, which will detach the "acked" from the original messages.
If a patch made it though with "[PATCH" in the subject line, then a reply (though *correctly* trimmed down as per Internet Etiquette which is something people - including yourself as evidenced by the message to which I'm replying - regularly don't do) will get through without any issues.
acked
Quoted 7 lines · Russell King - ARM Linux
Quoted 6 lines · Jason Cooper
Gregory,
I like the idea, and if you perhaps do '[PATCH X/Y] Acked' it should make it through the filters. (they currently whitelist 'GIT PULL' and 'PATCH' subjects).
Quoted 7 lines
Quoted 1 line
Sure would make things easier when going through the threads...
NAK. :)
The reason being that some mailing list archivers will break threads with a subject line change, which will detach the "acked" from the original messages.
Ahhh, you're right. I completely forgot about the archives. Shame on me.
Oh well, back to writing better scripts...
thx,
Jason.
acked
In reply to Jason CooperHi Jason,
Quoted 6 lines · Jason Cooper
Gregory,
I like the idea, and if you perhaps do '[PATCH X/Y] Acked' it should make it through the filters. (they currently whitelist 'GIT PULL' and 'PATCH' subjects).
Well actually it was a mistake! I ended to use a plugin to automatically writing some pattern instead of writing it myself each time, but I mis-configured it!
I am not sure that everybody like the idea to hijack the subject of a thread, but if there a agreement on it, now I know hot to do it! ;)
Gregory
Quoted 287 lines
Sure would make things easier when going through the threads...
thx,
Jason.
Quoted 280 lines · Gregory CLEMENT
Quoted 12 lines · Thomas Petazzoni
The OpenBlocks A7 board is designed and sold by PlatHome, and based on a Kirkwood 6283 Marvell SoC. It is quite similar to the OpenBlocks A6 already supported in the kernel, with the following main differences:
- The A6 uses a RTC on I2C, while the A7 uses the internal SoC RTC.
- The A6 has one Ethernet port, while the A7 has two Ethernet ports
- The A6 has only one USB port, while the A7 integrates a USB hub, which provides two front-side USB port, and an internal USB port as well.
Quoted 5 lines
- The A6 has 512 MB of RAM, while the A7 has 1 GB of RAM.
- Slightly different GPIOs for some functions.
Signed-off-by Thomas Petazzoni <[email protected]>Acked-by Gregory CLEMENT <[email protected]>Quoted 250 lines
--- arch/arm/boot/dts/Makefile | 3 +- arch/arm/boot/dts/kirkwood-openblocks_a7.dts | 223 +++++++++++++++++++++++++++ 2 files changed, 225 insertions(+), 1 deletion(-) create mode 100644 arch/arm/boot/dts/kirkwood-openblocks_a7.dtsarch/arm/boot/dts/Makefile +2
-1@@ -101,7 +101,8 @@ dtb-$(CONFIG_ARCH_KIRKWOOD) += kirkwood-cloudbox.dtb \ kirkwood-topkick.dtb \ kirkwood-ts219-6281.dtb \ kirkwood-ts219-6282.dtb \ - kirkwood-openblocks_a6.dtb + kirkwood-openblocks_a6.dtb \ + kirkwood-openblocks_a7.dtb dtb-$(CONFIG_ARCH_MARCO) += marco-evb.dtb dtb-$(CONFIG_ARCH_MSM) += msm8660-surf.dtb \ msm8960-cdp.dtbarch/arm/boot/dts/kirkwood-openblocks_a7.dts new file +223
-0@@ -0,0 +1,223 @@ +/* + * Device Tree file for OpenBlocks A7 board + * + * Copyright (C) 2013 Free Electrons + * + * Thomas Petazzoni <[email protected]> + * + * This file is licensed under the terms of the GNU General Public + * License version 2. This program is licensed "as is" without any + * warranty of any kind, whether express or implied. + */ + +/dts-v1/; + +#include "kirkwood.dtsi" +#include "kirkwood-6282.dtsi" + +/ { + model = "Plat'Home OpenBlocksA7"; + compatible = "plathome,openblocks-a7", "marvell,kirkwood-88f6283", "marvell,kirkwood"; + + memory { + device_type = "memory"; + reg = <0x00000000 0x40000000>; /* 1 GB */ + }; + + chosen { + bootargs = "console=ttyS0,115200n8 earlyprintk"; + }; + + ocp at f1000000 { + serial at 12000 { + status = "ok"; + pinctrl-0 = <&pmx_uart0>; + pinctrl-names = "default"; + }; + + serial at 12100 { + status = "ok"; + pinctrl-0 = <&pmx_uart1>; + pinctrl-names = "default"; + }; + + nand at 3000000 { + chip-delay = <25>; + status = "okay"; + pinctrl-0 = <&pmx_nand>; + pinctrl-names = "default"; + + partition at 0 { + label = "uboot"; + reg = <0x0 0x1c0000>; + }; + + partition at 90000 { + label = "env"; + reg = <0x1c0000 0x2c0000>; + }; + + partition at d4000 { + label = "test"; + reg = <0x480000 0x160000>; + }; + + partition at f4000 { + label = "conf"; + reg = <0x5e0000 0x540000>; + }; + + partition at 4f4000 { + label = "linux"; + reg = <0xb20000 0x3d40000>; + }; + + partition at 2214000 { + label = "user"; + reg = <0x4860000 0xb7a0000>; + }; + }; + + sata at 80000 { + nr-ports = <1>; + status = "okay"; + }; + + i2c at 11100 { + status = "okay"; + pinctrl-0 = <&pmx_twsi1>; + pinctrl-names = "default"; + + s24c02: s24c02 at 50 { + compatible = "24c02"; + reg = <0x50>; + }; + }; + + pinctrl: pinctrl at 10000 { + pinctrl-0 = <&pmx_dip_switches &pmx_gpio_header>; + pinctrl-names = "default"; + + pmx_uart0: pmx-uart0 { + marvell,pins = "mpp10", "mpp11", "mpp15", + "mpp16"; + marvell,function = "uart0"; + }; + + pmx_uart1: pmx-uart1 { + marvell,pins = "mpp13", "mpp14", "mpp8", + "mpp9"; + marvell,function = "uart1"; + }; + + pmx_sysrst: pmx-sysrst { + marvell,pins = "mpp6"; + marvell,function = "sysrst"; + }; + + pmx_dip_switches: pmx-dip-switches { + marvell,pins = "mpp44", "mpp45", "mpp46", "mpp47"; + marvell,function = "gpio"; + }; + + /* + * Accessible on connector J202. The MPP + * listed below are pin 1-7, pin 8 is unused, + * pin 9 is external reset input and pin 10 is + * ground. + */ + pmx_gpio_header: pmx-gpio-header { + marvell,pins = "mpp17", "mpp7", "mpp29", "mpp28", + "mpp35", "mpp34", "mpp40"; + marvell,function = "gpio"; + }; + + pmx_gpio_init: pmx-init { + marvell,pins = "mpp38"; + marvell,function = "gpio"; + }; + + pmx_usb_oc: pmx-usb-oc { + marvell,pins = "mpp39"; + marvell,function = "gpio"; + }; + + pmx_leds: pmx-leds { + marvell,pins = "mpp41", "mpp42", "mpp43"; + marvell,function = "gpio"; + }; + + pmx_ge1: pmx-ge1 { + marvell,pins = "mpp20", "mpp21", "mpp22", "mpp23", + "mpp24", "mpp25", "mpp26", "mpp27", + "mpp30", "mpp31", "mpp32", "mpp33"; + marvell,function = "ge1"; + }; + }; + }; + + gpio-leds { + compatible = "gpio-leds"; + pinctrl-0 = <&pmx_leds>; + pinctrl-names = "default"; + + led-red { + label = "obsa7:red:stat"; + gpios = <&gpio1 9 1>; + }; + + led-green { + label = "obsa7:green:stat"; + gpios = <&gpio1 10 1>; + }; + + led-yellow { + label = "obsa7:yellow:stat"; + gpios = <&gpio1 11 1>; + }; + }; + + gpio_keys { + compatible = "gpio-keys"; + pinctrl-0 = <&pmx_gpio_init>; + pinctrl-names = "default"; + #address-cells = <1>; + #size-cells = <0>; + + button at 1 { + label = "Init Button"; + linux,code = <116>; + gpios = <&gpio1 6 0>; + }; + }; +}; + +&mdio { + status = "okay"; + + ethphy0: ethernet-phy at 0 { + device_type = "ethernet-phy"; + reg = <0>; + }; + + ethphy1: ethernet-phy at 1 { + device_type = "ethernet-phy"; + reg = <1>; + }; +}; + +ð0 { + status = "okay"; + ethernet0-port at 0 { + phy-handle = <ðphy0>; + }; +}; + +ð1 { + status = "okay"; + pinctrl-0 = <&pmx_ge1>; + pinctrl-names = "default"; + ethernet1-port at 0 { + phy-handle = <ðphy1>; + }; +};Signature · 4 lines
Gregory Clement, Free Electrons Kernel, drivers, real-time and embedded Linux development, consulting, training and support. http://free-electrons.com
Signature · 4 lines
Gregory Clement, Free Electrons Kernel, drivers, real-time and embedded Linux development, consulting, training and support. http://free-electrons.com
acked
Quoted 5 lines · Gregory CLEMENT
Hi Jason,
Quoted 2 lines · Jason Cooper
Gregory,
Quoted 8 lines
Quoted 4 lines
I like the idea, and if you perhaps do '[PATCH X/Y] Acked' it should make it through the filters. (they currently whitelist 'GIT PULL' and 'PATCH' subjects).
Well actually it was a mistake! I ended to use a plugin to automatically writing some pattern instead of writing it myself each time, but I mis-configured it!
yeah, saw that on irc after I hit send.
Quoted 2 lines
I am not sure that everybody like the idea to hijack the subject of a thread, but if there a agreement on it, now I know hot to do it! ;)
No, rmk has a very valid point. It would break most ml archiving. We don't want to do that.
thx,
Jason.
PATCH 1/2 ARM: kirkwood: add support for OpenBlocks A7 platform
In reply to Thomas PetazzoniQuoted 91 lines · Thomas Petazzoni
The OpenBlocks A7 board is designed and sold by PlatHome, and based on a Kirkwood 6283 Marvell SoC. It is quite similar to the OpenBlocks A6 already supported in the kernel, with the following main differences:
- The A6 uses a RTC on I2C, while the A7 uses the internal SoC RTC.
- The A6 has one Ethernet port, while the A7 has two Ethernet ports
- The A6 has only one USB port, while the A7 integrates a USB hub, which provides two front-side USB port, and an internal USB port as well.
- The A6 has 512 MB of RAM, while the A7 has 1 GB of RAM.
- Slightly different GPIOs for some functions.
Signed-off-by Thomas Petazzoni <[email protected]>--- arch/arm/boot/dts/Makefile | 3 +- arch/arm/boot/dts/kirkwood-openblocks_a7.dts | 223 +++++++++++++++++++++++++++ 2 files changed, 225 insertions(+), 1 deletion(-) create mode 100644 arch/arm/boot/dts/kirkwood-openblocks_a7.dtsarch/arm/boot/dts/Makefile +2
-1@@ -101,7 +101,8 @@ dtb-$(CONFIG_ARCH_KIRKWOOD) += kirkwood-cloudbox.dtb \ kirkwood-topkick.dtb \ kirkwood-ts219-6281.dtb \ kirkwood-ts219-6282.dtb \ - kirkwood-openblocks_a6.dtb + kirkwood-openblocks_a6.dtb \ + kirkwood-openblocks_a7.dtb dtb-$(CONFIG_ARCH_MARCO) += marco-evb.dtb dtb-$(CONFIG_ARCH_MSM) += msm8660-surf.dtb \ msm8960-cdp.dtbarch/arm/boot/dts/kirkwood-openblocks_a7.dts new file +48
-0@@ -0,0 +1,223 @@ +/* + * Device Tree file for OpenBlocks A7 board + * + * Copyright (C) 2013 Free Electrons + * + * Thomas Petazzoni <[email protected]> + * + * This file is licensed under the terms of the GNU General Public + * License version 2. This program is licensed "as is" without any + * warranty of any kind, whether express or implied. + */ + +/dts-v1/; + +#include "kirkwood.dtsi" +#include "kirkwood-6282.dtsi" + +/ { + model = "Plat'Home OpenBlocksA7"; + compatible = "plathome,openblocks-a7", "marvell,kirkwood-88f6283", "marvell,kirkwood"; + + memory { + device_type = "memory"; + reg = <0x00000000 0x40000000>; /* 1 GB */ + }; + + chosen { + bootargs = "console=ttyS0,115200n8 earlyprintk"; + }; + + ocp at f1000000 { + serial at 12000 { + status = "ok"; + pinctrl-0 = <&pmx_uart0>; + pinctrl-names = "default"; + }; + + serial at 12100 { + status = "ok"; + pinctrl-0 = <&pmx_uart1>; + pinctrl-names = "default"; + }; + + nand at 3000000 { + chip-delay = <25>; + status = "okay"; + pinctrl-0 = <&pmx_nand>; + pinctrl-names = "default";
arch/arm/boot/dts/kirkwood-openblocks_a7.dts line 58
Quoted 10 lines
arch/arm/boot/dts/kirkwood-openblocks_a7.dts new file +10
-0+ + partition at 0 { + label = "uboot"; + reg = <0x0 0x1c0000>; + }; + + partition at 90000 { + label = "env"; + reg = <0x1c0000 0x2c0000>; + };
Hmm, something doesn't look right here. Cut-n-paste problem? Did you run 'make dtbs' against this? I get address size errors when I do.
At any rate, I've fixed it up (new version, incorporating my fix and Andrew's requested change, below) and added it to mvebu/dt, and for-next.
let me know if it's ok with you and I'll push it tomorrow.
thx,
Jason.
----->8------------------------------------
commit 8b96b90abbf6645e0a5e4ac68515f68d405a069b
Author: Thomas Petazzoni <[email protected]> Date: Wed Oct 30 17:55:09 2013 +0100
ARM: kirkwood: add support for OpenBlocks A7 platform
The OpenBlocks A7 board is designed and sold by PlatHome, and based on a Kirkwood 6283 Marvell SoC. It is quite similar to the OpenBlocks A6 already supported in the kernel, with the following main differences:
- The A6 uses a RTC on I2C, while the A7 uses the internal SoC RTC.
- The A6 has one Ethernet port, while the A7 has two Ethernet ports
- The A6 has only one USB port, while the A7 integrates a USB hub, which provides two front-side USB port, and an internal USB port as well.
- The A6 has 512 MB of RAM, while the A7 has 1 GB of RAM.
- Slightly different GPIOs for some functions.
arch/arm/boot/dts/Makefile +3 -2
@@ -95,12 +95,13 @@ dtb-$(CONFIG_ARCH_KIRKWOOD) += kirkwood-cloudbox.dtb \ kirkwood-ns2mini.dtb \ kirkwood-nsa310.dtb \ kirkwood-nsa310a.dtb \ + kirkwood-openblocks_a6.dtb \ + kirkwood-openblocks_a7.dtb \ kirkwood-sheevaplug.dtb \ kirkwood-sheevaplug-esata.dtb \ kirkwood-topkick.dtb \ kirkwood-ts219-6281.dtb \ - kirkwood-ts219-6282.dtb \ - kirkwood-openblocks_a6.dtb + kirkwood-ts219-6282.dtb dtb-$(CONFIG_ARCH_MARCO) += marco-evb.dtb dtb-$(CONFIG_ARCH_MSM) += msm8660-surf.dtb \ msm8960-cdp.dtb
arch/arm/boot/dts/kirkwood-openblocks_a7.dts new file +223 -0
223 lines not on this page · raw message
PATCH 1/2 ARM: kirkwood: add support for OpenBlocks A7 platform
Dear Jason Cooper,
Quoted 4 lines · Jason Cooper
Quoted 4 lines
arch/arm/boot/dts/kirkwood-openblocks_a7.dts new file +4
-0+ partition at 0 { + label = "uboot"; + reg = <0x0 0x1c0000>; + };
Quoted 8 lines
arch/arm/boot/dts/kirkwood-openblocks_a7.dts line 172
Quoted 5 lines
arch/arm/boot/dts/kirkwood-openblocks_a7.dts new file +5
-0+ + partition at 90000 { + label = "env"; + reg = <0x1c0000 0x2c0000>; + };Hmm, something doesn't look right here. Cut-n-paste problem? Did you run 'make dtbs' against this? I get address size errors when I do.
Strange. 'make dtbs' was working here. What was wrong exactly? Just that the unit address (@90000) didn't match the starting address 0x1c0000 ?
Quoted 1 line
let me know if it's ok with you and I'll push it tomorrow.
This all looks good to me!
Thanks a lot,
Thomas
Signature · 3 lines
Thomas Petazzoni, CTO, Free Electrons Embedded Linux, Kernel and Android engineering http://free-electrons.com
PATCH 1/2 ARM: kirkwood: add support for OpenBlocks A7 platform
Quoted 17 lines · Thomas Petazzoni
Dear Jason Cooper,
Quoted 4 lines · Jason Cooper
Quoted 4 lines
arch/arm/boot/dts/kirkwood-openblocks_a7.dts new file +4
-0+ partition at 0 { + label = "uboot"; + reg = <0x0 0x1c0000>; + };Quoted 8 lines
arch/arm/boot/dts/kirkwood-openblocks_a7.dts line 172
Quoted 5 lines
arch/arm/boot/dts/kirkwood-openblocks_a7.dts new file +5
-0+ + partition at 90000 { + label = "env"; + reg = <0x1c0000 0x2c0000>; + };Hmm, something doesn't look right here. Cut-n-paste problem? Did you run 'make dtbs' against this? I get address size errors when I do.
Quoted 3 lines
Strange. 'make dtbs' was working here. What was wrong exactly? Just that the unit address (@90000) didn't match the starting address
0x1c0000?
The unit address has no special meaning for the device tree it's just a way to give a unique name to a node right?
So in this case it is not really a problem, but it's just nicer for the coherency of the information in the dt to have the unit address which match the starting address.
I also do a make dtbs ans I didn't get any errors:
$ make dtbs [...] DTC arch/arm/boot/dts/kirkwood-openblocks_a6.dtb DTC arch/arm/boot/dts/kirkwood-openblocks_a7.dtb
Regards,
Quoted 9 lines
Quoted 2 lines
let me know if it's ok with you and I'll push it tomorrow.
This all looks good to me!
Thanks a lot,
Thomas
Signature · 4 lines
Gregory Clement, Free Electrons Kernel, drivers, real-time and embedded Linux development, consulting, training and support. http://free-electrons.com
PATCH 1/2 ARM: kirkwood: add support for OpenBlocks A7 platform
Dear Gregory CLEMENT,
Quoted 6 lines · Gregory CLEMENT
Quoted 3 lines
Strange. 'make dtbs' was working here. What was wrong exactly? Just that the unit address (@90000) didn't match the starting address
0x1c0000?The unit address has no special meaning for the device tree it's just a way to give a unique name to a node right?
Yes, that's also my understanding.
Quoted 3 lines
So in this case it is not really a problem, but it's just nicer for the coherency of the information in the dt to have the unit address which match the starting address.
Indeed, it's much better if they match (shame on me for the silly copy/paste), but having then *not* matching should not cause any DTC error, I believe.
Quoted 5 lines
I also do a make dtbs ans I didn't get any errors:
$ make dtbs [...] DTC arch/arm/boot/dts/kirkwood-openblocks_a6.dtb DTC arch/arm/boot/dts/kirkwood-openblocks_a7.dtb
Same here.
Thomas
Signature · 3 lines
Thomas Petazzoni, CTO, Free Electrons Embedded Linux, Kernel and Android engineering http://free-electrons.com
PATCH 1/2 ARM: kirkwood: add support for OpenBlocks A7 platform
Quoted 4 lines · Thomas Petazzoni
Dear Gregory CLEMENT,
On Thu, 31 Oct 2013 10:17:43 +0100, Gregory CLEMENT wrote:
Quoted 8 lines
Quoted 6 lines
Quoted 3 lines
Strange. 'make dtbs' was working here. What was wrong exactly? Just that the unit address (@90000) didn't match the starting address
0x1c0000?The unit address has no special meaning for the device tree it's just a way to give a unique name to a node right?
Yes, that's also my understanding.
Correct, that's not what caused the error.
Quoted 8 lines
Quoted 3 lines
So in this case it is not really a problem, but it's just nicer for the coherency of the information in the dt to have the unit address which match the starting address.
Indeed, it's much better if they match (shame on me for the silly copy/paste), but having then *not* matching should not cause any DTC error, I believe.
Quoted 7 lines
Quoted 5 lines
I also do a make dtbs ans I didn't get any errors:
$ make dtbs [...] DTC arch/arm/boot/dts/kirkwood-openblocks_a6.dtb DTC arch/arm/boot/dts/kirkwood-openblocks_a7.dtbSame here.
With Thomas' original patch (on top of mvebu/dt, based on v3.12-rc1):
$ make kirkwood_defconfig $ make dtbs ... DTC arch/arm/boot/dts/kirkwood-openblocks_a6.dtb DTC arch/arm/boot/dts/kirkwood-openblocks_a7.dtb Warning (reg_format): "reg" property in /ocp at f1000000/nand at 3000000/partition at 0 has invalid length (8 bytes) (#address-cells == 2, #size-cells == 1) Warning (reg_format): "reg" property in /ocp at f1000000/nand at 3000000/partition at 90000 has invalid length (8 bytes) (#address-cells == 2, #size-cells == 1) Warning (reg_format): "reg" property in /ocp at f1000000/nand at 3000000/partition at d4000 has invalid length (8 bytes) (#address-cells == 2, #size-cells == 1) Warning (reg_format): "reg" property in /ocp at f1000000/nand at 3000000/partition at f4000 has invalid length (8 bytes) (#address-cells == 2, #size-cells == 1) Warning (reg_format): "reg" property in /ocp at f1000000/nand at 3000000/partition at 4f4000 has invalid length (8 bytes) (#address-cells == 2, #size-cells == 1) Warning (reg_format): "reg" property in /ocp at f1000000/nand at 3000000/partition at 2214000 has invalid length (8 bytes) (#address-cells == 2, #size-cells == 1) Warning (avoid_default_addr_size): Relying on default #address-cells value for /ocp at f1000000/nand at 3000000/partition at 0 Warning (avoid_default_addr_size): Relying on default #size-cells value for /ocp at f1000000/nand at 3000000/partition at 0 Warning (avoid_default_addr_size): Relying on default #address-cells value for /ocp at f1000000/nand at 3000000/partition at 90000 Warning (avoid_default_addr_size): Relying on default #size-cells value for /ocp at f1000000/nand at 3000000/partition at 90000 Warning (avoid_default_addr_size): Relying on default #address-cells value for /ocp at f1000000/nand at 3000000/partition at d4000 Warning (avoid_default_addr_size): Relying on default #size-cells value for /ocp at f1000000/nand at 3000000/partition at d4000 Warning (avoid_default_addr_size): Relying on default #address-cells value for /ocp at f1000000/nand at 3000000/partition at f4000 Warning (avoid_default_addr_size): Relying on default #size-cells value for /ocp at f1000000/nand at 3000000/partition at f4000 Warning (avoid_default_addr_size): Relying on default #address-cells value for /ocp at f1000000/nand at 3000000/partition at 4f4000 Warning (avoid_default_addr_size): Relying on default #size-cells value for /ocp at f1000000/nand at 3000000/partition at 4f4000 Warning (avoid_default_addr_size): Relying on default #address-cells value for /ocp at f1000000/nand at 3000000/partition at 2214000 Warning (avoid_default_addr_size): Relying on default #size-cells value for /ocp at f1000000/nand at 3000000/partition at 2214000
thx,
Jason.
PATCH 1/2 ARM: kirkwood: add support for OpenBlocks A7 platform
Quoted 30 lines · Jason Cooper
Quoted 4 lines · Thomas Petazzoni
Dear Gregory CLEMENT,
On Thu, 31 Oct 2013 10:17:43 +0100, Gregory CLEMENT wrote:
Quoted 8 lines
Quoted 6 lines
Quoted 3 lines
Strange. 'make dtbs' was working here. What was wrong exactly? Just that the unit address (@90000) didn't match the starting address
0x1c0000?The unit address has no special meaning for the device tree it's just a way to give a unique name to a node right?
Yes, that's also my understanding.
Correct, that's not what caused the error.
Quoted 14 lines
Quoted 3 lines
So in this case it is not really a problem, but it's just nicer for the coherency of the information in the dt to have the unit address which match the starting address.
Indeed, it's much better if they match (shame on me for the silly copy/paste), but having then *not* matching should not cause any DTC error, I believe.
Quoted 5 lines
I also do a make dtbs ans I didn't get any errors:
$ make dtbs [...] DTC arch/arm/boot/dts/kirkwood-openblocks_a6.dtb DTC arch/arm/boot/dts/kirkwood-openblocks_a7.dtb
Quoted 3 lines
Quoted 1 line
Same here.
With Thomas' original patch (on top of mvebu/dt, based on v3.12-rc1):
On my side I tested the patch on top on v3.12-rc7. So the difference should be there.
Quoted 34 lines
$ make kirkwood_defconfig $ make dtbs ... DTC arch/arm/boot/dts/kirkwood-openblocks_a6.dtb DTC arch/arm/boot/dts/kirkwood-openblocks_a7.dtb Warning (reg_format): "reg" property in /ocp at f1000000/nand at 3000000/partition at 0 has invalid length (8 bytes) (#address-cells == 2, #size-cells == 1) Warning (reg_format): "reg" property in /ocp at f1000000/nand at 3000000/partition at 90000 has invalid length (8 bytes) (#address-cells == 2, #size-cells == 1) Warning (reg_format): "reg" property in /ocp at f1000000/nand at 3000000/partition at d4000 has invalid length (8 bytes) (#address-cells == 2, #size-cells == 1) Warning (reg_format): "reg" property in /ocp at f1000000/nand at 3000000/partition at f4000 has invalid length (8 bytes) (#address-cells == 2, #size-cells == 1) Warning (reg_format): "reg" property in /ocp at f1000000/nand at 3000000/partition at 4f4000 has invalid length (8 bytes) (#address-cells == 2, #size-cells == 1) Warning (reg_format): "reg" property in /ocp at f1000000/nand at 3000000/partition at 2214000 has invalid length (8 bytes) (#address-cells == 2, #size-cells == 1) Warning (avoid_default_addr_size): Relying on default #address-cells value for /ocp at f1000000/nand at 3000000/partition at 0 Warning (avoid_default_addr_size): Relying on default #size-cells value for /ocp at f1000000/nand at 3000000/partition at 0 Warning (avoid_default_addr_size): Relying on default #address-cells value for /ocp at f1000000/nand at 3000000/partition at 90000 Warning (avoid_default_addr_size): Relying on default #size-cells value for /ocp at f1000000/nand at 3000000/partition at 90000 Warning (avoid_default_addr_size): Relying on default #address-cells value for /ocp at f1000000/nand at 3000000/partition at d4000 Warning (avoid_default_addr_size): Relying on default #size-cells value for /ocp at f1000000/nand at 3000000/partition at d4000 Warning (avoid_default_addr_size): Relying on default #address-cells value for /ocp at f1000000/nand at 3000000/partition at f4000 Warning (avoid_default_addr_size): Relying on default #size-cells value for /ocp at f1000000/nand at 3000000/partition at f4000 Warning (avoid_default_addr_size): Relying on default #address-cells value for /ocp at f1000000/nand at 3000000/partition at 4f4000 Warning (avoid_default_addr_size): Relying on default #size-cells value for /ocp at f1000000/nand at 3000000/partition at 4f4000 Warning (avoid_default_addr_size): Relying on default #address-cells value for /ocp at f1000000/nand at 3000000/partition at 2214000 Warning (avoid_default_addr_size): Relying on default #size-cells value for /ocp at f1000000/nand at 3000000/partition at 2214000thx,
Jason.
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel at lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
Signature · 4 lines
Gregory Clement, Free Electrons Kernel, drivers, real-time and embedded Linux development, consulting, training and support. http://free-electrons.com
PATCH 1/2 ARM: kirkwood: add support for OpenBlocks A7 platform
Quoted 31 lines · Gregory CLEMENT
Quoted 30 lines · Jason Cooper
Quoted 4 lines · Thomas Petazzoni
Dear Gregory CLEMENT,
On Thu, 31 Oct 2013 10:17:43 +0100, Gregory CLEMENT wrote:
Quoted 8 lines
Quoted 6 lines
Quoted 3 lines
Strange. 'make dtbs' was working here. What was wrong exactly? Just that the unit address (@90000) didn't match the starting address
0x1c0000?The unit address has no special meaning for the device tree it's just a way to give a unique name to a node right?
Yes, that's also my understanding.
Correct, that's not what caused the error.
Quoted 14 lines
Quoted 3 lines
So in this case it is not really a problem, but it's just nicer for the coherency of the information in the dt to have the unit address which match the starting address.
Indeed, it's much better if they match (shame on me for the silly copy/paste), but having then *not* matching should not cause any DTC error, I believe.
Quoted 5 lines
I also do a make dtbs ans I didn't get any errors:
$ make dtbs [...] DTC arch/arm/boot/dts/kirkwood-openblocks_a6.dtb DTC arch/arm/boot/dts/kirkwood-openblocks_a7.dtb
Quoted 6 lines
Quoted 3 lines
Quoted 1 line
Same here.
With Thomas' original patch (on top of mvebu/dt, based on v3.12-rc1):
On my side I tested the patch on top on v3.12-rc7. So the difference should be there.
Ok, I get no warnings when I rebase the original patch onto v3.12-rc7.
Since Thomas is ok with my version, I'm going to send it up since it doesn't generate warnings. There's no point merging in v3.12-rc7 just to silence a few warnings.
thx,
Jason.
Quoted 23 lines
Quoted 23 lines
$ make kirkwood_defconfig $ make dtbs ... DTC arch/arm/boot/dts/kirkwood-openblocks_a6.dtb DTC arch/arm/boot/dts/kirkwood-openblocks_a7.dtb Warning (reg_format): "reg" property in /ocp at f1000000/nand at 3000000/partition at 0 has invalid length (8 bytes) (#address-cells == 2, #size-cells == 1) Warning (reg_format): "reg" property in /ocp at f1000000/nand at 3000000/partition at 90000 has invalid length (8 bytes) (#address-cells == 2, #size-cells == 1) Warning (reg_format): "reg" property in /ocp at f1000000/nand at 3000000/partition at d4000 has invalid length (8 bytes) (#address-cells == 2, #size-cells == 1) Warning (reg_format): "reg" property in /ocp at f1000000/nand at 3000000/partition at f4000 has invalid length (8 bytes) (#address-cells == 2, #size-cells == 1) Warning (reg_format): "reg" property in /ocp at f1000000/nand at 3000000/partition at 4f4000 has invalid length (8 bytes) (#address-cells == 2, #size-cells == 1) Warning (reg_format): "reg" property in /ocp at f1000000/nand at 3000000/partition at 2214000 has invalid length (8 bytes) (#address-cells == 2, #size-cells == 1) Warning (avoid_default_addr_size): Relying on default #address-cells value for /ocp at f1000000/nand at 3000000/partition at 0 Warning (avoid_default_addr_size): Relying on default #size-cells value for /ocp at f1000000/nand at 3000000/partition at 0 Warning (avoid_default_addr_size): Relying on default #address-cells value for /ocp at f1000000/nand at 3000000/partition at 90000 Warning (avoid_default_addr_size): Relying on default #size-cells value for /ocp at f1000000/nand at 3000000/partition at 90000 Warning (avoid_default_addr_size): Relying on default #address-cells value for /ocp at f1000000/nand at 3000000/partition at d4000 Warning (avoid_default_addr_size): Relying on default #size-cells value for /ocp at f1000000/nand at 3000000/partition at d4000 Warning (avoid_default_addr_size): Relying on default #address-cells value for /ocp at f1000000/nand at 3000000/partition at f4000 Warning (avoid_default_addr_size): Relying on default #size-cells value for /ocp at f1000000/nand at 3000000/partition at f4000 Warning (avoid_default_addr_size): Relying on default #address-cells value for /ocp at f1000000/nand at 3000000/partition at 4f4000 Warning (avoid_default_addr_size): Relying on default #size-cells value for /ocp at f1000000/nand at 3000000/partition at 4f4000 Warning (avoid_default_addr_size): Relying on default #address-cells value for /ocp at f1000000/nand at 3000000/partition at 2214000 Warning (avoid_default_addr_size): Relying on default #size-cells value for /ocp at f1000000/nand at 3000000/partition at 2214000
PATCH 2/2 ARM: kirkwood: enable HIGHMEM in defconfig
In reply to Thomas PetazzoniThe Kirkwood-based OpenBlocks A7 platform has 1 GB of memory. To make use of this memory completely, enabling HIGHMEM is needed, so we enable it by default in the kirkwood_defconfig.
--- arch/arm/configs/kirkwood_defconfig | 1 + 1 file changed, 1 insertion(+)
arch/arm/configs/kirkwood_defconfig +1 -0
@@ -27,6 +27,7 @@ CONFIG_PCI_MVEBU=y CONFIG_PREEMPT=y CONFIG_AEABI=y # CONFIG_OABI_COMPAT is not set +CONFIG_HIGHMEM=y CONFIG_ZBOOT_ROM_TEXT=0x0 CONFIG_ZBOOT_ROM_BSS=0x0 CONFIG_CPU_FREQ=y
Signature · 1 line
1.8.1.2
PATCH 2/2 ARM: kirkwood: enable HIGHMEM in defconfig
Quoted 5 lines · Thomas Petazzoni
The Kirkwood-based OpenBlocks A7 platform has 1 GB of memory. To make use of this memory completely, enabling HIGHMEM is needed, so we enable it by default in the
kirkwood_defconfig.Signed-off-by Thomas Petazzoni <[email protected]>
Andrew
Quoted 19 lines
--- arch/arm/configs/kirkwood_defconfig | 1 + 1 file changed, 1 insertion(+)arch/arm/configs/kirkwood_defconfig +1
-0@@ -27,6 +27,7 @@ CONFIG_PCI_MVEBU=y CONFIG_PREEMPT=y CONFIG_AEABI=y # CONFIG_OABI_COMPAT is not set +CONFIG_HIGHMEM=y CONFIG_ZBOOT_ROM_TEXT=0x0 CONFIG_ZBOOT_ROM_BSS=0x0 CONFIG_CPU_FREQ=ySignature · 1 line
1.8.1.2
PATCH 2/2 ARM: kirkwood: enable HIGHMEM in defconfig
In reply to Thomas PetazzoniQuoted 5 lines · Thomas Petazzoni
The Kirkwood-based OpenBlocks A7 platform has 1 GB of memory. To make use of this memory completely, enabling HIGHMEM is needed, so we enable it by default in the
kirkwood_defconfig.Signed-off-by Thomas Petazzoni <[email protected]>
Quoted 17 lines
--- arch/arm/configs/kirkwood_defconfig | 1 + 1 file changed, 1 insertion(+)arch/arm/configs/kirkwood_defconfig +1
-0@@ -27,6 +27,7 @@ CONFIG_PCI_MVEBU=y CONFIG_PREEMPT=y CONFIG_AEABI=y # CONFIG_OABI_COMPAT is not set +CONFIG_HIGHMEM=y CONFIG_ZBOOT_ROM_TEXT=0x0 CONFIG_ZBOOT_ROM_BSS=0x0 CONFIG_CPU_FREQ=y
Signature · 4 lines
Gregory Clement, Free Electrons Kernel, drivers, real-time and embedded Linux development, consulting, training and support. http://free-electrons.com
Jason Cooper
AppliedPATCH 2/2 ARM: kirkwood: enable HIGHMEM in defconfig
In reply to Thomas PetazzoniQuoted 8 lines · Thomas Petazzoni
The Kirkwood-based OpenBlocks A7 platform has 1 GB of memory. To make use of this memory completely, enabling HIGHMEM is needed, so we enable it by default in the
kirkwood_defconfig.Signed-off-by Thomas Petazzoni <[email protected]>--- arch/arm/configs/kirkwood_defconfig | 1 + 1 file changed, 1 insertion(+)
Applied to mvebu-next/defconfig
thx,
Jason.