Skip to contentSkip to conversation

HACK: clk: tegra: Do not mark PLLE as fixed

PATCH In review Thierry Reding 2 participants 3 messages Oct 29, 2013 – Oct 30, 2013 2 messages not in the archive

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 HACK: clk: tegra: Do not mark PLLE as fixed

---
 drivers/clk/tegra/clk-tegra114.c | 2 --
 drivers/clk/tegra/clk-tegra124.c | 2 --
 drivers/clk/tegra/clk-tegra20.c  | 2 --
 drivers/clk/tegra/clk-tegra30.c  | 3 +--
 4 files changed, 1 insertion(+), 8 deletions(-)
drivers/clk/tegra/clk-tegra114.c +0 -2
index 624077d..8f583dc 100644
@@ -587,8 +587,6 @@ static struct tegra_clk_pll_params pll_e_params = {
 	.lock_delay = 300,
 	.div_nmp = &plle_nmp,
 	.freq_table = pll_e_freq_table,
-	.flags = TEGRA_PLL_FIXED,
-	.fixed_rate = 100000000,
 };
 
 static struct div_nmp pllre_nmp = {
drivers/clk/tegra/clk-tegra124.c +0 -2
index 266e80b..2f7361f 100644
@@ -464,8 +464,6 @@ static struct tegra_clk_pll_params pll_e_params = {
 	.lock_delay = 300,
 	.div_nmp = &plle_nmp,
 	.freq_table = pll_e_freq_table,
-	.flags = TEGRA_PLL_FIXED,
-	.fixed_rate = 100000000,
 };
 
 static const struct clk_div_table pll_re_div_table[] = {
drivers/clk/tegra/clk-tegra20.c +0 -2
index 58faac5..e4d2071 100644
@@ -427,8 +427,6 @@ static struct tegra_clk_pll_params pll_e_params = {
 	.lock_enable_bit_idx = PLLE_MISC_LOCK_ENABLE,
 	.lock_delay = 0,
 	.freq_table = pll_e_freq_table,
-	.flags = TEGRA_PLL_FIXED,
-	.fixed_rate = 100000000,
 };
 
 static struct tegra_devclk devclks[] __initdata = {
drivers/clk/tegra/clk-tegra30.c +1 -2
index 24ce357..69bf84d 100644
@@ -577,8 +577,7 @@ static struct tegra_clk_pll_params pll_e_params = {
 	.lock_enable_bit_idx = PLLE_MISC_LOCK_ENABLE,
 	.lock_delay = 300,
 	.freq_table = pll_e_freq_table,
-	.flags = TEGRA_PLLE_CONFIGURE | TEGRA_PLL_FIXED,
-	.fixed_rate = 100000000,
+	.flags = TEGRA_PLLE_CONFIGURE,
 };
 
 static unsigned long tegra30_input_freq[] = {
Signature · 1 line
1.8.4

A message that is not in the archive (sent off-list or not yet received): 1383057631-32668-1-git-send-email-treding-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org

#2 lore raw
Quoted 1 line · Thierry Reding

What does this patch solve? A description would be nice.

I thought that this PLL essentially was fixed; while it may have some registers than /can/ change the rate, hasn't the HW team only characterized it to run at the single frequency that PCIe requires, hence SW is supposed to treat it as fixed?

A message that is not in the archive (sent off-list or not yet received): [email protected]

#4 lore raw
Quoted 9 lines · Stephen Warren
Quoted 1 line · Thierry Reding

What does this patch solve? A description would be nice.

I thought that this PLL essentially was fixed; while it may have some registers than /can/ change the rate, hasn't the HW team only characterized it to run at the single frequency that PCIe requires, hence SW is supposed to treat it as fixed?

Peter fixed it up properly. As indicated by the HACK: tag, this was really only a workaround to make Dalmore boot again. PLLE didn't use to be marked as fixed, which seems to be the reason why we've never seen this.

Thierry