Skip to contentSkip to conversation

ARM: shmobile: Include all 2 GiB of memory on APE6EVM

PATCH New Magnus Damm 2 participants 8 messages Oct 31, 2013 – Nov 28, 2013

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 ARM: shmobile: Include all 2 GiB of memory on APE6EVM

From: Takashi Yoshii <[email protected]>

Add 1GiB of DRAM at 0x2_0000_0000 to support the full 2GiB of APE6EVM system memory.

---

For correct run time operation regardless of kernel configuration ARM patches 7863/1 and 7864/1 are needed.

 arch/arm/boot/dts/r8a73a4-ape6evm.dts |    5 +++++
 1 file changed, 5 insertions(+)
arch/arm/boot/dts/r8a73a4-ape6evm.dts +5 -0
@@ -24,6 +24,11 @@
 		reg = <0 0x40000000 0 0x40000000>;
 	};
 
+	memory at 200000000 {
+		device_type = "memory";
+		reg = <2 0x00000000 0 0x40000000>;
+	};
+
 	ape6evm_fixed_3v3: fixedregulator at 0 {
 		compatible = "regulator-fixed";
 		regulator-name = "3V3";
#1 lore raw

PATCH 1/1 ARM: shmobile: Include all 2 GiB of memory on APE6EVM

Quoted 11 lines · Magnus Damm

From: Takashi Yoshii <[email protected]>

Add 1GiB of DRAM at 0x2_0000_0000 to support the full 2GiB of APE6EVM system memory.

---

For correct run time operation regardless of kernel configuration ARM patches 7863/1 and 7864/1 are needed.

I take it that I should wait for those patches before applying this one.

With those two patches and this one applied on top of renesas-devel-v3.12-rc7-20131030 I was able to successfully boot an ape6evm board. But /proc/meminfo still indicates only 1Gb of memory. What am I missing.

Quoted 19 lines
 arch/arm/boot/dts/r8a73a4-ape6evm.dts |    5 +++++
 1 file changed, 5 insertions(+)
arch/arm/boot/dts/r8a73a4-ape6evm.dts +5 -0
@@ -24,6 +24,11 @@
 		reg = <0 0x40000000 0 0x40000000>;
 	};
 
+	memory at 200000000 {
+		device_type = "memory";
+		reg = <2 0x00000000 0 0x40000000>;
+	};
+
 	ape6evm_fixed_3v3: fixedregulator at 0 {
 		compatible = "regulator-fixed";
 		regulator-name = "3V3";
#2 lore raw

PATCH 1/1 ARM: shmobile: Include all 2 GiB of memory on APE6EVM

Hi Simon,

Quoted 6 lines · Simon Horman
Quoted 5 lines · Magnus Damm

From: Takashi Yoshii <[email protected]>

Add 1GiB of DRAM at 0x2_0000_0000 to support the full 2GiB of APE6EVM system memory.

Quoted 8 lines
Quoted 6 lines

---

For correct run time operation regardless of kernel configuration ARM patches 7863/1 and 7864/1 are needed.

I take it that I should wait for those patches before applying this one.

That's probably a good idea. RMK has applied them to "git-curr", so I suppose they are queued up for something at least:

http://www.arm.linux.org.uk/developer/patches/viewpatch.php?id=7863/1

Quoted 4 lines

With those two patches and this one applied on top of renesas-devel-v3.12-rc7-20131030 I was able to successfully boot an ape6evm board. But /proc/meminfo still indicates only 1Gb of memory. What am I missing.

You probably need to enable HIGHMEM and LPAE to be able to access to all memory. Same thing on Lager, to get the full 4GiB you need to select those in your kernel configuration too.

Please note that having memory located on 64-bit addresses may break some drivers doing bus mastering or using the DMAC. These drivers need to be fixed both with short term DMA zone workarounds and proper 64-bit address support whenever possible.

So if I could suggest a policy then having LPAE=n in defconfig for the C board code for default stable operation. This together with LPAE=y in the case of DT reference and/or Multiplatform where we can be a bit more experimental. I don't care enough to send defconfig patches, but if some issue comes up then perhaps adjusting the defconfig to disable LPAE may work well as a workaround.

Cheers,

/ magnus

#3 lore raw

PATCH 1/1 ARM: shmobile: Include all 2 GiB of memory on APE6EVM

Quoted 16 lines · Magnus Damm

Hi Simon,

Quoted 13 lines · Simon Horman
Quoted 11 lines · Magnus Damm

From: Takashi Yoshii <[email protected]>

Add 1GiB of DRAM at 0x2_0000_0000 to support the full 2GiB of APE6EVM system memory.

---

For correct run time operation regardless of kernel configuration ARM patches 7863/1 and 7864/1 are needed.

Quoted 6 lines
Quoted 1 line

I take it that I should wait for those patches before applying this one.

That's probably a good idea. RMK has applied them to "git-curr", so I suppose they are queued up for something at least:

http://www.arm.linux.org.uk/developer/patches/viewpatch.php?id=7863/1

I have also sighted them in linux-next.
So I expect they will show up in v3.13-rc1 or thereabouts.

Quoted 8 lines
Quoted 4 lines

With those two patches and this one applied on top of renesas-devel-v3.12-rc7-20131030 I was able to successfully boot an ape6evm board. But /proc/meminfo still indicates only 1Gb of memory. What am I missing.

You probably need to enable HIGHMEM and LPAE to be able to access to all memory. Same thing on Lager, to get the full 4GiB you need to select those in your kernel configuration too.

Thanks, I have been able to successfully test all 4 patches in this series with those settings enabled.

Quoted 11 lines

Please note that having memory located on 64-bit addresses may break some drivers doing bus mastering or using the DMAC. These drivers need to be fixed both with short term DMA zone workarounds and proper 64-bit address support whenever possible.

So if I could suggest a policy then having LPAE=n in defconfig for the C board code for default stable operation. This together with LPAE=y in the case of DT reference and/or Multiplatform where we can be a bit more experimental. I don't care enough to send defconfig patches, but if some issue comes up then perhaps adjusting the defconfig to disable LPAE may work well as a workaround.

Thanks.

As it stands the defconfig for both APE6EVM and Lager lead to a configuration with LPAE disabled, although neither explicitly disable LPAE. I think it is best to leave things as-is in this regards and explicitly disable LPAE in the defconfigs if the need arises.

While looking over this I noticed that the APE6EVM defconfig selects HIGHMEM while the Lager defconfig does not and it is not selected in the resulting config. Would it be worth updating the Lager defconfig to enable HIGHMEM? If so, I'll make a patch.

#4 lore raw

PATCH 1/1 ARM: shmobile: Include all 2 GiB of memory on APE6EVM

Hi Simon,

Quoted 60 lines · Simon Horman
Quoted 16 lines · Magnus Damm

Hi Simon,

Quoted 13 lines · Simon Horman
Quoted 11 lines · Magnus Damm

From: Takashi Yoshii <[email protected]>

Add 1GiB of DRAM at 0x2_0000_0000 to support the full 2GiB of APE6EVM system memory.

---

For correct run time operation regardless of kernel configuration ARM patches 7863/1 and 7864/1 are needed.

Quoted 6 lines
Quoted 1 line

I take it that I should wait for those patches before applying this one.

That's probably a good idea. RMK has applied them to "git-curr", so I suppose they are queued up for something at least:

http://www.arm.linux.org.uk/developer/patches/viewpatch.php?id=7863/1

I have also sighted them in linux-next.
So I expect they will show up in v3.13-rc1 or thereabouts.

Quoted 8 lines
Quoted 4 lines

With those two patches and this one applied on top of renesas-devel-v3.12-rc7-20131030 I was able to successfully boot an ape6evm board. But /proc/meminfo still indicates only 1Gb of memory. What am I missing.

You probably need to enable HIGHMEM and LPAE to be able to access to all memory. Same thing on Lager, to get the full 4GiB you need to select those in your kernel configuration too.

Thanks, I have been able to successfully test all 4 patches in this series with those settings enabled.

Quoted 11 lines

Please note that having memory located on 64-bit addresses may break some drivers doing bus mastering or using the DMAC. These drivers need to be fixed both with short term DMA zone workarounds and proper 64-bit address support whenever possible.

So if I could suggest a policy then having LPAE=n in defconfig for the C board code for default stable operation. This together with LPAE=y in the case of DT reference and/or Multiplatform where we can be a bit more experimental. I don't care enough to send defconfig patches, but if some issue comes up then perhaps adjusting the defconfig to disable LPAE may work well as a workaround.

Thanks.

As it stands the defconfig for both APE6EVM and Lager lead to a configuration with LPAE disabled, although neither explicitly disable LPAE. I think it is best to leave things as-is in this regards and explicitly disable LPAE in the defconfigs if the need arises.

Quoted 4 lines

While looking over this I noticed that the APE6EVM defconfig selects HIGHMEM while the Lager defconfig does not and it is not selected in the resulting config. Would it be worth updating the Lager defconfig to enable HIGHMEM? If so, I'll make a patch.

Thanks. I think it mainly makes sense to enable LPAE and HIGHMEM together, so easiest is probably just to wait with both Lager and APE6EVM.

Cheers,

/ magnus

#5 lore raw

PATCH 1/1 ARM: shmobile: Include all 2 GiB of memory on APE6EVM

Quoted 63 lines · Magnus Damm

Hi Simon,

Quoted 60 lines · Simon Horman
Quoted 16 lines · Magnus Damm

Hi Simon,

Quoted 13 lines · Simon Horman
Quoted 11 lines · Magnus Damm

From: Takashi Yoshii <[email protected]>

Add 1GiB of DRAM at 0x2_0000_0000 to support the full 2GiB of APE6EVM system memory.

---

For correct run time operation regardless of kernel configuration ARM patches 7863/1 and 7864/1 are needed.

Quoted 6 lines
Quoted 1 line

I take it that I should wait for those patches before applying this one.

That's probably a good idea. RMK has applied them to "git-curr", so I suppose they are queued up for something at least:

http://www.arm.linux.org.uk/developer/patches/viewpatch.php?id=7863/1

I have also sighted them in linux-next.
So I expect they will show up in v3.13-rc1 or thereabouts.

Quoted 8 lines
Quoted 4 lines

With those two patches and this one applied on top of renesas-devel-v3.12-rc7-20131030 I was able to successfully boot an ape6evm board. But /proc/meminfo still indicates only 1Gb of memory. What am I missing.

You probably need to enable HIGHMEM and LPAE to be able to access to all memory. Same thing on Lager, to get the full 4GiB you need to select those in your kernel configuration too.

Thanks, I have been able to successfully test all 4 patches in this series with those settings enabled.

Quoted 11 lines

Please note that having memory located on 64-bit addresses may break some drivers doing bus mastering or using the DMAC. These drivers need to be fixed both with short term DMA zone workarounds and proper 64-bit address support whenever possible.

So if I could suggest a policy then having LPAE=n in defconfig for the C board code for default stable operation. This together with LPAE=y in the case of DT reference and/or Multiplatform where we can be a bit more experimental. I don't care enough to send defconfig patches, but if some issue comes up then perhaps adjusting the defconfig to disable LPAE may work well as a workaround.

Thanks.

As it stands the defconfig for both APE6EVM and Lager lead to a configuration with LPAE disabled, although neither explicitly disable LPAE. I think it is best to leave things as-is in this regards and explicitly disable LPAE in the defconfigs if the need arises.

Quoted 8 lines
Quoted 4 lines

While looking over this I noticed that the APE6EVM defconfig selects HIGHMEM while the Lager defconfig does not and it is not selected in the resulting config. Would it be worth updating the Lager defconfig to enable HIGHMEM? If so, I'll make a patch.

Thanks. I think it mainly makes sense to enable LPAE and HIGHMEM together, so easiest is probably just to wait with both Lager and APE6EVM.

Sure. I will immediately do nothing :)

#6 lore raw

PATCH 1/1 ARM: shmobile: Include all 2 GiB of memory on APE6EVM

Quoted 23 lines · Simon Horman
Quoted 22 lines · Magnus Damm

Hi Simon,

Quoted 19 lines · Simon Horman
Quoted 18 lines · Magnus Damm

Hi Simon,

Quoted 14 lines · Simon Horman
Quoted 11 lines · Magnus Damm

From: Takashi Yoshii <[email protected]>

Add 1GiB of DRAM at 0x2_0000_0000 to support the full 2GiB of APE6EVM system memory.

---

For correct run time operation regardless of kernel configuration ARM patches 7863/1 and 7864/1 are needed.

I take it that I should wait for those patches before applying this one.

Quoted 7 lines
Quoted 7 lines
Quoted 7 lines
Quoted 4 lines

That's probably a good idea. RMK has applied them to "git-curr", so I suppose they are queued up for something at least:

http://www.arm.linux.org.uk/developer/patches/viewpatch.php?id=7863/1

I have also sighted them in linux-next.
So I expect they will show up in v3.13-rc1 or thereabouts.

v3.13-rc1 is released and I have rebased the branches in the renesas tree on top of it. Should I go ahead and queue up this patch and its 3 friends:

ARM: shmobile: Include all 2 GiB of memory on APE6EVM DT Ref
ARM: shmobile: Include all 4 GiB of memory on Lager
ARM: shmobile: Include all 4 GiB of memory on Lager DT Ref

Quoted 49 lines
Quoted 34 lines
Quoted 34 lines
Quoted 9 lines
Quoted 5 lines

With those two patches and this one applied on top of renesas-devel-v3.12-rc7-20131030 I was able to successfully boot an ape6evm board. But /proc/meminfo still indicates only 1Gb of memory. What am I missing.

You probably need to enable HIGHMEM and LPAE to be able to access to all memory. Same thing on Lager, to get the full 4GiB you need to select those in your kernel configuration too.

Thanks, I have been able to successfully test all 4 patches in this series with those settings enabled.

Quoted 11 lines

Please note that having memory located on 64-bit addresses may break some drivers doing bus mastering or using the DMAC. These drivers need to be fixed both with short term DMA zone workarounds and proper 64-bit address support whenever possible.

So if I could suggest a policy then having LPAE=n in defconfig for the C board code for default stable operation. This together with LPAE=y in the case of DT reference and/or Multiplatform where we can be a bit more experimental. I don't care enough to send defconfig patches, but if some issue comes up then perhaps adjusting the defconfig to disable LPAE may work well as a workaround.

Thanks.

As it stands the defconfig for both APE6EVM and Lager lead to a configuration with LPAE disabled, although neither explicitly disable LPAE. I think it is best to leave things as-is in this regards and explicitly disable LPAE in the defconfigs if the need arises.

Quoted 8 lines
Quoted 4 lines

While looking over this I noticed that the APE6EVM defconfig selects HIGHMEM while the Lager defconfig does not and it is not selected in the resulting config. Would it be worth updating the Lager defconfig to enable HIGHMEM? If so, I'll make a patch.

Thanks. I think it mainly makes sense to enable LPAE and HIGHMEM together, so easiest is probably just to wait with both Lager and APE6EVM.

Sure. I will immediately do nothing :)
--
To unsubscribe from this list: send the line "unsubscribe linux-sh" in the body of a message to majordomo at vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html

#7 lore raw

PATCH 1/1 ARM: shmobile: Include all 2 GiB of memory on APE6EVM

In reply to Magnus Damm
Quoted 8 lines · Magnus Damm

From: Takashi Yoshii <[email protected]>

Add 1GiB of DRAM at 0x2_0000_0000 to support the full 2GiB of APE6EVM system memory.

---

Thanks, I have queued this up.

Quoted 22 lines

For correct run time operation regardless of kernel configuration ARM patches 7863/1 and 7864/1 are needed.

 arch/arm/boot/dts/r8a73a4-ape6evm.dts |    5 +++++
 1 file changed, 5 insertions(+)
arch/arm/boot/dts/r8a73a4-ape6evm.dts +5 -0
@@ -24,6 +24,11 @@
 		reg = <0 0x40000000 0 0x40000000>;
 	};
 
+	memory at 200000000 {
+		device_type = "memory";
+		reg = <2 0x00000000 0 0x40000000>;
+	};
+
 	ape6evm_fixed_3v3: fixedregulator at 0 {
 		compatible = "regulator-fixed";
 		regulator-name = "3V3";