Skip to contentSkip to conversation

iommu: shmobile: Enable the driver on all ARM platforms

PATCH New Laurent Pinchart 5 participants 8 messages Oct 30, 2013 – Nov 5, 2013

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH v3 1/1 iommu: shmobile: Enable the driver on all ARM platforms

Renesas ARM platforms are transitioning from single-platform to multi-platform kernels using the new ARCH_SHMOBILE_MULTI. Make the driver available on all ARM platforms to enable it on both ARCH_SHMOBILE and ARCH_SHMOBILE_MULTI and increase build testing coverage.

Don't enable COMPILE_TEST support as the driver doesn't compile on non-ARM platforms due to usage of the ARM DMA IOMMU API.

Cc Joerg Roedel <[email protected]>
Cc iommu at lists.linux-foundation.org
---
 drivers/iommu/Kconfig | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/iommu/Kconfig +1 -1
index c880eba..3e7fdbb 100644
@@ -206,7 +206,7 @@ config SHMOBILE_IPMMU_TLB
 config SHMOBILE_IOMMU
 	bool "IOMMU for Renesas IPMMU/IPMMUI"
 	default n
-	depends on (ARM && ARCH_SHMOBILE)
+	depends on ARM
 	select IOMMU_API
 	select ARM_DMA_USE_IOMMU
 	select SHMOBILE_IPMMU
Signature · 1 line
1.8.1.5
#1 lore raw

PATCH v3 1/1 iommu: shmobile: Enable the driver on all ARM platforms

Quoted 7 lines · Laurent Pinchart

Renesas ARM platforms are transitioning from single-platform to multi-platform kernels using the new ARCH_SHMOBILE_MULTI. Make the driver available on all ARM platforms to enable it on both ARCH_SHMOBILE and ARCH_SHMOBILE_MULTI and increase build testing coverage.

Don't enable COMPILE_TEST support as the driver doesn't compile on non-ARM platforms due to usage of the ARM DMA IOMMU API.

For similar reasons as x86, can we please think about using:

	depends on ARM
	depends on ARCH_SHMOBILE || ARCH_SHMOBILE_MULTI || COMPILE_TEST

This way we don't end up polluting the configuration for non-shmobile platforms. Same goes for other ARM stuff... the number of options is getting rather large and we need to think about keeping that in check where its easily possible to do so.

#2 lore raw

PATCH v3 1/1 iommu: shmobile: Enable the driver on all ARM platforms

Hi Russell,

[CC'ing Mark Brown]

Quoted 11 lines · On Wednesday 30 October 2013 11:26:25 Russell King - ARM Linux wrote:
Quoted 7 lines · Laurent Pinchart

Renesas ARM platforms are transitioning from single-platform to multi-platform kernels using the new ARCH_SHMOBILE_MULTI. Make the driver available on all ARM platforms to enable it on both ARCH_SHMOBILE and ARCH_SHMOBILE_MULTI and increase build testing coverage.

Don't enable COMPILE_TEST support as the driver doesn't compile on non-ARM platforms due to usage of the ARM DMA IOMMU API.

For similar reasons as x86, can we please think about using:

Quoted 7 lines
	depends on ARM
	depends on ARCH_SHMOBILE || ARCH_SHMOBILE_MULTI || COMPILE_TEST

This way we don't end up polluting the configuration for non-shmobile platforms. Same goes for other ARM stuff... the number of options is getting rather large and we need to think about keeping that in check where its easily possible to do so.

I've been asked to move from depends ARM to no dependency at all, and have thus settled for ARM || COMPILE_TEST in most cases, and just ARM where the driver couldn't be compiled on other platforms.

I'm fine with your proposed option. As I don't want to respin the series dozens of time let's first agree on the course of action, I will then repost the patches. Mark, you've pushed towards as few platform dependencies as possible, what's your opinion on this ?

Signature · 3 lines
Regards,

Laurent Pinchart
#3 lore raw

PATCH v3 1/1 iommu: shmobile: Enable the driver on all ARM platforms

Quoted 9 lines · Laurent Pinchart
Quoted 4 lines

For similar reasons as x86, can we please think about using:

	depends on ARM
	depends on ARCH_SHMOBILE || ARCH_SHMOBILE_MULTI || COMPILE_TEST

I'm fine with your proposed option. As I don't want to respin the series dozens of time let's first agree on the course of action, I will then repost the patches. Mark, you've pushed towards as few platform dependencies as possible, what's your opinion on this ?

In general I think we should have whatever the real depedencies are or COMPILE_TEST (to the extent that they will actually build cleanly on other targets). That way only people who explicitly go looking to compile test things for build coverage (eg, when doing global cleanups or API updates) need to be bothered by the extra compile test options.

I'd read the above as saying the code needs ARM to build at all and that
the hardware will only ever appear on SHMOBILE.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 836 bytes
Desc: Digital signature
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20131030/ed1df549/attachment.sig>

#4 lore raw

PATCH v3 1/1 iommu: shmobile: Enable the driver on all ARM platforms

Quoted 12 lines · Mark Brown
Quoted 9 lines · Laurent Pinchart
Quoted 4 lines

For similar reasons as x86, can we please think about using:

	depends on ARM
	depends on ARCH_SHMOBILE || ARCH_SHMOBILE_MULTI || COMPILE_TEST

I'm fine with your proposed option. As I don't want to respin the series dozens of time let's first agree on the course of action, I will then repost the patches. Mark, you've pushed towards as few platform dependencies as possible, what's your opinion on this ?

Quoted 8 lines

In general I think we should have whatever the real depedencies are or COMPILE_TEST (to the extent that they will actually build cleanly on other targets). That way only people who explicitly go looking to compile test things for build coverage (eg, when doing global cleanups or API updates) need to be bothered by the extra compile test options.

I'd read the above as saying the code needs ARM to build at all and that the hardware will only ever appear on SHMOBILE.

I am curious to know the value of "depends ARM".
Is it to aid the reading that you spelt out?

#5 lore raw

PATCH v3 1/1 iommu: shmobile: Enable the driver on all ARM platforms

Quoted 5 lines · Simon Horman
Quoted 4 lines · Mark Brown
Quoted 1 line · Laurent Pinchart
Quoted 1 line

For similar reasons as x86, can we please think about using:

Quoted 8 lines
Quoted 5 lines
Quoted 2 lines
Quoted 2 lines
	depends on ARM
	depends on ARCH_SHMOBILE || ARCH_SHMOBILE_MULTI || COMPILE_TEST

I'd read the above as saying the code needs ARM to build at all and that the hardware will only ever appear on SHMOBILE.

I am curious to know the value of "depends ARM".
Is it to aid the reading that you spelt out?

That's a function of the compile time dependencies, if ARM is required
to build then it needs to be an unconditional dependency.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 836 bytes
Desc: Digital signature
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20131031/b091cd0a/attachment-0001.sig>

#6 lore raw

PATCH v3 1/1 iommu: shmobile: Enable the driver on all ARM platforms

Quoted 9 lines · Mark Brown
Quoted 7 lines · Simon Horman
Quoted 6 lines · Mark Brown
Quoted 4 lines · Laurent Pinchart
Quoted 4 lines

For similar reasons as x86, can we please think about using:

	depends on ARM
	depends on ARCH_SHMOBILE || ARCH_SHMOBILE_MULTI || COMPILE_TEST
Quoted 8 lines
Quoted 5 lines
Quoted 2 lines

I'd read the above as saying the code needs ARM to build at all and that the hardware will only ever appear on SHMOBILE.

I am curious to know the value of "depends ARM".
Is it to aid the reading that you spelt out?

That's a function of the compile time dependencies, if ARM is required to build then it needs to be an unconditional dependency.

Thanks, sorry for missing the obvious.

#7 lore raw

PATCH v3 1/1 iommu: shmobile: Enable the driver on all ARM platforms

In reply to Mark Brown
Quoted 10 lines · On Wednesday 30 October 2013 09:28:54 Mark Brown wrote:
Quoted 8 lines · Laurent Pinchart
Quoted 3 lines

For similar reasons as x86, can we please think about using:

	depends on ARM
	depends on ARCH_SHMOBILE || ARCH_SHMOBILE_MULTI || COMPILE_TEST

I'm fine with your proposed option. As I don't want to respin the series dozens of time let's first agree on the course of action, I will then repost the patches. Mark, you've pushed towards as few platform dependencies as possible, what's your opinion on this ?

Quoted 8 lines

In general I think we should have whatever the real depedencies are or COMPILE_TEST (to the extent that they will actually build cleanly on other targets). That way only people who explicitly go looking to compile test things for build coverage (eg, when doing global cleanups or API updates) need to be bothered by the extra compile test options.

I'd read the above as saying the code needs ARM to build at all and that the hardware will only ever appear on SHMOBILE.

That's my reading as well, and it makes sense to express it that way to me. I'll resubmit the whole series (minus the patches that have been applied already, I'll fix those in follow-up patches) with the dependencies expressed that way.

Signature · 10 lines
Regards,

Laurent Pinchart
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 490 bytes
Desc: This is a digitally signed message part.
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20131105/a21f7815/attachment.sig>