quota: info leak in quota_getquota()
Subsystems (2)
PATCH 1/1 quota: info leak in quota_getquota()
The if_dqblk struct has a 4 byte hole at the end of the struct so uninitialized stack information is leaked to user space.
Signed-off-by Dan Carpenter <[email protected]>
fs/quota/quota.c +1 -0
@@ -117,6 +117,7 @@ static int quota_setinfo(struct super_block *sb, int type, void __user *addr)static void copy_to_if_dqblk (struct if_dqblk *dst,struct fs_disk_quota *src) { +memset (dst,0 ,sizeof (*dst)); dst->dqb_bhardlimit = src->d_blk_hardlimit; dst->dqb_bsoftlimit = src->d_blk_softlimit; dst->dqb_curspace = src->d_bcount;
Quoted 4 lines · Dan Carpenter
The
if_dqblkstruct has a 4 byte hole at the end of the struct so uninitialized stack information is leaked to user space.Signed-off-by Dan Carpenter <[email protected]>
Thanks. I've merged the patch into my tree.
Honza
Quoted 13 lines
fs/quota/quota.c +1
-0@@ -117,6 +117,7 @@ static int quota_setinfo(struct super_block *sb, int type, void __user *addr)static void copy_to_if_dqblk (struct if_dqblk *dst,struct fs_disk_quota *src) { +memset (dst,0 ,sizeof (*dst)); dst->dqb_bhardlimit = src->d_blk_hardlimit; dst->dqb_bsoftlimit = src->d_blk_softlimit; dst->dqb_curspace = src->d_bcount;
Signature · 2 lines
Jan Kara <[email protected]> SUSE Labs, CR