Skip to contentSkip to conversation

cryptsetup: Fix autobuild error http://autobuild.buildroot.net/results/cc1a65b9554bc2ece1b3ea8b51cd805b9bda7e86/

PATCH New Clayton Shotwell 2 participants 2 messages Oct 31, 2013 – Nov 1, 2013

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 cryptsetup: Fix autobuild error http://autobuild.buildroot.net/results/cc1a65b9554bc2ece1b3ea8b51cd805b9bda7e86/

Adding libintl to the libraries list for cryptsetup when using a uclibc toolchain.

---
 package/cryptsetup/cryptsetup.mk |    4 ++++
 1 file changed, 4 insertions(+)
package/cryptsetup/cryptsetup.mk +4 -0
index 48d37f6..d6169ec 100644
@@ -12,4 +12,8 @@ CRYPTSETUP_DEPENDENCIES = lvm2 popt e2fsprogs libgcrypt host-pkgconf
 CRYPTSETUP_LICENSE = GPLv2+ (programs), LGPLv2.1+ (library)
 CRYPTSETUP_LICENSE_FILES = COPYING COPYING.LGPL
 
+ifeq ($(BR2_TOOLCHAIN_USES_UCLIBC),y)
+CRYPTSETUP_CONF_ENV += LDFLAGS="-lintl"
+endif
+
 $(eval $(autotools-package))
Signature · 1 line
1.7.9.5
#1 lore raw

PATCH 1/1 cryptsetup: Fix autobuild error http://autobuild.buildroot.net/results/cc1a65b9554bc2ece1b3ea8b51cd805b9bda7e86/

Dear Clayton Shotwell,

package/cryptsetup/cryptsetup.mk CRYPTSETUP_DEPENDENCIES = lvm2 popt e2fsprogs libgcrypt host-pkgconf · line 17

Quoted 3 lines · Clayton Shotwell
package/cryptsetup/cryptsetup.mk +3 -0
+ifeq ($(BR2_TOOLCHAIN_USES_UCLIBC),y)
+CRYPTSETUP_CONF_ENV += LDFLAGS="-lintl"
+endif

I don't think BR2_TOOLCHAIN_USES_UCLIBC is the right thing to use here. You should use either BR2_NEEDS_GETTEXT_IF_LOCALE or BR2_NEEDS_GETTEXT, depending on whether intl is needed unconditionally, or only when locale support is enabled (which is most likely the case).

Best regards,

Thomas

Signature · 3 lines
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com