Skip to contentSkip to conversation

dhcpcd: needs MMU

PATCH Superseded Thomas Petazzoni 3 participants 4 messages Nov 2, 2013

lore
Share & tools
lore
#0 lore raw

PATCH v2 1/1 dhcpcd: needs MMU

dhcpcd fails to build on non-MMU platforms, even with the --disable-fork option:

bind.o: In function `_daemonise':
bind.c:(.text+0x62): undefined reference to `_fork'
collect2: ld returned 1 exit status

Therefore, we make dhcpcd depend on MMU support, and remove the non-MMU condition in the .mk file. More recent versions of dhcpcd do support non-MMU properly, but this commit intends to be only a fix.

---
v1 -> v2: remove non-MMU condition in .mk file, mentionned by Gustavo.

---
 package/dhcpcd/Config.in | 1 +
 package/dhcpcd/dhcpcd.mk | 4 ----
 2 files changed, 1 insertion(+), 4 deletions(-)
package/dhcpcd/Config.in +1 -0
index dbde548..ddbc6f4 100644
@@ -1,5 +1,6 @@
 config BR2_PACKAGE_DHCPCD
 	depends on BR2_INET_IPV6
+	depends on BR2_USE_MMU # fork()
 	bool "dhcpcd"
 	help
 	  An RFC2131 compliant DHCP client
package/dhcpcd/dhcpcd.mk +0 -4
index 5296db8..13810f3 100644
@@ -9,10 +9,6 @@ DHCPCD_SOURCE = dhcpcd-$(DHCPCD_VERSION).tar.bz2
 DHCPCD_SITE = http://roy.marples.name/downloads/dhcpcd/
 DHCPCD_LICENSE = BSD-2c
 
-ifeq ($(BR2_USE_MMU),)
-	DHCPCD_CONFIG_OPT += --disable-fork
-endif
-
 define DHCPCD_CONFIGURE_CMDS
 	(cd $(@D); \
 	./configure \
Signature · 1 line
1.8.1.2
#1 lore raw

PATCH v2 1/1 dhcpcd: needs MMU

Thomas, All,

On 2013-11-02 14:47 +0100, Thomas Petazzoni spake thusly:

Quoted 7 lines

dhcpcd fails to build on non-MMU platforms, even with the --disable-fork option:

bind.o: In function `_daemonise':
bind.c:(.text+0x62): undefined reference to `_fork'
collect2: ld returned 1 exit status

Quoted 5 lines

Therefore, we make dhcpcd depend on MMU support, and remove the non-MMU condition in the .mk file. More recent versions of dhcpcd do support non-MMU properly, but this commit intends to be only a fix.

Quoted 40 lines

---
v1 -> v2: remove non-MMU condition in .mk file, mentionned by Gustavo.

---
 package/dhcpcd/Config.in | 1 +
 package/dhcpcd/dhcpcd.mk | 4 ----
 2 files changed, 1 insertion(+), 4 deletions(-)
package/dhcpcd/Config.in +1 -0
index dbde548..ddbc6f4 100644
@@ -1,5 +1,6 @@
 config BR2_PACKAGE_DHCPCD
 	depends on BR2_INET_IPV6
+	depends on BR2_USE_MMU # fork()
 	bool "dhcpcd"
 	help
 	  An RFC2131 compliant DHCP client
package/dhcpcd/dhcpcd.mk +0 -4
index 5296db8..13810f3 100644
@@ -9,10 +9,6 @@ DHCPCD_SOURCE = dhcpcd-$(DHCPCD_VERSION).tar.bz2
 DHCPCD_SITE = http://roy.marples.name/downloads/dhcpcd/
 DHCPCD_LICENSE = BSD-2c
 
-ifeq ($(BR2_USE_MMU),)
-	DHCPCD_CONFIG_OPT += --disable-fork
-endif
-
 define DHCPCD_CONFIGURE_CMDS
 	(cd $(@D); \
 	./configure \
Signature · 6 lines
1.8.1.2

_______________________________________________
buildroot mailing list
buildroot at busybox.net
http://lists.busybox.net/mailman/listinfo/buildroot
Signature · 6 lines
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 223 225 172 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'
#2 lore raw

PATCH v2 1/1 dhcpcd: needs MMU

In reply to Thomas Petazzoni

2013/11/2 Thomas Petazzoni <[email protected]>

Quoted 7 lines

dhcpcd fails to build on non-MMU platforms, even with the --disable-fork option:

bind.o: In function `_daemonise':
bind.c:(.text+0x62): undefined reference to `_fork'
collect2: ld returned 1 exit status

Quoted 6 lines

Therefore, we make dhcpcd depend on MMU support, and remove the non-MMU condition in the .mk file. More recent versions of dhcpcd do support non-MMU properly, but this commit intends to be only a fix.

Regards,

Signature · 4 lines
Samuel
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.busybox.net/pipermail/buildroot/attachments/20131102/27da748b/attachment-0001.html>
#3 lore raw

PATCH v2 1/1 dhcpcd: needs MMU

In reply to Thomas Petazzoni

Dear Thomas Petazzoni,

Quoted 11 lines · Thomas Petazzoni

dhcpcd fails to build on non-MMU platforms, even with the --disable-fork option:

bind.o: In function `_daemonise':
bind.c:(.text+0x62): undefined reference to `_fork'
collect2: ld returned 1 exit status

Therefore, we make dhcpcd depend on MMU support, and remove the non-MMU condition in the .mk file. More recent versions of dhcpcd do support non-MMU properly, but this commit intends to be only a fix.

Quoted 7 lines

---
v1 -> v2: remove non-MMU condition in .mk file, mentionned by Gustavo.

---
 package/dhcpcd/Config.in | 1 +
 package/dhcpcd/dhcpcd.mk | 4 ----
 2 files changed, 1 insertion(+), 4 deletions(-)

Committed to for-peter-2013.11, thanks!

Thomas

Signature · 3 lines
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com