Skip to contentSkip to conversation

utils.bbclass: Fix override ordering for FILESPATH

PATCH In review Richard Purdie 5 participants 16 messages Oct 9, 2013 – Nov 8, 2013

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 utils.bbclass: Fix override ordering for FILESPATH

Currently the overrides are being applied backwards. This means something which is platform specific is overriding something which is machine specific which is clearly not intended.

This patch corrects the ordering to match the normal expected behaviour of OVERRIDES.

Secondly, all overrides are being searched for each path in turn. What should really happen is that we should look for the highest priority override (e.g. distro or machine) in each layer, then move on to platform/tune (e.g. armv7a) and then to arch (e.g. arm). This patch therefore also reverses the for loops to achieve this behaviour and give the result the user would expect.

---

meta/classes/utils.bbclass +5 -4
index d1f6563..0a533af 100644
@@ -307,10 +307,11 @@ def base_set_filespath(path, d):
     if extrapaths != "":
         path = extrapaths.split(":") + path
     # The ":" ensures we have an 'empty' override
-    overrides = ((d.getVar("FILESOVERRIDES", True) or "") + ":").split(":")
-    for p in path:
-        if p != "": 
-            for o in overrides:
+    overrides = (":" + (d.getVar("FILESOVERRIDES", True) or "")).split(":")
+    overrides.reverse()
+    for o in overrides:
+        for p in path:
+            if p != "": 
                 filespath.append(os.path.join(p, o))
     return ":".join(filespath)
 
#1 lore raw

SRC_URI computing order

Hi Richard,

I saw your patch fixing FILESPATH's and Kergoth's one fixing PACKAGECONFIG processing order and I think I'm also facing an order problem when SRC_URI is computed.

So when building SRC_URI when two layers have bbappend which apply patches : the SRC_URI seems to be built using an order I fail to understand somewhere instead of priority or the overrides' order.

The use case is a System on Module and its custom motherboard :
- meta-fsl-arm :
* linux-imx_xyz.bb :
SRC_URI = "patchgeneric1 ..."

- meta-som-support :
* conf/machine/mysom.conf

* linux-imx_xyz.bbappend :
SRC_URI_append_mysom = "patchsom1 patchsom2 ..."

- meta-custommotherboard (SOM + Cunstom Motherboard) :
* conf/machine/myproduct.conf MACHINEOVERRIDES_prepend = "mysom:"
include conf/machine/mysom.conf

* linux-imx_xyz.bbappend :
SRC_URI_append_myproduct = "patchproduct1 patchproduct2 ..."

in the end I get :
SRC_URI = "patchgeneric1 ... patchsoc1 ... patchproduct1 ... patchsom1 ..."

and of course as patchproduct* are supposed to apply on top of patchsoc* the patch fail to apply.

I didn't found a way to build SRC_URI in the order I would like (I tested : changing MACHINEOVERRIDES 's order, changing layers' priority, changing machine's name to see if that was an alphabetical order ...).

In the end the only thing which worked was to add an (empty by default) variable in som's SRC_URI and filling this variables from the custommotherboard's bbappend.

Is the behaviour I'm seeing expected or is there something wrong in my setup ?

Thanks,
Eric

#2 lore raw

Re: SRC_URI computing order

Quoted 40 lines · Eric Bénard

Hi Richard,

I saw your patch fixing FILESPATH's and Kergoth's one fixing PACKAGECONFIG processing order and I think I'm also facing an order problem when SRC_URI is computed.

So when building SRC_URI when two layers have bbappend which apply patches : the SRC_URI seems to be built using an order I fail to understand somewhere instead of priority or the overrides' order.

The use case is a System on Module and its custom motherboard :
- meta-fsl-arm :
* linux-imx_xyz.bb :
SRC_URI = "patchgeneric1 ..."

- meta-som-support :
* conf/machine/mysom.conf

* linux-imx_xyz.bbappend :
SRC_URI_append_mysom = "patchsom1 patchsom2 ..."

- meta-custommotherboard (SOM + Cunstom Motherboard) :
* conf/machine/myproduct.conf MACHINEOVERRIDES_prepend = "mysom:"
include conf/machine/mysom.conf

* linux-imx_xyz.bbappend :
SRC_URI_append_myproduct = "patchproduct1 patchproduct2 ..."

in the end I get :
SRC_URI = "patchgeneric1 ... patchsoc1 ... patchproduct1 ... patchsom1 ..."

and of course as patchproduct* are supposed to apply on top of patchsoc* the patch fail to apply.

I didn't found a way to build SRC_URI in the order I would like (I tested : changing MACHINEOVERRIDES 's order, changing layers' priority, changing machine's name to see if that was an alphabetical order ...).

Quoted 6 lines

In the end the only thing which worked was to add an (empty by default) variable in som's SRC_URI and filling this variables from the custommotherboard's bbappend.

Is the behaviour I'm seeing expected or is there something wrong in my setup ?

what is your OVERRIDES order.

Quoted 7 lines

Thanks,
Eric
_______________________________________________
Openembedded-core mailing list
[email protected]
http://lists.openembedded.org/mailman/listinfo/openembedded-core

#3 lore raw

Re: SRC_URI computing order

Hi Khem,

Quoted 41 lines · Khem Raj
Quoted 40 lines · Eric Bénard

Hi Richard,

I saw your patch fixing FILESPATH's and Kergoth's one fixing PACKAGECONFIG processing order and I think I'm also facing an order problem when SRC_URI is computed.

So when building SRC_URI when two layers have bbappend which apply patches : the SRC_URI seems to be built using an order I fail to understand somewhere instead of priority or the overrides' order.

The use case is a System on Module and its custom motherboard :
- meta-fsl-arm :
* linux-imx_xyz.bb :
SRC_URI = "patchgeneric1 ..."

- meta-som-support :
* conf/machine/mysom.conf

* linux-imx_xyz.bbappend :
SRC_URI_append_mysom = "patchsom1 patchsom2 ..."

- meta-custommotherboard (SOM + Cunstom Motherboard) :
* conf/machine/myproduct.conf MACHINEOVERRIDES_prepend = "mysom:"
include conf/machine/mysom.conf

* linux-imx_xyz.bbappend :
SRC_URI_append_myproduct = "patchproduct1 patchproduct2 ..."

in the end I get :
SRC_URI = "patchgeneric1 ... patchsoc1 ... patchproduct1 ... patchsom1 ..."

and of course as patchproduct* are supposed to apply on top of patchsoc* the patch fail to apply.

I didn't found a way to build SRC_URI in the order I would like (I tested : changing MACHINEOVERRIDES 's order, changing layers' priority, changing machine's name to see if that was an alphabetical order ...).

Quoted 9 lines
Quoted 6 lines

In the end the only thing which worked was to add an (empty by default) variable in som's SRC_URI and filling this variables from the custommotherboard's bbappend.

Is the behaviour I'm seeing expected or is there something wrong in my setup ?

what is your OVERRIDES order.

"${TARGET_OS}:${TRANSLATED_TARGET_ARCH}:build-${BUILD_OS}:pn-${PN}:${MACHINEOVERRIDES}:${DISTROOVERRIDES}:${CLASSOVERRIDE}:forcevariable"

so it follows the MACHINEOVERRIDES order (and I tried both append and prepend to hack MACHINEOVERRIDES without any behaviour change).

Eric

#4 lore raw

Re: SRC_URI computing order

Quoted 53 lines · Eric Bénard

Hi Khem,

Quoted 48 lines · Khem Raj
Quoted 46 lines · Eric Bénard

Hi Richard,

I saw your patch fixing FILESPATH's and Kergoth's one fixing PACKAGECONFIG processing order and I think I'm also facing an order problem when SRC_URI is computed.

So when building SRC_URI when two layers have bbappend which apply patches : the SRC_URI seems to be built using an order I fail to understand somewhere instead of priority or the overrides' order.

The use case is a System on Module and its custom motherboard :
- meta-fsl-arm :
* linux-imx_xyz.bb :
SRC_URI = "patchgeneric1 ..."

- meta-som-support :
* conf/machine/mysom.conf

* linux-imx_xyz.bbappend :
SRC_URI_append_mysom = "patchsom1 patchsom2 ..."

- meta-custommotherboard (SOM + Cunstom Motherboard) :
* conf/machine/myproduct.conf MACHINEOVERRIDES_prepend = "mysom:"
include conf/machine/mysom.conf

* linux-imx_xyz.bbappend :
SRC_URI_append_myproduct = "patchproduct1 patchproduct2 ..."

in the end I get :
SRC_URI = "patchgeneric1 ... patchsoc1 ... patchproduct1 ... patchsom1 ..."

and of course as patchproduct* are supposed to apply on top of patchsoc* the patch fail to apply.

I didn't found a way to build SRC_URI in the order I would like (I tested : changing MACHINEOVERRIDES 's order, changing layers' priority, changing machine's name to see if that was an alphabetical order ...).

In the end the only thing which worked was to add an (empty by default) variable in som's SRC_URI and filling this variables from the custommotherboard's bbappend.

Is the behaviour I'm seeing expected or is there something wrong in my setup ?

Quoted 6 lines
Quoted 2 lines

what is your OVERRIDES order.

"${TARGET_OS}:${TRANSLATED_TARGET_ARCH}:build-${BUILD_OS}:pn-${PN}:${MACHINEOVERRIDES}:${DISTROOVERRIDES}:${CLASSOVERRIDE}:forcevariable"

so it follows the MACHINEOVERRIDES order (and I tried both append and prepend to hack MACHINEOVERRIDES without any behaviour change).

I think what Khem is asking is what OVERRIDES expands to?

You mean patchso* and not patchsoc* above, right? Or should patchsom1 be patchsoc2?

Its hard to follow and it might be easier if you could share a simplified test case we could reproduce this with. I don't doubt there is an issue in there but we need a way to reproduce and debug this.

Cheers,

Richard

#5 lore raw

Re: SRC_URI computing order

Hi Richard,

Quoted 58 lines · Richard Purdie
Quoted 57 lines · Eric Bénard

Hi Khem,

Quoted 41 lines · Khem Raj
Quoted 40 lines · Eric Bénard

Hi Richard,

I saw your patch fixing FILESPATH's and Kergoth's one fixing PACKAGECONFIG processing order and I think I'm also facing an order problem when SRC_URI is computed.

So when building SRC_URI when two layers have bbappend which apply patches : the SRC_URI seems to be built using an order I fail to understand somewhere instead of priority or the overrides' order.

The use case is a System on Module and its custom motherboard :
- meta-fsl-arm :
* linux-imx_xyz.bb :
SRC_URI = "patchgeneric1 ..."

- meta-som-support :
* conf/machine/mysom.conf

* linux-imx_xyz.bbappend :
SRC_URI_append_mysom = "patchsom1 patchsom2 ..."

- meta-custommotherboard (SOM + Cunstom Motherboard) :
* conf/machine/myproduct.conf MACHINEOVERRIDES_prepend = "mysom:"
include conf/machine/mysom.conf

* linux-imx_xyz.bbappend :
SRC_URI_append_myproduct = "patchproduct1 patchproduct2 ..."

in the end I get :
SRC_URI = "patchgeneric1 ... patchsoc1 ... patchproduct1 ... patchsom1 ..."

and of course as patchproduct* are supposed to apply on top of patchsoc* the patch fail to apply.

I didn't found a way to build SRC_URI in the order I would like (I tested : changing MACHINEOVERRIDES 's order, changing layers' priority, changing machine's name to see if that was an alphabetical order ...).

Quoted 9 lines
Quoted 6 lines

In the end the only thing which worked was to add an (empty by default) variable in som's SRC_URI and filling this variables from the custommotherboard's bbappend.

Is the behaviour I'm seeing expected or is there something wrong in my setup ?

what is your OVERRIDES order.

"${TARGET_OS}:${TRANSLATED_TARGET_ARCH}:build-${BUILD_OS}:pn-${PN}:${MACHINEOVERRIDES}:${DISTROOVERRIDES}:${CLASSOVERRIDE}:forcevariable"

Quoted 8 lines
Quoted 2 lines

so it follows the MACHINEOVERRIDES order (and I tried both append and prepend to hack MACHINEOVERRIDES without any behaviour change).

I think what Khem is asking is what OVERRIDES expands to?

You mean patchso* and not patchsoc* above, right? Or should patchsom1 be patchsoc2?

oops :
I expect SRC_URI = "patchgeneric1 ... patchsom1 ... patchproduct1 ..." and I get :
SRC_URI = "patchgeneric1 ... patchproduct1 ... patchsom1 ..."

Quoted 4 lines

Its hard to follow and it might be easier if you could share a simplified test case we could reproduce this with. I don't doubt there is an issue in there but we need a way to reproduce and debug this.

OK, I'm preparing a simple testcase to reproduce that with oe-core + meta-fsl-arm + meta-som + meta-baseboard.

Eric

#6 lore raw

Re: SRC_URI computing order

Quoted 80 lines · Eric Bénard

Hi Richard,

Quoted 58 lines · Richard Purdie
Quoted 57 lines · Eric Bénard

Hi Khem,

Quoted 41 lines · Khem Raj
Quoted 40 lines · Eric Bénard

Hi Richard,

I saw your patch fixing FILESPATH's and Kergoth's one fixing PACKAGECONFIG processing order and I think I'm also facing an order problem when SRC_URI is computed.

So when building SRC_URI when two layers have bbappend which apply patches : the SRC_URI seems to be built using an order I fail to understand somewhere instead of priority or the overrides' order.

The use case is a System on Module and its custom motherboard :
- meta-fsl-arm :
* linux-imx_xyz.bb :
SRC_URI = "patchgeneric1 ..."

- meta-som-support :
* conf/machine/mysom.conf

* linux-imx_xyz.bbappend :
SRC_URI_append_mysom = "patchsom1 patchsom2 ..."

- meta-custommotherboard (SOM + Cunstom Motherboard) :
* conf/machine/myproduct.conf MACHINEOVERRIDES_prepend = "mysom:"
include conf/machine/mysom.conf

* linux-imx_xyz.bbappend :
SRC_URI_append_myproduct = "patchproduct1 patchproduct2 ..."

in the end I get :
SRC_URI = "patchgeneric1 ... patchsoc1 ... patchproduct1 ... patchsom1 ..."

and of course as patchproduct* are supposed to apply on top of patchsoc* the patch fail to apply.

I didn't found a way to build SRC_URI in the order I would like (I tested : changing MACHINEOVERRIDES 's order, changing layers' priority, changing machine's name to see if that was an alphabetical order ...).

Quoted 9 lines
Quoted 6 lines

In the end the only thing which worked was to add an (empty by default) variable in som's SRC_URI and filling this variables from the custommotherboard's bbappend.

Is the behaviour I'm seeing expected or is there something wrong in my setup ?

what is your OVERRIDES order.

"${TARGET_OS}:${TRANSLATED_TARGET_ARCH}:build-${BUILD_OS}:pn-${PN}:${MACHINEOVERRIDES}:${DISTROOVERRIDES}:${CLASSOVERRIDE}:forcevariable"

Quoted 8 lines
Quoted 2 lines

so it follows the MACHINEOVERRIDES order (and I tried both append and prepend to hack MACHINEOVERRIDES without any behaviour change).

I think what Khem is asking is what OVERRIDES expands to?

You mean patchso* and not patchsoc* above, right? Or should patchsom1 be patchsoc2?

oops :
I expect SRC_URI = "patchgeneric1 ... patchsom1 ... patchproduct1 ..." and I get :
SRC_URI = "patchgeneric1 ... patchproduct1 ... patchsom1 ..."

Quoted 4 lines

Its hard to follow and it might be easier if you could share a simplified test case we could reproduce this with. I don't doubt there is an issue in there but we need a way to reproduce and debug this.

Quoted 8 lines

OK, I'm preparing a simple testcase to reproduce that with oe-core + meta-fsl-arm + meta-som + meta-baseboard.

Eric
_______________________________________________
Openembedded-core mailing list
[email protected]
http://lists.openembedded.org/mailman/listinfo/openembedded-core

I have to report an undesiderate behavior:

the formfactor files in our .bbappend are not considered :/
DEBUG: Searching for machconfig in paths:....
/oe/oe-core/meta/recipes-bsp/formfactor/formfactor-0.0/ /oe/oe-core/meta/recipes-bsp/formfactor/formfactor/ /oe/oe-core/meta/recipes-bsp/formfactor/files/ /oe/meta-handheld/recipes-bsp/formfactor/files/poodle

so we end up with the empty machconfig of
/oe/oe-core/meta/recipes-bsp/formfactor/files/

Surely this didn't happen when we tested the recipe.

Cheers

Andrea

#7 lore raw

Re: SRC_URI computing order

Quoted 100 lines · Andrea Adami
Quoted 80 lines · Eric Bénard

Hi Richard,

Quoted 58 lines · Richard Purdie
Quoted 57 lines · Eric Bénard

Hi Khem,

Quoted 41 lines · Khem Raj
Quoted 40 lines · Eric Bénard

Hi Richard,

I saw your patch fixing FILESPATH's and Kergoth's one fixing PACKAGECONFIG processing order and I think I'm also facing an order problem when SRC_URI is computed.

So when building SRC_URI when two layers have bbappend which apply patches : the SRC_URI seems to be built using an order I fail to understand somewhere instead of priority or the overrides' order.

The use case is a System on Module and its custom motherboard :
- meta-fsl-arm :
* linux-imx_xyz.bb :
SRC_URI = "patchgeneric1 ..."

- meta-som-support :
* conf/machine/mysom.conf

* linux-imx_xyz.bbappend :
SRC_URI_append_mysom = "patchsom1 patchsom2 ..."

- meta-custommotherboard (SOM + Cunstom Motherboard) :
* conf/machine/myproduct.conf MACHINEOVERRIDES_prepend = "mysom:"
include conf/machine/mysom.conf

* linux-imx_xyz.bbappend :
SRC_URI_append_myproduct = "patchproduct1 patchproduct2 ..."

in the end I get :
SRC_URI = "patchgeneric1 ... patchsoc1 ... patchproduct1 ... patchsom1 ..."

and of course as patchproduct* are supposed to apply on top of patchsoc* the patch fail to apply.

I didn't found a way to build SRC_URI in the order I would like (I tested : changing MACHINEOVERRIDES 's order, changing layers' priority, changing machine's name to see if that was an alphabetical order ...).

Quoted 9 lines
Quoted 6 lines

In the end the only thing which worked was to add an (empty by default) variable in som's SRC_URI and filling this variables from the custommotherboard's bbappend.

Is the behaviour I'm seeing expected or is there something wrong in my setup ?

what is your OVERRIDES order.

"${TARGET_OS}:${TRANSLATED_TARGET_ARCH}:build-${BUILD_OS}:pn-${PN}:${MACHINEOVERRIDES}:${DISTROOVERRIDES}:${CLASSOVERRIDE}:forcevariable"

Quoted 8 lines
Quoted 2 lines

so it follows the MACHINEOVERRIDES order (and I tried both append and prepend to hack MACHINEOVERRIDES without any behaviour change).

I think what Khem is asking is what OVERRIDES expands to?

You mean patchso* and not patchsoc* above, right? Or should patchsom1 be patchsoc2?

oops :
I expect SRC_URI = "patchgeneric1 ... patchsom1 ... patchproduct1 ..." and I get :
SRC_URI = "patchgeneric1 ... patchproduct1 ... patchsom1 ..."

Quoted 4 lines

Its hard to follow and it might be easier if you could share a simplified test case we could reproduce this with. I don't doubt there is an issue in there but we need a way to reproduce and debug this.

Quoted 8 lines

OK, I'm preparing a simple testcase to reproduce that with oe-core + meta-fsl-arm + meta-som + meta-baseboard.

Eric
_______________________________________________
Openembedded-core mailing list
[email protected]
http://lists.openembedded.org/mailman/listinfo/openembedded-core

I have to report an undesiderate behavior:

the formfactor files in our .bbappend are not considered :/
DEBUG: Searching for machconfig in paths:....
/oe/oe-core/meta/recipes-bsp/formfactor/formfactor-0.0/ /oe/oe-core/meta/recipes-bsp/formfactor/formfactor/ /oe/oe-core/meta/recipes-bsp/formfactor/files/ /oe/meta-handheld/recipes-bsp/formfactor/files/poodle

Quoted 4 lines

so we end up with the empty machconfig of
/oe/oe-core/meta/recipes-bsp/formfactor/files/

Surely this didn't happen when we tested the recipe.

With which revision of OE-Core? Was this with the dora release tag, current dora head or master?

Cheers,

Richard

#8 lore raw

Re: SRC_URI computing order

Quoted 104 lines · Richard Purdie
Quoted 103 lines · Andrea Adami
Quoted 80 lines · Eric Bénard

Hi Richard,

Quoted 58 lines · Richard Purdie
Quoted 57 lines · Eric Bénard

Hi Khem,

Quoted 41 lines · Khem Raj
Quoted 40 lines · Eric Bénard

Hi Richard,

I saw your patch fixing FILESPATH's and Kergoth's one fixing PACKAGECONFIG processing order and I think I'm also facing an order problem when SRC_URI is computed.

So when building SRC_URI when two layers have bbappend which apply patches : the SRC_URI seems to be built using an order I fail to understand somewhere instead of priority or the overrides' order.

The use case is a System on Module and its custom motherboard :
- meta-fsl-arm :
* linux-imx_xyz.bb :
SRC_URI = "patchgeneric1 ..."

- meta-som-support :
* conf/machine/mysom.conf

* linux-imx_xyz.bbappend :
SRC_URI_append_mysom = "patchsom1 patchsom2 ..."

- meta-custommotherboard (SOM + Cunstom Motherboard) :
* conf/machine/myproduct.conf MACHINEOVERRIDES_prepend = "mysom:"
include conf/machine/mysom.conf

* linux-imx_xyz.bbappend :
SRC_URI_append_myproduct = "patchproduct1 patchproduct2 ..."

in the end I get :
SRC_URI = "patchgeneric1 ... patchsoc1 ... patchproduct1 ... patchsom1 ..."

and of course as patchproduct* are supposed to apply on top of patchsoc* the patch fail to apply.

I didn't found a way to build SRC_URI in the order I would like (I tested : changing MACHINEOVERRIDES 's order, changing layers' priority, changing machine's name to see if that was an alphabetical order ...).

Quoted 9 lines
Quoted 6 lines

In the end the only thing which worked was to add an (empty by default) variable in som's SRC_URI and filling this variables from the custommotherboard's bbappend.

Is the behaviour I'm seeing expected or is there something wrong in my setup ?

what is your OVERRIDES order.

"${TARGET_OS}:${TRANSLATED_TARGET_ARCH}:build-${BUILD_OS}:pn-${PN}:${MACHINEOVERRIDES}:${DISTROOVERRIDES}:${CLASSOVERRIDE}:forcevariable"

Quoted 8 lines
Quoted 2 lines

so it follows the MACHINEOVERRIDES order (and I tried both append and prepend to hack MACHINEOVERRIDES without any behaviour change).

I think what Khem is asking is what OVERRIDES expands to?

You mean patchso* and not patchsoc* above, right? Or should patchsom1 be patchsoc2?

oops :
I expect SRC_URI = "patchgeneric1 ... patchsom1 ... patchproduct1 ..." and I get :
SRC_URI = "patchgeneric1 ... patchproduct1 ... patchsom1 ..."

Quoted 4 lines

Its hard to follow and it might be easier if you could share a simplified test case we could reproduce this with. I don't doubt there is an issue in there but we need a way to reproduce and debug this.

Quoted 8 lines

OK, I'm preparing a simple testcase to reproduce that with oe-core + meta-fsl-arm + meta-som + meta-baseboard.

Eric
_______________________________________________
Openembedded-core mailing list
[email protected]
http://lists.openembedded.org/mailman/listinfo/openembedded-core

I have to report an undesiderate behavior:

the formfactor files in our .bbappend are not considered :/
DEBUG: Searching for machconfig in paths:....
/oe/oe-core/meta/recipes-bsp/formfactor/formfactor-0.0/ /oe/oe-core/meta/recipes-bsp/formfactor/formfactor/ /oe/oe-core/meta/recipes-bsp/formfactor/files/ /oe/meta-handheld/recipes-bsp/formfactor/files/poodle

so we end up with the empty machconfig of
/oe/oe-core/meta/recipes-bsp/formfactor/files/

Quoted 10 lines
Quoted 1 line

Surely this didn't happen when we tested the recipe.

With which revision of OE-Core? Was this with the dora release tag, current dora head or master?

Cheers,

Richard

This was with fresh master:

Build Configuration:

BB_VERSION        = "1.21.0"
BUILD_SYS         = "i686-linux"
NATIVELSBSTRING   = "Gentoo"
TARGET_SYS        = "arm-oe-linux-gnueabi"
MACHINE           = "poodle"
DISTRO_VERSION    = "oe-core.0"
TUNE_FEATURES     = "armv5 thumb dsp"
TARGET_FPU        = "soft"
meta              = "master:511b4194165ed7a5645169e09c27db280d5a5316"
meta-initramfs    = "master:4d62e7f575e2a87197c74ab4639561b45eec0e60"
meta-handheld     = "master:55a310666b543e6beca47fa3c197492d5a6cf8ff"

Cheers

#9 lore raw

Re: SRC_URI computing order

Quoted 132 lines · Andrea Adami
Quoted 104 lines · Richard Purdie
Quoted 103 lines · Andrea Adami
Quoted 80 lines · Eric Bénard

Hi Richard,

Quoted 58 lines · Richard Purdie
Quoted 57 lines · Eric Bénard

Hi Khem,

Quoted 41 lines · Khem Raj
Quoted 40 lines · Eric Bénard

Hi Richard,

I saw your patch fixing FILESPATH's and Kergoth's one fixing PACKAGECONFIG processing order and I think I'm also facing an order problem when SRC_URI is computed.

So when building SRC_URI when two layers have bbappend which apply patches : the SRC_URI seems to be built using an order I fail to understand somewhere instead of priority or the overrides' order.

The use case is a System on Module and its custom motherboard :
- meta-fsl-arm :
* linux-imx_xyz.bb :
SRC_URI = "patchgeneric1 ..."

- meta-som-support :
* conf/machine/mysom.conf

* linux-imx_xyz.bbappend :
SRC_URI_append_mysom = "patchsom1 patchsom2 ..."

- meta-custommotherboard (SOM + Cunstom Motherboard) :
* conf/machine/myproduct.conf MACHINEOVERRIDES_prepend = "mysom:"
include conf/machine/mysom.conf

* linux-imx_xyz.bbappend :
SRC_URI_append_myproduct = "patchproduct1 patchproduct2 ..."

in the end I get :
SRC_URI = "patchgeneric1 ... patchsoc1 ... patchproduct1 ... patchsom1 ..."

and of course as patchproduct* are supposed to apply on top of patchsoc* the patch fail to apply.

I didn't found a way to build SRC_URI in the order I would like (I tested : changing MACHINEOVERRIDES 's order, changing layers' priority, changing machine's name to see if that was an alphabetical order ...).

Quoted 9 lines
Quoted 6 lines

In the end the only thing which worked was to add an (empty by default) variable in som's SRC_URI and filling this variables from the custommotherboard's bbappend.

Is the behaviour I'm seeing expected or is there something wrong in my setup ?

what is your OVERRIDES order.

"${TARGET_OS}:${TRANSLATED_TARGET_ARCH}:build-${BUILD_OS}:pn-${PN}:${MACHINEOVERRIDES}:${DISTROOVERRIDES}:${CLASSOVERRIDE}:forcevariable"

Quoted 8 lines
Quoted 2 lines

so it follows the MACHINEOVERRIDES order (and I tried both append and prepend to hack MACHINEOVERRIDES without any behaviour change).

I think what Khem is asking is what OVERRIDES expands to?

You mean patchso* and not patchsoc* above, right? Or should patchsom1 be patchsoc2?

oops :
I expect SRC_URI = "patchgeneric1 ... patchsom1 ... patchproduct1 ..." and I get :
SRC_URI = "patchgeneric1 ... patchproduct1 ... patchsom1 ..."

Quoted 4 lines

Its hard to follow and it might be easier if you could share a simplified test case we could reproduce this with. I don't doubt there is an issue in there but we need a way to reproduce and debug this.

Quoted 8 lines

OK, I'm preparing a simple testcase to reproduce that with oe-core + meta-fsl-arm + meta-som + meta-baseboard.

Eric
_______________________________________________
Openembedded-core mailing list
[email protected]
http://lists.openembedded.org/mailman/listinfo/openembedded-core

I have to report an undesiderate behavior:

the formfactor files in our .bbappend are not considered :/
DEBUG: Searching for machconfig in paths:....
/oe/oe-core/meta/recipes-bsp/formfactor/formfactor-0.0/ /oe/oe-core/meta/recipes-bsp/formfactor/formfactor/ /oe/oe-core/meta/recipes-bsp/formfactor/files/ /oe/meta-handheld/recipes-bsp/formfactor/files/poodle

so we end up with the empty machconfig of
/oe/oe-core/meta/recipes-bsp/formfactor/files/

Quoted 10 lines
Quoted 1 line

Surely this didn't happen when we tested the recipe.

With which revision of OE-Core? Was this with the dora release tag, current dora head or master?

Cheers,

Richard

This was with fresh master:

Build Configuration:

BB_VERSION        = "1.21.0"
BUILD_SYS         = "i686-linux"
NATIVELSBSTRING   = "Gentoo"
TARGET_SYS        = "arm-oe-linux-gnueabi"
MACHINE           = "poodle"
DISTRO_VERSION    = "oe-core.0"
TUNE_FEATURES     = "armv5 thumb dsp"
TARGET_FPU        = "soft"
meta              = "master:511b4194165ed7a5645169e09c27db280d5a5316"
meta-initramfs    = "master:4d62e7f575e2a87197c74ab4639561b45eec0e60"
meta-handheld     = "master:55a310666b543e6beca47fa3c197492d5a6cf8ff"
Quoted 1 line

Cheers

FYI
In the hurry for a solution for fixing formfactor and ipaq-boot-params my quick hack was to revert

http://cgit.openembedded.org/openembedded-core/commit/meta?id=92cbf7eeea553bfa24c7081473fa8bc4ebc1f552

That appears to fix the specific issue...

Andrea

#10 lore raw

Re: SRC_URI computing order

Quoted 42 lines · Andrea Adami
Quoted 41 lines · Andrea Adami
Quoted 13 lines · Richard Purdie
Quoted 12 lines · Andrea Adami

I have to report an undesiderate behavior:

the formfactor files in our .bbappend are not considered :/
DEBUG: Searching for machconfig in paths:....
/oe/oe-core/meta/recipes-bsp/formfactor/formfactor-0.0/ /oe/oe-core/meta/recipes-bsp/formfactor/formfactor/ /oe/oe-core/meta/recipes-bsp/formfactor/files/ /oe/meta-handheld/recipes-bsp/formfactor/files/poodle

so we end up with the empty machconfig of
/oe/oe-core/meta/recipes-bsp/formfactor/files/

Quoted 10 lines
Quoted 1 line

Surely this didn't happen when we tested the recipe.

With which revision of OE-Core? Was this with the dora release tag, current dora head or master?

Cheers,

Richard

This was with fresh master:

Build Configuration:

BB_VERSION        = "1.21.0"
BUILD_SYS         = "i686-linux"
NATIVELSBSTRING   = "Gentoo"
TARGET_SYS        = "arm-oe-linux-gnueabi"
MACHINE           = "poodle"
DISTRO_VERSION    = "oe-core.0"
TUNE_FEATURES     = "armv5 thumb dsp"
TARGET_FPU        = "soft"
meta              = "master:511b4194165ed7a5645169e09c27db280d5a5316"
meta-initramfs    = "master:4d62e7f575e2a87197c74ab4639561b45eec0e60"
meta-handheld     = "master:55a310666b543e6beca47fa3c197492d5a6cf8ff"
Quoted 8 lines
Quoted 1 line

Cheers

FYI
In the hurry for a solution for fixing formfactor and ipaq-boot-params my quick hack was to revert

http://cgit.openembedded.org/openembedded-core/commit/meta?id=92cbf7eeea553bfa24c7081473fa8bc4ebc1f552

That appears to fix the specific issue...

Its a hacky workaround. The real issue is that you don't set DISTRO and this puts a :: into FILESOVERRIDES (and OVERRIDES). I've sent a patch out which sets a default for DISTRO since its the nicer way I could find to fix this. The behaviour in the above patch is correct.

Cheers,

Richard

#11 lore raw

Re: SRC_URI computing order

Quoted 48 lines · Richard Purdie
Quoted 47 lines · Andrea Adami
Quoted 41 lines · Andrea Adami
Quoted 13 lines · Richard Purdie
Quoted 12 lines · Andrea Adami

I have to report an undesiderate behavior:

the formfactor files in our .bbappend are not considered :/
DEBUG: Searching for machconfig in paths:....
/oe/oe-core/meta/recipes-bsp/formfactor/formfactor-0.0/ /oe/oe-core/meta/recipes-bsp/formfactor/formfactor/ /oe/oe-core/meta/recipes-bsp/formfactor/files/ /oe/meta-handheld/recipes-bsp/formfactor/files/poodle

so we end up with the empty machconfig of
/oe/oe-core/meta/recipes-bsp/formfactor/files/

Quoted 10 lines
Quoted 1 line

Surely this didn't happen when we tested the recipe.

With which revision of OE-Core? Was this with the dora release tag, current dora head or master?

Cheers,

Richard

This was with fresh master:

Build Configuration:

BB_VERSION        = "1.21.0"
BUILD_SYS         = "i686-linux"
NATIVELSBSTRING   = "Gentoo"
TARGET_SYS        = "arm-oe-linux-gnueabi"
MACHINE           = "poodle"
DISTRO_VERSION    = "oe-core.0"
TUNE_FEATURES     = "armv5 thumb dsp"
TARGET_FPU        = "soft"
meta              = "master:511b4194165ed7a5645169e09c27db280d5a5316"
meta-initramfs    = "master:4d62e7f575e2a87197c74ab4639561b45eec0e60"
meta-handheld     = "master:55a310666b543e6beca47fa3c197492d5a6cf8ff"
Quoted 1 line

Cheers

FYI
In the hurry for a solution for fixing formfactor and ipaq-boot-params my quick hack was to revert

Quoted 8 lines
Quoted 3 lines

http://cgit.openembedded.org/openembedded-core/commit/meta?id=92cbf7eeea553bfa24c7081473fa8bc4ebc1f552

That appears to fix the specific issue...

Its a hacky workaround. The real issue is that you don't set DISTRO and this puts a :: into FILESOVERRIDES (and OVERRIDES). I've sent a patch out which sets a default for DISTRO since its the nicer way I could find to fix this. The behaviour in the above patch is correct.

Can you point this patch?

Signature · 3 lines
Otavio Salvador                             O.S. Systems
http://www.ossystems.com.br        http://code.ossystems.com.br
Mobile: +55 (53) 9981-7854            Mobile: +1 (347) 903-9750
#12 lore raw

Re: SRC_URI computing order

In reply to Andrea Adami

Hi Andrea,

Quoted 9 lines · Andrea Adami

I have to report an undesiderate behavior:

the formfactor files in our .bbappend are not considered :/
DEBUG: Searching for machconfig in paths:....
/oe/oe-core/meta/recipes-bsp/formfactor/formfactor-0.0/ /oe/oe-core/meta/recipes-bsp/formfactor/formfactor/ /oe/oe-core/meta/recipes-bsp/formfactor/files/ /oe/meta-handheld/recipes-bsp/formfactor/files/poodle

Quoted 5 lines

so we end up with the empty machconfig of
/oe/oe-core/meta/recipes-bsp/formfactor/files/

Surely this didn't happen when we tested the recipe.

isn't that problem fixed by cherry-picking commit 92cbf7eeea553bfa24c7081473fa8bc4ebc1f552 in oe-core ?

Eric

#13 lore raw

Re: SRC_URI computing order

In reply to Eric Bénard

Hi,

Quoted 38 lines · Eric Bénard

I saw your patch fixing FILESPATH's and Kergoth's one fixing PACKAGECONFIG processing order and I think I'm also facing an order problem when SRC_URI is computed.

So when building SRC_URI when two layers have bbappend which apply patches : the SRC_URI seems to be built using an order I fail to understand somewhere instead of priority or the overrides' order.

The use case is a System on Module and its custom motherboard :
- meta-fsl-arm :
* linux-imx_xyz.bb :
SRC_URI = "patchgeneric1 ..."

- meta-som-support :
* conf/machine/mysom.conf

* linux-imx_xyz.bbappend :
SRC_URI_append_mysom = "patchsom1 patchsom2 ..."

- meta-custommotherboard (SOM + Cunstom Motherboard) :
* conf/machine/myproduct.conf MACHINEOVERRIDES_prepend = "mysom:"
include conf/machine/mysom.conf

* linux-imx_xyz.bbappend :
SRC_URI_append_myproduct = "patchproduct1 patchproduct2 ..."

in the end I get :
SRC_URI = "patchgeneric1 ... patchsoc1 ... patchproduct1 ... patchsom1 ..."

and of course as patchproduct* are supposed to apply on top of patchsoc* the patch fail to apply.

I didn't found a way to build SRC_URI in the order I would like (I tested : changing MACHINEOVERRIDES 's order, changing layers' priority, changing machine's name to see if that was an alphabetical order ...).

Quoted 7 lines

In the end the only thing which worked was to add an (empty by default) variable in som's SRC_URI and filling this variables from the custommotherboard's bbappend.

Is the behaviour I'm seeing expected or is there something wrong in my setup ?

do you need more details concerning this problem ?

Thanks
Eric

#14 lore raw

Re: SRC_URI computing order

Quoted 42 lines · Eric Bénard

Hi,

Quoted 38 lines · Eric Bénard

I saw your patch fixing FILESPATH's and Kergoth's one fixing PACKAGECONFIG processing order and I think I'm also facing an order problem when SRC_URI is computed.

So when building SRC_URI when two layers have bbappend which apply patches : the SRC_URI seems to be built using an order I fail to understand somewhere instead of priority or the overrides' order.

The use case is a System on Module and its custom motherboard :
- meta-fsl-arm :
* linux-imx_xyz.bb :
SRC_URI = "patchgeneric1 ..."

- meta-som-support :
* conf/machine/mysom.conf

* linux-imx_xyz.bbappend :
SRC_URI_append_mysom = "patchsom1 patchsom2 ..."

- meta-custommotherboard (SOM + Cunstom Motherboard) :
* conf/machine/myproduct.conf MACHINEOVERRIDES_prepend = "mysom:"
include conf/machine/mysom.conf

* linux-imx_xyz.bbappend :
SRC_URI_append_myproduct = "patchproduct1 patchproduct2 ..."

in the end I get :
SRC_URI = "patchgeneric1 ... patchsoc1 ... patchproduct1 ... patchsom1 ..."

and of course as patchproduct* are supposed to apply on top of patchsoc* the patch fail to apply.

I didn't found a way to build SRC_URI in the order I would like (I tested : changing MACHINEOVERRIDES 's order, changing layers' priority, changing machine's name to see if that was an alphabetical order ...).

Quoted 8 lines
Quoted 7 lines

In the end the only thing which worked was to add an (empty by default) variable in som's SRC_URI and filling this variables from the custommotherboard's bbappend.

Is the behaviour I'm seeing expected or is there something wrong in my setup ?

do you need more details concerning this problem ?

I sent a reply asking for more info. I think there is a typo above which isn't helping...

Cheers,

Richard

#15 lore raw

Re: SRC_URI computing order

Quoted 47 lines · Richard Purdie
Quoted 46 lines · Eric Bénard

Hi,

Quoted 42 lines · Eric Bénard

I saw your patch fixing FILESPATH's and Kergoth's one fixing PACKAGECONFIG processing order and I think I'm also facing an order problem when SRC_URI is computed.

So when building SRC_URI when two layers have bbappend which apply patches : the SRC_URI seems to be built using an order I fail to understand somewhere instead of priority or the overrides' order.

The use case is a System on Module and its custom motherboard :
- meta-fsl-arm :
* linux-imx_xyz.bb :
SRC_URI = "patchgeneric1 ..."

- meta-som-support :
* conf/machine/mysom.conf

* linux-imx_xyz.bbappend :
SRC_URI_append_mysom = "patchsom1 patchsom2 ..."

- meta-custommotherboard (SOM + Cunstom Motherboard) :
* conf/machine/myproduct.conf MACHINEOVERRIDES_prepend = "mysom:"
include conf/machine/mysom.conf

* linux-imx_xyz.bbappend :
SRC_URI_append_myproduct = "patchproduct1 patchproduct2 ..."

in the end I get :
SRC_URI = "patchgeneric1 ... patchsoc1 ... patchproduct1 ... patchsom1 ..."

and of course as patchproduct* are supposed to apply on top of patchsoc* the patch fail to apply.

I didn't found a way to build SRC_URI in the order I would like (I tested : changing MACHINEOVERRIDES 's order, changing layers' priority, changing machine's name to see if that was an alphabetical order ...).

In the end the only thing which worked was to add an (empty by default) variable in som's SRC_URI and filling this variables from the custommotherboard's bbappend.

Quoted 8 lines
Quoted 4 lines
Quoted 3 lines

Is the behaviour I'm seeing expected or is there something wrong in my setup ?

do you need more details concerning this problem ?

I sent a reply asking for more info. I think there is a typo above which isn't helping...

sorry I missed your mail.

Eric