ARM: footbridge: fix build warning
Subsystems (3)
PATCH 1/1 ARM: footbridge: fix build warning
The raw spinlock in the netwinder GPIO implementation was using non-raw accessors, fix this warning from the autobuilder:
arch/arm/mach-footbridge/netwinder-hw.c:695:2:
warning: passing argument 1 of 'spinlock_check' from incompatible pointer type [enabled by default] arch/arm/mach-footbridge/netwinder-hw.c:702:2:
warning: passing argument 1 of 'spin_unlock_irqrestore' from incompatible pointer type [enabled by default] arch/arm/mach-footbridge/netwinder-hw.c:712:2:
warning: passing argument 1 of 'spinlock_check' from incompatible pointer type [enabled by default] arch/arm/mach-footbridge/netwinder-hw.c:714:2:
warning: passing argument 1 of 'spin_unlock_irqrestore' from incompatible pointer type [enabled by default]
---
ARM SoC folks: please apply this directly to fixes.
--- arch/arm/mach-footbridge/netwinder-hw.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-)
arch/arm/mach-footbridge/netwinder-hw.c +4 -4
@@ -692,14 +692,14 @@ static void netwinder_led_set(struct led_classdev *cdev,unsigned long flags;u32 reg; -spin_lock_irqsave (&nw_gpio_lock, flags); +raw_spin_lock_irqsave (&nw_gpio_lock, flags); reg =nw_gpio_read ();if (b !=LED_OFF ) reg &= ~led->mask;else reg |= led->mask;nw_gpio_modify_op (led->mask, reg); -spin_unlock_irqrestore (&nw_gpio_lock, flags); +raw_spin_unlock_irqrestore (&nw_gpio_lock, flags); }static enum led_brightness netwinder_led_get (struct led_classdev *cdev)
@@ -709,9 +709,9 @@ static enum led_brightness netwinder_led_get(struct led_classdev *cdev)unsigned long flags;u32 reg; -spin_lock_irqsave (&nw_gpio_lock, flags); +raw_spin_lock_irqsave (&nw_gpio_lock, flags); reg =nw_gpio_read (); -spin_unlock_irqrestore (&nw_gpio_lock, flags); +raw_spin_unlock_irqrestore (&nw_gpio_lock, flags);return (reg & led->mask) ?LED_OFF :LED_FULL ; }
Signature · 1 line
1.8.3.1
PATCH 1/1 ARM: footbridge: fix build warning
Quoted 2 lines · Linus Walleij
The raw spinlock in the netwinder GPIO implementation was using non-raw accessors, fix this warning from the autobuilder:
I've already got this in my tree. Thanks anyway.