Skip to contentSkip to conversation

FS: BTRFS: fixed coding style issues

PATCH In review Aldo Iljazi 2 participants 9 messages Nov 4, 2013 – Nov 12, 2013 Btrfs file system

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 FS: BTRFS: fixed coding style issues

Fixed three coding style issues. Replaced spaces with tabs.

---
 fs/btrfs/dev-replace.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)
fs/btrfs/dev-replace.c +3 -3
index 9efb94e..b2fe609 100644
@@ -377,7 +377,7 @@ int btrfs_dev_replace_start(struct btrfs_root *root,
 	printk_in_rcu(KERN_INFO
 		      "btrfs: dev_replace from %s (devid %llu) to %s) started\n",
 		      src_device->missing ? "<missing disk>" :
-		        rcu_str_deref(src_device->name),
+			rcu_str_deref(src_device->name),
 		      src_device->devid,
 		      rcu_str_deref(tgt_device->name));
 
@@ -500,7 +500,7 @@ static int btrfs_dev_replace_finishing(struct btrfs_fs_info *fs_info,
 		printk_in_rcu(KERN_ERR
 			      "btrfs: btrfs_scrub_dev(%s, %llu, %s) failed %d\n",
 			      src_device->missing ? "<missing disk>" :
-			        rcu_str_deref(src_device->name),
+				rcu_str_deref(src_device->name),
 			      src_device->devid,
 			      rcu_str_deref(tgt_device->name), scrub_ret);
 		btrfs_dev_replace_unlock(dev_replace);
@@ -515,7 +515,7 @@ static int btrfs_dev_replace_finishing(struct btrfs_fs_info *fs_info,
 	printk_in_rcu(KERN_INFO
 		      "btrfs: dev_replace from %s (devid %llu) to %s) finished\n",
 		      src_device->missing ? "<missing disk>" :
-		        rcu_str_deref(src_device->name),
+			rcu_str_deref(src_device->name),
 		      src_device->devid,
 		      rcu_str_deref(tgt_device->name));
 	tgt_device->is_tgtdev_for_dev_replace = 0;
Signature · 1 line
1.8.3.2
#1 lore raw
Quoted 12 lines · Aldo Iljazi

Fixed three coding style issues. Replaced spaces with tabs.

---
 fs/btrfs/dev-replace.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)
fs/btrfs/dev-replace.c +0 -0
index 9efb94e..b2fe609 100644

fs/btrfs/dev-replace.c int btrfs_dev_replace_start(struct btrfs_root *root, · line 380

Quoted 5 lines
fs/btrfs/dev-replace.c +1 -1
@@ -377,7 +377,7 @@ int btrfs_dev_replace_start(struct btrfs_root *root,
 	printk_in_rcu(KERN_INFO
 		      "btrfs: dev_replace from %s (devid %llu) to %s) started\n",
 		      src_device->missing ? "<missing disk>" :
-		        rcu_str_deref(src_device->name),
+			rcu_str_deref(src_device->name),

What's the change here? I don't think we need to fix whitespace, this makes searching in patch history more tedious, namely in case where the code looks exactly the same before and after the patch.

The style issues should be best fixed when the patch is about to be merged, doing it later like this is kind of not welcome, speaking for myself. There are lots of opportunities to do real code cleanups.

Whitespace changes are just noise, we don't need them at this point of development phase of btrfs.

david

#2 lore raw
Quoted 27 lines · David Sterba
Quoted 12 lines · Aldo Iljazi

Fixed three coding style issues. Replaced spaces with tabs.

---
 fs/btrfs/dev-replace.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)
fs/btrfs/dev-replace.c +0 -0
index 9efb94e..b2fe609 100644

fs/btrfs/dev-replace.c int btrfs_dev_replace_start(struct btrfs_root *root, · line 380

Quoted 5 lines
fs/btrfs/dev-replace.c +1 -1
@@ -377,7 +377,7 @@ int btrfs_dev_replace_start(struct btrfs_root *root,
 	printk_in_rcu(KERN_INFO
 		      "btrfs: dev_replace from %s (devid %llu) to %s) started\n",
 		      src_device->missing ? "<missing disk>" :
-		        rcu_str_deref(src_device->name),
+			rcu_str_deref(src_device->name),

What's the change here? I don't think we need to fix whitespace, this makes searching in patch history more tedious, namely in case where the code looks exactly the same before and after the patch.

The style issues should be best fixed when the patch is about to be merged, doing it later like this is kind of not welcome, speaking for myself. There are lots of opportunities to do real code cleanups.

Quoted 5 lines

Whitespace changes are just noise, we don't need them at this point of development phase of btrfs.

david

I replaced the spaces with tabs, as the kernel coding style suggests.

Signature · 1 line
Aldo Iljazi
#3 lore raw
Quoted 29 lines · Aldo Iljazi
Quoted 27 lines · David Sterba
Quoted 12 lines · Aldo Iljazi

Fixed three coding style issues. Replaced spaces with tabs.

---
 fs/btrfs/dev-replace.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)
fs/btrfs/dev-replace.c +0 -0
index 9efb94e..b2fe609 100644

fs/btrfs/dev-replace.c int btrfs_dev_replace_start(struct btrfs_root *root, · line 380

Quoted 5 lines
fs/btrfs/dev-replace.c +1 -1
@@ -377,7 +377,7 @@ int btrfs_dev_replace_start(struct btrfs_root *root,
 	printk_in_rcu(KERN_INFO
 		      "btrfs: dev_replace from %s (devid %llu) to %s) started\n",
 		      src_device->missing ? "<missing disk>" :
-		        rcu_str_deref(src_device->name),
+			rcu_str_deref(src_device->name),

What's the change here? I don't think we need to fix whitespace, this makes searching in patch history more tedious, namely in case where the code looks exactly the same before and after the patch.

The style issues should be best fixed when the patch is about to be merged, doing it later like this is kind of not welcome, speaking for myself. There are lots of opportunities to do real code cleanups.

Quoted 7 lines
Quoted 5 lines

Whitespace changes are just noise, we don't need them at this point of development phase of btrfs.

david

I replaced the spaces with tabs, as the kernel coding style suggests.

I repeat:

Whitespace changes are just noise, we don't need them at this point of development phase of btrfs.

david

#4 lore raw
Quoted 36 lines · David Sterba
Quoted 35 lines · Aldo Iljazi
Quoted 32 lines · David Sterba
Quoted 12 lines · Aldo Iljazi

Fixed three coding style issues. Replaced spaces with tabs.

---
 fs/btrfs/dev-replace.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)
fs/btrfs/dev-replace.c +0 -0
index 9efb94e..b2fe609 100644

fs/btrfs/dev-replace.c int btrfs_dev_replace_start(struct btrfs_root *root, · line 380

Quoted 5 lines
fs/btrfs/dev-replace.c +1 -1
@@ -377,7 +377,7 @@ int btrfs_dev_replace_start(struct btrfs_root *root,
 	printk_in_rcu(KERN_INFO
 		      "btrfs: dev_replace from %s (devid %llu) to %s) started\n",
 		      src_device->missing ? "<missing disk>" :
-		        rcu_str_deref(src_device->name),
+			rcu_str_deref(src_device->name),

What's the change here? I don't think we need to fix whitespace, this makes searching in patch history more tedious, namely in case where the code looks exactly the same before and after the patch.

The style issues should be best fixed when the patch is about to be merged, doing it later like this is kind of not welcome, speaking for myself. There are lots of opportunities to do real code cleanups.

Whitespace changes are just noise, we don't need them at this point of development phase of btrfs.

david

Quoted 8 lines
Quoted 1 line

I replaced the spaces with tabs, as the kernel coding style suggests.

I repeat:

Whitespace changes are just noise, we don't need them at this point of development phase of btrfs.

david

Okay then ignore the patch.

Signature · 1 line
Aldo Iljazi
#5 lore raw
Quoted 10 lines · Aldo Iljazi
Quoted 8 lines
Quoted 1 line

I replaced the spaces with tabs, as the kernel coding style suggests.

I repeat:

Whitespace changes are just noise, we don't need them at this point of development phase of btrfs.

david

Okay then ignore the patch.

Well, this also applies to patches with subject 'BTRFS: fixed coding style issues'

#6 lore raw
Quoted 5 lines · David Sterba
Quoted 4 lines · Aldo Iljazi
Quoted 4 lines
Quoted 1 line

I replaced the spaces with tabs, as the kernel coding style suggests.

I repeat:

Quoted 8 lines
Quoted 6 lines
Quoted 4 lines

Whitespace changes are just noise, we don't need them at this point of development phase of btrfs.

david

Okay then ignore the patch.

Well, this also applies to patches with subject 'BTRFS: fixed coding style issues'

Okay then.

Signature · 1 line
Aldo Iljazi
#7 lore raw
In reply to Aldo Iljazi
Quoted 12 lines · Aldo Iljazi

Fixed three coding style issues. Replaced spaces with tabs.

---
 fs/btrfs/dev-replace.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)
fs/btrfs/dev-replace.c +0 -0
index 9efb94e..b2fe609 100644

fs/btrfs/dev-replace.c int btrfs_dev_replace_start(struct btrfs_root *root, · line 380

Quoted 5 lines
fs/btrfs/dev-replace.c +1 -1
@@ -377,7 +377,7 @@ int btrfs_dev_replace_start(struct btrfs_root *root,
 	printk_in_rcu(KERN_INFO
 		      "btrfs: dev_replace from %s (devid %llu) to %s) started\n",
 		      src_device->missing ? "<missing disk>" :
-		        rcu_str_deref(src_device->name),
+			rcu_str_deref(src_device->name),

What's the change here? I don't think we need to fix whitespace, this makes searching in patch history more boring, namely in case where the code looks exactly the same before and after the patch.

The style issues should be best fixed when the patch is about to be merged, doing it later like this is kind of not welcome, speaking for myself. There are lots of opportunities to do real code cleanups.

david

#8 lore raw
Quoted 23 lines · David Sterba
Quoted 12 lines · Aldo Iljazi

Fixed three coding style issues. Replaced spaces with tabs.

---
 fs/btrfs/dev-replace.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)
fs/btrfs/dev-replace.c +0 -0
index 9efb94e..b2fe609 100644

fs/btrfs/dev-replace.c int btrfs_dev_replace_start(struct btrfs_root *root, · line 380

Quoted 5 lines
fs/btrfs/dev-replace.c +1 -1
@@ -377,7 +377,7 @@ int btrfs_dev_replace_start(struct btrfs_root *root,
 	printk_in_rcu(KERN_INFO
 		      "btrfs: dev_replace from %s (devid %llu) to %s) started\n",
 		      src_device->missing ? "<missing disk>" :
-		        rcu_str_deref(src_device->name),
+			rcu_str_deref(src_device->name),

What's the change here? I don't think we need to fix whitespace, this makes searching in patch history more boring, namely in case where the code looks exactly the same before and after the patch.

Quoted 6 lines

The style issues should be best fixed when the patch is about to be merged, doing it later like this is kind of not welcome, speaking for myself. There are lots of opportunities to do real code cleanups.

david

Okay thanks.

Signature · 1 line
Aldo Iljazi