wcn36xx: missing unlocks on error paths
Subsystems (2)
PATCH 1/1 wcn36xx: missing unlocks on error paths
There are several places which are missing unlocks.
Signed-off-by Dan Carpenter <[email protected]>
drivers/net/wireless/ath/wcn36xx/smd.c +6 -3
@@ -1286,7 +1286,8 @@ int wcn36xx_smd_send_beacon(struct wcn36xx *wcn, struct ieee80211_vif *vif, }else {wcn36xx_err ("Beacon is to big: beacon size=%d\n" , msg_body.beacon_length); -return -ENOMEM ; + ret = -ENOMEM ; + goto out; }memcpy (msg_body.bssid, vif->addr,ETH_ALEN );
@@ -1327,7 +1328,8 @@ int wcn36xx_smd_update_proberesp_tmpl(struct wcn36xx *wcn,if (skb->len >BEACON_TEMPLATE_SIZE ) {wcn36xx_warn ("probe response template is too big: %d\n" , skb->len); -return -E2BIG ; + ret = -E2BIG ; + goto out; } msg.probe_resp_template_len = skb->len;
@@ -1606,7 +1608,8 @@ int wcn36xx_smd_keep_alive_req(struct wcn36xx *wcn,/* TODO: it also support ARP response type */ }else {wcn36xx_warn ("unknow keep alive packet type %d\n" , packet_type); -return -EINVAL ; + ret = -EINVAL ; + goto out; }PREPARE_HAL_BUF (wcn->hal_buf, msg_body);
Looks good to me, thanx!
Quoted 38 lines · Dan Carpenter
There are several places which are missing unlocks.
Signed-off-by Dan Carpenter <[email protected]>drivers/net/wireless/ath/wcn36xx/smd.c +6
-3@@ -1286,7 +1286,8 @@ int wcn36xx_smd_send_beacon(struct wcn36xx *wcn, struct ieee80211_vif *vif, }else {wcn36xx_err ("Beacon is to big: beacon size=%d\n" , msg_body.beacon_length); -return -ENOMEM ; + ret = -ENOMEM ; + goto out; }memcpy (msg_body.bssid, vif->addr,ETH_ALEN );@@ -1327,7 +1328,8 @@ int wcn36xx_smd_update_proberesp_tmpl(struct wcn36xx *wcn,if (skb->len >BEACON_TEMPLATE_SIZE ) {wcn36xx_warn ("probe response template is too big: %d\n" , skb->len); -return -E2BIG ; + ret = -E2BIG ; + goto out; } msg.probe_resp_template_len = skb->len;@@ -1606,7 +1608,8 @@ int wcn36xx_smd_keep_alive_req(struct wcn36xx *wcn,/* TODO: it also support ARP response type */ }else {wcn36xx_warn ("unknow keep alive packet type %d\n" , packet_type); -return -EINVAL ; + ret = -EINVAL ; + goto out; }PREPARE_HAL_BUF (wcn->hal_buf, msg_body);
Signature · 2 lines
Best regards, Eugene
Forgot to mention that there was an overlap with a patch from Wei Yongjun but that i will resolve myself because i was too slow with applying patches.
Quoted 47 lines · Eugene Krasnikov
Looks good to me, thanx!
Quoted 29 lines · Dan Carpenter
There are several places which are missing unlocks.
Signed-off-by Dan Carpenter <[email protected]>drivers/net/wireless/ath/wcn36xx/smd.c +4
-2@@ -1286,7 +1286,8 @@ int wcn36xx_smd_send_beacon(struct wcn36xx *wcn, struct ieee80211_vif *vif, }else {wcn36xx_err ("Beacon is to big: beacon size=%d\n" , msg_body.beacon_length); -return -ENOMEM ; + ret = -ENOMEM ; + goto out; }memcpy (msg_body.bssid, vif->addr,ETH_ALEN );@@ -1327,7 +1328,8 @@ int wcn36xx_smd_update_proberesp_tmpl(struct wcn36xx *wcn,if (skb->len >BEACON_TEMPLATE_SIZE ) {wcn36xx_warn ("probe response template is too big: %d\n" , skb->len); -return -E2BIG ; + ret = -E2BIG ; + goto out; } msg.probe_resp_template_len = skb->len;drivers/net/wireless/ath/wcn36xx/smd.c int wcn36xx_smd_keep_alive_req(struct wcn36xx *wcn, · line 1615
Quoted 9 lines
drivers/net/wireless/ath/wcn36xx/smd.c +2
-1@@ -1606,7 +1608,8 @@ int wcn36xx_smd_keep_alive_req(struct wcn36xx *wcn,/* TODO: it also support ARP response type */ }else {wcn36xx_warn ("unknow keep alive packet type %d\n" , packet_type); -return -EINVAL ; + ret = -EINVAL ; + goto out; }PREPARE_HAL_BUF (wcn->hal_buf, msg_body);--
Best regards,
Eugene
Signature · 2 lines
Best regards, Eugene