Skip to contentSkip to conversation

drm/i915: Demote drop_caches_set print

PATCH In review Ben Widawsky 3 participants 4 messages Nov 6, 2013

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 drm/i915: Demote drop_caches_set print

Many tests call this ad naseum now (in an infinite loop, very often). It clutters the logs. Actually, I'd rather drop it completely...

Cc Daniel Vetter <[email protected]>
Cc Chris Wilson <[email protected]>
---
 drivers/gpu/drm/i915/i915_debugfs.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/gpu/drm/i915/i915_debugfs.c +1 -1
index 7008aac..d24e7d1 100644
@@ -2657,7 +2657,7 @@ i915_drop_caches_set(void *data, u64 val)
 	struct i915_vma *vma, *x;
 	int ret;
 
-	DRM_DEBUG_DRIVER("Dropping caches: 0x%08llx\n", val);
+	DRM_DEBUG("Dropping caches: 0x%08llx\n", val);
 
 	/* No need to check and wait for gpu resets, only libdrm auto-restarts
 	 * on ioctls on -EAGAIN. */
Signature · 1 line
1.8.4.2
#1 lore raw
Quoted 2 lines · Ben Widawsky

Many tests call this ad naseum now (in an infinite loop, very often). It clutters the logs. Actually, I'd rather drop it completely...

Dropping it completely seems like the right solutions due to those "drop caches in an infinite loop" kind of tests.
-Daniel

Quoted 24 lines
Cc Daniel Vetter <[email protected]>
Cc Chris Wilson <[email protected]>
---
 drivers/gpu/drm/i915/i915_debugfs.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/gpu/drm/i915/i915_debugfs.c +1 -1
index 7008aac..d24e7d1 100644
@@ -2657,7 +2657,7 @@ i915_drop_caches_set(void *data, u64 val)
 	struct i915_vma *vma, *x;
 	int ret;
 
-	DRM_DEBUG_DRIVER("Dropping caches: 0x%08llx\n", val);
+	DRM_DEBUG("Dropping caches: 0x%08llx\n", val);
 
 	/* No need to check and wait for gpu resets, only libdrm auto-restarts
 	 * on ioctls on -EAGAIN. */
Signature · 1 line
1.8.4.2
Signature · 3 lines
Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch
#2 lore raw
Quoted 6 lines · Daniel Vetter
Quoted 2 lines · Ben Widawsky

Many tests call this ad naseum now (in an infinite loop, very often). It clutters the logs. Actually, I'd rather drop it completely...

Dropping it completely seems like the right solutions due to those "drop caches in an infinite loop" kind of tests.

By that argument we should remove all log messages. Why are we doing this ad nausem? I thought the recent intention was to call it around tests, in which case the debug log would be busy enough to hide this noise. (Noise until it is vital to explain some behavioural artifact.) -Chris

Signature · 1 line
Chris Wilson, Intel Open Source Technology Centre
#3 lore raw
Quoted 5 lines · Chris Wilson
Quoted 4 lines · Daniel Vetter
Quoted 2 lines · Ben Widawsky

Many tests call this ad naseum now (in an infinite loop, very often). It clutters the logs. Actually, I'd rather drop it completely...

Quoted 7 lines
Quoted 2 lines

Dropping it completely seems like the right solutions due to those "drop caches in an infinite loop" kind of tests.

By that argument we should remove all log messages. Why are we doing this ad nausem? I thought the recent intention was to call it around tests, in which case the debug log would be busy enough to hide this noise. (Noise until it is vital to explain some behavioural artifact.)

Some tests fork a 2nd thread which calls this in a busy loop. Together with using gtt mmaps for ioctl data it's a very effective means to hit the slowpath maze in our execbuf code. Iirc without this at least some of the older bugs wouldn't be possible to hit (namely the slowpath of the writeout of the updated gtt offset in the slow relocation path that we've killed since it's too hard).

Generally I agree with you, but since I abuse this facility rather badly in some tests I guess we should drop the debug output. -Daniel

Signature · 3 lines
Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch