Skip to contentSkip to conversation

usb: phy: phy-mxs-usb: set the correct platform drvdata

PATCH Superseded Jisheng Zhang 3 participants 4 messages Nov 7, 2013

Subsystems (2)

v1 of 2 Superseded Latest is v2 →

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 usb: phy: phy-mxs-usb: set the correct platform drvdata

We need to set mxs_phy rather as the platform drvdata so that we can get the correct mxs_phy in mxs_phy_remove().

Change-Id I6e1753cc978e2ed3fbb3d1865be0c54031d337d2
---
 drivers/usb/phy/phy-mxs-usb.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/usb/phy/phy-mxs-usb.c +1 -1
index fdd33b4..545844b 100644
@@ -164,7 +164,7 @@ static int mxs_phy_probe(struct platform_device *pdev)
 
 	mxs_phy->clk = clk;
 
-	platform_set_drvdata(pdev, &mxs_phy->phy);
+	platform_set_drvdata(pdev, mxs_phy);
 
 	ret = usb_add_phy_dev(&mxs_phy->phy);
 	if (ret)
Signature · 1 line
1.8.4.2
Acked-by on v1 1/1
#1 lore raw
Quoted 5 lines · Jisheng Zhang

We need to set mxs_phy rather as the platform drvdata so that we can get the correct mxs_phy in mxs_phy_remove().

Change-Id I6e1753cc978e2ed3fbb3d1865be0c54031d337d2

Change-Id should be dropped though.

Shawn

Quoted 20 lines
---
 drivers/usb/phy/phy-mxs-usb.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/usb/phy/phy-mxs-usb.c +1 -1
index fdd33b4..545844b 100644
@@ -164,7 +164,7 @@ static int mxs_phy_probe(struct platform_device *pdev)
 
 	mxs_phy->clk = clk;
 
-	platform_set_drvdata(pdev, &mxs_phy->phy);
+	platform_set_drvdata(pdev, mxs_phy);
 
 	ret = usb_add_phy_dev(&mxs_phy->phy);
 	if (ret)
Signature · 1 line
1.8.4.2
#2 lore raw
Quoted 10 lines · On Wed, 6 Nov 2013 18:34:47 -0800 Shawn Guo <[email protected]> wrote:
Quoted 5 lines · Jisheng Zhang

We need to set mxs_phy rather as the platform drvdata so that we can get the correct mxs_phy in mxs_phy_remove().

Change-Id I6e1753cc978e2ed3fbb3d1865be0c54031d337d2

Change-Id should be dropped though.

OOPs, sorry, I should take care of that. I'll remind myself every time.

Thank you for your pointing out

Jisheng

Quoted 24 lines

Shawn

Quoted 20 lines
---
 drivers/usb/phy/phy-mxs-usb.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/usb/phy/phy-mxs-usb.c +1 -1
index fdd33b4..545844b 100644
@@ -164,7 +164,7 @@ static int mxs_phy_probe(struct platform_device *pdev)
 
 	mxs_phy->clk = clk;
 
-	platform_set_drvdata(pdev, &mxs_phy->phy);
+	platform_set_drvdata(pdev, mxs_phy);
 
 	ret = usb_add_phy_dev(&mxs_phy->phy);
 	if (ret)
Signature · 1 line
1.8.4.2
#3 lore raw
In reply to Jisheng Zhang
Quoted 4 lines · Jisheng Zhang

We need to set mxs_phy rather as the platform drvdata so that we can get the correct mxs_phy in mxs_phy_remove().

Change-Id: I6e1753cc978e2ed3fbb3d1865be0c54031d337d2

please strip Gerrit-specific tags from commit log.

Signature · 1 line
balbi