usb: phy: phy-mxs-usb: set the correct platform drvdata
Subsystems (2)
PATCH 1/1 usb: phy: phy-mxs-usb: set the correct platform drvdata
We need to set mxs_phy rather as the platform drvdata so that we can get the correct mxs_phy in mxs_phy_remove().
--- drivers/usb/phy/phy-mxs-usb.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/usb/phy/phy-mxs-usb.c +1 -1
@@ -164,7 +164,7 @@ static int mxs_phy_probe(struct platform_device *pdev) mxs_phy->clk = clk; -platform_set_drvdata (pdev, &mxs_phy->phy); +platform_set_drvdata (pdev, mxs_phy); ret =usb_add_phy_dev (&mxs_phy->phy);if (ret)
Signature · 1 line
1.8.4.2
Quoted 5 lines · Jisheng Zhang
We need to set
mxs_phyrather as the platform drvdata so that we can get the correctmxs_phyinmxs_phy_remove().Change-Id I6e1753cc978e2ed3fbb3d1865be0c54031d337d2Signed-off-by Jisheng Zhang <[email protected]>
Change-Id should be dropped though.
Shawn
Quoted 20 lines
--- drivers/usb/phy/phy-mxs-usb.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)drivers/usb/phy/phy-mxs-usb.c +1
-1@@ -164,7 +164,7 @@ static int mxs_phy_probe(struct platform_device *pdev) mxs_phy->clk = clk; -platform_set_drvdata (pdev, &mxs_phy->phy); +platform_set_drvdata (pdev, mxs_phy); ret =usb_add_phy_dev (&mxs_phy->phy);if (ret)Signature · 1 line
1.8.4.2
Quoted 10 lines · On Wed, 6 Nov 2013 18:34:47 -0800 Shawn Guo <[email protected]> wrote:
Quoted 5 lines · Jisheng Zhang
We need to set
mxs_phyrather as the platform drvdata so that we can get the correctmxs_phyinmxs_phy_remove().Change-Id I6e1753cc978e2ed3fbb3d1865be0c54031d337d2Signed-off-by Jisheng Zhang <[email protected]>Acked-by Shawn Guo <[email protected]>Change-Id should be dropped though.
OOPs, sorry, I should take care of that. I'll remind myself every time.
Thank you for your pointing out
Jisheng
Quoted 24 lines
Shawn
Quoted 20 lines
--- drivers/usb/phy/phy-mxs-usb.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)drivers/usb/phy/phy-mxs-usb.c +1
-1@@ -164,7 +164,7 @@ static int mxs_phy_probe(struct platform_device *pdev) mxs_phy->clk = clk; -platform_set_drvdata (pdev, &mxs_phy->phy); +platform_set_drvdata (pdev, mxs_phy); ret =usb_add_phy_dev (&mxs_phy->phy);if (ret)Signature · 1 line
1.8.4.2
Quoted 4 lines · Jisheng Zhang
We need to set
mxs_phyrather as the platform drvdata so that we can get the correctmxs_phyinmxs_phy_remove().Change-Id: I6e1753cc978e2ed3fbb3d1865be0c54031d337d2
please strip Gerrit-specific tags from commit log.
Signature · 1 line
balbi