mailbox/omap: make mbox->irq signed for error handling
Subsystems (2)
PATCH 1/1 mailbox/omap: make mbox->irq signed for error handling
There is a bug in omap2_mbox_probe() where we try do:
mbox->irq = platform_get_irq(pdev, info->irq_id);
if (mbox->irq < 0) {The problem is that mbox->irq is unsigned so the error handling doesn't work. I've changed it to a signed integer.
Signed-off-by Dan Carpenter <[email protected]>
drivers/mailbox/omap-mbox.h +1 -1
@@ -52,7 +52,7 @@ struct omap_mbox_queue {struct omap_mbox {const char *name; -unsigned int irq; +int irq;struct omap_mbox_queue *txq, *rxq;struct omap_mbox_ops *ops;struct device *dev;
Quoted 9 lines · Dan Carpenter
There is a bug in
omap2_mbox_probe()where we try do:mbox->irq = platform_get_irq(pdev, info->irq_id); if (mbox->irq < 0) {The problem is that
mbox->irqis unsigned so the error handling doesn't work. I've changed it to a signed integer.Signed-off-by Dan Carpenter <[email protected]>
LGTM, thanks for the fix.
regards
Suman