Skip to contentSkip to conversation

ARM: kirkwood: stop printk TCLK value at boot for DT boards

PATCH New Arnaud Patard (Rtp) 4 participants 7 messages Nov 5, 2013 – Nov 24, 2013

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 ARM: kirkwood: stop printk TCLK value at boot for DT boards

Commit 2326f04321a9 (ARM: kirkwood: convert to DT irqchip and clocksource) dropped the call to kirkwood_timer_init() when booting with DT. This results in kirkwood_tclk not being set and the boot message is now:

Kirkwood: MV88F6281-A0, TCLK=0

This patch modifies the message for printing only the kirkwood id, as it allows to detect if we're running A0/A1/... variants with a simple dmesg.

---

arch/arm/mach-kirkwood/board-dt.c +1 -1
Index: linux-next/arch/arm/mach-kirkwood/board-dt.c
===================================================================
@@ -140,7 +140,7 @@ eth_fixup_skip:
 
 static void __init kirkwood_dt_init(void)
 {
-	pr_info("Kirkwood: %s, TCLK=%d.\n", kirkwood_id(), kirkwood_tclk);
+	pr_info("Kirkwood: %s.\n", kirkwood_id());
 
 	/*
 	 * Disable propagation of mbus errors to the CPU local bus,
#1 lore raw

PATCH 1/1 ARM: kirkwood: stop printk TCLK value at boot for DT boards

Quoted 9 lines · Arnaud Patard (Rtp)

Commit 2326f04321a9 (ARM: kirkwood: convert to DT irqchip and clocksource) dropped the call to kirkwood_timer_init() when booting with DT. This results in kirkwood_tclk not being set and the boot message is now:

Kirkwood: MV88F6281-A0, TCLK=0

This patch modifies the message for printing only the kirkwood id, as it allows to detect if we're running A0/A1/... variants with a simple dmesg.

Arnaud,

for DT based booting we also have the "Machine" printed right above the "Kirkwood" string. Don't you think, that we can remove the pr_info completely?

Sebastian

Quoted 23 lines

---

Index: linux-next/arch/arm/mach-kirkwood/board-dt.c
===================================================================

arch/arm/mach-kirkwood/board-dt.c +1 -1
@@ -140,7 +140,7 @@ eth_fixup_skip:
 
  static void __init kirkwood_dt_init(void)
  {
-	pr_info("Kirkwood: %s, TCLK=%d.\n", kirkwood_id(), kirkwood_tclk);
+	pr_info("Kirkwood: %s.\n", kirkwood_id());
 
  	/*
  	 * Disable propagation of mbus errors to the CPU local bus,

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel at lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

#2 lore raw

PATCH 1/1 ARM: kirkwood: stop printk TCLK value at boot for DT boards

Quoted 11 lines
Quoted 5 lines

Kirkwood: MV88F6281-A0, TCLK=0

This patch modifies the message for printing only the kirkwood id, as it allows to detect if we're running A0/A1/... variants with a simple dmesg.

Arnaud,

for DT based booting we also have the "Machine" printed right above the "Kirkwood" string. Don't you think, that we can remove the pr_info completely?

Hi Sebastian

I think it is useful, as a debug tool. What is printed here is probed from the hardware. We know it is correct. The Machine string is from DT and somebody could be trying to boot with the wrong DT blob.

Andrew

#3 lore raw

PATCH 1/1 ARM: kirkwood: stop printk TCLK value at boot for DT boards

In reply to Sebastian Hesselbarth
Quoted 11 lines · Sebastian Hesselbarth
Quoted 9 lines · Arnaud Patard (Rtp)

Commit 2326f04321a9 (ARM: kirkwood: convert to DT irqchip and clocksource) dropped the call to kirkwood_timer_init() when booting with DT. This results in kirkwood_tclk not being set and the boot message is now:

Kirkwood: MV88F6281-A0, TCLK=0

This patch modifies the message for printing only the kirkwood id, as it allows to detect if we're running A0/A1/... variants with a simple dmesg.

Quoted 5 lines

Arnaud,

for DT based booting we also have the "Machine" printed right above the "Kirkwood" string. Don't you think, that we can remove the pr_info completely?

The Machine give some valuable information as one can load wrong dtb (already happened here). Moreover, it's a of thing (see of_flat_dt_match_machine) so not something that can be decided on kirkwookd side.
About possible redundancy of informations between the "Kirkwood:" and the "Machine" lines, the former one gives the stepping. This allows to know easily if kwboot has a chance to work on the serial port.

Arnaud

#4 lore raw

PATCH 1/1 ARM: kirkwood: stop printk TCLK value at boot for DT boards

Quoted 16 lines · Arnaud Patard (Rtp)
Quoted 7 lines · Sebastian Hesselbarth
Quoted 6 lines · Arnaud Patard (Rtp)

Commit 2326f04321a9 (ARM: kirkwood: convert to DT irqchip and clocksource) dropped the call to kirkwood_timer_init() when booting with DT. This results in kirkwood_tclk not being set and the boot message is now:

Kirkwood: MV88F6281-A0, TCLK=0

Quoted 7 lines
Quoted 3 lines

This patch modifies the message for printing only the kirkwood id, as it allows to detect if we're running A0/A1/... variants with a simple dmesg.

for DT based booting we also have the "Machine" printed right above the "Kirkwood" string. Don't you think, that we can remove the pr_info completely?

Quoted 7 lines

The Machine give some valuable information as one can load wrong dtb (already happened here). Moreover, it's a of thing (see of_flat_dt_match_machine) so not something that can be decided on kirkwookd side.
About possible redundancy of informations between the "Kirkwood:" and the "Machine" lines, the former one gives the stepping. This allows to know easily if kwboot has a chance to work on the serial port.

Ok, I see there is a use for it. So,

Sebastian

#5 lore raw

PATCH 1/1 ARM: kirkwood: stop printk TCLK value at boot for DT boards

In reply to Arnaud Patard (Rtp)
Quoted 11 lines · Arnaud Patard

Commit 2326f04321a9 (ARM: kirkwood: convert to DT irqchip and clocksource) dropped the call to kirkwood_timer_init() when booting with DT. This results in kirkwood_tclk not being set and the boot message is now:

Kirkwood: MV88F6281-A0, TCLK=0

This patch modifies the message for printing only the kirkwood id, as it allows to detect if we're running A0/A1/... variants with a simple dmesg.

Andrew

Quoted 16 lines

Index: linux-next/arch/arm/mach-kirkwood/board-dt.c
===================================================================

arch/arm/mach-kirkwood/board-dt.c +1 -1
@@ -140,7 +140,7 @@ eth_fixup_skip:
 
 static void __init kirkwood_dt_init(void)
 {
-	pr_info("Kirkwood: %s, TCLK=%d.\n", kirkwood_id(), kirkwood_tclk);
+	pr_info("Kirkwood: %s.\n", kirkwood_id());
 
 	/*
 	 * Disable propagation of mbus errors to the CPU local bus,
Applied
#6 lore raw

PATCH 1/1 ARM: kirkwood: stop printk TCLK value at boot for DT boards

In reply to Arnaud Patard (Rtp)
Quoted 6 lines · Arnaud Patard

Commit 2326f04321a9 (ARM: kirkwood: convert to DT irqchip and clocksource) dropped the call to kirkwood_timer_init() when booting with DT. This results in kirkwood_tclk not being set and the boot message is now:

Kirkwood: MV88F6281-A0, TCLK=0

Quoted 8 lines

This patch modifies the message for printing only the kirkwood id, as it allows to detect if we're running A0/A1/... variants with a simple dmesg.

---

Index: linux-next/arch/arm/mach-kirkwood/board-dt.c

Applied to mvebu/soc with Sebastian and Andrew's Acks.

thx,

Jason.