serial: icom: dereference after free in load_code()
Subsystems (2)
PATCH 1/1 serial: icom: dereference after free in load_code()
We use "fw" in the next line after we release it. I've shifted the call to release_firmware() down a couple lines to fix this.
Signed-off-by Dan Carpenter <[email protected]>
drivers/tty/serial/icom.c +2 -2
@@ -455,11 +455,11 @@ static void load_code(struct icom_port *icom_port)for (index =0 ; index < fw->size; index++) new_page[index] = fw->data[index]; -release_firmware (fw); -writeb ((char ) ((fw->size +16 )/16 ), &icom_port->dram->mac_length);writel (temp_pci, &icom_port->dram->mac_load_addr); +release_firmware (fw); +/*Setting the syncReg to 0x80 causes adapter to start downloading the personality code into adapter instruction RAM. Once code is loaded, it will begin executing and, based on