pinctrl: rockchip: testing the wrong variable
Subsystems (3)
PATCH 1/1 pinctrl: rockchip: testing the wrong variable
There is a copy and paste bug so we test "info->reg_base" instead of "info->reg_pull".
Signed-off-by Dan Carpenter <[email protected]>
---
I can't compile this.
drivers/pinctrl/pinctrl-rockchip.c +2 -2
@@ -1453,8 +1453,8 @@ static int rockchip_pinctrl_probe(struct platform_device *pdev)if (ctrl->type =RK3188 ) { res =platform_get_resource (pdev,IORESOURCE_MEM ,1 ); info->reg_pull =devm_ioremap_resource (&pdev->dev, res); -if (IS_ERR (info->reg_base)) -return PTR_ERR (info->reg_base); +if (IS_ERR (info->reg_pull)) +return PTR_ERR (info->reg_pull); } ret =rockchip_gpiolib_register (pdev, info);
Am Freitag, 8. November 2013, 11:01:38 schrieb Dan Carpenter:
Quoted 4 lines
There is a copy and paste bug so we test "
info->reg_base" instead of "info->reg_pull".Signed-off-by Dan Carpenter <[email protected]>
Thanks for the catch
Acked-by Heiko Stuebner <[email protected]>
Quoted 18 lines
---
I can't compile this.(quoted diff) +0
-0
b/drivers/pinctrl/pinctrl-rockchip.cindex e939c28..fe2ec1b 100644drivers/pinctrl/pinctrl-rockchip.c +2
-2@@ -1453,8 +1453,8 @@ static int rockchip_pinctrl_probe(struct platform_device *pdev) if (ctrl->type = RK3188) { res =platform_get_resource (pdev,IORESOURCE_MEM ,1 ); info->reg_pull =devm_ioremap_resource (&pdev->dev, res); -if (IS_ERR (info->reg_base)) -return PTR_ERR (info->reg_base); +if (IS_ERR (info->reg_pull)) +return PTR_ERR (info->reg_pull); } ret =rockchip_gpiolib_register (pdev, info);
Quoted 4 lines · Dan Carpenter
There is a copy and paste bug so we test "
info->reg_base" instead of "info->reg_pull".Signed-off-by Dan Carpenter <[email protected]>
Patch applied for fixes with Heiko's ACK.
Yours,
Linus Walleij