Skip to contentSkip to conversation

mmc: sdhci-s3c: fix missing clock for gpio card-detect

DISCUSSION Dan Carpenter 1 participant 1 message Nov 8, 2013 MMC, SD and SDIO

lore
Share & tools
lore
#0 lore raw

Hello Heiko Stübner,

This is a semi-automatic email about new static checker warnings.

The patch fe007c02f965: "mmc: sdhci-s3c: fix missing clock for gpio card-detect" from Nov 18, 2012, leads to the following Smatch complaint:

drivers/mmc/host/sdhci-s3c.c:381 sdhci_s3c_notify_change()
warn: variable dereferenced before check 'host' (see line 377)

drivers/mmc/host/sdhci-s3c.c
376 #ifdef CONFIG_PM_RUNTIME

   377		struct sdhci_s3c *sc = sdhci_priv(host);
                                       ^^^^^^^^^^^^^^^^

Dereference.

378 #endif
379 unsigned long flags;
380

   381		if (host) {
                   ^^^^^

Check.

   382			spin_lock_irqsave(&host->lock, flags);
   383			if (state) {

regards,
dan carpenter