Skip to contentSkip to conversation

gma500: initial medfield merge

DISCUSSION Dan Carpenter 1 participant 1 message Nov 8, 2013 Kernel janitors

lore
Share & tools
lore
#0 lore raw

Hello Kirill A. Shutemov,

This is a semi-automatic email about new static checker warnings.

The patch 026abc333205: "gma500: initial medfield merge" from Mar 8, 2012, leads to the following Smatch complaint:

drivers/gpu/drm/gma500/mdfld_dsi_pkg_sender.c:541 __read_panel_data()
warn: variable dereferenced before check 'sender' (see line 536)

drivers/gpu/drm/gma500/mdfld_dsi_pkg_sender.c
535 unsigned long flags;

   536		struct drm_device *dev = sender->dev;
                                         ^^^^^^^^^^^

Dereference.

537 int i;
538 u32 gen_data_reg;
539 int retry = MDFLD_DSI_READ_MAX_COUNT;
540

   541		if (!sender || !data_out || !len_out) {
                    ^^^^^^^

Check.

   542			DRM_ERROR("Invalid parameters\n");
   543			return -EINVAL;

regards,
dan carpenter