Skip to contentSkip to conversation

ipv6: protect for_each_sk_fl_rcu in mem_check with rcu_read_lock_bh

PATCH In review Hannes Frederic Sowa 2 participants 2 messages Nov 8, 2013 – Nov 11, 2013

Subsystems (4)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 ipv6: protect for_each_sk_fl_rcu in mem_check with rcu_read_lock_bh

Fixes a suspicious rcu derference warning.

---
 net/ipv6/ip6_flowlabel.c | 2 ++
 1 file changed, 2 insertions(+)
net/ipv6/ip6_flowlabel.c +2 -0
index 98fdcc6..e7fb710 100644
@@ -457,8 +457,10 @@ static int mem_check(struct sock *sk)
 	if (room > FL_MAX_SIZE - FL_MAX_PER_SOCK)
 		return 0;
 
+	rcu_read_lock_bh();
 	for_each_sk_fl_rcu(np, sfl)
 		count++;
+	rcu_read_unlock_bh();
 
 	if (room <= 0 ||
 	    ((count >= FL_MAX_PER_SOCK ||
Signature · 1 line
1.8.3.1