Skip to contentSkip to conversation

iozone: disable for uClibc 0.9.31

PATCH New spdawson at gmail.com 4 participants 6 messages Nov 11, 2013

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 iozone: disable for uClibc 0.9.31

From: Simon Dawson <[email protected]>

uClibc 0.9.31.x does not include the pthread_setaffinity_np GNU extension.

Fixes build failures such as the following.

http://autobuild.buildroot.net/results/e21526c0c18733310d3fb322d79d5fff3a71af51/

---
 package/iozone/Config.in | 1 +
 1 file changed, 1 insertion(+)
package/iozone/Config.in +1 -0
index 26d4daa..33e12ca 100644
@@ -1,6 +1,7 @@
 config BR2_PACKAGE_IOZONE
 	bool "iozone"
 	depends on BR2_USE_MMU # fork()
+	depends on !BR2_UCLIBC_VERSION_0_9_31 # no pthread_setaffinity_np
 	help
 	  IOzone is a filesystem benchmark tool.
 	  The benchmark generates and measures a variety of file operations
Signature · 1 line
1.8.3.2
#1 lore raw

PATCH 1/1 iozone: disable for uClibc 0.9.31

Quoted 19 lines
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line

"spdawson" == spdawson <[email protected]> writes:

From: Simon Dawson <[email protected]>
uClibc 0.9.31.x does not include the pthread_setaffinity_np GNU extension.

Fixes build failures such as the following.

http://autobuild.buildroot.net/results/e21526c0c18733310d3fb322d79d5fff3a71af51/

---
 package/iozone/Config.in | 1 +
 1 file changed, 1 insertion(+)
package/iozone/Config.in +0 -0
index 26d4daa..33e12ca 100644

package/iozone/Config.in line 4

Quoted 4 lines
package/iozone/Config.in +1 -0
@@ -1,6 +1,7 @@
 config BR2_PACKAGE_IOZONE
 	bool "iozone"
 	depends on BR2_USE_MMU # fork()
+	depends on !BR2_UCLIBC_VERSION_0_9_31 # no pthread_setaffinity_np

Committed, thanks. It sounds like it also needs to depend on BR2_TOOLCHAIN_HAS_THREADS. Care to send a patch adding that dependency and a comment line?

Signature · 1 line
Bye, Peter Korsgaard
#2 lore raw

PATCH 1/1 iozone: disable for uClibc 0.9.31

Hi Peter,

Quoted 3 lines · Peter Korsgaard

Committed, thanks. It sounds like it also needs to depend on BR2_TOOLCHAIN_HAS_THREADS. Care to send a patch adding that dependency and a comment line?

Yes, okay.

Simon.

#3 lore raw

PATCH 1/1 iozone: disable for uClibc 0.9.31

In reply to Peter Korsgaard

Hi Peter, Simon,

Quoted 14 lines · Peter Korsgaard
Quoted 13 lines
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line

"spdawson" == spdawson <[email protected]> writes:

From: Simon Dawson <[email protected]>
uClibc 0.9.31.x does not include the pthread_setaffinity_np GNU extension.

Fixes build failures such as the following.

http://autobuild.buildroot.net/results/e21526c0c18733310d3fb322d79d5fff3a71af51/

---
 package/iozone/Config.in | 1 +
 1 file changed, 1 insertion(+)
Quoted 13 lines

package/iozone/Config.in line 4

Quoted 9 lines
package/iozone/Config.in +1 -0
index 26d4daa..33e12ca 100644
@@ -1,6 +1,7 @@
 config BR2_PACKAGE_IOZONE
 	bool "iozone"
 	depends on BR2_USE_MMU # fork()
+	depends on !BR2_UCLIBC_VERSION_0_9_31 # no pthread_setaffinity_np

Committed, thanks. It sounds like it also needs to depend on BR2_TOOLCHAIN_HAS_THREADS. Care to send a patch adding that dependency and a comment line?

It also depends on BR2_PTHREADS_NATIVE. linuxthreads doesn't have pthread_setaffinity_np.

baruch

Signature · 3 lines
     http://baruch.siach.name/blog/                  ~. .~   Tk Open Systems
=}------------------------------------------------ooO--U--Ooo------------{=
   - baruch at tkos.co.il - tel: +972.2.679.5364, http://www.tkos.co.il -
#4 lore raw

PATCH 1/1 iozone: disable for uClibc 0.9.31

Hi Baruch,

Quoted 2 lines · Baruch Siach

It also depends on BR2_PTHREADS_NATIVE. linuxthreads doesn't have pthread_setaffinity_np.

Okay, thanks.

Simon.

#5 lore raw

PATCH 1/1 iozone: disable for uClibc 0.9.31

In reply to Baruch Siach

Dear Baruch Siach,

Quoted 6 lines · Baruch Siach
Quoted 3 lines

Committed, thanks. It sounds like it also needs to depend on BR2_TOOLCHAIN_HAS_THREADS. Care to send a patch adding that dependency and a comment line?

It also depends on BR2_PTHREADS_NATIVE. linuxthreads doesn't have pthread_setaffinity_np.

It is not allowed to add a BR2_PTHREADS_NATIVE dependency to a package, because this symbol is meaningless in the context of the external toolchain backend.

We probably need to add something like
http://patchwork.ozlabs.org/patch/258723/, but updated, and with a check in the external toolchain code to verify that the selection matches the reality.

Best regards,

Thomas

Signature · 3 lines
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com