Bug#511720: [PATCH iproute2] ss: avoid passing negative numbers to malloc
Subsystems (2)
Example:
$ ss state established \( sport = :4060 or sport = :4061 or sport = :4062 or sport = :4063 or sport = :4064 or sport = :4065 or sport = :4066 or sport = :4067 \) > /dev/null Aborted
In the example above ssfilter_bytecompile(...) will return (int)136. char l1 = 136; means -120 which will result in a negative number being passed to malloc at misc/ss.c:913.
Simply declare l1 and l2 as intergers to avoid the char overflow.
This is one of the issues originally reported in http://bugs.debian.org/511720
--- misc/ss.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)
misc/ss.c +2 -1
@@ -907,7 +907,8 @@ static int ssfilter_bytecompile(struct ssfilter *f, char **bytecode) }case SSF_OR : { -char *a1, *a2, *a, l1, l2; +char *a1, *a2, *a; +int l1, l2; l1 =ssfilter_bytecompile (f->pred, &a1); l2 =ssfilter_bytecompile (f->post, &a2);if (!(a =malloc (l1+l2+4 )))abort ();
Signature · 1 line
1.8.4.3
Re: [PATCH iproute2] ss: avoid passing negative numbers to malloc
Quoted 24 lines · Andreas Henriksson
Example:
$ ss state established \( sport = :4060 or sport = :4061 or sport = :4062 or sport = :4063 or sport = :4064 or sport = :4065 or sport = :4066 or sport = :4067 \) > /dev/null AbortedIn the example above
ssfilter_bytecompile(...)will return (int)136. char l1 = 136; means -120 which will result in a negative number being passed to malloc atmisc/ss.c:913.Simply declare l1 and l2 as intergers to avoid the char overflow.
This is one of the issues originally reported in http://bugs.debian.org/511720
Reported-by Andreas Schuldei <[email protected]>Signed-off-by Andreas Henriksson <[email protected]>--- misc/ss.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)misc/ss.c +0
-0
misc/ss.c static int ssfilter_bytecompile(struct ssfilter *f, char **bytecode) · line 914
Quoted 9 lines
misc/ss.c +2
-1@@ -907,7 +907,8 @@ static int ssfilter_bytecompile(struct ssfilter *f, char **bytecode) }case SSF_OR : { -char *a1, *a2, *a, l1, l2; +char *a1, *a2, *a; +int l1, l2; l1 =ssfilter_bytecompile (f->pred, &a1); l2 =ssfilter_bytecompile (f->post, &a2);if (!(a =malloc (l1+l2+4 )))abort ();
Please fix the other cases (SSF_NOT and SSF_AND) ?
Thanks !
PATCH v2 1/1 ss: avoid passing negative numbers to malloc
Example:
$ ss state established \( sport = :4060 or sport = :4061 or sport = :4062 or sport = :4063 or sport = :4064 or sport = :4065 or sport = :4066 or sport = :4067 \) > /dev/null Aborted
In the example above ssfilter_bytecompile(...) will return (int)136. char l1 = 136; means -120 which will result in a negative number being passed to malloc at misc/ss.c:913.
Simply declare l1 and l2 as integers to avoid the char overflow.
This is one of the issues originally reported in http://bugs.debian.org/511720
Fix the same problem in other code paths as well (thanks to Eric Dumazet).
--- misc/ss.c | 9 ++++++--- 1 file changed, 6 insertions(+), 3 deletions(-)
v2 fixes the same problem in other code paths (AND, NOT). Pointed out by Eric Dumazet.
misc/ss.c +6 -3
@@ -894,7 +894,8 @@ static int ssfilter_bytecompile(struct ssfilter *f, char **bytecode)case SSF_AND : { -char *a1, *a2, *a, l1, l2; +char *a1, *a2, *a; +int l1, l2; l1 =ssfilter_bytecompile (f->pred, &a1); l2 =ssfilter_bytecompile (f->post, &a2);if (!(a =malloc (l1+l2)))abort ();
@@ -907,7 +908,8 @@ static int ssfilter_bytecompile(struct ssfilter *f, char **bytecode) }case SSF_OR : { -char *a1, *a2, *a, l1, l2; +char *a1, *a2, *a; +int l1, l2; l1 =ssfilter_bytecompile (f->pred, &a1); l2 =ssfilter_bytecompile (f->post, &a2);if (!(a =malloc (l1+l2+4 )))abort ();
@@ -920,7 +922,8 @@ static int ssfilter_bytecompile(struct ssfilter *f, char **bytecode) }case SSF_NOT : { -char *a1, *a, l1; +char *a1, *a; +int l1; l1 =ssfilter_bytecompile (f->pred, &a1);if (!(a =malloc (l1+4 )))abort ();memcpy (a, a1, l1);
Signature · 1 line
1.8.4.3
Re: [PATCH iproute2 v2] ss: avoid passing negative numbers to malloc
Quoted 9 lines · Andreas Henriksson
Example:
$ ss state established \( sport = :4060 or sport = :4061 or sport = :4062 or sport = :4063 or sport = :4064 or sport = :4065 or sport = :4066 or sport = :4067 \) > /dev/null AbortedIn the example above
ssfilter_bytecompile(...)will return (int)136. char l1 = 136; means -120 which will result in a negative number being passed to malloc atmisc/ss.c:913.
Quoted 8 lines
Simply declare l1 and l2 as integers to avoid the char overflow.
This is one of the issues originally reported in http://bugs.debian.org/511720
Fix the same problem in other code paths as well (thanks to Eric Dumazet).
Reported-by Andreas Schuldei <[email protected]>Signed-off-by Andreas Henriksson <[email protected]>
Thanks !