perf trace: Tweak summary output
PATCH 1/1 perf trace: Tweak summary output
Tweak the summary output as suggested by Ingo Molnar:
[penberg@localhost ~]$ perf trace -a --duration 10000 --summary -- sleep 1 ^C Summary of events:
Xorg (817), 148 events, 0.0%, 0.000 msec
syscall calls min avg max stddev
(msec) (msec) (msec) (%)
--------------- -------- --------- --------- --------- ------
read 7 0.002 0.004 0.011 32.00%
rt_sigprocmask 40 0.001 0.001 0.002 1.31%
ioctl 6 0.002 0.003 0.005 19.45%
writev 7 0.004 0.018 0.059 43.76%
select 9 0.000 74.513 507.869 74.61%
setitimer 4 0.001 0.002 0.002 10.08%--- tools/perf/builtin-trace.c | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-)
tools/perf/builtin-trace.c +5 -5
@@ -2104,9 +2104,9 @@ static size_t thread__dump_stats(struct thread_trace *ttrace, printed +=fprintf (fp,"\n" ); - printed +=fprintf (fp," msec/call\n" ); - printed +=fprintf (fp," syscall calls min avg max stddev\n" ); - printed +=fprintf (fp," --------------- -------- -------- -------- -------- ------\n" ); + printed +=fprintf (fp," syscall calls min avg max stddev\n" ); + printed +=fprintf (fp," (msec) (msec) (msec) (%%)\n" ); + printed +=fprintf (fp," --------------- -------- --------- --------- --------- ------\n" );/* each int_node is a syscall */ while (inode) {
@@ -2123,9 +2123,9 @@ static size_t thread__dump_stats(struct thread_trace *ttrace, sc = &trace->syscalls.table[inode->i]; printed +=fprintf (fp," %-15s" , sc->name); - printed +=fprintf (fp," %8" PRIu64" %8.3f %8.3f" , + printed +=fprintf (fp," %8" PRIu64" %9.3f %9.3f" , n, min, avg); - printed +=fprintf (fp," %8.3f %6.2f\n" , max, pct); + printed +=fprintf (fp," %9.3f %9.2f%%\n" , max, pct); } inode =intlist__next (inode);
Signature · 1 line
1.8.3.1
Quoted 6 lines · Pekka Enberg
Tweak the summary output as suggested by Ingo Molnar:
[penberg@localhost ~]$ perf trace -a --duration 10000 --summary -- sleep 1 ^C Summary of events:
Quoted 11 lines
Xorg (817), 148 events, 0.0%, 0.000 msec
syscall calls min avg max stddev
(msec) (msec) (msec) (%)
--------------- -------- --------- --------- --------- ------
read 7 0.002 0.004 0.011 32.00%
rt_sigprocmask 40 0.001 0.001 0.002 1.31%
ioctl 6 0.002 0.003 0.005 19.45%
writev 7 0.004 0.018 0.059 43.76%
select 9 0.000 74.513 507.869 74.61%
setitimer 4 0.001 0.002 0.002 10.08%Are you convinced about double-digit precision output for percentages?
I think it suggest a false level of accuracy, but YYMV - typographically xx.yy certainly looks nicer than xx.y (it's more symmetric).
Thanks,
Ingo
Quoted 4 lines · Ingo Molnar
Are you convinced about double-digit precision output for percentages?
I think it suggest a false level of accuracy, but YYMV - typographically xx.yy certainly looks nicer than xx.y (it's more symmetric).
Yeah, I think it's OK.
Pekka
Ingo Molnar
Acked-byQuoted 7 lines · Pekka Enberg
Quoted 4 lines · Ingo Molnar
Are you convinced about double-digit precision output for percentages?
I think it suggest a false level of accuracy, but YYMV - typographically xx.yy certainly looks nicer than xx.y (it's more symmetric).
Yeah, I think it's OK.
ok.
Thanks,
Ingo
tip-bot for Pekka Enberg
merge botperf trace: Tweak summary output
Commit-ID: 27a778b512e002d856952b4f01842ba4d34bc3d1 Gitweb: http://git.kernel.org/tip/27a778b512e002d856952b4f01842ba4d34bc3d1 Author: Pekka Enberg <[email protected]> AuthorDate: Wed, 13 Nov 2013 14:21:48 +0200 Committer: Arnaldo Carvalho de Melo <[email protected]> CommitDate: Thu, 14 Nov 2013 15:59:20 -0300
perf trace: Tweak summary output
Tweak the summary output as suggested by Ingo Molnar:
[penberg@localhost ~]$ perf trace -a --duration 10000 --summary -- sleep 1 ^C Summary of events:
Xorg (817), 148 events, 0.0%, 0.000 msec
syscall calls min avg max stddev
(msec) (msec) (msec) (%)
--------------- -------- --------- --------- --------- ------
read 7 0.002 0.004 0.011 32.00%
rt_sigprocmask 40 0.001 0.001 0.002 1.31%
ioctl 6 0.002 0.003 0.005 19.45%
writev 7 0.004 0.018 0.059 43.76%
select 9 0.000 74.513 507.869 74.61%
setitimer 4 0.001 0.002 0.002 10.08%--- tools/perf/builtin-trace.c | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-)
tools/perf/builtin-trace.c +5 -5
@@ -2112,9 +2112,9 @@ static size_t thread__dump_stats(struct thread_trace *ttrace, printed +=fprintf (fp,"\n" ); - printed +=fprintf (fp," msec/call\n" ); - printed +=fprintf (fp," syscall calls min avg max stddev\n" ); - printed +=fprintf (fp," --------------- -------- -------- -------- -------- ------\n" ); + printed +=fprintf (fp," syscall calls min avg max stddev\n" ); + printed +=fprintf (fp," (msec) (msec) (msec) (%%)\n" ); + printed +=fprintf (fp," --------------- -------- --------- --------- --------- ------\n" );/* each int_node is a syscall */ while (inode) {
@@ -2131,9 +2131,9 @@ static size_t thread__dump_stats(struct thread_trace *ttrace, sc = &trace->syscalls.table[inode->i]; printed +=fprintf (fp," %-15s" , sc->name); - printed +=fprintf (fp," %8" PRIu64" %8.3f %8.3f" , + printed +=fprintf (fp," %8" PRIu64" %9.3f %9.3f" , n, min, avg); - printed +=fprintf (fp," %8.3f %6.2f\n" , max, pct); + printed +=fprintf (fp," %9.3f %9.2f%%\n" , max, pct); } inode =intlist__next (inode);