aio: checking for NULL instead of IS_ERR
Subsystems (3)
PATCH 1/1 aio: checking for NULL instead of IS_ERR
alloc_anon_inode() returns an ERR_PTR(), it doesn't return NULL.
Fixes 71ad7490c1f3 ('rework aio migrate pages to use aio fs')
Signed-off-by Dan Carpenter <[email protected]>
fs/aio.c +2 -2
@@ -164,8 +164,8 @@ static struct file *aio_private_file(struct kioctx *ctx, loff_t nr_pages)struct file *file;struct path path;struct inode *inode =alloc_anon_inode (aio_mnt->mnt_sb); -if (!inode) -return ERR_PTR (-ENOMEM ); +if (IS_ERR (inode)) +return ERR_CAST (inode); inode->i_mapping->a_ops = &aio_ctx_aops; inode->i_mapping->private_data = ctx;
Quoted 4 lines · Dan Carpenter
alloc_anon_inode()returns anERR_PTR(), it doesn't return NULL.Fixes 71ad7490c1f3 ('rework aio migrate pages to use aio fs')Signed-off-by Dan Carpenter <[email protected]>
Applied.
Quoted 4 lines · Dan Carpenter
alloc_anon_inode()returns anERR_PTR(), it doesn't return NULL.Fixes 71ad7490c1f3 ('rework aio migrate pages to use aio fs')Signed-off-by Dan Carpenter <[email protected]>
Thanks for spotting this.
Acked-by Benjamin LaHaise <[email protected]>
-ben
Quoted 15 lines
fs/aio.c +2
-2@@ -164,8 +164,8 @@ static struct file *aio_private_file(struct kioctx *ctx, loff_t nr_pages)struct file *file;struct path path;struct inode *inode =alloc_anon_inode (aio_mnt->mnt_sb); -if (!inode) -return ERR_PTR (-ENOMEM ); +if (IS_ERR (inode)) +return ERR_CAST (inode); inode->i_mapping->a_ops = &aio_ctx_aops; inode->i_mapping->private_data = ctx;
Signature · 1 line
"Thought is the essence of where you are now."