Skip to contentSkip to conversation

netfilter: Fix the format of /proc/net/nf_conntrack_expect

PATCH In review Changli Gao 2 participants 2 messages Nov 12, 2013 – Nov 13, 2013

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 netfilter: Fix the format of /proc/net/nf_conntrack_expect

There should not be any white space around `='.

---
 net/netfilter/nf_conntrack_expect.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
net/netfilter/nf_conntrack_expect.c +1 -1
index 4fd1ca9..151af72 100644
@@ -517,7 +517,7 @@ static int exp_seq_show(struct seq_file *s, void *v)
 			   ? (long)(expect->timeout.expires - jiffies)/HZ : 0);
 	else
 		seq_printf(s, "- ");
-	seq_printf(s, "l3proto = %u proto=%u ",
+	seq_printf(s, "l3proto=%u proto=%u ",
 		   expect->tuple.src.l3num,
 		   expect->tuple.dst.protonum);
 	print_tuple(s, &expect->tuple,
Signature · 1 line
1.7.9.5
#1 lore raw
Quoted 11 lines · Changli Gao

There should not be any white space around `='.

---
 net/netfilter/nf_conntrack_expect.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
net/netfilter/nf_conntrack_expect.c +0 -0
index 4fd1ca9..151af72 100644

net/netfilter/nf_conntrack_expect.c static int exp_seq_show(struct seq_file *s, void *v) · line 520

Quoted 5 lines
net/netfilter/nf_conntrack_expect.c +1 -1
@@ -517,7 +517,7 @@ static int exp_seq_show(struct seq_file *s, void *v)
 			   ? (long)(expect->timeout.expires - jiffies)/HZ : 0);
 	else
 		seq_printf(s, "- ");
-	seq_printf(s, "l3proto = %u proto=%u ",
+	seq_printf(s, "l3proto=%u proto=%u ",

Yes, that doesn't look nice, but that output format is there since 2006 (introduced in 77ab9cff).

This is a legacy interface (we have ctnetlink and the conntrack utility these days) and I don't want to break backward for applications parsing that output. I'm not taking this.