ARM: shmobile: r7s72100 GPIO DT nodes for GPIO RZ
Subsystems (2)
PATCH 1/1 ARM: shmobile: r7s72100 GPIO DT nodes for GPIO RZ
From: Magnus Damm <[email protected]>
Add a total of 13 GPIO DT device nodes for r7s72100.
---
arch/arm/boot/dts/r7s72100.dtsi | 131 +++++++++++++++++++++++++++++++++++++++ 1 file changed, 131 insertions(+)
arch/arm/boot/dts/r7s72100.dtsi +131 -0
@@ -14,6 +14,22 @@ #address-cells = <1>; #size-cells = <1>; + aliases { + gpio0 = &p0; + gpio1 = &p1; + gpio2 = &p2; + gpio3 = &p3; + gpio4 = &p4; + gpio5 = &p5; + gpio6 = &p6; + gpio7 = &p7; + gpio8 = &p8; + gpio9 = &p9; + gpio10 = &p10; + gpio11 = &p11; + gpio12 = &jp0; + }; + cpus { #address-cells = <1>; #size-cells = <0>;
@@ -33,4 +49,119 @@ reg = <0xe8201000 0x1000>, <0xe8202000 0x1000>; }; + + p0: gpio at fcfe3100 { + compatible = "renesas,gpio-r7s72100", "renesas,gpio-rz"; + reg = <0xfcfe3100 0x4>, /* PSR */ + <0xfcfe3200 0x2>, /* PPR */ + <0xfcfe3800 0x4>; /* PMSR */ + #gpio-cells = <2>; + gpio-controller; + }; + + p1: gpio at fcfe3104 { + compatible = "renesas,gpio-r7s72100", "renesas,gpio-rz"; + reg = <0xfcfe3104 0x4>, /* PSR */ + <0xfcfe3204 0x2>, /* PPR */ + <0xfcfe3804 0x4>; /* PMSR */ + #gpio-cells = <2>; + gpio-controller; + }; + + p2: gpio at fcfe3108 { + compatible = "renesas,gpio-r7s72100", "renesas,gpio-rz"; + reg = <0xfcfe3108 0x4>, /* PSR */ + <0xfcfe3208 0x2>, /* PPR */ + <0xfcfe3808 0x4>; /* PMSR */ + #gpio-cells = <2>; + gpio-controller; + }; + + p3: gpio at fcfe310c { + compatible = "renesas,gpio-r7s72100", "renesas,gpio-rz"; + reg = <0xfcfe310c 0x4>, /* PSR */ + <0xfcfe320c 0x2>, /* PPR */ + <0xfcfe380c 0x4>; /* PMSR */ + #gpio-cells = <2>; + gpio-controller; + }; + + p4: gpio at fcfe3110 { + compatible = "renesas,gpio-r7s72100", "renesas,gpio-rz"; + reg = <0xfcfe3110 0x4>, /* PSR */ + <0xfcfe3210 0x2>, /* PPR */ + <0xfcfe3810 0x4>; /* PMSR */ + #gpio-cells = <2>; + gpio-controller; + }; + + p5: gpio at fcfe3114 { + compatible = "renesas,gpio-r7s72100", "renesas,gpio-rz"; + reg = <0xfcfe3114 0x4>, /* PSR */ + <0xfcfe3214 0x2>, /* PPR */ + <0xfcfe3814 0x4>; /* PMSR */ + #gpio-cells = <2>; + gpio-controller; + }; + + p6: gpio at fcfe3118 { + compatible = "renesas,gpio-r7s72100", "renesas,gpio-rz"; + reg = <0xfcfe3118 0x4>, /* PSR */ + <0xfcfe3218 0x2>, /* PPR */ + <0xfcfe3818 0x4>; /* PMSR */ + #gpio-cells = <2>; + gpio-controller; + }; + + p7: gpio at fcfe311c { + compatible = "renesas,gpio-r7s72100", "renesas,gpio-rz"; + reg = <0xfcfe311c 0x4>, /* PSR */ + <0xfcfe321c 0x2>, /* PPR */ + <0xfcfe381c 0x4>; /* PMSR */ + #gpio-cells = <2>; + gpio-controller; + }; + + p8: gpio at fcfe3120 { + compatible = "renesas,gpio-r7s72100", "renesas,gpio-rz"; + reg = <0xfcfe3120 0x4>, /* PSR */ + <0xfcfe3220 0x2>, /* PPR */ + <0xfcfe3820 0x4>; /* PMSR */ + #gpio-cells = <2>; + gpio-controller; + }; + + p9: gpio at fcfe3124 { + compatible = "renesas,gpio-r7s72100", "renesas,gpio-rz"; + reg = <0xfcfe3124 0x4>, /* PSR */ + <0xfcfe3224 0x2>, /* PPR */ + <0xfcfe3824 0x4>; /* PMSR */ + #gpio-cells = <2>; + gpio-controller; + }; + + p10: gpio at fcfe3128 { + compatible = "renesas,gpio-r7s72100", "renesas,gpio-rz"; + reg = <0xfcfe3128 0x4>, /* PSR */ + <0xfcfe3228 0x2>, /* PPR */ + <0xfcfe3828 0x4>; /* PMSR */ + #gpio-cells = <2>; + gpio-controller; + }; + + p11: gpio at fcfe312c { + compatible = "renesas,gpio-r7s72100", "renesas,gpio-rz"; + reg = <0xfcfe312c 0x4>, /* PSR */ + <0xfcfe322c 0x2>, /* PPR */ + <0xfcfe382c 0x4>; /* PMSR */ + #gpio-cells = <2>; + gpio-controller; + }; + + jp0: gpio at fcfe7b20 { + compatible = "renesas,gpio-r7s72100", "renesas,gpio-rz"; + reg = <0xfcfe7b20 0x2>; /* JPPR */ + #gpio-cells = <2>; + gpio-controller; + }; };
PATCH 1/1 ARM: shmobile: r7s72100 GPIO DT nodes for GPIO RZ
Hi Magnus,
Thank you for the patch.
arch/arm/boot/dts/r7s72100.dtsi
Quoted 12 lines · On Thursday 14 November 2013 08:39:27 Magnus Damm wrote:
From: Magnus Damm <[email protected]>
Add a total of 13 GPIO DT device nodes for r7s72100.
Signed-off-by Magnus Damm <[email protected]>---
arch/arm/boot/dts/r7s72100.dtsi | 131 ++++++++++++++++++++++++++++++++++++ 1 file changed, 131 insertions(+)arch/arm/boot/dts/r7s72100.dtsi +0
-0
+0900
Quoted 7 lines
arch/arm/boot/dts/r7s72100.dtsi +3
-0@@ -14,6 +14,22 @@ #address-cells = <1>; #size-cells = <1>; + aliases { + gpio0 = &p0; + gpio1 = &p1;
arch/arm/boot/dts/r7s72100.dtsi line 29
Quoted 10 lines
arch/arm/boot/dts/r7s72100.dtsi +10
-0+ gpio2 = &p2; + gpio3 = &p3; + gpio4 = &p4; + gpio5 = &p5; + gpio6 = &p6; + gpio7 = &p7; + gpio8 = &p8; + gpio9 = &p9; + gpio10 = &p10; + gpio11 = &p11;
I would have called the phandles gpio[0-9]* instead of p[0-9]*. Shorter names may clash with something else later.
arch/arm/boot/dts/r7s72100.dtsi line 30
Quoted 1 line
arch/arm/boot/dts/r7s72100.dtsi +1
-0+ gpio12 = &jp0;
What is this special GPIO controller instance ?
Quoted 125 lines
arch/arm/boot/dts/r7s72100.dtsi +117
-0+ }; + cpus { #address-cells = <1>; #size-cells = <0>;@@ -33,4 +49,119 @@ reg = <0xe8201000 0x1000>, <0xe8202000 0x1000>; }; + + p0: gpio at fcfe3100 { + compatible = "renesas,gpio-r7s72100", "renesas,gpio-rz"; + reg = <0xfcfe3100 0x4>, /* PSR */ + <0xfcfe3200 0x2>, /* PPR */ + <0xfcfe3800 0x4>; /* PMSR */ + #gpio-cells = <2>; + gpio-controller; + }; + + p1: gpio at fcfe3104 { + compatible = "renesas,gpio-r7s72100", "renesas,gpio-rz"; + reg = <0xfcfe3104 0x4>, /* PSR */ + <0xfcfe3204 0x2>, /* PPR */ + <0xfcfe3804 0x4>; /* PMSR */ + #gpio-cells = <2>; + gpio-controller; + }; + + p2: gpio at fcfe3108 { + compatible = "renesas,gpio-r7s72100", "renesas,gpio-rz"; + reg = <0xfcfe3108 0x4>, /* PSR */ + <0xfcfe3208 0x2>, /* PPR */ + <0xfcfe3808 0x4>; /* PMSR */ + #gpio-cells = <2>; + gpio-controller; + }; + + p3: gpio at fcfe310c { + compatible = "renesas,gpio-r7s72100", "renesas,gpio-rz"; + reg = <0xfcfe310c 0x4>, /* PSR */ + <0xfcfe320c 0x2>, /* PPR */ + <0xfcfe380c 0x4>; /* PMSR */ + #gpio-cells = <2>; + gpio-controller; + }; + + p4: gpio at fcfe3110 { + compatible = "renesas,gpio-r7s72100", "renesas,gpio-rz"; + reg = <0xfcfe3110 0x4>, /* PSR */ + <0xfcfe3210 0x2>, /* PPR */ + <0xfcfe3810 0x4>; /* PMSR */ + #gpio-cells = <2>; + gpio-controller; + }; + + p5: gpio at fcfe3114 { + compatible = "renesas,gpio-r7s72100", "renesas,gpio-rz"; + reg = <0xfcfe3114 0x4>, /* PSR */ + <0xfcfe3214 0x2>, /* PPR */ + <0xfcfe3814 0x4>; /* PMSR */ + #gpio-cells = <2>; + gpio-controller; + }; + + p6: gpio at fcfe3118 { + compatible = "renesas,gpio-r7s72100", "renesas,gpio-rz"; + reg = <0xfcfe3118 0x4>, /* PSR */ + <0xfcfe3218 0x2>, /* PPR */ + <0xfcfe3818 0x4>; /* PMSR */ + #gpio-cells = <2>; + gpio-controller; + }; + + p7: gpio at fcfe311c { + compatible = "renesas,gpio-r7s72100", "renesas,gpio-rz"; + reg = <0xfcfe311c 0x4>, /* PSR */ + <0xfcfe321c 0x2>, /* PPR */ + <0xfcfe381c 0x4>; /* PMSR */ + #gpio-cells = <2>; + gpio-controller; + }; + + p8: gpio at fcfe3120 { + compatible = "renesas,gpio-r7s72100", "renesas,gpio-rz"; + reg = <0xfcfe3120 0x4>, /* PSR */ + <0xfcfe3220 0x2>, /* PPR */ + <0xfcfe3820 0x4>; /* PMSR */ + #gpio-cells = <2>; + gpio-controller; + }; + + p9: gpio at fcfe3124 { + compatible = "renesas,gpio-r7s72100", "renesas,gpio-rz"; + reg = <0xfcfe3124 0x4>, /* PSR */ + <0xfcfe3224 0x2>, /* PPR */ + <0xfcfe3824 0x4>; /* PMSR */ + #gpio-cells = <2>; + gpio-controller; + }; + + p10: gpio at fcfe3128 { + compatible = "renesas,gpio-r7s72100", "renesas,gpio-rz"; + reg = <0xfcfe3128 0x4>, /* PSR */ + <0xfcfe3228 0x2>, /* PPR */ + <0xfcfe3828 0x4>; /* PMSR */ + #gpio-cells = <2>; + gpio-controller; + }; + + p11: gpio at fcfe312c { + compatible = "renesas,gpio-r7s72100", "renesas,gpio-rz"; + reg = <0xfcfe312c 0x4>, /* PSR */ + <0xfcfe322c 0x2>, /* PPR */ + <0xfcfe382c 0x4>; /* PMSR */ + #gpio-cells = <2>; + gpio-controller; + }; + + jp0: gpio at fcfe7b20 { + compatible = "renesas,gpio-r7s72100", "renesas,gpio-rz"; + reg = <0xfcfe7b20 0x2>; /* JPPR */ + #gpio-cells = <2>; + gpio-controller; + }; };
Signature · 3 lines
Regards, Laurent Pinchart
PATCH 1/1 ARM: shmobile: r7s72100 GPIO DT nodes for GPIO RZ
Hi Laurent,
Quoted 22 lines · Laurent Pinchart
Hi Magnus,
Thank you for the patch.
arch/arm/boot/dts/r7s72100.dtsi 2013-11-13 22:33:56.000000000
Quoted 12 lines · On Thursday 14 November 2013 08:39:27 Magnus Damm wrote:
From: Magnus Damm <[email protected]>
Add a total of 13 GPIO DT device nodes for r7s72100.
Signed-off-by Magnus Damm <[email protected]>---
arch/arm/boot/dts/r7s72100.dtsi | 131 ++++++++++++++++++++++++++++++++++++ 1 file changed, 131 insertions(+)arch/arm/boot/dts/r7s72100.dtsi 2013-11-13 22:33:56.000000000 renamed from arch/arm/boot/dts/r7s72100.dtsi +0
-0+0900
Quoted 4 lines
arch/arm/boot/dts/r7s72100.dtsi 2013-11-13 22:33:56.000000000 renamed from arch/arm/boot/dts/r7s72100.dtsi +0
-0@@ -14,6 +14,22 @@ #address-cells = <1>; #size-cells = <1>;
Quoted 16 lines
arch/arm/boot/dts/r7s72100.dtsi 2013-11-13 22:33:56.000000000 line 29
Quoted 13 lines
arch/arm/boot/dts/r7s72100.dtsi 2013-11-13 22:33:56.000000000 renamed from arch/arm/boot/dts/r7s72100.dtsi +13
-0+ aliases { + gpio0 = &p0; + gpio1 = &p1; + gpio2 = &p2; + gpio3 = &p3; + gpio4 = &p4; + gpio5 = &p5; + gpio6 = &p6; + gpio7 = &p7; + gpio8 = &p8; + gpio9 = &p9; + gpio10 = &p10; + gpio11 = &p11;I would have called the phandles gpio[0-9]* instead of p[0-9]*. Shorter names may clash with something else later.
I see. In this case the p0-p11 names match with the datasheet. Would you prefer "port0" to match "Port 0" in the data sheet instead?
Quoted 3 lines
arch/arm/boot/dts/r7s72100.dtsi 2013-11-13 22:33:56.000000000 line 30
Quoted 1 line
arch/arm/boot/dts/r7s72100.dtsi 2013-11-13 22:33:56.000000000 renamed from arch/arm/boot/dts/r7s72100.dtsi +1
-0+ gpio12 = &jp0;What is this special GPIO controller instance ?
It is called "jp0" or "JTAG Port 0" in the data sheet. It's a read-only port for some pins associated with the JTAG connector.
Of course, it is possible to use gpio0 -> gpio12 but that is IMO more difficult to use since those won't match with the data sheet or schematics.
Thanks,
/ magnus
PATCH 1/1 ARM: shmobile: r7s72100 GPIO DT nodes for GPIO RZ
Hi Magnus,
Quoted 41 lines · On Thursday 14 November 2013 17:39:08 Magnus Damm wrote:
Quoted 18 lines · Laurent Pinchart
Quoted 17 lines · On Thursday 14 November 2013 08:39:27 Magnus Damm wrote:
From: Magnus Damm <[email protected]>
Add a total of 13 GPIO DT device nodes for r7s72100.
Signed-off-by Magnus Damm <[email protected]>---
arch/arm/boot/dts/r7s72100.dtsi | 131 +++++++++++++++++++++++++++++++++ 1 file changed, 131 insertions(+)arch/arm/boot/dts/r7s72100.dtsi 2013-11-13 renamed from arch/arm/boot/dts/r7s72100.dtsi +0
-022:33:56.000000000 +0900
arch/arm/boot/dts/r7s72100.dtsi 2013-11-13 renamed from arch/arm/boot/dts/r7s72100.dtsi +0
-0@@ -14,6 +14,22 @@ #address-cells = <1>; #size-cells = <1>;Quoted 16 lines
arch/arm/boot/dts/r7s72100.dtsi 2013-11-13 line 29
Quoted 13 lines
arch/arm/boot/dts/r7s72100.dtsi 2013-11-13 renamed from arch/arm/boot/dts/r7s72100.dtsi +13
-0+ aliases { + gpio0 = &p0; + gpio1 = &p1; + gpio2 = &p2; + gpio3 = &p3; + gpio4 = &p4; + gpio5 = &p5; + gpio6 = &p6; + gpio7 = &p7; + gpio8 = &p8; + gpio9 = &p9; + gpio10 = &p10; + gpio11 = &p11;I would have called the phandles gpio[0-9]* instead of p[0-9]*. Shorter names may clash with something else later.
I see. In this case the p0-p11 names match with the datasheet. Would you prefer "port0" to match "Port 0" in the data sheet instead?
Quoted 2 lines
Quoted 1 line
arch/arm/boot/dts/r7s72100.dtsi 2013-11-13 renamed from arch/arm/boot/dts/r7s72100.dtsi +1
-0+ gpio12 = &jp0;
Quoted 8 lines
Quoted 1 line
What is this special GPIO controller instance ?
It is called "jp0" or "JTAG Port 0" in the data sheet. It's a read-only port for some pins associated with the JTAG connector.
Of course, it is possible to use gpio0 -> gpio12 but that is IMO more difficult to use since those won't match with the data sheet or schematics.
Would port0 -> port 11 and jtag-port be fine ?
Signature · 3 lines
Regards, Laurent Pinchart