Input: hp_sdc_rtc - unlock on error in hp_sdc_rtc_read_i8042timer()
Subsystems (4)
PATCH 1/1 Input: hp_sdc_rtc - unlock on error in hp_sdc_rtc_read_i8042timer()
The transaction task here is hp_sdc_tasklet() and it releases the lock. The problem is if we aren't able to queue the transaction then we need to release the lock ourselves.
Signed-off-by Dan Carpenter <[email protected]>
drivers/input/misc/hp_sdc_rtc.c +4 -1
@@ -180,7 +180,10 @@ static int64_t hp_sdc_rtc_read_i8042timer (uint8_t loadcmd, int numreg)if (WARN_ON (down_interruptible (&i8042tregs)))return -1 ; -if (hp_sdc_enqueue_transaction (&t))return -1 ; +if (hp_sdc_enqueue_transaction (&t)) { +up (&i8042tregs); +return -1 ; + }/* Sleep until results come back. */ if (WARN_ON (down_interruptible (&i8042tregs)))
Quoted 5 lines · Dan Carpenter
The transaction task here is
hp_sdc_tasklet()and it releases the lock. The problem is if we aren't able to queue the transaction then we need to release the lock ourselves.Signed-off-by Dan Carpenter <[email protected]>
Applied, thank you.
Quoted 17 lines
drivers/input/misc/hp_sdc_rtc.c +4
-1@@ -180,7 +180,10 @@ static int64_t hp_sdc_rtc_read_i8042timer (uint8_t loadcmd, int numreg)if (WARN_ON (down_interruptible (&i8042tregs)))return -1 ; -if (hp_sdc_enqueue_transaction (&t))return -1 ; +if (hp_sdc_enqueue_transaction (&t)) { +up (&i8042tregs); +return -1 ; + }/* Sleep until results come back. */ if (WARN_ON (down_interruptible (&i8042tregs)))
Signature · 1 line
Dmitry