Skip to contentSkip to conversation

Require a 1.2.x PolarSSL version

PATCH In review Josh Cepek 3 participants 3 messages Nov 14, 2013

lore
Share & tools
lore

Josh Cepek

author
#0 lore raw

PATCH 1/1 Require a 1.2.x PolarSSL version

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

When used with PolarSSL, OpenVPN requires a library version 1.2.x (and not later.)

The attached patch fixes bug#343.

- --
Josh Cepek

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2.0.20 (GNU/Linux)

iQGcBAEBAgAGBQJShPMtAAoJENcx2Xpgb9RjfvkL/0R/n9dbIE59ox8M7TH6dsIZ yG8Sd0syIjZANwqti1WSwYjKI3cTnngTQH0piFaxPm37p+fj2ZudkggXnlzRvdBN GXdE3c1PDo13rGVKLopTUZ1pmX4zVHvCRkhhQaI6d6MFDqWauBUawIIEEmyen/xx jhgYJIzLYYaMN5Aent/yxScPleuze1d9b3cxoKsLNHLqcpj7WaN08YHW5It8KYWG 2AFFfrfvnpqSxO2ksP4AK/N2BRsAHOhmj1VCr5nQm59RrNB7PV5+aMBai3Rk8aMH xfkjSML6Y/vJ9vn/NZ2ohFKoobK7MpLnmHbp5VMfzUSiu3ew46euXyRorJRS4FQW xq3i73DbDiRJziJNvKsbT9qSEfqTcQY/7XhLwVdFPuZmL7bcTICeClz4TCqV9BrB 8kIIrGE9Q6cuM553/mWy/7SmnFDmaYSi3Tpeg18gXUB9TvH9eTpbgwr0cNwNAl/P S/N/pgU5owhhi59saD7Ao6tMD+nHTtiS2QMgnZF10A==
=wH4G
-----END PGP SIGNATURE-----

From 7ab2fcdbf75f37e86ba6f9d23bedf0d33547c59f Mon Sep 17 00:00:00 2001
From: Josh Cepek <[email protected]...>
Date: Thu, 14 Nov 2013 12:02:59 -0600
Subject: [PATCH] Require a 1.2.x PolarSSL version

Upstream policy on PolarSSL API compatibility does not guarantee stability between point-releases. For OpenVPN, we must verify a 1.2.x version with the current codebase.

This fixes bug#343.

---
 configure.ac | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
configure.ac +2 -2
index 5fad0af..b181f6d 100644
@@ -814,13 +814,13 @@ if test "${with_crypto_library}" = "polarssl" ; then
 #include <polarssl/version.h>
 			]],
 			[[
-#if POLARSSL_VERSION_NUMBER < 0x01020A00
+#if POLARSSL_VERSION_NUMBER < 0x01020A00 || POLARSSL_VERSION_NUMBER >= 0x01030000
 #error invalid version
 #endif
 			]]
 		)],
 		[AC_MSG_RESULT([ok])],
-		[AC_MSG_ERROR([PolarSSL 1.2.10 or newer required])]
+		[AC_MSG_ERROR([PolarSSL 1.2.x required and must be 1.2.10 or later])]
 	)
 
 	polarssl_with_pkcs11="no"
Signature · 1 line
1.8.1.5
#1 lore raw

Ack, the polarssl API policy requires us to be this strict.

-Steffan

Quoted 31 lines

-----Original Message-----
From: Josh Cepek [mailto:[email protected]...]
Sent: donderdag 14 november 2013 16:59
To: [email protected]
Subject: [Openvpn-devel] [PATCH] Require a 1.2.x PolarSSL version

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

When used with PolarSSL, OpenVPN requires a library version 1.2.x (and not later.)

The attached patch fixes bug#343.

- --
Josh Cepek

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2.0.20 (GNU/Linux)

iQGcBAEBAgAGBQJShPMtAAoJENcx2Xpgb9RjfvkL/0R/n9dbIE59ox8M7TH6dsIZ yG8Sd0syIjZANwqti1WSwYjKI3cTnngTQH0piFaxPm37p+fj2ZudkggXnlzRvdBN GXdE3c1PDo13rGVKLopTUZ1pmX4zVHvCRkhhQaI6d6MFDqWauBUawIIEEmyen/xx jhgYJIzLYYaMN5Aent/yxScPleuze1d9b3cxoKsLNHLqcpj7WaN08YHW5It8KYWG 2AFFfrfvnpqSxO2ksP4AK/N2BRsAHOhmj1VCr5nQm59RrNB7PV5+aMBai3Rk8aMH xfkjSML6Y/vJ9vn/NZ2ohFKoobK7MpLnmHbp5VMfzUSiu3ew46euXyRorJRS4FQW xq3i73DbDiRJziJNvKsbT9qSEfqTcQY/7XhLwVdFPuZmL7bcTICeClz4TCqV9BrB 8kIIrGE9Q6cuM553/mWy/7SmnFDmaYSi3Tpeg18gXUB9TvH9eTpbgwr0cNwNAl/P S/N/pgU5owhhi59saD7Ao6tMD+nHTtiS2QMgnZF10A==
=wH4G
-----END PGP SIGNATURE-----

#2 lore raw
In reply to Josh Cepek

Patch has been applied to the master and release/2.3 branch.

commit 7fc9245f5d97c7d76c635f8a3e38ab55ab27b27b (master) commit 941118fba8974464081f88c94b79e6e3c9a2779e (master)

Author: Josh Cepek <[email protected]...>
Date:   Thu Nov 14 12:02:59 2013 -0600
     Require a 1.2.x PolarSSL version

     Signed-off-by: Josh Cepek <[email protected]...>
     Acked-by: Steffan Karger <[email protected]...>
     Message-Id: <[email protected]...>
     URL: http://article.gmane.org/gmane.network.openvpn.devel/7968
     Signed-off-by: Gert Doering <[email protected]...>

--
kind regards,

Gert Doering