Skip to contentSkip to conversation

spi: s3c64xx: fix reference leak to master in s3c64xx_spi_remove()

PATCH New Wei Yongjun 2 participants 2 messages Nov 15, 2013

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 spi: s3c64xx: fix reference leak to master in s3c64xx_spi_remove()

From: Wei Yongjun <[email protected]>

Once a spi_master_get() call succeeds, we need an additional spi_master_put() call to free the memory, otherwise we will leak a reference to master. Fix by removing the unnecessary spi_master_get() call.

---
 drivers/spi/spi-s3c64xx.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/spi/spi-s3c64xx.c +1 -1
index 9e2020d..9c82d7b 100644
@@ -1439,7 +1439,7 @@ err0:
 
 static int s3c64xx_spi_remove(struct platform_device *pdev)
 {
-	struct spi_master *master = spi_master_get(platform_get_drvdata(pdev));
+	struct spi_master *master = platform_get_drvdata(pdev);
 	struct s3c64xx_spi_driver_data *sdd = spi_master_get_devdata(master);
 
 	pm_runtime_disable(&pdev->dev);
maintainer
#1 lore raw

PATCH 1/1 spi: s3c64xx: fix reference leak to master in s3c64xx_spi_remove()

Quoted 6 lines · Wei Yongjun

From: Wei Yongjun <[email protected]>

Once a spi_master_get() call succeeds, we need an additional spi_master_put() call to free the memory, otherwise we will leak a reference to master. Fix by removing the unnecessary spi_master_get() call.

Applied, thanks.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 836 bytes
Desc: Digital signature
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20131115/1b398e42/attachment-0001.sig>