Skip to contentSkip to conversation

ARM: nommu: Include asm/procinfo.h to fix build warning

PATCH New Axel Lin 4 participants 4 messages Nov 15, 2013 Arm (32-bit)

lore
Share & tools
lore

Axel Lin

author
#0 lore raw

PATCH 1/1 ARM: nommu: Include asm/procinfo.h to fix build warning

Include asm/procinfo.h to fix below build warning:
CC arch/arm/mm/nommu.o
arch/arm/mm/nommu.c:303:17: warning: 'struct proc_info_list' declared inside parameter list [enabled by default] arch/arm/mm/nommu.c:303:17: warning: its scope is only this definition or declaration, which is probably not what you want [enabled by default]

---
 arch/arm/mm/nommu.c | 1 +
 1 file changed, 1 insertion(+)
arch/arm/mm/nommu.c +1 -0
index 5c668b7..55764a7 100644
@@ -18,6 +18,7 @@
 #include <asm/mach/arch.h>
 #include <asm/cputype.h>
 #include <asm/mpu.h>
+#include <asm/procinfo.h>
 
 #include "mm.h"
 
Signature · 1 line
1.8.1.2
#1 lore raw

PATCH 1/1 ARM: nommu: Include asm/procinfo.h to fix build warning

Quoted 6 lines · Axel Lin

Include asm/procinfo.h to fix below build warning:
CC arch/arm/mm/nommu.o
arch/arm/mm/nommu.c:303:17: warning: 'struct proc_info_list' declared inside parameter list [enabled by default] arch/arm/mm/nommu.c:303:17: warning: its scope is only this definition or declaration, which is probably not what you want [enabled by default]

This is identical to the patch I posted a day earlier, that I just sent to Russell's patch tracker. :)

-Olof

#2 lore raw

PATCH 1/1 ARM: nommu: Include asm/procinfo.h to fix build warning

Quoted 10 lines · Olof Johansson
Quoted 6 lines · Axel Lin

Include asm/procinfo.h to fix below build warning:
CC arch/arm/mm/nommu.o
arch/arm/mm/nommu.c:303:17: warning: 'struct proc_info_list' declared inside parameter list [enabled by default] arch/arm/mm/nommu.c:303:17: warning: its scope is only this definition or declaration, which is probably not what you want [enabled by default]

This is identical to the patch I posted a day earlier, that I just sent to Russell's patch tracker. :)

And I probably have a near identical patch which I committed yesterday morning.

#3 lore raw

PATCH 1/1 ARM: nommu: Include asm/procinfo.h to fix build warning

In reply to Axel Lin
Quoted 9 lines · Axel Lin

Include asm/procinfo.h to fix below build warning:
CC arch/arm/mm/nommu.o
arch/arm/mm/nommu.c:303:17: warning: 'struct proc_info_list' declared inside parameter list [enabled by default] arch/arm/mm/nommu.c:303:17: warning: its scope is only this definition or declaration, which is probably not what you want [enabled by default]

---
 arch/arm/mm/nommu.c | 1 +
 1 file changed, 1 insertion(+)

Interesting, I didn't see those at the time when writing the patch. Perhaps some reordering of includes subsequently caused this to happen?

Thierry
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 836 bytes
Desc: not available
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20131115/cf0b6c13/attachment-0001.sig>