Skip to contentSkip to conversation

t_client.sh: Write errors to stderr and document requirements

PATCH In review David Sommerseth 3 participants 3 messages Nov 16, 2013

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 t_client.sh: Write errors to stderr and document requirements

From: David Sommerseth <[email protected]...>

---
 INSTALL              | 4 ++++
 tests/t_client.sh.in | 4 ++--
 2 files changed, 6 insertions(+), 2 deletions(-)
INSTALL +4 -0
index 61dc975..2ef7904 100644
@@ -87,6 +87,10 @@ OPTIONAL (for developers only):
       -- available from http://www.gnu.org/software/software.html
   (2) Dmalloc library
       -- available from http://dmalloc.com/
+  (3) If using t_client.sh test framework, fping/fping6 is needed
+      -- Available from http://www.fping.org/
+      Note: t_client.sh needs an external configured OpenVPN server.
+      See t_client.rc-sample for more info.
 
 *************************************************************************
 
tests/t_client.sh.in +2 -2
index af12e2d..b13c802 100755
@@ -27,12 +27,12 @@ fi
 # Check for external dependencies
 which fping > /dev/null
 if [ $? -ne 0 ]; then
-    echo "$0: fping is not available in \$PATH"
+    echo "$0: fping is not available in \$PATH" >&2
     exit 77
 fi
 which fping6 > /dev/null
 if [ $? -ne 0 ]; then
-    echo "$0: fping6 is not available in \$PATH"
+    echo "$0: fping6 is not available in \$PATH" >&2
     exit 77
 fi
 
Signature · 1 line
1.8.3.1
#1 lore raw

ACK.

Am 16.11.2013 11:23, schrieb David Sommerseth:

Quoted 43 lines

From: David Sommerseth <[email protected]...>

---
 INSTALL              | 4 ++++
 tests/t_client.sh.in | 4 ++--
 2 files changed, 6 insertions(+), 2 deletions(-)
INSTALL +4 -0
index 61dc975..2ef7904 100644
@@ -87,6 +87,10 @@ OPTIONAL (for developers only):
       -- available from http://www.gnu.org/software/software.html
   (2) Dmalloc library
       -- available from http://dmalloc.com/
+  (3) If using t_client.sh test framework, fping/fping6 is needed
+      -- Available from http://www.fping.org/
+      Note: t_client.sh needs an external configured OpenVPN server.
+      See t_client.rc-sample for more info.
 
 *************************************************************************
 
tests/t_client.sh.in +2 -2
index af12e2d..b13c802 100755
@@ -27,12 +27,12 @@ fi
 # Check for external dependencies
 which fping > /dev/null
 if [ $? -ne 0 ]; then
-    echo "$0: fping is not available in \$PATH"
+    echo "$0: fping is not available in \$PATH" >&2
     exit 77
 fi
 which fping6 > /dev/null
 if [ $? -ne 0 ]; then
-    echo "$0: fping6 is not available in \$PATH"
+    echo "$0: fping6 is not available in \$PATH" >&2
     exit 77
 fi
 
#2 lore raw
In reply to David Sommerseth

ACK. Patch has been applied to the master branch.

commit ebcd7549ac73a2d649afd0629cb5a7fe0e02b8f7

Author: David Sommerseth
Date:   Sat Nov 16 11:23:43 2013 +0100
     t_client.sh: Write errors to stderr and document requirements

     Signed-off-by: David Sommerseth <[email protected]...>
     Acked-by: Matthias Andree <[email protected]...>
     Acked-by: Gert Doering <[email protected]...>
     Message-Id: <[email protected]...>
     URL: http://article.gmane.org/gmane.network.openvpn.devel/7984
     Signed-off-by: Gert Doering <[email protected]...>

--
kind regards,

Gert Doering