net, virtio_net: replace the magic value
Subsystems (3)
PATCH 4/4 net, virtio_net: replace the magic value
From: Zhi Yong Wu <[email protected]>
It is more appropriate to use # of queue pairs currently used by the driver instead of a magic value.
--- drivers/net/virtio_net.c | 4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-)
drivers/net/virtio_net.c +2 -2
@@ -1619,8 +1619,8 @@ static int virtnet_probe(struct virtio_device *vdev)if (err) goto free_stats; -netif_set_real_num_tx_queues (dev,1 ); -netif_set_real_num_rx_queues (dev,1 ); +netif_set_real_num_tx_queues (dev, vi->curr_queue_pairs); +netif_set_real_num_rx_queues (dev, vi->curr_queue_pairs); err =register_netdev (dev);if (err) {
Signature · 1 line
1.7.6.5
Michael S. Tsirkin
maintainerQuoted 6 lines · Zhi Yong Wu
From: Zhi Yong Wu <[email protected]>
It is more appropriate to use # of queue pairs currently used by the driver instead of a magic value.
Signed-off-by Zhi Yong Wu <[email protected]>
I don't mind, but driver should be submitted separately from qemu patches. As it is only patch 4/4 made it to netdev.
Quoted 22 lines
--- drivers/net/virtio_net.c | 4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-)drivers/net/virtio_net.c +2
-2@@ -1619,8 +1619,8 @@ static int virtnet_probe(struct virtio_device *vdev)if (err) goto free_stats; -netif_set_real_num_tx_queues (dev,1 ); -netif_set_real_num_rx_queues (dev,1 ); +netif_set_real_num_tx_queues (dev, vi->curr_queue_pairs); +netif_set_real_num_rx_queues (dev, vi->curr_queue_pairs); err =register_netdev (dev);if (err) {Signature · 1 line
1.7.6.5
Quoted 10 lines · Michael S. Tsirkin
Quoted 6 lines · Zhi Yong Wu
From: Zhi Yong Wu <[email protected]>
It is more appropriate to use # of queue pairs currently used by the driver instead of a magic value.
Signed-off-by Zhi Yong Wu <[email protected]>I don't mind, but driver should be submitted separately from qemu patches. As it is only patch 4/4 made it to netdev.
ok, i will sent v2. By the way, can you help take a look at the following patches? Maybe i can send their v2 together. [PATCH 1/3] vhost: remove the dead branch
[PATCH 2/3] vhost: adjust vhost_dev_init() to be void [PATCH 3/3] vhost: fix the wrong log descriptions
Quoted 23 lines
Quoted 23 lines
--- drivers/net/virtio_net.c | 4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-)drivers/net/virtio_net.c +2
-3@@ -1619,8 +1619,8 @@ static int virtnet_probe(struct virtio_device *vdev)if (err) goto free_stats; -netif_set_real_num_tx_queues (dev,1 ); -netif_set_real_num_rx_queues (dev,1 ); +netif_set_real_num_tx_queues (dev, vi->curr_queue_pairs); +netif_set_real_num_rx_queues (dev, vi->curr_queue_pairs); err =register_netdev (dev);if (err) { --1.7.6.5
Signature · 3 lines
Regards, Zhi Yong Wu
Michael S. Tsirkin
maintainerQuoted 7 lines · Zhi Yong Wu
Quoted 6 lines · Michael S. Tsirkin
Quoted 5 lines · Zhi Yong Wu
From: Zhi Yong Wu <[email protected]>
It is more appropriate to use # of queue pairs currently used by the driver instead of a magic value.
Quoted 6 lines
Quoted 4 lines
Quoted 1 line
Signed-off-by Zhi Yong Wu <[email protected]>I don't mind, but driver should be submitted separately from qemu patches. As it is only patch 4/4 made it to netdev.
ok, i will sent v2. By the way, can you help take a look at the following patches?
Will do.
Quoted 1 line
Maybe i can send their v2 together.
Please don't, these seem to be completely unrelated.
Quoted 35 lines
[PATCH 1/3] vhost: remove the dead branch [PATCH 2/3] vhost: adjust
vhost_dev_init()to be void [PATCH 3/3] vhost: fix the wrong log descriptionsQuoted 23 lines
Quoted 23 lines
--- drivers/net/virtio_net.c | 4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-)drivers/net/virtio_net.c +2
-3@@ -1619,8 +1619,8 @@ static int virtnet_probe(struct virtio_device *vdev)if (err) goto free_stats; -netif_set_real_num_tx_queues (dev,1 ); -netif_set_real_num_rx_queues (dev,1 ); +netif_set_real_num_tx_queues (dev, vi->curr_queue_pairs); +netif_set_real_num_rx_queues (dev, vi->curr_queue_pairs); err =register_netdev (dev);if (err) { --1.7.6.5
Signature · 3 lines
Regards, Zhi Yong Wu
Quoted 12 lines · Michael S. Tsirkin
Quoted 11 lines · Zhi Yong Wu
Quoted 10 lines · Michael S. Tsirkin
Quoted 6 lines · Zhi Yong Wu
From: Zhi Yong Wu <[email protected]>
It is more appropriate to use # of queue pairs currently used by the driver instead of a magic value.
Signed-off-by Zhi Yong Wu <[email protected]>I don't mind, but driver should be submitted separately from qemu patches. As it is only patch 4/4 made it to netdev.
Quoted 8 lines
Quoted 2 lines
ok, i will sent v2. By the way, can you help take a look at the following patches?
Will do.
Quoted 1 line
Maybe i can send their v2 together.
Please don't, these seem to be completely unrelated.
OK, i will send it separately.
Quoted 36 lines
Quoted 36 lines
[PATCH 1/3] vhost: remove the dead branch [PATCH 2/3] vhost: adjust
vhost_dev_init()to be void [PATCH 3/3] vhost: fix the wrong log descriptionsQuoted 18 lines
Quoted 18 lines
--- drivers/net/virtio_net.c | 4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-)drivers/net/virtio_net.c +2
-2@@ -1619,8 +1619,8 @@ static int virtnet_probe(struct virtio_device *vdev)if (err) goto free_stats; -netif_set_real_num_tx_queues (dev,1 ); -netif_set_real_num_rx_queues (dev,1 ); +netif_set_real_num_tx_queues (dev, vi->curr_queue_pairs); +netif_set_real_num_rx_queues (dev, vi->curr_queue_pairs);Quoted 5 lines
Quoted 5 lines
drivers/net/virtio_net.c +0
-1err =register_netdev (dev);if (err) { --1.7.6.5
--
Regards,Zhi Yong Wu
Signature · 3 lines
Regards, Zhi Yong Wu