Prepare making omap3 device tree only and convert LDP
Subsystems (6)
Tony Lindgren
maintainercover Prepare making omap3 device tree only and convert LDP
Hi all,
Here are few patches to deal with the mix of legacy platform data and device tree that we still need to do at least until DSS has device tree bindings. These patches should allow the remaining omap3 boards to be made device tree only so we can remove the board-*.c files.
I've also converted the old LDP board to be device tree only as that has the typical TWL GPIO controlled LCD panel setup, and made sure the basic things work.
These patches are against mainline tree commit 10d0c9705, and also needs the recently posted patches from following:
[PATCH 0/8] Various omap device tree usability fixes for v3.13 merge window [PATCH 00/11] Make omap24xx booting device tree based for v3.14 merge window
I've also pushed all the related patches to a temporary branch omap-for-v3.14/tmp-testing-dt in the linux-omap git tree.
Regards,
Tony
Tony Lindgren (5):
mfd: twl-core: Fix passing of platform data in the device tree case
ARM: OMAP2+: Add support for legacy auxdata for twl
ARM: OMAP2+: Add DT init code for DPI displays and make omap3 LDP to
use it
ARM: dts: Add basic support for omap3 LDP zoom1 labrador
ARM: OMAP2+: Remove legacy booting support for LDP
arch/arm/boot/dts/Makefile | 1 + arch/arm/boot/dts/omap3-ldp.dts | 231 ++++++++++++++++++++ arch/arm/mach-omap2/Kconfig | 6 - arch/arm/mach-omap2/Makefile | 1 - arch/arm/mach-omap2/board-ldp.c | 425 ------------------------------------- arch/arm/mach-omap2/common.h | 1 + arch/arm/mach-omap2/dss-common.c | 67 ++++++ arch/arm/mach-omap2/dss-common.h | 1 + arch/arm/mach-omap2/omap_device.c | 2 + arch/arm/mach-omap2/pdata-quirks.c | 31 +++ drivers/mfd/twl-core.c | 15 +- 11 files changed, 346 insertions(+), 435 deletions(-) create mode 100644 arch/arm/boot/dts/omap3-ldp.dts delete mode 100644 arch/arm/mach-omap2/board-ldp.c
Signature · 1 line
1.8.1.1
Tony Lindgren
maintainerPATCH 1/5 mfd: twl-core: Fix passing of platform data in the device tree case
Since we still need to rely on a mix of device tree initialized drivers and legacy platform data initialize drivers, let's fix the passing of platform data to twl4030-gpio.
As the twl4030 GPIO is initialized by twl-core.c, we need to register the auxdata for twl4030 GPIO in twl-core.c.
---
Samuel & Lee, I'd like to merge this fix via arm-soc tree if this looks OK to you as I have other patches that depend on this.
--- drivers/mfd/twl-core.c | 15 ++++++++++++--- 1 file changed, 12 insertions(+), 3 deletions(-)
drivers/mfd/twl-core.c +12 -3
@@ -1133,6 +1133,11 @@ static int twl_remove(struct i2c_client *client)return 0 ; } +static struct of_dev_auxdata twl_auxdata_lookup[] = { +OF_DEV_AUXDATA ("ti,twl4030-gpio" ,0 ,"twl4030-gpio" ,NULL ), + {/* sentinel */ }, +}; +/* NOTE: This driver only handles a single twl4030/tps659x0 chip */ static int twl_probe (struct i2c_client *client,const struct i2c_device_id *id)
@@ -1271,10 +1276,14 @@ twl_probe(struct i2c_client *client, const struct i2c_device_id *id)twl_i2c_write_u8 (TWL4030_MODULE_INTBR , temp,REG_GPPUPDCTR1 ); } -if (node) - status =of_platform_populate (node,NULL ,NULL , &client->dev); -else +if (node) { +if (pdata) + twl_auxdata_lookup[0 ].platform_data = pdata->gpio; + status =of_platform_populate (node,NULL , twl_auxdata_lookup, + &client->dev); + }else { status =add_children (pdata, irq_base, id->driver_data); + } fail:if (status <0 )
Signature · 1 line
1.8.1.1
PATCH 1/5 mfd: twl-core: Fix passing of platform data in the device tree case
Quoted 39 lines
Since we still need to rely on a mix of device tree initialized drivers and legacy platform data initialize drivers, let's fix the passing of platform data to twl4030-gpio.
As the twl4030 GPIO is initialized by
twl-core.c, we need to register the auxdata for twl4030 GPIO intwl-core.c.Cc Samuel Ortiz <[email protected]>Cc Lee Jones <[email protected]>Signed-off-by Tony Lindgren <[email protected]>---
Samuel & Lee, I'd like to merge this fix via arm-soc tree if this looks OK to you as I have other patches that depend on this.
--- drivers/mfd/twl-core.c | 15 ++++++++++++--- 1 file changed, 12 insertions(+), 3 deletions(-)drivers/mfd/twl-core.c +5
-0@@ -1133,6 +1133,11 @@ static int twl_remove(struct i2c_client *client)return 0 ; } +static struct of_dev_auxdata twl_auxdata_lookup[] = { +OF_DEV_AUXDATA ("ti,twl4030-gpio" ,0 ,"twl4030-gpio" ,NULL ), + {/* sentinel */ }, +}; +/* NOTE: This driver only handles a single twl4030/tps659x0 chip */ static int twl_probe (struct i2c_client *client,const struct i2c_device_id *id)@@ -1271,10 +1276,14 @@ twl_probe(struct i2c_client *client, const struct i2c_device_id *id)twl_i2c_write_u8 (TWL4030_MODULE_INTBR , temp,REG_GPPUPDCTR1 ); }
drivers/mfd/twl-core.c twl_probe(struct i2c_client *client, const struct i2c_device_id *id) · line 1285
Quoted 10 lines
drivers/mfd/twl-core.c +6
-3-if (node) - status =of_platform_populate (node,NULL ,NULL , &client->dev); -else +if (node) { +if (pdata) + twl_auxdata_lookup[0 ].platform_data = pdata->gpio; + status =of_platform_populate (node,NULL , twl_auxdata_lookup, + &client->dev); + }else { status =add_children (pdata, irq_base, id->driver_data);
Why doesn't the TWL driver use the MFD framework for this stuff?
Quoted 4 lines
drivers/mfd/twl-core.c +1
-0+ } fail:if (status <0 )
Signature · 4 lines
Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org ? Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog
PATCH 1/5 mfd: twl-core: Fix passing of platform data in the device tree case
Hi,
Quoted 39 lines · Lee Jones
Quoted 39 lines
Since we still need to rely on a mix of device tree initialized drivers and legacy platform data initialize drivers, let's fix the passing of platform data to twl4030-gpio.
As the twl4030 GPIO is initialized by
twl-core.c, we need to register the auxdata for twl4030 GPIO intwl-core.c.Cc Samuel Ortiz <[email protected]>Cc Lee Jones <[email protected]>Signed-off-by Tony Lindgren <[email protected]>---
Samuel & Lee, I'd like to merge this fix via arm-soc tree if this looks OK to you as I have other patches that depend on this.
--- drivers/mfd/twl-core.c | 15 ++++++++++++--- 1 file changed, 12 insertions(+), 3 deletions(-)drivers/mfd/twl-core.c +5
-0@@ -1133,6 +1133,11 @@ static int twl_remove(struct i2c_client *client)return 0 ; } +static struct of_dev_auxdata twl_auxdata_lookup[] = { +OF_DEV_AUXDATA ("ti,twl4030-gpio" ,0 ,"twl4030-gpio" ,NULL ), + {/* sentinel */ }, +}; +/* NOTE: This driver only handles a single twl4030/tps659x0 chip */ static int twl_probe (struct i2c_client *client,const struct i2c_device_id *id)@@ -1271,10 +1276,14 @@ twl_probe(struct i2c_client *client, const struct i2c_device_id *id)twl_i2c_write_u8 (TWL4030_MODULE_INTBR , temp,REG_GPPUPDCTR1 ); }
Quoted 12 lines
drivers/mfd/twl-core.c twl_probe(struct i2c_client *client, const struct i2c_device_id *id) · line 1285
Quoted 10 lines
drivers/mfd/twl-core.c +6
-3-if (node) - status =of_platform_populate (node,NULL ,NULL , &client->dev); -else +if (node) { +if (pdata) + twl_auxdata_lookup[0 ].platform_data = pdata->gpio; + status =of_platform_populate (node,NULL , twl_auxdata_lookup, + &client->dev); + }else { status =add_children (pdata, irq_base, id->driver_data);Why doesn't the TWL driver use the MFD framework for this stuff?
that's reminiscent from years ago and, surely, needs to be fixed. Should we gate $subject for that, though ? This has been in tree for quite a few years already and Tony's patch is still a step forward, since most omap3 platforms would break on DT-only without it.
There are quite a few folks who could volunteer to fixing that after Tony's patch is in (me included, although there could be better choices hehe).
cheers
Signature · 8 lines
balbi -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 836 bytes Desc: Digital signature URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20131118/c09d0cfa/attachment.sig>
PATCH 1/5 mfd: twl-core: Fix passing of platform data in the device tree case
Quoted 25 lines
Quoted 12 lines
Quoted 12 lines
drivers/mfd/twl-core.c +5
-0+static struct of_dev_auxdata twl_auxdata_lookup[] = { +OF_DEV_AUXDATA ("ti,twl4030-gpio" ,0 ,"twl4030-gpio" ,NULL ), + {/* sentinel */ }, +}; +/* NOTE: This driver only handles a single twl4030/tps659x0 chip */ static int twl_probe (struct i2c_client *client,const struct i2c_device_id *id)@@ -1271,10 +1276,14 @@ twl_probe(struct i2c_client *client, const struct i2c_device_id *id)twl_i2c_write_u8 (TWL4030_MODULE_INTBR , temp,REG_GPPUPDCTR1 ); }Quoted 12 lines
drivers/mfd/twl-core.c twl_probe(struct i2c_client *client, const struct i2c_device_id *id) · line 1285
Quoted 10 lines
drivers/mfd/twl-core.c +6
-3-if (node) - status =of_platform_populate (node,NULL ,NULL , &client->dev); -else +if (node) { +if (pdata) + twl_auxdata_lookup[0 ].platform_data = pdata->gpio; + status =of_platform_populate (node,NULL , twl_auxdata_lookup, + &client->dev); + }else { status =add_children (pdata, irq_base, id->driver_data);Why doesn't the TWL driver use the MFD framework for this stuff?
Quoted 4 lines
that's reminiscent from years ago and, surely, needs to be fixed. Should we gate $subject for that, though ? This has been in tree for quite a few years already and Tony's patch is still a step forward, since most omap3 platforms would break on DT-only without it.
I didn't say that I would reject the patch. I was just surprised to see so much hand-rolling, as the MFD core code does much of it automatically. This is the first time I've taken a look at this and it seems to be quite the relic.
Quoted 3 lines
There are quite a few folks who could volunteer to fixing that after Tony's patch is in (me included, although there could be better choices hehe).
Well it's not doing any harm. I'll make a note to fix it myself if a) no one has done so already and b) I manage to find some spare time. The latter issue is less likely to be resolved. :)
Are you Acking this patch by the way?
Signature · 4 lines
Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org ? Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog
Tony Lindgren
maintainerPATCH 1/5 mfd: twl-core: Fix passing of platform data in the device tree case
Quoted 30 lines · Lee Jones
Quoted 25 lines
Quoted 12 lines
Quoted 12 lines
drivers/mfd/twl-core.c +5
-0+static struct of_dev_auxdata twl_auxdata_lookup[] = { +OF_DEV_AUXDATA ("ti,twl4030-gpio" ,0 ,"twl4030-gpio" ,NULL ), + {/* sentinel */ }, +}; +/* NOTE: This driver only handles a single twl4030/tps659x0 chip */ static int twl_probe (struct i2c_client *client,const struct i2c_device_id *id)@@ -1271,10 +1276,14 @@ twl_probe(struct i2c_client *client, const struct i2c_device_id *id)twl_i2c_write_u8 (TWL4030_MODULE_INTBR , temp,REG_GPPUPDCTR1 ); }Quoted 12 lines
drivers/mfd/twl-core.c twl_probe(struct i2c_client *client, const struct i2c_device_id *id) · line 1285
Quoted 10 lines
drivers/mfd/twl-core.c +6
-3-if (node) - status =of_platform_populate (node,NULL ,NULL , &client->dev); -else +if (node) { +if (pdata) + twl_auxdata_lookup[0 ].platform_data = pdata->gpio; + status =of_platform_populate (node,NULL , twl_auxdata_lookup, + &client->dev); + }else { status =add_children (pdata, irq_base, id->driver_data);Why doesn't the TWL driver use the MFD framework for this stuff?
Quoted 4 lines
that's reminiscent from years ago and, surely, needs to be fixed. Should we gate $subject for that, though ? This has been in tree for quite a few years already and Tony's patch is still a step forward, since most omap3 platforms would break on DT-only without it.
Quoted 4 lines
I didn't say that I would reject the patch. I was just surprised to see so much hand-rolling, as the MFD core code does much of it automatically. This is the first time I've taken a look at this and it seems to be quite the relic.
Yeah it seems something from the early days of MFD code. Then grepping for add_children shows that drivers/mfd/dm355evm_msp.c is doing it too, which should also be fixed while at it.
Quoted 7 lines
Quoted 3 lines
There are quite a few folks who could volunteer to fixing that after Tony's patch is in (me included, although there could be better choices hehe).
Well it's not doing any harm. I'll make a note to fix it myself if a) no one has done so already and b) I manage to find some spare time. The latter issue is less likely to be resolved. :)
Sounds like Felipe has already picked it up for future work :)
Quoted 1 line
Are you Acking this patch by the way?
If this looks acceptable to you guys, I'd like to merge this via my fixes branch this week with your acks if that works for you. That way I can base my omap legacy platform data removal patches on my fixes branch while keep things working for the drivers. Alternatively I can naturally base my legacy data removal on -rc2 too if this gets merged to mainline by then via the MFD tree.
Regards,
Tony
PATCH 1/5 mfd: twl-core: Fix passing of platform data in the device tree case
Quoted 8 lines
Quoted 1 line
Are you Acking this patch by the way?
If this looks acceptable to you guys, I'd like to merge this via my fixes branch this week with your acks if that works for you. That way I can base my omap legacy platform data removal patches on my fixes branch while keep things working for the drivers. Alternatively I can naturally base my legacy data removal on -rc2 too if this gets merged to mainline by then via the MFD tree.
I can either send it up for the -rcs, or I can create an immutable branch for you to pull from. That way the patch can do in via ARM-SoC and MFD and we can let Git sort it out.
Signature · 4 lines
Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org ? Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog
Tony Lindgren
maintainerPATCH 1/5 mfd: twl-core: Fix passing of platform data in the device tree case
Quoted 9 lines · Lee Jones
Quoted 8 lines
Quoted 1 line
Are you Acking this patch by the way?
If this looks acceptable to you guys, I'd like to merge this via my fixes branch this week with your acks if that works for you. That way I can base my omap legacy platform data removal patches on my fixes branch while keep things working for the drivers. Alternatively I can naturally base my legacy data removal on -rc2 too if this gets merged to mainline by then via the MFD tree.
Quoted 3 lines
I can either send it up for the -rcs, or I can create an immutable branch for you to pull from. That way the patch can do in via ARM-SoC and MFD and we can let Git sort it out.
OK great, I'd prefer an immutable branch that I can merge in too. Then you can bundle it with other MFD fixes for the -rc series and send it in when it suits you :)
Regards,
Tony
PATCH 1/5 mfd: twl-core: Fix passing of platform data in the device tree case
Quoted 10 lines · Tony Lindgren
Quoted 9 lines · Lee Jones
Quoted 8 lines
Quoted 1 line
Are you Acking this patch by the way?
If this looks acceptable to you guys, I'd like to merge this via my fixes branch this week with your acks if that works for you. That way I can base my omap legacy platform data removal patches on my fixes branch while keep things working for the drivers. Alternatively I can naturally base my legacy data removal on -rc2 too if this gets merged to mainline by then via the MFD tree.
Quoted 7 lines
Quoted 3 lines
I can either send it up for the -rcs, or I can create an immutable branch for you to pull from. That way the patch can do in via ARM-SoC and MFD and we can let Git sort it out.
OK great, I'd prefer an immutable branch that I can merge in too. Then you can bundle it with other MFD fixes for the -rc series and send it in when it suits you :)
That's fine. It's 19:30 here now and I still have a shed load of debugging to do, so I'll deal with this tomorrow if it's all the same to you?
Signature · 4 lines
Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org ? Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog
Tony Lindgren
maintainerPATCH 1/5 mfd: twl-core: Fix passing of platform data in the device tree case
Quoted 16 lines · Lee Jones
Quoted 14 lines · Tony Lindgren
Quoted 12 lines · Lee Jones
Quoted 8 lines
Quoted 1 line
Are you Acking this patch by the way?
If this looks acceptable to you guys, I'd like to merge this via my fixes branch this week with your acks if that works for you. That way I can base my omap legacy platform data removal patches on my fixes branch while keep things working for the drivers. Alternatively I can naturally base my legacy data removal on -rc2 too if this gets merged to mainline by then via the MFD tree.
I can either send it up for the -rcs, or I can create an immutable branch for you to pull from. That way the patch can do in via ARM-SoC and MFD and we can let Git sort it out.
Quoted 7 lines
Quoted 3 lines
OK great, I'd prefer an immutable branch that I can merge in too. Then you can bundle it with other MFD fixes for the -rc series and send it in when it suits you :)
That's fine. It's 19:30 here now and I still have a shed load of debugging to do, so I'll deal with this tomorrow if it's all the same to you?
Yeah sure I can wait few days no problem.
Thanks,
Tony
PATCH 1/5 mfd: twl-core: Fix passing of platform data in the device tree case
In reply to Tony LindgrenQuoted 10 lines · Tony Lindgren
Quoted 9 lines · Lee Jones
Quoted 8 lines
Quoted 1 line
Are you Acking this patch by the way?
If this looks acceptable to you guys, I'd like to merge this via my fixes branch this week with your acks if that works for you. That way I can base my omap legacy platform data removal patches on my fixes branch while keep things working for the drivers. Alternatively I can naturally base my legacy data removal on -rc2 too if this gets merged to mainline by then via the MFD tree.
Quoted 7 lines
Quoted 3 lines
I can either send it up for the -rcs, or I can create an immutable branch for you to pull from. That way the patch can do in via ARM-SoC and MFD and we can let Git sort it out.
OK great, I'd prefer an immutable branch that I can merge in too. Then you can bundle it with other MFD fixes for the -rc series and send it in when it suits you :)
https://git.linaro.org/gitweb?p=people/ljones/mfd.git;a=shortlog;h=refs/heads/for-mfd-fixes
Here Tony, you can take this one.
I will simply apply my other fixes on top of it.
The issue is, I will most likely have to rebase it on top of -rc1 prior to sending a request to Linus, so in that regard it's not exactly immutable.
Signature · 4 lines
Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org ? Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog
PATCH 1/5 mfd: twl-core: Fix passing of platform data in the device tree case
Quoted 8 lines
Here Tony, you can take this one.
I will simply apply my other fixes on top of it.
The issue is, I will most likely have to rebase it on top of -rc1 prior to sending a request to Linus, so in that regard it's not exactly immutable.
Ignore the above. This is what you want:
The following changes since commit 5e01dc7b26d9f24f39abace5da98ccbd6a5ceb52:
Linux 3.12 (2013-11-03 15:41:51 -0800)
are available in the git repository at:
git://git.linaro.org/people/ljones/mfd.git tags/ib-tony
for you to fetch changes up to f984370913d3ba5d13806cc8ac6fc26f8ebd1694:
mfd: twl-core: Fix passing of platform data in the device tree case (2013-11-21 10:42:36 +0000)
----------------------------------------------------------------
warning: refname 'ib-tony' is ambiguous. Immutable branch for Tony Lindgren
----------------------------------------------------------------
Tony Lindgren (1):
mfd: twl-core: Fix passing of platform data in the device tree case
drivers/mfd/twl-core.c | 15 ++++++++++++--- 1 file changed, 12 insertions(+), 3 deletions(-)
Signature · 4 lines
Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org ? Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog
Tony Lindgren
maintainerPATCH 1/5 mfd: twl-core: Fix passing of platform data in the device tree case
Quoted 10 lines · Lee Jones
Quoted 8 lines
Here Tony, you can take this one.
I will simply apply my other fixes on top of it.
The issue is, I will most likely have to rebase it on top of -rc1 prior to sending a request to Linus, so in that regard it's not exactly immutable.
Ignore the above. This is what you want:
Thanks, I'll use that commit in my omap-for-v3.14/board-removal branch.
Regards,
Tony
Quoted 28 lines
The following changes since commit
5e01dc7b26d9f24f39abace5da98ccbd6a5ceb52:Linux 3.12 (2013-11-03 15:41:51 -0800)
are available in the git repository at:
git://git.linaro.org/people/ljones/mfd.gittags/ib-tonyfor you to fetch changes up to
f984370913d3ba5d13806cc8ac6fc26f8ebd1694:mfd: twl-core: Fix passing of platform data in the device tree case (2013-11-21 10:42:36 +0000)
----------------------------------------------------------------
warning: refname 'ib-tony' is ambiguous. Immutable branch for Tony Lindgren----------------------------------------------------------------
Tony Lindgren (1):
mfd: twl-core: Fix passing of platform data in the device tree casedrivers/mfd/twl-core.c | 15 ++++++++++++--- 1 file changed, 12 insertions(+), 3 deletions(-)Signature · 4 lines
Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org ? Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog
PATCH 1/5 mfd: twl-core: Fix passing of platform data in the device tree case
In reply to Lee JonesHi,
Quoted 30 lines · Lee Jones
Quoted 25 lines
Quoted 12 lines
Quoted 12 lines
drivers/mfd/twl-core.c +5
-0+static struct of_dev_auxdata twl_auxdata_lookup[] = { +OF_DEV_AUXDATA ("ti,twl4030-gpio" ,0 ,"twl4030-gpio" ,NULL ), + {/* sentinel */ }, +}; +/* NOTE: This driver only handles a single twl4030/tps659x0 chip */ static int twl_probe (struct i2c_client *client,const struct i2c_device_id *id)@@ -1271,10 +1276,14 @@ twl_probe(struct i2c_client *client, const struct i2c_device_id *id)twl_i2c_write_u8 (TWL4030_MODULE_INTBR , temp,REG_GPPUPDCTR1 ); }Quoted 12 lines
drivers/mfd/twl-core.c twl_probe(struct i2c_client *client, const struct i2c_device_id *id) · line 1285
Quoted 10 lines
drivers/mfd/twl-core.c +6
-3-if (node) - status =of_platform_populate (node,NULL ,NULL , &client->dev); -else +if (node) { +if (pdata) + twl_auxdata_lookup[0 ].platform_data = pdata->gpio; + status =of_platform_populate (node,NULL , twl_auxdata_lookup, + &client->dev); + }else { status =add_children (pdata, irq_base, id->driver_data);Why doesn't the TWL driver use the MFD framework for this stuff?
Quoted 4 lines
that's reminiscent from years ago and, surely, needs to be fixed. Should we gate $subject for that, though ? This has been in tree for quite a few years already and Tony's patch is still a step forward, since most omap3 platforms would break on DT-only without it.
Quoted 4 lines
I didn't say that I would reject the patch. I was just surprised to see so much hand-rolling, as the MFD core code does much of it automatically. This is the first time I've taken a look at this and it seems to be quite the relic.
alright, thanks for confirming.
Quoted 9 lines
Quoted 3 lines
There are quite a few folks who could volunteer to fixing that after Tony's patch is in (me included, although there could be better choices hehe).
Well it's not doing any harm. I'll make a note to fix it myself if a) no one has done so already and b) I manage to find some spare time. The latter issue is less likely to be resolved. :)
Are you Acking this patch by the way?
sure:
Signature · 8 lines
balbi -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 836 bytes Desc: Digital signature URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20131118/db765769/attachment-0001.sig>
Tony Lindgren
maintainerPATCH 2/5 ARM: OMAP2+: Add support for legacy auxdata for twl
In reply to Tony LindgrenAs we currently need to support a mix of legacy platform data and device tree intialized data, let's make sure things keep working for the TWL GPIOs.
Mostly the issue is caused by the fact that DSS does not yet have device tree bindings, so we need to rely on the TWL GPIO callback for setting up things like LCD backlight for some boards.
As of_platform_populate() for the TWL GPIO is called by twl-core after the I2C bus has been initialized, we cannot pass the auxdata table from the board init code to twl-core like we used to with just legacy platform data.
So let's use the omap_device bus hook to patch in the platform data for TWL GPIO until we have sorted out the issues with the TWL GPIOs and device tree bindings.
The other option was be to initialize twl core using legacy platform data, which seems like a step backwards as we're moving to device tree only initialization. And we really don't want to add custom configuration functions to the TWL GPIO driver either for this.
--- arch/arm/mach-omap2/common.h | 1 + arch/arm/mach-omap2/omap_device.c | 2 ++ arch/arm/mach-omap2/pdata-quirks.c | 16 ++++++++++++++++ 3 files changed, 19 insertions(+)
arch/arm/mach-omap2/common.h +1 -0
@@ -293,6 +293,7 @@ static inline void omap4_cpu_resume(void)#endif void pdata_quirks_init (struct of_device_id *); +void omap_auxdata_legacy_init (struct device *dev);void omap_pcs_legacy_init (int irq,void (*rearm)(void ));struct omap_sdrc_params ;
arch/arm/mach-omap2/omap_device.c +2 -0
@@ -36,6 +36,7 @@#include <linux/of.h> #include <linux/notifier.h> +#include "common.h" #include "soc.h" #include "omap_device.h" #include "omap_hwmod.h"
@@ -200,6 +201,7 @@ static int _omap_device_notifier_call(struct notifier_block *nb,case BUS_NOTIFY_ADD_DEVICE :if (pdev->dev.of_node)omap_device_build_from_dt (pdev); +omap_auxdata_legacy_init (dev);/* fall through */ default : od =to_omap_device (pdev);
arch/arm/mach-omap2/pdata-quirks.c +16 -0
@@ -27,6 +27,7 @@ struct pdata_init { };struct of_dev_auxdata omap_auxdata_lookup[]; +static struct twl4030_gpio_platform_data twl_gpio_auxdata;/* * Create alias for USB host PHY clock.
@@ -137,6 +138,21 @@ void omap_pcs_legacy_init(int irq, void (*rearm)(void)) }/* +* GPIOs for TWL are initialized by the I2C bus and need custom +* handing until DSS has device tree bindings. +*/ +void omap_auxdata_legacy_init (struct device *dev) +{ +if (dev->platform_data) +return ; + +if (strcmp ("twl4030-gpio" ,dev_name (dev))) +return ; + + dev->platform_data = &twl_gpio_auxdata; +} + +/* * Few boards still need auxdata populated before we populate * the dev entries in of_platform_populate(). */
Signature · 1 line
1.8.1.1
Tony Lindgren
maintainerPATCH 3/5 ARM: OMAP2+: Add DT init code for DPI displays and make omap3 LDP to use it
In reply to Tony LindgrenIn order to make the remaining omap3 boards usable with device tree, we need to initialize the DPI based displays using pdata until we have the DSS bindings in place.
At least board-am3517evm.c, board-cm-t35.c, board-devkit8000.c, board-ldp.c and board-overo.c all use fairly similar DPI setup, so let's add generic code for it. And let's make omap3 LDP to use it and also initialize the ads7846 until we have a binding for it.
Note that at least LDP needs the TWL bug fix posted as "gpio: twl4030: Fix regression for twl gpio output" for the LCD backlight to power.
--- arch/arm/mach-omap2/dss-common.c | 67 ++++++++++++++++++++++++++++++++++++++ arch/arm/mach-omap2/dss-common.h | 1 + arch/arm/mach-omap2/pdata-quirks.c | 15 +++++++++ 3 files changed, 83 insertions(+)
arch/arm/mach-omap2/dss-common.c +67 -0
@@ -257,3 +257,70 @@ void __init omap3_igep2_display_init_of(void)platform_device_register (&omap3_igep2_tfp410_device);platform_device_register (&omap3_igep2_dvi_connector_device); } + +/* Systems with DPI LCD */ + +static struct panel_dpi_platform_data dpi_lcd = { + .name ="lcd" , + .source ="dpi.0" , + .enable_gpio =-1 , + .backlight_gpio =-1 , +}; + +static struct platform_device dpi_lcd_device = { + .name ="panel-dpi" , + .id =0 , + .dev.platform_data = &dpi_lcd, +}; + +static struct omap_dss_board_info dpi_dss_data = { + .default_display_name ="lcd" , +}; + +static void dpi_display_init (void ) +{ +platform_device_register (&dpi_lcd_device); +omap_display_init (&dpi_dss_data); +} + +/* DPI on omap3 LDP */ + +static const struct display_timing ldp_lcd_videomode = { + .pixelclock = {0 ,5400000 ,0 }, + + .hactive = {0 ,240 ,0 }, + .hfront_porch = {0 ,3 ,0 }, + .hback_porch = {0 ,39 ,0 }, + .hsync_len = {0 ,3 ,0 }, + + .vactive = {0 ,320 ,0 }, + .vfront_porch = {0 ,2 ,0 }, + .vback_porch = {0 ,7 ,0 }, + .vsync_len = {0 ,1 ,0 }, + + .flags =DISPLAY_FLAGS_HSYNC_LOW |DISPLAY_FLAGS_VSYNC_LOW | +DISPLAY_FLAGS_DE_HIGH |DISPLAY_FLAGS_PIXDATA_POSEDGE , +}; + +void __init omap3_ldp_display_init_of (int gpio_bl,int gpio_en) +{ +int r; + +static struct gpio gpios[] = { + {55 ,GPIOF_OUT_INIT_HIGH ,"LCD RESET" }, + {56 ,GPIOF_OUT_INIT_HIGH ,"LCD QVGA" }, + }; + + r =gpio_request_array (gpios,ARRAY_SIZE (gpios)); +if (r) { +pr_err ("Cannot request LCD GPIOs, error %d\n" , r); +return ; + } + + dpi_lcd.data_lines =18 ; + dpi_lcd.display_timing = &ldp_lcd_videomode; + dpi_lcd.enable_gpio = gpio_en; + dpi_lcd.backlight_gpio = gpio_bl; + +dpi_display_init (); +}
arch/arm/mach-omap2/dss-common.h +1 -0
@@ -9,5 +9,6 @@void __init omap4_panda_display_init_of (void );void __init omap_4430sdp_display_init_of (void );void __init omap3_igep2_display_init_of (void ); +void omap3_ldp_display_init_of (int gpio_bl,int gpio_en);#endif
arch/arm/mach-omap2/pdata-quirks.c +15 -0
@@ -100,6 +100,20 @@ static void __init omap3_evm_legacy_init(void)legacy_init_wl12xx (WL12XX_REFCLOCK_38 ,0 ,149 ); } +/* Pass enable and backlight GPIO to DSS code */ +int __init ldp_twl_gpio_setup (struct device *dev,unsigned gpio,unsigned ngpio) +{ +omap3_ldp_display_init_of (gpio +7 , gpio +15 ); +omap_ads7846_init (1 ,54 ,310 ,NULL ); + +return 0 ; +} + +static void __init omap3_ldp_legacy_init (void ) +{ + twl_gpio_auxdata.setup = ldp_twl_gpio_setup; +} +static void __init omap3_zoom_legacy_init (void ) {legacy_init_wl12xx (WL12XX_REFCLOCK_26 ,0 ,162 );
@@ -190,6 +204,7 @@ static struct pdata_init pdata_quirks[] __initdata = { { "nokia,omap3-n950", hsmmc2_internal_input_clk, }, { "isee,omap3-igep0020", omap3_igep0020_legacy_init, }, { "ti,omap3-evm-37xx", omap3_evm_legacy_init, }, + { "ti,omap3-ldp", omap3_ldp_legacy_init, }, { "ti,omap3-zoom3", omap3_zoom_legacy_init, }, #endif #ifdef CONFIG_ARCH_OMAP4
Signature · 1 line
1.8.1.1
PATCH 3/5 ARM: OMAP2+: Add DT init code for DPI displays and make omap3 LDP to use it
Quoted 10 lines · Tony Lindgren
In order to make the remaining omap3 boards usable with device tree, we need to initialize the DPI based displays using pdata until we have the DSS bindings in place.
At least
board-am3517evm.c,board-cm-t35.c,board-devkit8000.c,board-ldp.candboard-overo.call use fairly similar DPI setup, so let's add generic code for it. And let's make omap3 LDP to use it and also initialize the ads7846 until we have a binding for it.
Quoted 3 lines
Note that at least LDP needs the TWL bug fix posted as "gpio: twl4030: Fix regression for twl gpio output" for the LCD backlight to power.
Looks fine to me.
Is it possible to keep this, and other similar DSS patches, in a separate branch, that could be dropped if needed? I'm kind of hoping I would get the DSS DT finished for the next merge window (but I've said that before, so...).
Tomi
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 901 bytes
Desc: OpenPGP digital signature
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20131118/c02ffb77/attachment.sig>
Tony Lindgren
maintainerPATCH 3/5 ARM: OMAP2+: Add DT init code for DPI displays and make omap3 LDP to use it
Quoted 15 lines · Tomi Valkeinen
Quoted 10 lines · Tony Lindgren
In order to make the remaining omap3 boards usable with device tree, we need to initialize the DPI based displays using pdata until we have the DSS bindings in place.
At least
board-am3517evm.c,board-cm-t35.c,board-devkit8000.c,board-ldp.candboard-overo.call use fairly similar DPI setup, so let's add generic code for it. And let's make omap3 LDP to use it and also initialize the ads7846 until we have a binding for it.Quoted 3 lines
Note that at least LDP needs the TWL bug fix posted as "gpio: twl4030: Fix regression for twl gpio output" for the LCD backlight to power.
Quoted 6 lines
Looks fine to me.
Is it possible to keep this, and other similar DSS patches, in a separate branch, that could be dropped if needed? I'm kind of hoping I would get the DSS DT finished for the next merge window (but I've said that before, so...).
OK let's keep the DSS pdata quirks separate for now. How about we set -rc3 as a deadline for deciding which way to go for the DSS DT bindings for v3.14?
BTW, Russell posted some interesting comments on LAKML this weekend on binding together driver components if that helps.
Regards,
Tony
Tony Lindgren
maintainerPATCH 4/5 ARM: dts: Add basic support for omap3 LDP zoom1 labrador
In reply to Tony LindgrenBasic things like serial, Ethernet, MMC, NAND, DSS, touchscreen and GPIO keys work.
For twl4030-keypad we're still missing the binding, but support for that should be trivial to add once the driver has been updated.
MUSB I'm pretty sure I got got to enumerate once, but I suspect the battery charging somehow disrupts it and it's not enumerating in general for some reason.
Patches are welcome to improve things if people are still using this board.
For reference, here's some more info on this old board:
http://www.openomap.org/wiki/tiki-index.php?page=HardwareInfo
--- arch/arm/boot/dts/Makefile | 1 + arch/arm/boot/dts/omap3-ldp.dts | 231 ++++++++++++++++++++++++++++++++++++++++ 2 files changed, 232 insertions(+) create mode 100644 arch/arm/boot/dts/omap3-ldp.dts
arch/arm/boot/dts/Makefile +1 -0
@@ -183,6 +183,7 @@ dtb-$(CONFIG_ARCH_OMAP2PLUS) += omap2420-h4.dtb \ omap3-beagle-xm.dtb \ omap3-evm.dtb \ omap3-evm-37xx.dtb \ + omap3-ldp.dtb \ omap3-n900.dtb \ omap3-n9.dtb \ omap3-n950.dtb \
arch/arm/boot/dts/omap3-ldp.dts new file +231 -0
231 lines not on this page · raw message
Signature · 1 line
1.8.1.1
PATCH 4/5 ARM: dts: Add basic support for omap3 LDP zoom1 labrador
Quoted 6 lines · Tony Lindgren
Basic things like serial, Ethernet, MMC, NAND, DSS, touchscreen and GPIO keys work.
For twl4030-keypad we're still missing the binding, but support for that should be trivial to add once the driver has been updated.
DT bindings for twl4030-keypad are being worked on:
https://lkml.org/lkml/2013/11/8/463
Quoted 3 lines
MUSB I'm pretty sure I got got to enumerate once, but I suspect the battery charging somehow disrupts it and it's not enumerating in general for some reason.
Try to add this:
&usb_otg_hs {
phys = <&usb2_phy>;
phy-names = "usb2-phy";
};Those were introduced by the new generic PHY framework, see for example: https://lkml.org/lkml/2013/9/27/37
Quoted 1 line
[...]
-- Sebastian
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 836 bytes
Desc: Digital signature
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20131116/c6bc0b72/attachment.sig>
Tony Lindgren
maintainerPATCH 4/5 ARM: dts: Add basic support for omap3 LDP zoom1 labrador
Quoted 18 lines · Sebastian Reichel
Quoted 6 lines · Tony Lindgren
Basic things like serial, Ethernet, MMC, NAND, DSS, touchscreen and GPIO keys work.
For twl4030-keypad we're still missing the binding, but support for that should be trivial to add once the driver has been updated.
DT bindings for twl4030-keypad are being worked on:
https://lkml.org/lkml/2013/11/8/463
Quoted 3 lines
MUSB I'm pretty sure I got got to enumerate once, but I suspect the battery charging somehow disrupts it and it's not enumerating in general for some reason.
Try to add this:
Quoted 7 lines
&usb_otg_hs { phys = <&usb2_phy>; phy-names = "usb2-phy"; };Those were introduced by the new generic PHY framework, see for example: https://lkml.org/lkml/2013/9/27/37
Thanks yeah those should be added. No luck with those either though, I do have MUSB working fine on the 37xx-evm with the same image.
I seem to get twl4030_usb interrupts on cable insert and remove, then enabling debugging I see the following:
connectHW_CONDITIONS 0xe0/224; link 3
disconnectHW_CONDITIONS 0x60/96; link 4
Regards,
Tony
Tony Lindgren
maintainerPATCH 5/5 ARM: OMAP2+: Remove legacy booting support for LDP
In reply to Tony LindgrenWe can now boot with appended device tree with pretty much the same functionality. So let's remove the legacy board file as we want to make mach-omap2 device tree only.
--- arch/arm/mach-omap2/Kconfig | 6 - arch/arm/mach-omap2/Makefile | 1 - arch/arm/mach-omap2/board-ldp.c | 425 ---------------------------------------- 3 files changed, 432 deletions(-) delete mode 100644 arch/arm/mach-omap2/board-ldp.c
arch/arm/mach-omap2/Kconfig +0 -6
@@ -204,12 +204,6 @@ config MACH_DEVKIT8000 default y select OMAP_PACKAGE_CUS -config MACH_OMAP_LDP - bool "OMAP3 LDP board" - depends on ARCH_OMAP3 - default y - select OMAP_PACKAGE_CBB - config MACH_OMAP3530_LV_SOM bool "OMAP3 Logic 3530 LV SOM board" depends on ARCH_OMAP3
arch/arm/mach-omap2/Makefile +0 -1
@@ -237,7 +237,6 @@ obj-$(CONFIG_SOC_OMAP2420) += msdi.o obj-$(CONFIG_MACH_OMAP_GENERIC) += board-generic.o pdata-quirks.o obj-$(CONFIG_MACH_OMAP3_BEAGLE) += board-omap3beagle.o obj-$(CONFIG_MACH_DEVKIT8000) += board-devkit8000.o -obj-$(CONFIG_MACH_OMAP_LDP) += board-ldp.o obj-$(CONFIG_MACH_OMAP3530_LV_SOM) += board-omap3logic.o obj-$(CONFIG_MACH_OMAP3_TORPEDO) += board-omap3logic.o obj-$(CONFIG_MACH_OVERO) += board-overo.o
arch/arm/mach-omap2/board-ldp.c deleted +0 -425
425 lines not on this page · raw message
Signature · 1 line
1.8.1.1
N900 board code in 3.14
In reply to Tony LindgrenHi Tony,
Quoted 5 lines · Tony Lindgren
Here are few patches to deal with the mix of legacy platform data and device tree that we still need to do at least until DSS has device tree bindings. These patches should allow the remaining omap3 boards to be made device tree only so we can remove the board-*.c files.
Do you plan to remove the Nokia N900 board code in 3.14, too?
I see two big issues with that:
a) Using DT boot the display is currently not working.
b) I could not get the 32GB eMMC working. For me the chip is not found and I don't know how to debug it.
There are two reasons for broken display:
1. omap_mux_init_gpio(RX51_LCD_RESET_GPIO, OMAP_PIN_OUTPUT) fails. This can be fixed by simply not calling it in DT mode. DT data contains pinmux information for this from 3.13 onwards [0].
2. The spi panel driver is not probed.
I have a local hack to probe the panel driver via DT. I changed the display node to look as follows:
&mcspi1 {
/* ... tsc2005 ... */
mipid@2 {
compatible = "sony,acx565akm";
spi-max-frequency = <6000000>;
reg = <2>;
vdds_sdi-supply = <&vaux1>;
label = "lcd";
reset-gpio = <&gpio3 26 GPIO_ACTIVE_HIGH>; /* 90 */
ti,sdi-datapairs = <2>;
ti,dss-source = "sdi.0";
pinctrl-names = "default";
pinctrl-0 = <&display_pins>;
};
};Then I changed the acx565akm panel driver to get data from DT and the DSS to get SDI regulator from the panel. This is obviously not the way to got, so I wonder how to proceed. omapdss DT seems not to be ready for the next kernel releases.
My suggestion would be:
1. Find a better workaround for omapdss to acquire the SDI regulator. My current hack is obviously not acceptable.
2. Load the panel driver via DT as seen above and reference the omapdss interface with something like the above "ti,dss-source".
This is obviously not a stable DT interface, but that's also the case if everything is done via platform quirks: An old DT file without any display stuff in it would not work with a newer kernel without the quirks.
-- Sebastian
Tony Lindgren
maintainerN900 board code in 3.14
Quoted 10 lines · Sebastian Reichel
Hi Tony,
Quoted 5 lines · Tony Lindgren
Here are few patches to deal with the mix of legacy platform data and device tree that we still need to do at least until DSS has device tree bindings. These patches should allow the remaining omap3 boards to be made device tree only so we can remove the board-*.c files.
Do you plan to remove the Nokia N900 board code in 3.14, too?
Probably not completely, we should still keep the pieces that are needed to initialize things in legacy mode. Then those can be dealt with using the auxdata hooks in pdata-quirks.c.
But we do want to boot everything in in DT mode for mach-omap2 for v3.14 as that leaves out huge amounts of old duplicate code.
Quoted 2 lines
I see two big issues with that:
a) Using DT boot the display is currently not working.
OK
Quoted 2 lines
b) I could not get the 32GB eMMC working. For me the chip is not found and I don't know how to debug it.
OK the eMMC issue might be related to the control module PBIAS register support missing. If so, that should be fixable with the auxdata until we have a minimal control module device driver to deal with the PBIAS and expose those features as regulators to the omap-hsmmc driver.
Quoted 5 lines
There are two reasons for broken display:
1.
omap_mux_init_gpio(RX51_LCD_RESET_GPIO, OMAP_PIN_OUTPUT)fails. This can be fixed by simply not calling it in DT mode. DT data contains pinmux information for this from 3.13 onwards [0].
OK yeah makes sense. The pins should be set up using pinctrl-single for DT.
Quoted 27 lines
2. The spi panel driver is not probed.
I have a local hack to probe the panel driver via DT. I changed the display node to look as follows:
&mcspi1 { /* ... tsc2005 ... */ mipid at 2 { compatible = "sony,acx565akm"; spi-max-frequency = <6000000>; reg = <2>; vdds_sdi-supply = <&vaux1>; label = "lcd"; reset-gpio = <&gpio3 26 GPIO_ACTIVE_HIGH>; /* 90 */ ti,sdi-datapairs = <2>; ti,dss-source = "sdi.0"; pinctrl-names = "default"; pinctrl-0 = <&display_pins>; }; };Then I changed the acx565akm panel driver to get data from DT and the DSS to get SDI regulator from the panel. This is obviously not the way to got, so I wonder how to proceed. omapdss DT seems not to be ready for the next kernel releases.
Quoted 6 lines
My suggestion would be:
1. Find a better workaround for omapdss to acquire the SDI regulator. My current hack is obviously not acceptable.
2. Load the panel driver via DT as seen above and reference the omapdss interface with something like the above "ti,dss-source".
To me it seems that we should be able to add minimal panel entries to DT if we stick to existing standard bindings. Then the timings etc can be set up based on the compatible flag. So I would leave out the properties for ti,sdi-datapairs and ti,dss-source for now, and just set those in the driver based on the sony,acx565akm compatible flag. Or maybe it should be sony,acx565akm-n900 if there's some board specific configuration info.
Quoted 3 lines
This is obviously not a stable DT interface, but that's also the case if everything is done via platform quirks: An old DT file without any display stuff in it would not work with a newer kernel without the quirks.
Right, naturally we cannot support missing properties in the old DT files. But the standard properties are stable, so those should be OK to use. But let's see what Tomi says, he may have some good ideas :)
Regards,
Tony
N900 board code in 3.14
Quoted 9 lines · Tony Lindgren
[...]
Quoted 2 lines
b) I could not get the 32GB eMMC working. For me the chip is not found and I don't know how to debug it.
OK the eMMC issue might be related to the control module PBIAS register support missing. If so, that should be fixable with the auxdata until we have a minimal control module device driver to deal with the PBIAS and expose those features as regulators to the omap-hsmmc driver.
I wasn't aware, that PBIAS register support is missing for DT boot. The existing board code uses a 2.8-3.0V regulator for mmc1, so missing PBIAS is probably the problem.
Quoted 9 lines
Quoted 8 lines
[...]
My suggestion would be:
1. Find a better workaround for omapdss to acquire the SDI regulator. My current hack is obviously not acceptable.
2. Load the panel driver via DT as seen above and reference the omapdss interface with something like the above "ti,dss-source".
Quoted 6 lines
To me it seems that we should be able to add minimal panel entries to DT if we stick to existing standard bindings. Then the timings etc can be set up based on the compatible flag. So I would leave out the properties for ti,sdi-datapairs and ti,dss-source for now, and just set those in the driver based on the sony,acx565akm compatible flag. Or maybe it should be sony,acx565akm-n900 if there's some board specific configuration info.
So we add reset-gpio and label to the DT data (they are panel specific and independent of omapdss) and just hardcode "dsi.0" with 2 data lanes into the driver? That sounds fine for me.
If neither Tomi nor anybody else has better ideas I will cook a patch for that. I'm not sure how to setup the vdds_sdi regulator for omapdss, though. Is there an example for a legacy driver using a DT regulator available?
Quoted 1 line
[...]
-- Sebastian
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 836 bytes
Desc: Digital signature
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20131116/a814c255/attachment.sig>
Tony Lindgren
maintainerN900 board code in 3.14
Quoted 11 lines · Sebastian Reichel
Quoted 9 lines · Tony Lindgren
[...]
Quoted 2 lines
b) I could not get the 32GB eMMC working. For me the chip is not found and I don't know how to debug it.
OK the eMMC issue might be related to the control module PBIAS register support missing. If so, that should be fixable with the auxdata until we have a minimal control module device driver to deal with the PBIAS and expose those features as regulators to the omap-hsmmc driver.
Quoted 3 lines
I wasn't aware, that PBIAS register support is missing for DT boot. The existing board code uses a 2.8-3.0V regulator for mmc1, so missing PBIAS is probably the problem.
Right, sorry I was confused, looks like we don't need to worry about that. And looks like Balaji just posted patches for the PBIAS support.
Also, I just posted a patch to fix the eMMC that you may want to try out.
Quoted 16 lines
Quoted 9 lines
Quoted 8 lines
[...]
My suggestion would be:
1. Find a better workaround for omapdss to acquire the SDI regulator. My current hack is obviously not acceptable.
2. Load the panel driver via DT as seen above and reference the omapdss interface with something like the above "ti,dss-source".Quoted 6 lines
To me it seems that we should be able to add minimal panel entries to DT if we stick to existing standard bindings. Then the timings etc can be set up based on the compatible flag. So I would leave out the properties for ti,sdi-datapairs and ti,dss-source for now, and just set those in the driver based on the sony,acx565akm compatible flag. Or maybe it should be sony,acx565akm-n900 if there's some board specific configuration info.
Quoted 8 lines
So we add reset-gpio and label to the DT data (they are panel specific and independent of omapdss) and just hardcode "dsi.0" with 2 data lanes into the driver? That sounds fine for me.
If neither Tomi nor anybody else has better ideas I will cook a patch for that. I'm not sure how to setup the
vdds_sdiregulator for omapdss, though. Is there an example for a legacy driver using a DT regulator available?
Not that I know of :) But I guess only the panel driver would need to parse the compatible flag and the rest of the DSS could still be initialize the legacy way if needed.
Regards,
Tony
N900 board code in 3.14
Hi Tony,
Quoted 2 lines · Tony Lindgren
Also, I just posted a patch to fix the eMMC that you may want to try out.
Let's move eMMC diskussion to that patch :)
Quoted 20 lines
Quoted 20 lines
Quoted 9 lines
Quoted 8 lines
[...]
My suggestion would be:
1. Find a better workaround for omapdss to acquire the SDI regulator. My current hack is obviously not acceptable.
2. Load the panel driver via DT as seen above and reference the omapdss interface with something like the above "ti,dss-source".Quoted 6 lines
To me it seems that we should be able to add minimal panel entries to DT if we stick to existing standard bindings. Then the timings etc can be set up based on the compatible flag. So I would leave out the properties for ti,sdi-datapairs and ti,dss-source for now, and just set those in the driver based on the sony,acx565akm compatible flag. Or maybe it should be sony,acx565akm-n900 if there's some board specific configuration info.
So we add reset-gpio and label to the DT data (they are panel specific and independent of omapdss) and just hardcode "dsi.0" with 2 data lanes into the driver? That sounds fine for me.
Quoted 6 lines
Quoted 4 lines
If neither Tomi nor anybody else has better ideas I will cook a patch for that. I'm not sure how to setup the
vdds_sdiregulator for omapdss, though. Is there an example for a legacy driver using a DT regulator available?Not that I know of :)
Javier Martinez Canillas patch did what I was thinking of in [0]. My suggestion would be to add something like this pseudocode to omapdss:
if(board_is_n900_dt()) {
vdds_dsi = devm_regulator_get(&dpi.pdev->dev, "V28");
}The problem is, that we do not want to name the regulator "vdds_dsi", since it's not used exclusivly for omapdss.
In the future it can get the regulator via phandle of course.
Quoted 3 lines
But I guess only the panel driver would need to parse the compatible flag and the rest of the DSS could still be initialize the legacy way if needed.
Yes, except of the regulator. I will try to get this working tomorrow.
[0] http://www.spinics.net/lists/arm-kernel/msg286896.html
-- Sebastian
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 836 bytes
Desc: Digital signature
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20131122/7be710c1/attachment.sig>
N900 board code in 3.14
Quoted 28 lines · Sebastian Reichel
Hi Tony,
Quoted 2 lines · Tony Lindgren
Also, I just posted a patch to fix the eMMC that you may want to try out.
Let's move eMMC diskussion to that patch :)
Quoted 20 lines
Quoted 20 lines
Quoted 9 lines
Quoted 8 lines
[...]
My suggestion would be:
1. Find a better workaround for omapdss to acquire the SDI regulator. My current hack is obviously not acceptable.
2. Load the panel driver via DT as seen above and reference the omapdss interface with something like the above "ti,dss-source".Quoted 6 lines
To me it seems that we should be able to add minimal panel entries to DT if we stick to existing standard bindings. Then the timings etc can be set up based on the compatible flag. So I would leave out the properties for ti,sdi-datapairs and ti,dss-source for now, and just set those in the driver based on the sony,acx565akm compatible flag. Or maybe it should be sony,acx565akm-n900 if there's some board specific configuration info.
So we add reset-gpio and label to the DT data (they are panel specific and independent of omapdss) and just hardcode "dsi.0" with 2 data lanes into the driver? That sounds fine for me.
Quoted 8 lines
Quoted 6 lines
Quoted 4 lines
If neither Tomi nor anybody else has better ideas I will cook a patch for that. I'm not sure how to setup the
vdds_sdiregulator for omapdss, though. Is there an example for a legacy driver using a DT regulator available?Not that I know of :)
Javier Martinez Canillas patch did what I was thinking of in [0].
I dropped that patch from my series and posted a v2 that just name the VPLL2 regulator as vdds_dsi [1]. That way will be safer for Tony and Benoit to take this series as a fix for the -rc cycle since the changes are contained within IGEP boards DTS.
Quoted 12 lines
My suggestion would be to add something like this pseudocode to omapdss:
if(board_is_n900_dt()) { vdds_dsi = devm_regulator_get(&dpi.pdev->dev, "V28"); }The problem is, that we do not want to name the regulator "
vdds_dsi", since it's not used exclusivly for omapdss.In the future it can get the regulator via phandle of course.
For what is worth I think that your suggestion is a good workaround. Please just add a comment specifying that it is a hack and that we have to get rid of these once the DSS DT bindings land on mainline and we can use a phandle to get the regulator.
Quoted 10 lines
Quoted 3 lines
But I guess only the panel driver would need to parse the compatible flag and the rest of the DSS could still be initialize the legacy way if needed.
Yes, except of the regulator. I will try to get this working tomorrow.
[0] http://www.spinics.net/lists/arm-kernel/msg286896.html
-- Sebastian
[1]: http://www.spinics.net/lists/arm-kernel/msg287703.html
Best regards,
Javier
N900 board code in 3.14
Hi,
Quoted 4 lines · Javier Martinez Canillas
I dropped that patch from my series and posted a v2 that just name the VPLL2 regulator as
vdds_dsi[1]. That way will be safer for Tony and Benoit to take this series as a fix for the -rc cycle since the changes are contained within IGEP boards DTS.
I know, but the patch serves as example for me :)
Quoted 10 lines
Quoted 10 lines
My suggestion would be to add something like this pseudocode to omapdss:
if(board_is_n900_dt()) { vdds_dsi = devm_regulator_get(&dpi.pdev->dev, "V28"); }The problem is, that we do not want to name the regulator "
vdds_dsi", since it's not used exclusivly for omapdss.
Quoted 6 lines
Quoted 1 line
In the future it can get the regulator via phandle of course.
For what is worth I think that your suggestion is a good workaround. Please just add a comment specifying that it is a hack and that we have to get rid of these once the DSS DT bindings land on mainline and we can use a phandle to get the regulator.
I just sent a patchset, that adds DT panel support for N900.
-- Sebastian
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 836 bytes
Desc: Digital signature
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20131123/c3c30061/attachment.sig>