RFQ: changes on ldattach.c for GSM710 discipline
Hello
I'm just preparing for some add-ons and wanted to check if someone else is working on it and if my ideas are not too far away from what is the intention of the tool.
I'd like to add support for N_GSM710 that comes with the kernel module n_gsm. Someone else ('guowenxue') has already brought a slightly patched version into the wild which is too restricted and specific.
The planned features are:
- setting the GSM710 discipline
- sending a configurable string out (parameter '--mux' or '-m', default AT+CMUX=0)
- configurable pause in seconds after the command (parameter '--pause' or -p)
- UUCP lock file support (-l or --lock, default none, '/var/lock/<devicename>' if no argument is given)
/Martin
Signature · 4 lines
Martin Schmid APS systems AG, Neumatt 4, CH-4626 Niederbuchsiten Tel direkt: +41 62 389 8891, Fax: +41 62 389 8880, Tel: +41 62 389 8888 www.aps-systems.ch
Quoted 7 lines · Martin Schmid
I'd like to add support for
N_GSM710that comes with the kernel modulen_gsm. Someone else ('guowenxue') has already brought a slightly patched version into the wild which is too restricted and specific.The planned features are:
- setting the GSM710 discipline
Sounds like a great plan to me. Just a minor nit:
"GSM 0710" (or maybe even better: "GSM 07.10") and "N_GSM0710"
"All 3GPP specifications have a specification number consisting of 4 or 5 digits." - ref http://www.3gpp.org/specifications/specification-numbering
You don't want this work confused with GSM 71.0x support when the 3GPP gets there :-)
Bjørn
Karel Zak
maintainerQuoted 10 lines · Martin Schmid
I'm just preparing for some add-ons and wanted to check if someone else is working on it and if my ideas are not too far away from what is the intention of the tool.
I'd like to add support for
N_GSM710that comes with the kernel modulen_gsm. Someone else ('guowenxue') has already brought a slightly patched version into the wild which is too restricted and specific.The planned features are:
Quoted 7 lines
- setting the GSM710 discipline
- sending a configurable string out (parameter '--mux' or '-m', default AT+CMUX=0)
- configurable pause in seconds after the command (parameter '--pause' or -p)
- UUCP lock file support (-l or --lock, default none, '/var/lock/<devicename>' if no argument is given)
Please, don't send one huge patch - split it per-feature.
Do we really need support for the locks? There is lockdev(3) (although it seems currently unmaintained).
Karel
Signature · 2 lines
Karel Zak <[email protected]> http://karelzak.blogspot.com