Skip to contentSkip to conversation

sched_clock: Document 4Mhz vs 1Mhz decision

tip:sched/urgent Russell King 2 participants 2 messages Nov 19, 2013 1 message not in the archive

lore
Share & tools
lore

A message that is not in the archive (sent off-list or not yet received): [email protected]

#1 lore raw

Review

Quoted 3 lines · tip-bot for Stephen Boyd
(quoted diff) +3 -0
+	/*
+	 * Use 4MHz instead of 1MHz so that things like 1.832Mhz show as
+	 * 1832Khz

How about getting proper SI units.

Hertz is Hz - that's capital H and lower case z. It's also the surname of an engineer.

Kilo is always lower case k. Therefore, the unit of 1000 cycles per second is kHz and not KHZ, khz, Khz, khZ or any other stupid mixture of cases.

Given that we are programmers, and programming computers requires an attention to detail, completely ignoring such detail when it comes to SI units is extremely poor - and suggests that we are illerate.

May I suggest more care is taken in the future?

Signature · 2 lines
Russell King
ARM architecture Linux Kernel maintainer
#2 lore raw
Quoted 6 lines · Russell King

Review

Quoted 3 lines · tip-bot for Stephen Boyd
(quoted diff) +3 -0
+	/*
+	 * Use 4MHz instead of 1MHz so that things like 1.832Mhz show as
+	 * 1832Khz

How about getting proper SI units.

Note that I objected to this patch earlier today, I think this code should look differently - so your objection to this particular patch is mooted.

Thanks,

Ingo