Skip to contentSkip to conversation

ARM: shmobile: Use r8a7790 suffix for IRQC compat string

PATCH New Magnus Damm 3 participants 5 messages Nov 20, 2013 – Nov 28, 2013

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 ARM: shmobile: Use r8a7790 suffix for IRQC compat string

From: Magnus Damm <[email protected]>

Add "renesas,irqc-r8a7790" to the compatible string for IRQC in case of r8a7790. This makes the IRQC follow the same style as the other devices and also makes it more future proof.

---

 arch/arm/boot/dts/r8a7790.dtsi |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
arch/arm/boot/dts/r8a7790.dtsi +1 -1
@@ -171,7 +171,7 @@
 	};
 
 	irqc0: interrupt-controller at e61c0000 {
-		compatible = "renesas,irqc";
+		compatible = "renesas,irqc-r8a7790", "renesas,irqc";
 		#interrupt-cells = <2>;
 		interrupt-controller;
 		reg = <0 0xe61c0000 0 0x200>;
#1 lore raw

PATCH 1/1 ARM: shmobile: Use r8a7790 suffix for IRQC compat string

Quoted 11 lines · Magnus Damm

From: Magnus Damm <[email protected]>

Add "renesas,irqc-r8a7790" to the compatible string for IRQC in case of r8a7790. This makes the IRQC follow the same style as the other devices and also makes it more future proof.

---

 arch/arm/boot/dts/r8a7790.dtsi |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Thanks, I will queue this up.
Assuming all goes will I plan to push this and other updates today or tomorrow.

Quoted 17 lines
arch/arm/boot/dts/r8a7790.dtsi +1 -2
@@ -171,7 +171,7 @@
 	};
 
 	irqc0: interrupt-controller at e61c0000 {
-		compatible = "renesas,irqc";
+		compatible = "renesas,irqc-r8a7790", "renesas,irqc";
 		#interrupt-cells = <2>;
 		interrupt-controller;
 		reg = <0 0xe61c0000 0 0x200>;
--

To unsubscribe from this list: send the line "unsubscribe linux-sh" in the body of a message to majordomo at vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html

#2 lore raw

PATCH 1/1 ARM: shmobile: Use r8a7790 suffix for IRQC compat string

In reply to Magnus Damm

Hi Magnus,

Thank you for the patch.

Quoted 5 lines · On Wednesday 20 November 2013 09:07:40 Magnus Damm wrote:

From: Magnus Damm <[email protected]>

Add "renesas,irqc-r8a7790" to the compatible string for IRQC in case of r8a7790. This makes the IRQC follow the same style as the other devices and also makes it more future proof.

You should update the device tree bindings documentation as well. As there's no such documentation of the irqc, you should create it ;-)

Quoted 17 lines

---

 arch/arm/boot/dts/r8a7790.dtsi |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
arch/arm/boot/dts/r8a7790.dtsi +1 -1
@@ -171,7 +171,7 @@
 	};
 
 	irqc0: interrupt-controller at e61c0000 {
-		compatible = "renesas,irqc";
+		compatible = "renesas,irqc-r8a7790", "renesas,irqc";
 		#interrupt-cells = <2>;
 		interrupt-controller;
 		reg = <0 0xe61c0000 0 0x200>;
Signature · 3 lines
Regards,

Laurent Pinchart
#3 lore raw

PATCH 1/1 ARM: shmobile: Use r8a7790 suffix for IRQC compat string

Quoted 5 lines · Laurent Pinchart

Hi Magnus,

Thank you for the patch.

On Wednesday 20 November 2013 09:07:40 Magnus Damm wrote:

Quoted 8 lines
Quoted 5 lines

From: Magnus Damm <[email protected]>

Add "renesas,irqc-r8a7790" to the compatible string for IRQC in case of r8a7790. This makes the IRQC follow the same style as the other devices and also makes it more future proof.

You should update the device tree bindings documentation as well. As there's no such documentation of the irqc, you should create it ;-)

I will submit a patch for this.

#4 lore raw

PATCH 1/1 ARM: shmobile: Use r8a7790 suffix for IRQC compat string

In reply to Magnus Damm
Quoted 7 lines · Magnus Damm

From: Magnus Damm <[email protected]>

Add "renesas,irqc-r8a7790" to the compatible string for IRQC in case of r8a7790. This makes the IRQC follow the same style as the other devices and also makes it more future proof.

Should I make a similar patch for the r8a73a4?

Quoted 21 lines

---

 arch/arm/boot/dts/r8a7790.dtsi |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
arch/arm/boot/dts/r8a7790.dtsi +1 -2
@@ -171,7 +171,7 @@
 	};
 
 	irqc0: interrupt-controller at e61c0000 {
-		compatible = "renesas,irqc";
+		compatible = "renesas,irqc-r8a7790", "renesas,irqc";
 		#interrupt-cells = <2>;
 		interrupt-controller;
 		reg = <0 0xe61c0000 0 0x200>;
--

To unsubscribe from this list: send the line "unsubscribe linux-sh" in the body of a message to majordomo at vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html