watchdog: Drop unnecessary include of miscdevice.h
Subsystems (6)
Guenter Roeck
maintainerPATCH 1/1 watchdog: Drop unnecessary include of miscdevice.h
After commit 487722cf2 (watchdog: Get rid of MODULE_ALIAS_MISCDEV statements) the affected drivers no longer need to include miscdevice.h. Only exception is rt2880_wdt.c which never needed it.
Signed-off-by Guenter Roeck <[email protected]>
---
Compile tested.
drivers/watchdog/bcm2835_wdt.c | 1 - drivers/watchdog/ep93xx_wdt.c | 1 - drivers/watchdog/ie6xx_wdt.c | 1 - drivers/watchdog/jz4740_wdt.c | 1 - drivers/watchdog/kempld_wdt.c | 1 - drivers/watchdog/max63xx_wdt.c | 1 - drivers/watchdog/orion_wdt.c | 1 - drivers/watchdog/pnx4008_wdt.c | 1 - drivers/watchdog/rt2880_wdt.c | 1 - drivers/watchdog/shwdt.c | 1 - drivers/watchdog/softdog.c | 1 - drivers/watchdog/stmp3xxx_rtc_wdt.c | 1 - drivers/watchdog/txx9wdt.c | 1 - drivers/watchdog/ux500_wdt.c | 1 - 14 files changed, 14 deletions(-)
drivers/watchdog/bcm2835_wdt.c +0 -1
@@ -19,7 +19,6 @@#include <linux/watchdog.h> #include <linux/platform_device.h> #include <linux/of_address.h> -#include <linux/miscdevice.h> #define PM_RSTC 0x1c#define PM_WDOG 0x24
drivers/watchdog/ep93xx_wdt.c +0 -1
@@ -28,7 +28,6 @@#include <linux/platform_device.h> #include <linux/module.h> -#include <linux/miscdevice.h> #include <linux/watchdog.h> #include <linux/timer.h> #include <linux/io.h>
drivers/watchdog/ie6xx_wdt.c +0 -1
@@ -28,7 +28,6 @@#include <linux/kernel.h> #include <linux/types.h> #include <linux/watchdog.h> -#include <linux/miscdevice.h> #include <linux/seq_file.h> #include <linux/debugfs.h> #include <linux/uaccess.h>
drivers/watchdog/jz4740_wdt.c +0 -1
@@ -17,7 +17,6 @@#include <linux/moduleparam.h> #include <linux/types.h> #include <linux/kernel.h> -#include <linux/miscdevice.h> #include <linux/watchdog.h> #include <linux/init.h> #include <linux/platform_device.h>
drivers/watchdog/kempld_wdt.c +0 -1
@@ -26,7 +26,6 @@#include <linux/module.h> #include <linux/moduleparam.h> -#include <linux/miscdevice.h> #include <linux/uaccess.h> #include <linux/watchdog.h> #include <linux/platform_device.h>
drivers/watchdog/max63xx_wdt.c +0 -1
@@ -19,7 +19,6 @@#include <linux/moduleparam.h> #include <linux/types.h> #include <linux/kernel.h> -#include <linux/miscdevice.h> #include <linux/watchdog.h> #include <linux/init.h> #include <linux/bitops.h>
drivers/watchdog/orion_wdt.c +0 -1
@@ -16,7 +16,6 @@#include <linux/moduleparam.h> #include <linux/types.h> #include <linux/kernel.h> -#include <linux/miscdevice.h> #include <linux/platform_device.h> #include <linux/watchdog.h> #include <linux/init.h>
drivers/watchdog/pnx4008_wdt.c +0 -1
@@ -23,7 +23,6 @@#include <linux/moduleparam.h> #include <linux/types.h> #include <linux/kernel.h> -#include <linux/miscdevice.h> #include <linux/watchdog.h> #include <linux/init.h> #include <linux/platform_device.h>
drivers/watchdog/rt2880_wdt.c +0 -1
@@ -16,7 +16,6 @@#include <linux/module.h> #include <linux/kernel.h> #include <linux/watchdog.h> -#include <linux/miscdevice.h> #include <linux/moduleparam.h> #include <linux/platform_device.h>
drivers/watchdog/shwdt.c +0 -1
@@ -26,7 +26,6 @@#include <linux/init.h> #include <linux/types.h> #include <linux/spinlock.h> -#include <linux/miscdevice.h> #include <linux/watchdog.h> #include <linux/pm_runtime.h> #include <linux/fs.h>
drivers/watchdog/softdog.c +0 -1
@@ -42,7 +42,6 @@#include <linux/moduleparam.h> #include <linux/types.h> #include <linux/timer.h> -#include <linux/miscdevice.h> #include <linux/watchdog.h> #include <linux/notifier.h> #include <linux/reboot.h>
drivers/watchdog/stmp3xxx_rtc_wdt.c +0 -1
@@ -12,7 +12,6 @@#include <linux/init.h> #include <linux/kernel.h> #include <linux/module.h> -#include <linux/miscdevice.h> #include <linux/watchdog.h> #include <linux/platform_device.h> #include <linux/stmp3xxx_rtc_wdt.h>
drivers/watchdog/txx9wdt.c +0 -1
@@ -13,7 +13,6 @@#include <linux/module.h> #include <linux/moduleparam.h> #include <linux/types.h> -#include <linux/miscdevice.h> #include <linux/watchdog.h> #include <linux/init.h> #include <linux/platform_device.h>
drivers/watchdog/ux500_wdt.c +0 -1
@@ -12,7 +12,6 @@#include <linux/module.h> #include <linux/kernel.h> #include <linux/moduleparam.h> -#include <linux/miscdevice.h> #include <linux/err.h> #include <linux/uaccess.h> #include <linux/watchdog.h>
Signature · 1 line
1.7.9.7
Hi Guenter,
Quoted 3 lines · Guenter Roeck
After commit
487722cf2(watchdog: Get rid ofMODULE_ALIAS_MISCDEVstatements) the affected drivers no longer need to includemiscdevice.h. Only exception isrt2880_wdt.cwhich never needed it.
I'm surprised because I thought I did check after applying my changes and had removed the #include <linux/miscdevice.h> every time it was OK to do so. But apparently I missed many... Thanks for noticing.
Reviewed-by Jean Delvare <[email protected]>
Quoted 20 lines
Signed-off-by Guenter Roeck <[email protected]>---
Compile tested.drivers/watchdog/bcm2835_wdt.c | 1 - drivers/watchdog/ep93xx_wdt.c | 1 - drivers/watchdog/ie6xx_wdt.c | 1 - drivers/watchdog/jz4740_wdt.c | 1 - drivers/watchdog/kempld_wdt.c | 1 - drivers/watchdog/max63xx_wdt.c | 1 - drivers/watchdog/orion_wdt.c | 1 - drivers/watchdog/pnx4008_wdt.c | 1 - drivers/watchdog/rt2880_wdt.c | 1 - drivers/watchdog/shwdt.c | 1 - drivers/watchdog/softdog.c | 1 - drivers/watchdog/stmp3xxx_rtc_wdt.c | 1 - drivers/watchdog/txx9wdt.c | 1 - drivers/watchdog/ux500_wdt.c | 1 - 14 files changed, 14 deletions(-)(...)
Signature · 2 lines
Jean Delvare Suse L3 Support