Mark MIPS I, II, III and IV as deprecated
PATCH 1/1 Mark MIPS I, II, III and IV as deprecated
--- arch/Config.in.mips | 6 ++++-- 1 files changed, 4 insertions(+), 2 deletions(-)
arch/Config.in.mips +4 -2
@@ -12,14 +12,16 @@ choice config BR2_mips_1 bool "mips I (generic)" - depends on !BR2_ARCH_IS_64 + depends on !BR2_ARCH_IS_64 && BR2_DEPRECATED config BR2_mips_2 bool "mips II" - depends on !BR2_ARCH_IS_64 + depends on !BR2_ARCH_IS_64 && BR2_DEPRECATED config BR2_mips_3 bool "mips III" + depends on BR2_DEPRECATED config BR2_mips_4 bool "mips IV" + depends on BR2_DEPRECATED config BR2_mips_32 bool "mips 32" depends on !BR2_ARCH_IS_64
Signature · 1 line
1.7.1
PATCH 1/1 Mark MIPS I, II, III and IV as deprecated
Dear Vicente Olivert Riera,
Quoted 18 lines · Vicente Olivert Riera
Signed-off-by Vicente Olivert Riera <[email protected]>--- arch/Config.in.mips | 6 ++++-- 1 files changed, 4 insertions(+), 2 deletions(-)arch/Config.in.mips +1
-2@@ -12,14 +12,16 @@ choice config BR2_mips_1 bool "mips I (generic)" - depends on !BR2_ARCH_IS_64 + depends on !BR2_ARCH_IS_64 && BR2_DEPRECATED config BR2_mips_2 bool "mips II" - depends on !BR2_ARCH_IS_64
arch/Config.in.mips choice · line 27
Quoted 10 lines
arch/Config.in.mips +3
-0+ depends on !BR2_ARCH_IS_64 && BR2_DEPRECATED config BR2_mips_3 bool "mips III" + depends on BR2_DEPRECATED config BR2_mips_4 bool "mips IV" + depends on BR2_DEPRECATED config BR2_mips_32 bool "mips 32" depends on !BR2_ARCH_IS_64
The commit log should explain *why* we're deprecating these CPU variants.
Moreover, if we deprecate mips_1 and mips_3, then there should be some change in:
choice
prompt "Target Architecture Variant"
depends on BR2_mips || BR2_mipsel || BR2_mips64 || BR2_mips64el default BR2_mips_3 if BR2_mips
default BR2_mips_1 if BR2_mipsel
default BR2_mips_64 if BR2_mips64 || BR2_mips64el help
at the beginning of Config.in.mips
Thomas
Signature · 3 lines
Thomas Petazzoni, CTO, Free Electrons Embedded Linux, Kernel and Android engineering http://free-electrons.com
PATCH 1/1 Mark MIPS I, II, III and IV as deprecated
Quoted 46 lines · Thomas Petazzoni
Dear Vicente Olivert Riera,
Quoted 18 lines · Vicente Olivert Riera
Signed-off-by Vicente Olivert Riera <[email protected]>--- arch/Config.in.mips | 6 ++++-- 1 files changed, 4 insertions(+), 2 deletions(-)arch/Config.in.mips +1
-2@@ -12,14 +12,16 @@ choice config BR2_mips_1 bool "mips I (generic)" - depends on !BR2_ARCH_IS_64 + depends on !BR2_ARCH_IS_64 && BR2_DEPRECATED config BR2_mips_2 bool "mips II" - depends on !BR2_ARCH_IS_64arch/Config.in.mips choice · line 27
Quoted 10 lines
arch/Config.in.mips +3
-0+ depends on !BR2_ARCH_IS_64 && BR2_DEPRECATED config BR2_mips_3 bool "mips III" + depends on BR2_DEPRECATED config BR2_mips_4 bool "mips IV" + depends on BR2_DEPRECATED config BR2_mips_32 bool "mips 32" depends on !BR2_ARCH_IS_64The commit log should explain *why* we're deprecating these CPU variants.
Moreover, if we deprecate
mips_1andmips_3, then there should be some change in:choice
prompt "Target Architecture Variant"
depends onBR2_mips||BR2_mipsel||BR2_mips64||BR2_mips64eldefaultBR2_mips_3ifBR2_mips
defaultBR2_mips_1ifBR2_mipsel
defaultBR2_mips_64ifBR2_mips64||BR2_mips64elhelp
Quoted 4 lines
at the beginning of Config.in.mips
Thomas
Thanks for your help Thomas. I have sent a V2.
Signature · 1 line
Vincent