ASoC: arizona: Set FLL to free-run before disabling
Subsystems (3)
PATCH 1/1 ASoC: arizona: Set FLL to free-run before disabling
Signed-off-by Richard Fitzgerald <[email protected]>
--- sound/soc/codecs/arizona.c | 4 ++++ 1 files changed, 4 insertions(+), 0 deletions(-)
sound/soc/codecs/arizona.c +4 -0
@@ -1529,6 +1529,8 @@ static void arizona_enable_fll(struct arizona_fll *fll,try_wait_for_completion (&fll->ok);regmap_update_bits (arizona->regmap, fll->base +1 , +ARIZONA_FLL1_FREERUN ,0 ); +regmap_update_bits (arizona->regmap, fll->base +1 ,ARIZONA_FLL1_ENA ,ARIZONA_FLL1_ENA );if (use_sync) regmap_update_bits(arizona->regmap, fll->base + 0x11,
@@ -1546,6 +1548,8 @@ static void arizona_disable_fll(struct arizona_fll *fll)struct arizona *arizona = fll->arizona;bool change; +regmap_update_bits (arizona->regmap, fll->base +1 , +ARIZONA_FLL1_FREERUN ,ARIZONA_FLL1_FREERUN );regmap_update_bits_check (arizona->regmap, fll->base +1 ,ARIZONA_FLL1_ENA ,0 , &change); regmap_update_bits(arizona->regmap, fll->base + 0x11,
Signature · 1 line
1.7.2.5
Mark Brown
maintainerQuoted 2 lines · Richard Fitzgerald
Signed-off-by Richard Fitzgerald <[email protected]>
Why? Is this a bug fix or a feature?
PATCH v2 1/1 ASoC: arizona: Set FLL to free-run before disabling
In reply to Richard FitzgeraldThe FLL must be placed into free-run mode before disabling to allow it to entirely shut down.
Signed-off-by Richard Fitzgerald <[email protected]>
--- sound/soc/codecs/arizona.c | 4 ++++ 1 files changed, 4 insertions(+), 0 deletions(-)
sound/soc/codecs/arizona.c +4 -0
@@ -1529,6 +1529,8 @@ static void arizona_enable_fll(struct arizona_fll *fll,try_wait_for_completion (&fll->ok);regmap_update_bits (arizona->regmap, fll->base +1 , +ARIZONA_FLL1_FREERUN ,0 ); +regmap_update_bits (arizona->regmap, fll->base +1 ,ARIZONA_FLL1_ENA ,ARIZONA_FLL1_ENA );if (use_sync) regmap_update_bits(arizona->regmap, fll->base + 0x11,
@@ -1546,6 +1548,8 @@ static void arizona_disable_fll(struct arizona_fll *fll)struct arizona *arizona = fll->arizona;bool change; +regmap_update_bits (arizona->regmap, fll->base +1 , +ARIZONA_FLL1_FREERUN ,ARIZONA_FLL1_FREERUN );regmap_update_bits_check (arizona->regmap, fll->base +1 ,ARIZONA_FLL1_ENA ,0 , &change); regmap_update_bits(arizona->regmap, fll->base + 0x11,
Signature · 1 line
1.7.2.5
Quoted 2 lines · Richard Fitzgerald
The FLL must be placed into free-run mode before disabling to allow it to entirely shut down.
Applied, thanks.