Skip to contentSkip to conversation

arm mach-at91: add support for Cosino board series by HCE Engineering

PATCH New Rodolfo Giometti 5 participants 14 messages Nov 6, 2013 – Nov 21, 2013

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 arm mach-at91: add support for Cosino board series by HCE Engineering

This board has been registered at #4607 on http://www.arm.linux.org.uk:

    http://www.arm.linux.org.uk/developer/machines/list.php?id=4607
---
 arch/arm/boot/dts/Makefile            |   1 +
 arch/arm/boot/dts/cosino.dtsi         | 131 ++++++++++++++++++++++++++++++++++
 arch/arm/boot/dts/cosino_mega2560.dts | 101 ++++++++++++++++++++++++++
 3 files changed, 233 insertions(+)
 create mode 100644 arch/arm/boot/dts/cosino.dtsi
 create mode 100644 arch/arm/boot/dts/cosino_mega2560.dts
arch/arm/boot/dts/Makefile +1 -0
index ab6a9f5..15ae041 100644
@@ -35,6 +35,7 @@ dtb-$(CONFIG_ARCH_AT91) += at91sam9g25ek.dtb
 dtb-$(CONFIG_ARCH_AT91) += at91sam9g35ek.dtb
 dtb-$(CONFIG_ARCH_AT91) += at91sam9x25ek.dtb
 dtb-$(CONFIG_ARCH_AT91) += at91sam9x35ek.dtb
+dtb-$(CONFIG_ARCH_AT91) += cosino_mega2560.dtb
 # sama5d3
 dtb-$(CONFIG_ARCH_AT91)	+= sama5d31ek.dtb
 dtb-$(CONFIG_ARCH_AT91)	+= sama5d33ek.dtb
arch/arm/boot/dts/cosino.dtsi new file +131 -0

131 lines not on this page · raw message

arch/arm/boot/dts/cosino_mega2560.dts new file +101 -0

101 lines not on this page · raw message

Signature · 1 line
1.8.1.2
#2 lore raw

PATCH 1/1 arm mach-at91: add support for Cosino board series by HCE Engineering

Quoted 7 lines · Russell King - ARM Linux
Quoted 3 lines · Rodolfo Giometti

This board has been registered at #4607 on http://www.arm.linux.org.uk:

    http://www.arm.linux.org.uk/developer/machines/list.php?id=4607

There is no need to register anything there if you're using DT - the numbers are meaningless with DT.

I see. I just add this info for completness... so you can find whatever info you need about it. :)

Ciao,

Rodolfo

Signature · 5 lines
GNU/Linux Solutions                  e-mail: giometti at enneenne.com
Linux Device Driver                          giometti at linux.it
Embedded Systems                     phone:  +39 349 2432127
UNIX programming                     skype:  rodolfo.giometti
Freelance ICT Italia - Consulente ICT Italia - www.consulenti-ict.it
#3 lore raw

PATCH 1/1 arm mach-at91: add support for Cosino board series by HCE Engineering

In reply to Rodolfo Giometti
Quoted 18 lines · Rodolfo Giometti

This board has been registered at #4607 on http://www.arm.linux.org.uk:

    http://www.arm.linux.org.uk/developer/machines/list.php?id=4607
---
 arch/arm/boot/dts/Makefile            |   1 +
 arch/arm/boot/dts/cosino.dtsi         | 131 ++++++++++++++++++++++++++++++++++
 arch/arm/boot/dts/cosino_mega2560.dts | 101 ++++++++++++++++++++++++++
 3 files changed, 233 insertions(+)
 create mode 100644 arch/arm/boot/dts/cosino.dtsi
 create mode 100644 arch/arm/boot/dts/cosino_mega2560.dts
arch/arm/boot/dts/Makefile +0 -0
index ab6a9f5..15ae041 100644

arch/arm/boot/dts/Makefile dtb-$(CONFIG_ARCH_AT91) += at91sam9g25ek.dtb · line 38

Quoted 4 lines
arch/arm/boot/dts/Makefile +1 -0
@@ -35,6 +35,7 @@ dtb-$(CONFIG_ARCH_AT91) += at91sam9g25ek.dtb
 dtb-$(CONFIG_ARCH_AT91) += at91sam9g35ek.dtb
 dtb-$(CONFIG_ARCH_AT91) += at91sam9x25ek.dtb
 dtb-$(CONFIG_ARCH_AT91) += at91sam9x35ek.dtb
+dtb-$(CONFIG_ARCH_AT91) += cosino_mega2560.dtb

add at91- prefix to all board file

Quoted 80 lines
arch/arm/boot/dts/Makefile +0 -0
 # sama5d3
 dtb-$(CONFIG_ARCH_AT91)	+= sama5d31ek.dtb
 dtb-$(CONFIG_ARCH_AT91)	+= sama5d33ek.dtb
arch/arm/boot/dts/cosino.dtsi new file +71 -0
new file mode 100644
index 0000000..2ae4578
@@ -0,0 +1,131 @@
+/*
+ * cosino.dtsi - Device Tree file for Cosino core module
+ *
+ * Copyright (C) 2013 - Rodolfo Giometti <[email protected]>
+ *			HCE Engineering
+ *
+ * Derived from at91sam9x5ek.dtsi by:
+ *	Copyright (C) 2012 Atmel,
+ *	2012 Nicolas Ferre <[email protected]>
+ *
+ * Licensed under GPLv2 or later.
+ */
+
+#include "at91sam9x5.dtsi"
+
+/ {
+	model = "HCE Cosino core module";
+	compatible = "hce,cosino", "atmel,at91sam9x5ek",
+			"atmel,at91sam9x5", "atmel,at91sam9";
+
+	chosen {
+		bootargs = "console=ttyS0,115200 root=/dev/mmcblk0p2 rw rootfstype=ext3 rootwait";
+	};
+
+	memory {
+		reg = <0x20000000 0x8000000>;
+	};
+
+	clocks {
+		#address-cells = <1>;
+		#size-cells = <1>;
+		ranges;
+
+		main_clock: clock at 0 {
+			compatible = "atmel,osc", "fixed-clock";
+			clock-frequency = <12000000>;
+		};
+	};
+
+	ahb {
+		apb {
+			mmc0: mmc at f0008000 {
+				pinctrl-0 = <
+					&pinctrl_board_mmc0
+					&pinctrl_mmc0_slot0_clk_cmd_dat0
+					&pinctrl_mmc0_slot0_dat1_3>;
+				status = "okay";
+				slot at 0 {
+					reg = <0>;
+					bus-width = <4>;
+					cd-gpios = <&pioD 15 GPIO_ACTIVE_HIGH>;
+				};
+			};
+
+			dbgu: serial at fffff200 {
+				status = "okay";
+			};
+
+			usart0: serial at f801c000 {
+				status = "okay";
+			};
+
+			i2c0: i2c at f8010000 {
+				status = "okay";
+			};
+
+			adc0: adc at f804c000 {
+				atmel,adc-clock-rate = <1000000>;
+				atmel,adc-ts-wires = <4>;
+				atmel,adc-ts-pressure-threshold = <10000>;
+				status = "okay";

arch/arm/boot/dts/cosino.dtsi line 81

Quoted 10 lines
arch/arm/boot/dts/cosino.dtsi new file +10 -0
+			};
+
+			pinctrl at fffff400 {
+				atmel,mux-mask = <
+					/*   A	        B	   C    */
+					0xffffffff 0xffe0399f 0xc000000c  /* pioA */
+					0x000406ff 0x00047e3f 0x00000000  /* pioB */
+					0xfdffffff 0x00000000 0xb83fffff  /* pioC */
+					0x003fffff 0x003f8000 0x00000000  /* pioD */
+				>;

never touch this

this is SoC code not bard

Quoted 67 lines
arch/arm/boot/dts/cosino.dtsi new file +50 -0
+
+				mmc0 {
+					pinctrl_board_mmc0: mmc0-board {
+						atmel,pins =
+							<AT91_PIOD 15 AT91_PERIPH_GPIO AT91_PINCTRL_PULL_UP_DEGLITCH>;	/* PD15 gpio CD pin pull up and deglitch */
+					};
+				};
+			};
+
+			watchdog at fffffe40 {
+				status = "okay";
+			};
+		};
+
+		nand0: nand at 40000000 {
+			nand-bus-width = <8>;
+			nand-ecc-mode = "hw";
+			atmel,has-pmecc;	/* Enable PMECC */
+			atmel,pmecc-cap = <4>;
+			atmel,pmecc-sector-size = <512>;
+			nand-on-flash-bbt;
+			status = "okay";
+
+			at91bootstrap at 0 {
+				label = "at91bootstrap";
+				reg = <0x0 0x40000>;
+			};
+
+			uboot at 40000 {
+				label = "u-boot";
+				reg = <0x40000 0x80000>;
+			};
+
+			ubootenv at c0000 {
+				label = "U-Boot Env";
+				reg = <0xc0000 0x140000>;
+			};
+
+			kernel at 200000 {
+				label = "kernel";
+				reg = <0x200000 0x600000>;
+			};
+
+			rootfs at 800000 {
+				label = "rootfs";
+				reg = <0x800000 0x0f800000>;
+			};
+		};
+	};
+};
arch/arm/boot/dts/cosino_mega2560.dts new file +11 -0
new file mode 100644
index 0000000..677ac6e
@@ -0,0 +1,101 @@
+/*
+ * cosino_mega2560.dts - Device Tree file for Cosino board with Mega 2560
+ *			 extension
+ *
+ * Copyright (C) 2013 - Rodolfo Giometti <[email protected]>
+ *			HCE Engineering
+ *
+ * Derived from at91sam9g35ek.dts by:
+ * 	Copyright (C) 2012 Atmel,
+ *      2012 Nicolas Ferre <[email protected]>
+ *

arch/arm/boot/dts/cosino_mega2560.dts line 21

Quoted 10 lines
arch/arm/boot/dts/cosino_mega2560.dts new file +10 -0
+ * Licensed under GPLv2 or later.
+ */
+
+/dts-v1/;
+#include "cosino.dtsi"
+
+/ {
+	model = "HCE Cosino Mega 2560";
+	compatible = "hce,cosino_mega2560", "atmel,at91sam9x5ek",
+			"atmel,at91sam9x5", "atmel,at91sam9";

on one line so we can grep it

Quoted 24 lines
arch/arm/boot/dts/cosino_mega2560.dts new file +24 -0
+
+	ahb {
+		apb {
+			macb0: ethernet at f802c000 {
+				phy-mode = "rmii";
+				status = "okay";
+			};
+
+			adc0: adc at f804c000 {
+				atmel,adc-clock-rate = <1000000>;
+				atmel,adc-ts-wires = <4>;
+				atmel,adc-ts-pressure-threshold = <10000>;
+				status = "okay";
+			};
+
+
+			tsadcc: tsadcc at f804c000 {
+				status = "okay";
+			};
+
+			lcd_bus at f8038000 {
+				status = "okay";
+				lcd at f8038000 {
+					status = "okay";

arch/arm/boot/dts/cosino_mega2560.dts line 55

Quoted 10 lines
arch/arm/boot/dts/cosino_mega2560.dts new file +10 -0
+				};
+
+				lcdovl1 at f8038100 {
+					status = "okay";
+				};
+
+				lcdheo1 at f8038280 {
+					status = "okay";
+				};
+			};

drop this lcd binding it's not mainline and will not be

Best Best Regards,
J.

#4 lore raw

RFC PATCH v2 1/1 ARM: at91: add support for Cosino board series by HCE Engineering

In reply to Rodolfo Giometti

From: Rodolfo Giometti <[email protected]>

This patch adds the Cosino at91sam9g35 based CPU module and the Cosino Mega 2560 extension board.

Web site: http://www.cosino.it

[nicolas.ferre at atmel.com: adapted to newer kernel, modified commit message]

---
Rodolfo,

Can you please review this adaptation of your previous patch to newer kernel. I hope to integrate your board in upcoming 3.14.

You will see that I addressed the remarks by Jean-Christophe and Russell (about commit message). Please tell me if it is good on your side.

Ciao,

 arch/arm/boot/dts/Makefile                 |   1 +
 arch/arm/boot/dts/at91-cosino.dtsi         | 122 +++++++++++++++++++++++++++++
 arch/arm/boot/dts/at91-cosino_mega2560.dts |  85 ++++++++++++++++++++
 3 files changed, 208 insertions(+)
 create mode 100644 arch/arm/boot/dts/at91-cosino.dtsi
 create mode 100644 arch/arm/boot/dts/at91-cosino_mega2560.dts
arch/arm/boot/dts/Makefile +1 -0
index d57c1a6..772a30e 100644
@@ -30,6 +30,7 @@ dtb-$(CONFIG_ARCH_AT91) += pm9g45.dtb
 dtb-$(CONFIG_ARCH_AT91) += at91sam9n12ek.dtb
 # sam9x5
 dtb-$(CONFIG_ARCH_AT91) += at91-ariag25.dtb
+dtb-$(CONFIG_ARCH_AT91) += at91-cosino_mega2560.dtb
 dtb-$(CONFIG_ARCH_AT91) += at91sam9g15ek.dtb
 dtb-$(CONFIG_ARCH_AT91) += at91sam9g25ek.dtb
 dtb-$(CONFIG_ARCH_AT91) += at91sam9g35ek.dtb
arch/arm/boot/dts/at91-cosino.dtsi new file +122 -0

122 lines not on this page · raw message

arch/arm/boot/dts/at91-cosino_mega2560.dts new file +85 -0

85 lines not on this page · raw message

Signature · 1 line
1.8.2.2
#5 lore raw

RFC PATCH v2 1/1 ARM: at91: add support for Cosino board series by HCE Engineering

Quoted 10 lines · Nicolas Ferre

From: Rodolfo Giometti <[email protected]>

This patch adds the Cosino at91sam9g35 based CPU module and the Cosino Mega 2560 extension board.

Web site: http://www.cosino.it

[nicolas.ferre at atmel.com: adapted to newer kernel, modified commit message]
Quoted 8 lines

---
Rodolfo,

Can you please review this adaptation of your previous patch to newer kernel. I hope to integrate your board in upcoming 3.14.

You will see that I addressed the remarks by Jean-Christophe and Russell (about commit message). Please tell me if it is good on your side.

I did some changes... attached are the correct patches.

Here the changelog V1 -> V2:

[Jean-Christophe PLAGNIOL-VILLARD <[email protected]>]
* prefix "at91-" added
* atmel,mux-mask stuff removed
* "compatible" stuff is now on the same line for easy-grep(TM)
* lcd binding dropped

Ciao,

Rodolfo

Signature · 12 lines
GNU/Linux Solutions                  e-mail: giometti at enneenne.com
Linux Device Driver                          giometti at linux.it
Embedded Systems                     phone:  +39 349 2432127
UNIX programming                     skype:  rodolfo.giometti
Freelance ICT Italia - Consulente ICT Italia - www.consulenti-ict.it
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-arm-mach-at91-add-support-for-Cosino-board-series-by.patch
Type: text/x-diff
Size: 6038 bytes
Desc: not available
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20131113/0b99b342/attachment.bin>
#6 lore raw

RFC PATCH v2 1/1 ARM: at91: add support for Cosino board series by HCE Engineering

On 13/11/2013 18:46, Rodolfo Giometti :

Quoted 14 lines · Nicolas Ferre
Quoted 13 lines

From: Rodolfo Giometti <[email protected]>

This patch adds the Cosino at91sam9g35 based CPU module and the Cosino Mega 2560 extension board.

Web site: http://www.cosino.it

[nicolas.ferre at atmel.com: adapted to newer kernel, modified commit message]

---
Rodolfo,

Quoted 7 lines
Quoted 5 lines

Can you please review this adaptation of your previous patch to newer kernel. I hope to integrate your board in upcoming 3.14.

You will see that I addressed the remarks by Jean-Christophe and Russell (about commit message). Please tell me if it is good on your side.

I did some changes... attached are the correct patches.

Doing the diff between our patch I only seen a difference in nand binding:
nand-on-flash-bbt;
is present in my adaptation while it is not in yours but I do not think it is a problem to keep it.

Quoted 7 lines

Here the changelog V1 -> V2:

[Jean-Christophe PLAGNIOL-VILLARD <[email protected]>]
* prefix "at91-" added
* atmel,mux-mask stuff removed
* "compatible" stuff is now on the same line for easy-grep(TM)
* lcd binding dropped

Absolutely, I will add it to the commit log and integrate in the upcoming at91-3.14-dt branch.

Thanks for your quick feedback. Bye,

Signature · 1 line
Nicolas Ferre
#7 lore raw

RFC PATCH v2 1/1 ARM: at91: add support for Cosino board series by HCE Engineering

Quoted 21 lines · Nicolas Ferre

On 13/11/2013 18:46, Rodolfo Giometti :

Quoted 20 lines · Nicolas Ferre
Quoted 18 lines

From: Rodolfo Giometti <[email protected]>

This patch adds the Cosino at91sam9g35 based CPU module and the Cosino Mega 2560 extension board.

Web site: http://www.cosino.it

[nicolas.ferre at atmel.com: adapted to newer kernel, modified commit message]

---
Rodolfo,

Can you please review this adaptation of your previous patch to newer kernel. I hope to integrate your board in upcoming 3.14.

You will see that I addressed the remarks by Jean-Christophe and Russell (about commit message). Please tell me if it is good on your side.

Quoted 6 lines
Quoted 1 line

I did some changes... attached are the correct patches.

Doing the diff between our patch I only seen a difference in nand binding:
nand-on-flash-bbt;
is present in my adaptation while it is not in yours but I do not think it is a problem to keep it.

Well, I tested Cosino's NAND flash without such parameter... however if you think it could not be a problem you can leave it.

Quoted 8 lines
Quoted 7 lines

Here the changelog V1 -> V2:

[Jean-Christophe PLAGNIOL-VILLARD <[email protected]>]
* prefix "at91-" added
* atmel,mux-mask stuff removed
* "compatible" stuff is now on the same line for easy-grep(TM)
* lcd binding dropped

Quoted 4 lines

Absolutely, I will add it to the commit log and integrate in the upcoming at91-3.14-dt branch.

Thanks for your quick feedback. Bye,

Great! Thanks. :)

Ciao,

Rodolfo

Signature · 5 lines
GNU/Linux Solutions                  e-mail: giometti at enneenne.com
Linux Device Driver                          giometti at linux.it
Embedded Systems                     phone:  +39 349 2432127
UNIX programming                     skype:  rodolfo.giometti
Freelance ICT Italia - Consulente ICT Italia - www.consulenti-ict.it
#8 lore raw

RFC PATCH v2 1/1 ARM: at91: add support for Cosino board series by HCE Engineering

In reply to Nicolas Ferre
Quoted 55 lines · Nicolas Ferre

From: Rodolfo Giometti <[email protected]>

This patch adds the Cosino at91sam9g35 based CPU module and the Cosino Mega 2560 extension board.

Web site: http://www.cosino.it

[nicolas.ferre at atmel.com: adapted to newer kernel, modified commit message]

---
Rodolfo,

Can you please review this adaptation of your previous patch to newer kernel. I hope to integrate your board in upcoming 3.14.

You will see that I addressed the remarks by Jean-Christophe and Russell (about commit message). Please tell me if it is good on your side.

Ciao,

 arch/arm/boot/dts/Makefile                 |   1 +
 arch/arm/boot/dts/at91-cosino.dtsi         | 122 +++++++++++++++++++++++++++++
 arch/arm/boot/dts/at91-cosino_mega2560.dts |  85 ++++++++++++++++++++
 3 files changed, 208 insertions(+)
 create mode 100644 arch/arm/boot/dts/at91-cosino.dtsi
 create mode 100644 arch/arm/boot/dts/at91-cosino_mega2560.dts
arch/arm/boot/dts/Makefile +1 -0
index d57c1a6..772a30e 100644
@@ -30,6 +30,7 @@ dtb-$(CONFIG_ARCH_AT91) += pm9g45.dtb
 dtb-$(CONFIG_ARCH_AT91) += at91sam9n12ek.dtb
 # sam9x5
 dtb-$(CONFIG_ARCH_AT91) += at91-ariag25.dtb
+dtb-$(CONFIG_ARCH_AT91) += at91-cosino_mega2560.dtb
 dtb-$(CONFIG_ARCH_AT91) += at91sam9g15ek.dtb
 dtb-$(CONFIG_ARCH_AT91) += at91sam9g25ek.dtb
 dtb-$(CONFIG_ARCH_AT91) += at91sam9g35ek.dtb
arch/arm/boot/dts/at91-cosino.dtsi new file +8 -0
new file mode 100644
index 0000000..53f2b01
@@ -0,0 +1,122 @@
+/*
+ * at91-cosino.dtsi - Device Tree file for Cosino core module
+ *
+ * Copyright (C) 2013 - Rodolfo Giometti <[email protected]>
+ *			HCE Engineering
+ *
+ * Derived from at91sam9x5ek.dtsi by:
+ *	Copyright (C) 2012 Atmel,

arch/arm/boot/dts/at91-cosino.dtsi line 18

Quoted 10 lines
arch/arm/boot/dts/at91-cosino.dtsi new file +10 -0
+ *	2012 Nicolas Ferre <[email protected]>
+ *
+ * Licensed under GPLv2 or later.
+ */
+
+#include "at91sam9g35.dtsi"
+
+/ {
+	model = "HCE Cosino core module";
+	compatible = "hce,cosino", "atmel,at91sam9x5ek", "atmel,at91sam9x5", "atmel,at91sam9";

is this really sam9xek compatible?

Quoted 5 lines
arch/arm/boot/dts/at91-cosino.dtsi new file +5 -0
+
+	chosen {
+		bootargs = "console=ttyS0,115200 root=/dev/mmcblk0p2 rw rootfstype=ext3 rootwait";
+	};
+

...

arch/arm/boot/dts/at91-cosino.dtsi

Quoted 3 lines
arch/arm/boot/dts/at91-cosino.dtsi new file +3 -0
+/ {
+	model = "HCE Cosino Mega 2560";
+	compatible = "hce,cosino_mega2560", "atmel,at91sam9x5ek", "atmel,at91sam9x5", "atmel,at91sam9";

ditto

Quoted 16 lines
arch/arm/boot/dts/at91-cosino.dtsi new file +16 -0
+
+	ahb {
+		apb {
+			macb0: ethernet at f802c000 {
+				phy-mode = "rmii";
+				status = "okay";
+			};
+
+			adc0: adc at f804c000 {
+				atmel,adc-clock-rate = <1000000>;
+				atmel,adc-ts-wires = <4>;
+				atmel,adc-ts-pressure-threshold = <10000>;
+				status = "okay";
+			};
+
+

arch/arm/boot/dts/at91-cosino.dtsi

Quoted 10 lines
arch/arm/boot/dts/at91-cosino.dtsi new file +10 -0
+			tsadcc: tsadcc at f804c000 {
+				status = "okay";
+			};
+
+			rtc at fffffeb0 {
+				status = "okay";
+			};
+
+			usart1: serial at f8020000 {
+			       status = "okay";

tab no space

arch/arm/boot/dts/at91-cosino.dtsi

Quoted 4 lines
arch/arm/boot/dts/at91-cosino.dtsi new file +4 -0
+			};
+
+			usart2: serial at f8024000 {
+			       status = "okay";

tab no space

arch/arm/boot/dts/at91-cosino.dtsi

Quoted 11 lines
arch/arm/boot/dts/at91-cosino.dtsi new file +11 -0
+			};
+
+			usb2: gadget at f803c000 {
+				atmel,vbus-gpio = <&pioB 16 GPIO_ACTIVE_HIGH>;
+				status = "okay";
+			};
+
+		usb0: ohci at 00600000 {
+			status = "okay";
+			num-ports = <3>;
+			atmel,vbus-gpio = <0 /* &pioD 18 GPIO_ACTIVE_LOW *//* Activate to have access to port A */

do we really need the comment code?

arch/arm/boot/dts/at91-cosino.dtsi

Quoted 5 lines
arch/arm/boot/dts/at91-cosino.dtsi new file +5 -0
+					   &pioD 19 GPIO_ACTIVE_LOW
+					   &pioD 20 GPIO_ACTIVE_LOW
+					  >;
+		};
+

Best Regards,
J.

#9 lore raw

RFC PATCH v2 1/1 ARM: at91: add support for Cosino board series by HCE Engineering

Quoted 59 lines · Jean-Christophe PLAGNIOL-VILLARD
Quoted 58 lines · Nicolas Ferre

From: Rodolfo Giometti <[email protected]>

This patch adds the Cosino at91sam9g35 based CPU module and the Cosino Mega 2560 extension board.

Web site: http://www.cosino.it

[nicolas.ferre at atmel.com: adapted to newer kernel, modified commit message]

---
Rodolfo,

Can you please review this adaptation of your previous patch to newer kernel. I hope to integrate your board in upcoming 3.14.

You will see that I addressed the remarks by Jean-Christophe and Russell (about commit message). Please tell me if it is good on your side.

Ciao,

 arch/arm/boot/dts/Makefile                 |   1 +
 arch/arm/boot/dts/at91-cosino.dtsi         | 122 +++++++++++++++++++++++++++++
 arch/arm/boot/dts/at91-cosino_mega2560.dts |  85 ++++++++++++++++++++
 3 files changed, 208 insertions(+)
 create mode 100644 arch/arm/boot/dts/at91-cosino.dtsi
 create mode 100644 arch/arm/boot/dts/at91-cosino_mega2560.dts
arch/arm/boot/dts/Makefile +1 -0
index d57c1a6..772a30e 100644
@@ -30,6 +30,7 @@ dtb-$(CONFIG_ARCH_AT91) += pm9g45.dtb
 dtb-$(CONFIG_ARCH_AT91) += at91sam9n12ek.dtb
 # sam9x5
 dtb-$(CONFIG_ARCH_AT91) += at91-ariag25.dtb
+dtb-$(CONFIG_ARCH_AT91) += at91-cosino_mega2560.dtb
 dtb-$(CONFIG_ARCH_AT91) += at91sam9g15ek.dtb
 dtb-$(CONFIG_ARCH_AT91) += at91sam9g25ek.dtb
 dtb-$(CONFIG_ARCH_AT91) += at91sam9g35ek.dtb
arch/arm/boot/dts/at91-cosino.dtsi new file +11 -0
new file mode 100644
index 0000000..53f2b01
@@ -0,0 +1,122 @@
+/*
+ * at91-cosino.dtsi - Device Tree file for Cosino core module
+ *
+ * Copyright (C) 2013 - Rodolfo Giometti <[email protected]>
+ *			HCE Engineering
+ *
+ * Derived from at91sam9x5ek.dtsi by:
+ *	Copyright (C) 2012 Atmel,
+ *	2012 Nicolas Ferre <[email protected]>
+ *
+ * Licensed under GPLv2 or later.
Quoted 8 lines

arch/arm/boot/dts/at91-cosino.dtsi line 18

Quoted 7 lines
arch/arm/boot/dts/at91-cosino.dtsi new file +7 -0
+ */
+
+#include "at91sam9g35.dtsi"
+
+/ {
+	model = "HCE Cosino core module";
+	compatible = "hce,cosino", "atmel,at91sam9x5ek", "atmel,at91sam9x5", "atmel,at91sam9";

is this really sam9xek compatible?

Well, the board is derived from ATMEL dev board... maybe I can remove these lines... :-/

Quoted 29 lines
Quoted 5 lines
arch/arm/boot/dts/at91-cosino.dtsi new file +5 -0
+
+	chosen {
+		bootargs = "console=ttyS0,115200 root=/dev/mmcblk0p2 rw rootfstype=ext3 rootwait";
+	};
+

...

arch/arm/boot/dts/at91-cosino.dtsi

Quoted 3 lines
arch/arm/boot/dts/at91-cosino.dtsi new file +3 -0
+/ {
+	model = "HCE Cosino Mega 2560";
+	compatible = "hce,cosino_mega2560", "atmel,at91sam9x5ek", "atmel,at91sam9x5", "atmel,at91sam9";

ditto

Quoted 19 lines
arch/arm/boot/dts/at91-cosino.dtsi new file +19 -0
+
+	ahb {
+		apb {
+			macb0: ethernet at f802c000 {
+				phy-mode = "rmii";
+				status = "okay";
+			};
+
+			adc0: adc at f804c000 {
+				atmel,adc-clock-rate = <1000000>;
+				atmel,adc-ts-wires = <4>;
+				atmel,adc-ts-pressure-threshold = <10000>;
+				status = "okay";
+			};
+
+
+			tsadcc: tsadcc at f804c000 {
+				status = "okay";
+			};
Quoted 8 lines

arch/arm/boot/dts/at91-cosino.dtsi

Quoted 7 lines
arch/arm/boot/dts/at91-cosino.dtsi new file +7 -0
+
+			rtc at fffffeb0 {
+				status = "okay";
+			};
+
+			usart1: serial at f8020000 {
+			       status = "okay";

tab no space

Fixed

Quoted 5 lines

arch/arm/boot/dts/at91-cosino.dtsi

Quoted 4 lines
arch/arm/boot/dts/at91-cosino.dtsi new file +4 -0
+			};
+
+			usart2: serial at f8024000 {
+			       status = "okay";

tab no space

Fixed

Quoted 4 lines
Quoted 4 lines
arch/arm/boot/dts/at91-cosino.dtsi new file +4 -0
+			};
+
+			usb2: gadget at f803c000 {
+				atmel,vbus-gpio = <&pioB 16 GPIO_ACTIVE_HIGH>;
Quoted 8 lines

arch/arm/boot/dts/at91-cosino.dtsi

Quoted 7 lines
arch/arm/boot/dts/at91-cosino.dtsi new file +7 -0
+				status = "okay";
+			};
+
+		usb0: ohci at 00600000 {
+			status = "okay";
+			num-ports = <3>;
+			atmel,vbus-gpio = <0 /* &pioD 18 GPIO_ACTIVE_LOW *//* Activate to have access to port A */

do we really need the comment code?

Ok, I dropped second comment...

Quoted 7 lines

arch/arm/boot/dts/at91-cosino.dtsi

Quoted 5 lines
arch/arm/boot/dts/at91-cosino.dtsi new file +5 -0
+					   &pioD 19 GPIO_ACTIVE_LOW
+					   &pioD 20 GPIO_ACTIVE_LOW
+					  >;
+		};
+

Best Regards,
J.

Attached the new patch version.

Ciao,

Rodolfo

Signature · 12 lines
GNU/Linux Solutions                  e-mail: giometti at enneenne.com
Linux Device Driver                          giometti at linux.it
Embedded Systems                     phone:  +39 349 2432127
UNIX programming                     skype:  rodolfo.giometti
Freelance ICT Italia - Consulente ICT Italia - www.consulenti-ict.it
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-arm-mach-at91-add-support-for-Cosino-board-series-by.patch
Type: text/x-diff
Size: 5939 bytes
Desc: not available
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20131114/f087a269/attachment-0001.bin>
#10 lore raw

RFC PATCH v2 1/1 ARM: at91: add support for Cosino board series by HCE Engineering

Quoted 69 lines · Rodolfo Giometti
Quoted 59 lines · Jean-Christophe PLAGNIOL-VILLARD
Quoted 58 lines · Nicolas Ferre

From: Rodolfo Giometti <[email protected]>

This patch adds the Cosino at91sam9g35 based CPU module and the Cosino Mega 2560 extension board.

Web site: http://www.cosino.it

[nicolas.ferre at atmel.com: adapted to newer kernel, modified commit message]

---
Rodolfo,

Can you please review this adaptation of your previous patch to newer kernel. I hope to integrate your board in upcoming 3.14.

You will see that I addressed the remarks by Jean-Christophe and Russell (about commit message). Please tell me if it is good on your side.

Ciao,

 arch/arm/boot/dts/Makefile                 |   1 +
 arch/arm/boot/dts/at91-cosino.dtsi         | 122 +++++++++++++++++++++++++++++
 arch/arm/boot/dts/at91-cosino_mega2560.dts |  85 ++++++++++++++++++++
 3 files changed, 208 insertions(+)
 create mode 100644 arch/arm/boot/dts/at91-cosino.dtsi
 create mode 100644 arch/arm/boot/dts/at91-cosino_mega2560.dts
arch/arm/boot/dts/Makefile +1 -0
index d57c1a6..772a30e 100644
@@ -30,6 +30,7 @@ dtb-$(CONFIG_ARCH_AT91) += pm9g45.dtb
 dtb-$(CONFIG_ARCH_AT91) += at91sam9n12ek.dtb
 # sam9x5
 dtb-$(CONFIG_ARCH_AT91) += at91-ariag25.dtb
+dtb-$(CONFIG_ARCH_AT91) += at91-cosino_mega2560.dtb
 dtb-$(CONFIG_ARCH_AT91) += at91sam9g15ek.dtb
 dtb-$(CONFIG_ARCH_AT91) += at91sam9g25ek.dtb
 dtb-$(CONFIG_ARCH_AT91) += at91sam9g35ek.dtb
arch/arm/boot/dts/at91-cosino.dtsi new file +11 -0
new file mode 100644
index 0000000..53f2b01
@@ -0,0 +1,122 @@
+/*
+ * at91-cosino.dtsi - Device Tree file for Cosino core module
+ *
+ * Copyright (C) 2013 - Rodolfo Giometti <[email protected]>
+ *			HCE Engineering
+ *
+ * Derived from at91sam9x5ek.dtsi by:
+ *	Copyright (C) 2012 Atmel,
+ *	2012 Nicolas Ferre <[email protected]>
+ *
+ * Licensed under GPLv2 or later.
Quoted 8 lines

arch/arm/boot/dts/at91-cosino.dtsi line 18

Quoted 7 lines
arch/arm/boot/dts/at91-cosino.dtsi new file +7 -0
+ */
+
+#include "at91sam9g35.dtsi"
+
+/ {
+	model = "HCE Cosino core module";
+	compatible = "hce,cosino", "atmel,at91sam9x5ek", "atmel,at91sam9x5", "atmel,at91sam9";

is this really sam9xek compatible?

Quoted 2 lines

Well, the board is derived from ATMEL dev board... maybe I can remove these lines... :-/

compatible means you board is an extension and that the kernel + dtb will run on both without modification

Quoted 10 lines
Quoted 10 lines
Quoted 6 lines
arch/arm/boot/dts/at91-cosino.dtsi new file +5 -0
+
+	chosen {
+		bootargs = "console=ttyS0,115200 root=/dev/mmcblk0p2 rw rootfstype=ext3 rootwait";
+	};
+

...

Quoted 3 lines
arch/arm/boot/dts/at91-cosino.dtsi new file +3 -0
+/ {
+	model = "HCE Cosino Mega 2560";
+	compatible = "hce,cosino_mega2560", "atmel,at91sam9x5ek", "atmel,at91sam9x5", "atmel,at91sam9";

...

Quoted 16 lines
arch/arm/boot/dts/at91-cosino.dtsi new file +16 -0
+
+	ahb {
+		apb {
+			mmc0: mmc at f0008000 {
+				pinctrl-0 = <
+					&pinctrl_board_mmc0
+					&pinctrl_mmc0_slot0_clk_cmd_dat0
+					&pinctrl_mmc0_slot0_dat1_3>;
+				status = "okay";
+				slot at 0 {
+					reg = <0>;
+					bus-width = <4>;
+					cd-gpios = <&pioD 15 GPIO_ACTIVE_HIGH>;
+				};
+			};
+

...

arch/arm/boot/dts/at91-cosino_mega2560.dts line 60

Quoted 4 lines
arch/arm/boot/dts/at91-cosino_mega2560.dts new file +4 -0
+
+			mmc1: mmc at f000c000 {
+				pinctrl-0 = <
+					&pinctrl_board_mmc0

this will failled you can not have the same pux on 2 device

arch/arm/boot/dts/at91-cosino_mega2560.dts line 71

Quoted 11 lines
arch/arm/boot/dts/at91-cosino_mega2560.dts new file +11 -0
+					&pinctrl_mmc1_slot0_clk_cmd_dat0
+					&pinctrl_mmc1_slot0_dat1_3>;
+				status = "okay";
+				slot at 0 {
+					reg = <0>;
+					bus-width = <4>;
+					non-removable;
+				};
+			};
+		};
+

Best Regards,
J.

#11 lore raw

RFC PATCH v2 1/1 ARM: at91: add support for Cosino board series by HCE Engineering

Quoted 7 lines · Jean-Christophe PLAGNIOL-VILLARD
Quoted 7 lines
Quoted 6 lines

arch/arm/boot/dts/at91-cosino.dtsi line 18

Quoted 5 lines
arch/arm/boot/dts/at91-cosino.dtsi new file +5 -0
+#include "at91sam9g35.dtsi"
+
+/ {
+	model = "HCE Cosino core module";
+	compatible = "hce,cosino", "atmel,at91sam9x5ek", "atmel,at91sam9x5", "atmel,at91sam9";

is this really sam9xek compatible?

Quoted 5 lines
Quoted 2 lines

Well, the board is derived from ATMEL dev board... maybe I can remove these lines... :-/

compatible means you board is an extension and that the kernel + dtb will run on both without modification

Ok, at91sam9x5ek dropped.

Quoted 5 lines

arch/arm/boot/dts/at91-cosino_mega2560.dts line 60

Quoted 4 lines
arch/arm/boot/dts/at91-cosino_mega2560.dts new file +4 -0
+
+			mmc1: mmc at f000c000 {
+				pinctrl-0 = <
+					&pinctrl_board_mmc0

this will failled you can not have the same pux on 2 device

Fixed.

Attached a new patch version (V3).

### Changelog

V2 -> V3

[Jean-Christophe PLAGNIOL-VILLARD <[email protected]>]
* Reference to at91sam9x5ek dropped.
* Inavlid mmc1 pinctrl-0 setting fixed

V1 -> V2

[Jean-Christophe PLAGNIOL-VILLARD <[email protected]>]
* prefix "at91-" added
* atmel,mux-mask stuff removed
* "compatible" stuff is now on the same line for easy-grep(TM)
* lcd binding dropped

Ciao,

Rodolfo

Signature · 12 lines
GNU/Linux Solutions                  e-mail: giometti at enneenne.com
Linux Device Driver                          giometti at linux.it
Embedded Systems                     phone:  +39 349 2432127
UNIX programming                     skype:  rodolfo.giometti
Freelance ICT Italia - Consulente ICT Italia - www.consulenti-ict.it
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-arm-mach-at91-add-support-for-Cosino-board-series-by.patch
Type: text/x-diff
Size: 5913 bytes
Desc: not available
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20131120/c06f5cf8/attachment.bin>
#12 lore raw

RFC PATCH v2 1/1 ARM: at91: add support for Cosino board series by HCE Engineering

Quoted 8 lines · Rodolfo Giometti
Quoted 7 lines · Jean-Christophe PLAGNIOL-VILLARD
Quoted 7 lines
Quoted 6 lines

arch/arm/boot/dts/at91-cosino.dtsi line 18

Quoted 5 lines
arch/arm/boot/dts/at91-cosino.dtsi new file +5 -0
+#include "at91sam9g35.dtsi"
+
+/ {
+	model = "HCE Cosino core module";
+	compatible = "hce,cosino", "atmel,at91sam9x5ek", "atmel,at91sam9x5", "atmel,at91sam9";

is this really sam9xek compatible?

Quoted 5 lines
Quoted 5 lines
Quoted 2 lines

Well, the board is derived from ATMEL dev board... maybe I can remove these lines... :-/

compatible means you board is an extension and that the kernel + dtb will run on both without modification

this time look ok a small issue the file in the comment is missing the at91-

otherwise

Best Regards,
J.

Quoted 300 lines

Ok, at91sam9x5ek dropped.

Quoted 5 lines

arch/arm/boot/dts/at91-cosino_mega2560.dts line 60

Quoted 4 lines
arch/arm/boot/dts/at91-cosino_mega2560.dts new file +4 -0
+
+			mmc1: mmc at f000c000 {
+				pinctrl-0 = <
+					&pinctrl_board_mmc0

this will failled you can not have the same pux on 2 device

Fixed.

Attached a new patch version (V3).

### Changelog

V2 -> V3

[Jean-Christophe PLAGNIOL-VILLARD <[email protected]>]
* Reference to at91sam9x5ek dropped.
* Inavlid mmc1 pinctrl-0 setting fixed

V1 -> V2

[Jean-Christophe PLAGNIOL-VILLARD <[email protected]>]
* prefix "at91-" added
* atmel,mux-mask stuff removed
* "compatible" stuff is now on the same line for easy-grep(TM)
* lcd binding dropped

Ciao,

Rodolfo

Signature · 27 lines
GNU/Linux Solutions                  e-mail: giometti at enneenne.com
Linux Device Driver                          giometti at linux.it
Embedded Systems                     phone:  +39 349 2432127
UNIX programming                     skype:  rodolfo.giometti
Freelance ICT Italia - Consulente ICT Italia - www.consulenti-ict.it

From 16882a9f85faa21bcd7102894b7829eb4d77f97d Mon Sep 17 00:00:00 2001
From: Rodolfo Giometti <[email protected]>
Date: Wed, 6 Nov 2013 16:31:50 +0100
Subject: [PATCH] arm mach-at91: add support for Cosino board series by HCE
 Engineering

This patch adds the Cosino at91sam9g35 based CPU module and the
Cosino Mega 2560 extension board.

Web site: http://www.cosino.it

Signed-off-by: Rodolfo Giometti <[email protected]>
[nicolas.ferre at atmel.com: adapted to newer kernel, modified commit message]
Signed-off-by: Nicolas Ferre <[email protected]>
---
 arch/arm/boot/dts/Makefile                 |   1 +
 arch/arm/boot/dts/at91-cosino.dtsi         | 121 +++++++++++++++++++++++++++++
 arch/arm/boot/dts/at91-cosino_mega2560.dts |  84 ++++++++++++++++++++
 3 files changed, 206 insertions(+)
 create mode 100644 arch/arm/boot/dts/at91-cosino.dtsi
 create mode 100644 arch/arm/boot/dts/at91-cosino_mega2560.dts
arch/arm/boot/dts/Makefile +1 -0
index ab6a9f5..b05f5e6 100644
@@ -35,6 +35,7 @@ dtb-$(CONFIG_ARCH_AT91) += at91sam9g25ek.dtb
 dtb-$(CONFIG_ARCH_AT91) += at91sam9g35ek.dtb
 dtb-$(CONFIG_ARCH_AT91) += at91sam9x25ek.dtb
 dtb-$(CONFIG_ARCH_AT91) += at91sam9x35ek.dtb
+dtb-$(CONFIG_ARCH_AT91) += at91-cosino_mega2560.dtb
 # sama5d3
 dtb-$(CONFIG_ARCH_AT91)	+= sama5d31ek.dtb
 dtb-$(CONFIG_ARCH_AT91)	+= sama5d33ek.dtb
arch/arm/boot/dts/at91-cosino.dtsi new file +121 -0
new file mode 100644
index 0000000..00e2112
@@ -0,0 +1,121 @@
+/*
+ * cosino.dtsi - Device Tree file for Cosino core module
+ *
+ * Copyright (C) 2013 - Rodolfo Giometti <[email protected]>
+ *			HCE Engineering
+ *
+ * Derived from at91sam9x5ek.dtsi by:
+ *	Copyright (C) 2012 Atmel,
+ *	2012 Nicolas Ferre <[email protected]>
+ *
+ * Licensed under GPLv2 or later.
+ */
+
+#include "at91sam9g35.dtsi"
+
+/ {
+	model = "HCE Cosino core module";
+	compatible = "hce,cosino", "atmel,at91sam9x5", "atmel,at91sam9";
+
+	chosen {
+		bootargs = "console=ttyS0,115200 root=/dev/mmcblk0p2 rw rootfstype=ext3 rootwait";
+	};
+
+	memory {
+		reg = <0x20000000 0x8000000>;
+	};
+
+	clocks {
+		#address-cells = <1>;
+		#size-cells = <1>;
+		ranges;
+
+		main_clock: clock at 0 {
+			compatible = "atmel,osc", "fixed-clock";
+			clock-frequency = <12000000>;
+		};
+	};
+
+	ahb {
+		apb {
+			mmc0: mmc at f0008000 {
+				pinctrl-0 = <
+					&pinctrl_board_mmc0
+					&pinctrl_mmc0_slot0_clk_cmd_dat0
+					&pinctrl_mmc0_slot0_dat1_3>;
+				status = "okay";
+				slot at 0 {
+					reg = <0>;
+					bus-width = <4>;
+					cd-gpios = <&pioD 15 GPIO_ACTIVE_HIGH>;
+				};
+			};
+
+			dbgu: serial at fffff200 {
+				status = "okay";
+			};
+
+			usart0: serial at f801c000 {
+				status = "okay";
+			};
+
+			i2c0: i2c at f8010000 {
+				status = "okay";
+			};
+
+			adc0: adc at f804c000 {
+				atmel,adc-clock-rate = <1000000>;
+				atmel,adc-ts-wires = <4>;
+				atmel,adc-ts-pressure-threshold = <10000>;
+				status = "okay";
+			};
+
+			pinctrl at fffff400 {
+				mmc0 {
+					pinctrl_board_mmc0: mmc0-board {
+						atmel,pins =
+							<AT91_PIOD 15 AT91_PERIPH_GPIO AT91_PINCTRL_PULL_UP_DEGLITCH>;	/* PD15 gpio CD pin pull up and deglitch */
+					};
+				};
+			};
+
+			watchdog at fffffe40 {
+				status = "okay";
+			};
+		};
+
+		nand0: nand at 40000000 {
+			nand-bus-width = <8>;
+			nand-ecc-mode = "hw";
+			atmel,has-pmecc;	/* Enable PMECC */
+			atmel,pmecc-cap = <4>;
+			atmel,pmecc-sector-size = <512>;
+			status = "okay";
+
+			at91bootstrap at 0 {
+				label = "at91bootstrap";
+				reg = <0x0 0x40000>;
+			};
+
+			uboot at 40000 {
+				label = "u-boot";
+				reg = <0x40000 0x80000>;
+			};
+
+			ubootenv at c0000 {
+				label = "U-Boot Env";
+				reg = <0xc0000 0x140000>;
+			};
+
+			kernel at 200000 {
+				label = "kernel";
+				reg = <0x200000 0x600000>;
+			};
+
+			rootfs at 800000 {
+				label = "rootfs";
+				reg = <0x800000 0x0f800000>;
+			};
+		};
+	};
+};
arch/arm/boot/dts/at91-cosino_mega2560.dts new file +84 -0
new file mode 100644
index 0000000..c29c53c
@@ -0,0 +1,84 @@
+/*
+ * cosino_mega2560.dts - Device Tree file for Cosino board with Mega 2560
+ *			 extension
+ *
+ * Copyright (C) 2013 - Rodolfo Giometti <[email protected]>
+ *			HCE Engineering
+ *
+ * Derived from at91sam9g35ek.dts by:
+ * 	Copyright (C) 2012 Atmel,
+ *      2012 Nicolas Ferre <[email protected]>
+ *
+ * Licensed under GPLv2 or later.
+ */
+
+/dts-v1/;
+#include "at91-cosino.dtsi"
+
+/ {
+	model = "HCE Cosino Mega 2560";
+	compatible = "hce,cosino_mega2560", "atmel,at91sam9x5", "atmel,at91sam9";
+
+	ahb {
+		apb {
+			macb0: ethernet at f802c000 {
+				phy-mode = "rmii";
+				status = "okay";
+			};
+
+			adc0: adc at f804c000 {
+				atmel,adc-clock-rate = <1000000>;
+				atmel,adc-ts-wires = <4>;
+				atmel,adc-ts-pressure-threshold = <10000>;
+				status = "okay";
+			};
+
+
+			tsadcc: tsadcc at f804c000 {
+				status = "okay";
+			};
+
+			rtc at fffffeb0 {
+				status = "okay";
+			};
+
+			usart1: serial at f8020000 {
+				status = "okay";
+			};
+
+			usart2: serial at f8024000 {
+				status = "okay";
+			};
+
+			usb2: gadget at f803c000 {
+				atmel,vbus-gpio = <&pioB 16 GPIO_ACTIVE_HIGH>;
+				status = "okay";
+			};
+
+			mmc1: mmc at f000c000 {
+				pinctrl-0 = <
+					&pinctrl_mmc1_slot0_clk_cmd_dat0
+					&pinctrl_mmc1_slot0_dat1_3>;
+				status = "okay";
+				slot at 0 {
+					reg = <0>;
+					bus-width = <4>;
+					non-removable;
+				};
+			};
+		};
+
+		usb0: ohci at 00600000 {
+			status = "okay";
+			num-ports = <3>;
+			atmel,vbus-gpio = <0 /* &pioD 18 GPIO_ACTIVE_LOW */
+					   &pioD 19 GPIO_ACTIVE_LOW
+					   &pioD 20 GPIO_ACTIVE_LOW
+					  >;
+		};
+
+		usb1: ehci at 00700000 {
+			status = "okay";
+		};
+	};
+};
Signature · 7 lines
1.8.1.2


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel at lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
#13 lore raw

RFC PATCH v2 1/1 ARM: at91: add support for Cosino board series by HCE Engineering

On 20/11/2013 19:50, Jean-Christophe PLAGNIOL-VILLARD :

Quoted 9 lines · Rodolfo Giometti
Quoted 8 lines · Jean-Christophe PLAGNIOL-VILLARD
Quoted 7 lines
Quoted 7 lines
Quoted 6 lines

arch/arm/boot/dts/at91-cosino.dtsi line 18

Quoted 5 lines
arch/arm/boot/dts/at91-cosino.dtsi new file +5 -0
+#include "at91sam9g35.dtsi"
+
+/ {
+	model = "HCE Cosino core module";
+	compatible = "hce,cosino", "atmel,at91sam9x5ek", "atmel,at91sam9x5", "atmel,at91sam9";

is this really sam9xek compatible?

Quoted 7 lines
Quoted 5 lines
Quoted 5 lines
Quoted 2 lines

Well, the board is derived from ATMEL dev board... maybe I can remove these lines... :-/

compatible means you board is an extension and that the kernel + dtb will run on both without modification

this time look ok a small issue the file in the comment is missing the at91-

No wories, I fixed this while integrating the patch in at91-3.14-dt branch.

Quoted 4 lines

otherwise

Thanks, bye.

Quoted 301 lines
Quoted 299 lines

Ok, at91sam9x5ek dropped.

Quoted 5 lines

arch/arm/boot/dts/at91-cosino_mega2560.dts line 60

Quoted 4 lines
arch/arm/boot/dts/at91-cosino_mega2560.dts new file +4 -0
+
+			mmc1: mmc at f000c000 {
+				pinctrl-0 = <
+					&pinctrl_board_mmc0

this will failled you can not have the same pux on 2 device

Fixed.

Attached a new patch version (V3).

### Changelog

V2 -> V3

[Jean-Christophe PLAGNIOL-VILLARD <[email protected]>]
* Reference to at91sam9x5ek dropped.
* Inavlid mmc1 pinctrl-0 setting fixed

V1 -> V2

[Jean-Christophe PLAGNIOL-VILLARD <[email protected]>]
* prefix "at91-" added
* atmel,mux-mask stuff removed
* "compatible" stuff is now on the same line for easy-grep(TM)
* lcd binding dropped

Ciao,

Rodolfo

--

GNU/Linux Solutions e-mail: giometti at enneenne.com

Linux Device Driver                          giometti at linux.it
Embedded Systems                     phone:  +39 349 2432127
UNIX programming                     skype:  rodolfo.giometti

Freelance ICT Italia - Consulente ICT Italia - www.consulenti-ict.it

From 16882a9f85faa21bcd7102894b7829eb4d77f97d Mon Sep 17 00:00:00 2001
From: Rodolfo Giometti <[email protected]>
Date: Wed, 6 Nov 2013 16:31:50 +0100
Subject: [PATCH] arm mach-at91: add support for Cosino board series by HCE
Engineering

This patch adds the Cosino at91sam9g35 based CPU module and the Cosino Mega 2560 extension board.

Web site: http://www.cosino.it

[nicolas.ferre at atmel.com: adapted to newer kernel, modified commit message]
---
  arch/arm/boot/dts/Makefile                 |   1 +
  arch/arm/boot/dts/at91-cosino.dtsi         | 121 +++++++++++++++++++++++++++++
  arch/arm/boot/dts/at91-cosino_mega2560.dts |  84 ++++++++++++++++++++
  3 files changed, 206 insertions(+)

create mode 100644 arch/arm/boot/dts/at91-cosino.dtsi create mode 100644 arch/arm/boot/dts/at91-cosino_mega2560.dts

arch/arm/boot/dts/Makefile +1 -0
index ab6a9f5..b05f5e6 100644
@@ -35,6 +35,7 @@ dtb-$(CONFIG_ARCH_AT91) += at91sam9g25ek.dtb
  dtb-$(CONFIG_ARCH_AT91) += at91sam9g35ek.dtb
  dtb-$(CONFIG_ARCH_AT91) += at91sam9x25ek.dtb
  dtb-$(CONFIG_ARCH_AT91) += at91sam9x35ek.dtb
+dtb-$(CONFIG_ARCH_AT91) += at91-cosino_mega2560.dtb
  # sama5d3
  dtb-$(CONFIG_ARCH_AT91)	+= sama5d31ek.dtb
  dtb-$(CONFIG_ARCH_AT91)	+= sama5d33ek.dtb
arch/arm/boot/dts/at91-cosino.dtsi new file +121 -0
new file mode 100644
index 0000000..00e2112
@@ -0,0 +1,121 @@
+/*
+ * cosino.dtsi - Device Tree file for Cosino core module
+ *
+ * Copyright (C) 2013 - Rodolfo Giometti <[email protected]>
+ *			HCE Engineering
+ *
+ * Derived from at91sam9x5ek.dtsi by:
+ *	Copyright (C) 2012 Atmel,
+ *	2012 Nicolas Ferre <[email protected]>
+ *
+ * Licensed under GPLv2 or later.
+ */
+
+#include "at91sam9g35.dtsi"
+
+/ {
+	model = "HCE Cosino core module";
+	compatible = "hce,cosino", "atmel,at91sam9x5", "atmel,at91sam9";
+
+	chosen {
+		bootargs = "console=ttyS0,115200 root=/dev/mmcblk0p2 rw rootfstype=ext3 rootwait";
+	};
+
+	memory {
+		reg = <0x20000000 0x8000000>;
+	};
+
+	clocks {
+		#address-cells = <1>;
+		#size-cells = <1>;
+		ranges;
+
+		main_clock: clock at 0 {
+			compatible = "atmel,osc", "fixed-clock";
+			clock-frequency = <12000000>;
+		};
+	};
+
+	ahb {
+		apb {
+			mmc0: mmc at f0008000 {
+				pinctrl-0 = <
+					&pinctrl_board_mmc0
+					&pinctrl_mmc0_slot0_clk_cmd_dat0
+					&pinctrl_mmc0_slot0_dat1_3>;
+				status = "okay";
+				slot at 0 {
+					reg = <0>;
+					bus-width = <4>;
+					cd-gpios = <&pioD 15 GPIO_ACTIVE_HIGH>;
+				};
+			};
+
+			dbgu: serial at fffff200 {
+				status = "okay";
+			};
+
+			usart0: serial at f801c000 {
+				status = "okay";
+			};
+
+			i2c0: i2c at f8010000 {
+				status = "okay";
+			};
+
+			adc0: adc at f804c000 {
+				atmel,adc-clock-rate = <1000000>;
+				atmel,adc-ts-wires = <4>;
+				atmel,adc-ts-pressure-threshold = <10000>;
+				status = "okay";
+			};
+
+			pinctrl at fffff400 {
+				mmc0 {
+					pinctrl_board_mmc0: mmc0-board {
+						atmel,pins =
+							<AT91_PIOD 15 AT91_PERIPH_GPIO AT91_PINCTRL_PULL_UP_DEGLITCH>;	/* PD15 gpio CD pin pull up and deglitch */
+					};
+				};
+			};
+
+			watchdog at fffffe40 {
+				status = "okay";
+			};
+		};
+
+		nand0: nand at 40000000 {
+			nand-bus-width = <8>;
+			nand-ecc-mode = "hw";
+			atmel,has-pmecc;	/* Enable PMECC */
+			atmel,pmecc-cap = <4>;
+			atmel,pmecc-sector-size = <512>;
+			status = "okay";
+
+			at91bootstrap at 0 {
+				label = "at91bootstrap";
+				reg = <0x0 0x40000>;
+			};
+
+			uboot at 40000 {
+				label = "u-boot";
+				reg = <0x40000 0x80000>;
+			};
+
+			ubootenv at c0000 {
+				label = "U-Boot Env";
+				reg = <0xc0000 0x140000>;
+			};
+
+			kernel at 200000 {
+				label = "kernel";
+				reg = <0x200000 0x600000>;
+			};
+
+			rootfs at 800000 {
+				label = "rootfs";
+				reg = <0x800000 0x0f800000>;
+			};
+		};
+	};
+};
arch/arm/boot/dts/at91-cosino_mega2560.dts new file +84 -1
new file mode 100644
index 0000000..c29c53c
@@ -0,0 +1,84 @@
+/*
+ * cosino_mega2560.dts - Device Tree file for Cosino board with Mega 2560
+ *			 extension
+ *
+ * Copyright (C) 2013 - Rodolfo Giometti <[email protected]>
+ *			HCE Engineering
+ *
+ * Derived from at91sam9g35ek.dts by:
+ * 	Copyright (C) 2012 Atmel,
+ *      2012 Nicolas Ferre <[email protected]>
+ *
+ * Licensed under GPLv2 or later.
+ */
+
+/dts-v1/;
+#include "at91-cosino.dtsi"
+
+/ {
+	model = "HCE Cosino Mega 2560";
+	compatible = "hce,cosino_mega2560", "atmel,at91sam9x5", "atmel,at91sam9";
+
+	ahb {
+		apb {
+			macb0: ethernet at f802c000 {
+				phy-mode = "rmii";
+				status = "okay";
+			};
+
+			adc0: adc at f804c000 {
+				atmel,adc-clock-rate = <1000000>;
+				atmel,adc-ts-wires = <4>;
+				atmel,adc-ts-pressure-threshold = <10000>;
+				status = "okay";
+			};
+
+
+			tsadcc: tsadcc at f804c000 {
+				status = "okay";
+			};
+
+			rtc at fffffeb0 {
+				status = "okay";
+			};
+
+			usart1: serial at f8020000 {
+				status = "okay";
+			};
+
+			usart2: serial at f8024000 {
+				status = "okay";
+			};
+
+			usb2: gadget at f803c000 {
+				atmel,vbus-gpio = <&pioB 16 GPIO_ACTIVE_HIGH>;
+				status = "okay";
+			};
+
+			mmc1: mmc at f000c000 {
+				pinctrl-0 = <
+					&pinctrl_mmc1_slot0_clk_cmd_dat0
+					&pinctrl_mmc1_slot0_dat1_3>;
+				status = "okay";
+				slot at 0 {
+					reg = <0>;
+					bus-width = <4>;
+					non-removable;
+				};
+			};
+		};
+
+		usb0: ohci at 00600000 {
+			status = "okay";
+			num-ports = <3>;
+			atmel,vbus-gpio = <0 /* &pioD 18 GPIO_ACTIVE_LOW */
+					   &pioD 19 GPIO_ACTIVE_LOW
+					   &pioD 20 GPIO_ACTIVE_LOW
+					  >;
+		};
+
+		usb1: ehci at 00700000 {
+			status = "okay";
+		};
+	};
+};
--

1.8.1.2

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel at lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

Signature · 1 line
Nicolas Ferre