Skip to contentSkip to conversation

remove recursive call to migrate_disable in write_lock_bh

PATCH In review Nicholas Mc Guire 1 participant 2 messages Nov 20, 2013 – Nov 21, 2013 Locking primitives

lore
Share & tools
lore
#0 lore raw

PATCH 2/2 remove recursive call to migrate_disable in write_lock_bh

Quoted 1 line

From 19176ba9a8a83e4acf34d9739fa06d6c18fa957f Mon Sep 17 00:00:00 2001

From: Nicholas Mc Guire <[email protected]>
Date: Tue, 19 Nov 2013 23:33:10 -0500
Subject: [PATCH 2/2] remove recursive call to migrate_disable in write_lock_bh

write_lock_bh/write_unlock_bh calls local_bh_disable/enable which already does a migrate_disable/enable no need for this recursive call.

patch is on top of 3.12-rt2

No change of functionality

---
 include/linux/rwlock_rt.h |    2 --
 1 files changed, 0 insertions(+), 2 deletions(-)
include/linux/rwlock_rt.h +0 -2
index 87f5a1d..9a5fe26 100644
@@ -67,7 +67,6 @@ extern void __rt_rwlock_init(rwlock_t *rwlock, char *name, struct lock_class_key
 #define write_lock_bh(lock)				\
 	do {						\
 		local_bh_disable();			\
-		migrate_disable();			\
 		rt_write_lock(lock);			\
 	} while (0)
 
@@ -96,7 +95,6 @@ extern void __rt_rwlock_init(rwlock_t *rwlock, char *name, struct lock_class_key
 #define write_unlock_bh(lock)				\
 	do {						\
 		rt_write_unlock(lock);			\
-		migrate_enable();			\
 		local_bh_enable();			\
 	} while (0)
 
Signature · 1 line
1.7.2.5
#1 lore raw

Hi !

"[PATCH 2/2] remove recursive call to migrate_disable in write_lock_bh" seems to be blowing up in unpin_current_cpu - seems that I still did not get the dependencies between interleved write_lock_bh/read_unlock, read_unlock/write_lock_bh right...

thx!
hofrat