Skip to contentSkip to conversation

ARM: shmobile: Use ->init_late() on Lager

PATCH New Magnus Damm 2 participants 3 messages Nov 20, 2013 – Nov 21, 2013

Subsystems (4)
lore
Share & tools
lore

Magnus Damm

author maintainer
#0 lore raw

PATCH v2 1/1 ARM: shmobile: Use ->init_late() on Lager

From: Magnus Damm <[email protected]>

Hook in shmobile_init_late() on Lager V2. This enables some PM related things like CPUIdle and Suspend-to-RAM.

With this patch applied it is possible to use Suspend-to-RAM:

# echo enabled > /sys/class/tty/ttySC6/power/wakeup
# echo mem > /sys/power/state 
(wake by sending a character on the serial console)

---

Changes since V1:
- added missing include <mach/common.h> to DT reference code

Written on top of renesas.git renesas-devel-v3.12-20131119

 arch/arm/mach-shmobile/board-lager-reference.c |    2 ++
 arch/arm/mach-shmobile/board-lager.c           |    1 +
 2 files changed, 3 insertions(+)
arch/arm/mach-shmobile/board-lager-reference.c +2 -0
@@ -20,6 +20,7 @@
 
 #include <linux/init.h>
 #include <linux/of_platform.h>
+#include <mach/common.h>
 #include <mach/rcar-gen2.h>
 #include <mach/r8a7790.h>
 #include <asm/mach/arch.h>
@@ -41,5 +42,6 @@ DT_MACHINE_START(LAGER_DT, "lager")
 	.init_early	= r8a7790_init_early,
 	.init_time	= rcar_gen2_timer_init,
 	.init_machine	= lager_add_standard_devices,
+	.init_late	= shmobile_init_late,
 	.dt_compat	= lager_boards_compat_dt,
 MACHINE_END
arch/arm/mach-shmobile/board-lager.c +1 -0
@@ -259,5 +259,6 @@ DT_MACHINE_START(LAGER_DT, "lager")
 	.init_early	= r8a7790_init_early,
 	.init_time	= rcar_gen2_timer_init,
 	.init_machine	= lager_init,
+	.init_late	= shmobile_init_late,
 	.dt_compat	= lager_boards_compat_dt,
 MACHINE_END
#1 lore raw

PATCH v2 1/1 ARM: shmobile: Use ->init_late() on Lager

Quoted 42 lines · Magnus Damm

From: Magnus Damm <[email protected]>

Hook in shmobile_init_late() on Lager V2. This enables some PM related things like CPUIdle and Suspend-to-RAM.

With this patch applied it is possible to use Suspend-to-RAM:

# echo enabled > /sys/class/tty/ttySC6/power/wakeup
# echo mem > /sys/power/state 
(wake by sending a character on the serial console)

---

Changes since V1:
- added missing include <mach/common.h> to DT reference code

Written on top of renesas.git renesas-devel-v3.12-20131119

 arch/arm/mach-shmobile/board-lager-reference.c |    2 ++
 arch/arm/mach-shmobile/board-lager.c           |    1 +
 2 files changed, 3 insertions(+)
arch/arm/mach-shmobile/board-lager-reference.c +2 -0
@@ -20,6 +20,7 @@
 
 #include <linux/init.h>
 #include <linux/of_platform.h>
+#include <mach/common.h>
 #include <mach/rcar-gen2.h>
 #include <mach/r8a7790.h>
 #include <asm/mach/arch.h>
@@ -41,5 +42,6 @@ DT_MACHINE_START(LAGER_DT, "lager")
 	.init_early	= r8a7790_init_early,
 	.init_time	= rcar_gen2_timer_init,
 	.init_machine	= lager_add_standard_devices,
+	.init_late	= shmobile_init_late,
 	.dt_compat	= lager_boards_compat_dt,
 MACHINE_END

arch/arm/mach-shmobile/board-lager.c DT_MACHINE_START(LAGER_DT, "lager") · line 264

Quoted 6 lines
arch/arm/mach-shmobile/board-lager.c +1 -0
@@ -259,5 +259,6 @@ DT_MACHINE_START(LAGER_DT, "lager")
 	.init_early	= r8a7790_init_early,
 	.init_time	= rcar_gen2_timer_init,
 	.init_machine	= lager_init,
+	.init_late	= shmobile_init_late,
 	.dt_compat	= lager_boards_compat_dt,
 MACHINE_END

Thanks. I have manually applied the following onto the soc3 branch. Please check that it is correct.

Assuming all goes will I plan to push this and other updates today or tomorrow.

From: Magnus Damm <[email protected]>

[PATCH] ARM: shmobile: Use ->init_late() on Lager

Hook in shmobile_init_late() on Lager V2. This enables some PM related things like CPUIdle and Suspend-to-RAM.

With this patch applied it is possible to use Suspend-to-RAM:

# echo enabled > /sys/class/tty/ttySC6/power/wakeup
# echo mem > /sys/power/state
(wake by sending a character on the serial console)
---
 arch/arm/mach-shmobile/board-lager-reference.c | 2 ++
 arch/arm/mach-shmobile/board-lager.c           | 1 +
 2 files changed, 3 insertions(+)
arch/arm/mach-shmobile/board-lager-reference.c +2 -0
index 1a1a4a8..ea85527 100644
@@ -20,6 +20,7 @@
 
 #include <linux/init.h>
 #include <linux/of_platform.h>
+#include <mach/common.h>
 #include <mach/r8a7790.h>
 #include <asm/mach/arch.h>
 
@@ -42,5 +43,6 @@ DT_MACHINE_START(LAGER_DT, "lager")
 	.init_early	= r8a7790_init_early,
 	.init_time	= rcar_gen2_timer_init,
 	.init_machine	= lager_add_standard_devices,
+	.init_late	= shmobile_init_late,
 	.dt_compat	= lager_boards_compat_dt,
 MACHINE_END
arch/arm/mach-shmobile/board-lager.c +1 -0
index 32183a3..ff82576 100644
@@ -258,5 +258,6 @@ DT_MACHINE_START(LAGER_DT, "lager")
 	.init_early	= r8a7790_init_early,
 	.init_time	= rcar_gen2_timer_init,
 	.init_machine	= lager_init,
+	.init_late	= shmobile_init_late,
 	.dt_compat	= lager_boards_compat_dt,
 MACHINE_END
Signature · 1 line
1.8.4
#2 lore raw

PATCH v2 1/1 ARM: shmobile: Use ->init_late() on Lager

Quoted 54 lines · Simon Horman
Quoted 42 lines · Magnus Damm

From: Magnus Damm <[email protected]>

Hook in shmobile_init_late() on Lager V2. This enables some PM related things like CPUIdle and Suspend-to-RAM.

With this patch applied it is possible to use Suspend-to-RAM:

# echo enabled > /sys/class/tty/ttySC6/power/wakeup
# echo mem > /sys/power/state 
(wake by sending a character on the serial console)

---

Changes since V1:
- added missing include <mach/common.h> to DT reference code

Written on top of renesas.git renesas-devel-v3.12-20131119

 arch/arm/mach-shmobile/board-lager-reference.c |    2 ++
 arch/arm/mach-shmobile/board-lager.c           |    1 +
 2 files changed, 3 insertions(+)
arch/arm/mach-shmobile/board-lager-reference.c +2 -0
@@ -20,6 +20,7 @@
 
 #include <linux/init.h>
 #include <linux/of_platform.h>
+#include <mach/common.h>
 #include <mach/rcar-gen2.h>
 #include <mach/r8a7790.h>
 #include <asm/mach/arch.h>
@@ -41,5 +42,6 @@ DT_MACHINE_START(LAGER_DT, "lager")
 	.init_early	= r8a7790_init_early,
 	.init_time	= rcar_gen2_timer_init,
 	.init_machine	= lager_add_standard_devices,
+	.init_late	= shmobile_init_late,
 	.dt_compat	= lager_boards_compat_dt,
 MACHINE_END

arch/arm/mach-shmobile/board-lager.c DT_MACHINE_START(LAGER_DT, "lager") · line 264

Quoted 6 lines
arch/arm/mach-shmobile/board-lager.c +1 -0
@@ -259,5 +259,6 @@ DT_MACHINE_START(LAGER_DT, "lager")
 	.init_early	= r8a7790_init_early,
 	.init_time	= rcar_gen2_timer_init,
 	.init_machine	= lager_init,
+	.init_late	= shmobile_init_late,
 	.dt_compat	= lager_boards_compat_dt,
 MACHINE_END

Thanks. I have manually applied the following onto the soc3 branch. Please check that it is correct.

Quoted 2 lines

Assuming all goes will I plan to push this and other updates today or tomorrow.

Take II: I have applied your patch as is without any manual intervention.