Skip to contentSkip to conversation

seccomp: add kill() to the syscall whitelist

PATCH In review Paul Moore 2 participants 3 messages Nov 21, 2013 – Nov 26, 2013

lore
Share & tools
lore

Paul Moore

author
#0 lore raw

PATCH 1/1 seccomp: add kill() to the syscall whitelist

The kill() syscall is triggered with the following command:

 # qemu -sandbox on -monitor stdio \
        -device intel-hda -device hda-duplex -vnc :0

The resulting syslog/audit message:

 # ausearch -m SECCOMP
 ----
 time->Wed Nov 20 09:52:08 2013
 type=SECCOMP msg=audit(1384912328.482:6656): auid=0 uid=0 gid=0 ses=854
  subj=unconfined_u:unconfined_r:unconfined_t:s0-s0:c0.c1023 pid=12087
  comm="qemu-kvm" sig=31 syscall=62 compat=0 ip=0x7f7a1d2abc67 code=0x0
 # scmp_sys_resolver 62
 kill
---
 qemu-seccomp.c |    1 +
 1 file changed, 1 insertion(+)
qemu-seccomp.c +1 -0
index 69cee44..cf07869 100644
@@ -114,6 +114,7 @@ static const struct QemuSeccompSyscall seccomp_whitelist[] = {
     { SCMP_SYS(write), 244 },
     { SCMP_SYS(fcntl), 243 },
     { SCMP_SYS(tgkill), 242 },
+    { SCMP_SYS(kill), 242 },
     { SCMP_SYS(rt_sigaction), 242 },
     { SCMP_SYS(pipe2), 242 },
     { SCMP_SYS(munmap), 242 },
Reviewed-by on v1 1/1
#1 lore raw
Quoted 29 lines · Paul Moore

The kill() syscall is triggered with the following command:

  # qemu -sandbox on -monitor stdio \
         -device intel-hda -device hda-duplex -vnc :0

The resulting syslog/audit message:

  # ausearch -m SECCOMP
  ----
  time->Wed Nov 20 09:52:08 2013
  type=SECCOMP msg=audit(1384912328.482:6656): auid=0 uid=0 gid=0 ses=854
   subj=unconfined_u:unconfined_r:unconfined_t:s0-s0:c0.c1023 pid=12087
   comm="qemu-kvm" sig=31 syscall=62 compat=0 ip=0x7f7a1d2abc67 code=0x0
  # scmp_sys_resolver 62
  kill
---
  qemu-seccomp.c |    1 +
  1 file changed, 1 insertion(+)
qemu-seccomp.c +0 -0
index 69cee44..cf07869 100644

qemu-seccomp.c static const struct QemuSeccompSyscall seccomp_whitelist[] = { · line 120

Quoted 7 lines
qemu-seccomp.c +1 -0
@@ -114,6 +114,7 @@ static const struct QemuSeccompSyscall seccomp_whitelist[] = {
      { SCMP_SYS(write), 244 },
      { SCMP_SYS(fcntl), 243 },
      { SCMP_SYS(tgkill), 242 },
+    { SCMP_SYS(kill), 242 },
      { SCMP_SYS(rt_sigaction), 242 },
      { SCMP_SYS(pipe2), 242 },
      { SCMP_SYS(munmap), 242 },

ACK, Reviewed and tested.
(I'll send a pull request tomorrow EOD)

Signature · 2 lines
Eduardo Otubo
IBM Linux Technology Center
author
#2 lore raw
Quoted 38 lines · Eduardo Otubo
Quoted 37 lines · Paul Moore

The kill() syscall is triggered with the following command:

  # qemu -sandbox on -monitor stdio \

-device intel-hda -device hda-duplex -vnc :0

The resulting syslog/audit message:

  # ausearch -m SECCOMP
  ----
  time->Wed Nov 20 09:52:08 2013
  type=SECCOMP msg=audit(1384912328.482:6656): auid=0 uid=0 gid=0 ses=854
   subj=unconfined_u:unconfined_r:unconfined_t:s0-s0:c0.c1023 pid=12087
   comm="qemu-kvm" sig=31 syscall=62 compat=0 ip=0x7f7a1d2abc67 code=0x0
  # scmp_sys_resolver 62
  kill

---

  qemu-seccomp.c |    1 +
  1 file changed, 1 insertion(+)
qemu-seccomp.c +0 -0
index 69cee44..cf07869 100644
@@ -114,6 +114,7 @@ static const struct QemuSeccompSyscall

seccomp_whitelist[] = {>

      { SCMP_SYS(write), 244 },
      { SCMP_SYS(fcntl), 243 },
      { SCMP_SYS(tgkill), 242 },

+ { SCMP_SYS(kill), 242 },

Quoted 8 lines
Quoted 3 lines
      { SCMP_SYS(rt_sigaction), 242 },
      { SCMP_SYS(pipe2), 242 },
      { SCMP_SYS(munmap), 242 },

ACK, Reviewed and tested.
(I'll send a pull request tomorrow EOD)

Ping?

Signature · 2 lines
paul moore
security and virtualization @ redhat