Skip to contentSkip to conversation

xerces: add host

PATCH New Matt Weber 2 participants 6 messages Nov 21, 2013 – Apr 20, 2014

lore
Share & tools
lore

Matt Weber

author
#0 lore raw

PATCH 1/1 xerces: add host

---
 package/xerces/xerces.mk |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)
package/xerces/xerces.mk +1 -0
index 7bd7070..2e4c512 100644
@@ -25,3 +25,4 @@ XERCES_CONF_OPT += --disable-network
 endif
 
 $(eval $(autotools-package))
+$(eval $(host-autotools-package))
Signature · 1 line
1.7.1
#1 lore raw

PATCH 1/1 xerces: add host

Dear Matt Weber,

Quoted 5 lines · Matt Weber
---
 package/xerces/xerces.mk |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)

Yes, but why?

Thomas

Signature · 3 lines
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
#2 lore raw

PATCH 1/1 xerces: add host

Thomas Petazzoni <[email protected]> wrote on 11/21/2013 03:54:46 PM:

Quoted 8 lines

From: Thomas Petazzoni <[email protected]>
To: Matt Weber <[email protected]>
Cc: buildroot at busybox.net
Date: 11/21/2013 03:54 PM
Subject: Re: [Buildroot] [PATCH 1/1] xerces: add host

Dear Matt Weber,

Quoted 8 lines
Quoted 5 lines · Matt Weber
---
 package/xerces/xerces.mk |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)

Yes, but why?

Opps, should have included that.

I'm working on adding support for an older package called xalan that requires host-xerces.
However the build infrastructure in the xalan package is pretty bad and I'm not sure if I'll be
able to get it cleaned up to the point of posting a patch set. So for now, I've submitted
this patch to add host-xerces support to allow us to build the xalan package using
BR2_EXTERNAL until I get it hopefully cleaned up and submitted.

Quoted 6 lines

Thomas

Signature · 3 lines
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
#3 lore raw

PATCH 1/1 xerces: add host

Dear Matthew Weber,

Quoted 11 lines · Matthew Weber

Opps, should have included that.

I'm working on adding support for an older package called xalan that requires host-xerces.
However the build infrastructure in the xalan package is pretty bad and I'm not sure if I'll be
able to get it cleaned up to the point of posting a patch set. So for now, I've submitted
this patch to add host-xerces support to allow us to build the xalan package using
BR2_EXTERNAL until I get it hopefully cleaned up and submitted.

Hum, okay. I'm generally not a big fan on having the host variant of packages if they are not used by packages in Buildroot. I usually prefer when the host variant of package A is added as part of a patch set that allows adds package B, which depends on host-A. That being said, I do understand the idea of upstreaming what you can for now, and see later for the remaining things.

Best regards,

Thomas

Signature · 3 lines
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
#4 lore raw

PATCH 1/1 xerces: add host

Thomas Petazzoni <[email protected]> wrote on 11/22/2013 02:17:51 AM:

Quoted 6 lines

From: Thomas Petazzoni <[email protected]>
To: "Matthew Weber" <[email protected]>
Cc: buildroot at busybox.net
Date: 11/22/2013 02:17 AM
Subject: Re: [Buildroot] [PATCH 1/1] xerces: add host

Quoted 9 lines

Dear Matthew Weber,

Quoted 5 lines · Matthew Weber

Opps, should have included that.

I'm working on adding support for an older package called xalan that requires host-xerces.
However the build infrastructure in the xalan package is pretty bad

and

Quoted 8 lines
Quoted 7 lines

I'm not sure if I'll be
able to get it cleaned up to the point of posting a patch set. So for

now, I've submitted
this patch to add host-xerces support to allow us to build the xalan package using
BR2_EXTERNAL until I get it hopefully cleaned up and submitted.

Quoted 6 lines

Hum, okay. I'm generally not a big fan on having the host variant of packages if they are not used by packages in Buildroot. I usually prefer when the host variant of package A is added as part of a patch set that allows adds package B, which depends on host-A. That being said, I do understand the idea of upstreaming what you can for now, and see later for the remaining things.

I completely agree that it definitely isn't ideal. I'll work on getting the
out of tree package upstream'd and see how bad the package cross compile patch set ends up. The community around the xalan development is starting to get a little more active so I'll see what I can get updated in their next release.

Thanks for the feedback!
Matt

Quoted 8 lines

Best regards,

Thomas

Signature · 3 lines
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.busybox.net/pipermail/buildroot/attachments/20131122/e519273d/attachment.html>

#5 lore raw

PATCH 1/1 xerces: add host

In reply to Matt Weber

Dear Matt Weber,

Quoted 11 lines · Matt Weber
---
 package/xerces/xerces.mk |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)
package/xerces/xerces.mk +0 -0
index 7bd7070..2e4c512 100644

package/xerces/xerces.mk XERCES_CONF_OPT += --disable-network · line 28

Quoted 4 lines
package/xerces/xerces.mk +1 -0
@@ -25,3 +25,4 @@ XERCES_CONF_OPT += --disable-network
 endif
 
 $(eval $(autotools-package))
+$(eval $(host-autotools-package))

Since there is no package in mainline Buildroot that needs host-xerces and that you've never submitted the other packages you mentioned back in November, I've marked this patch as Rejected in Patchwork for now. Do not hesitate to resend it later, together with other patches making use of it.

Thanks!

Thomas

Signature · 3 lines
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com