pinctrl-baytrail: show pin label with the reset of the gpio debug data
Subsystems (2)
PATCH 1/1 pinctrl-baytrail: show pin label with the reset of the gpio debug data
The default gpiolib debug output shows pin labels.
We want baytrail custom debug output to have the same functionality.
Signed-off-by Mathias Nyman <[email protected]>
--- drivers/pinctrl/pinctrl-baytrail.c | 8 +++++++- 1 file changed, 7 insertions(+), 1 deletion(-)
drivers/pinctrl/pinctrl-baytrail.c +7 -1
@@ -286,13 +286,19 @@ static void byt_gpio_dbg_show(struct seq_file *s, struct gpio_chip *chip)spin_lock_irqsave (&vg->lock, flags);for (i =0 ; i < vg->chip.ngpio; i++) { +const char *label; offs = vg->range->pins[i] *16 ; conf0 =readl (vg->reg_base + offs +BYT_CONF0_REG ); val =readl (vg->reg_base + offs +BYT_VAL_REG ); + label =gpiochip_is_requested (chip, i); +if (!label) + label ="Unrequested" ; + seq_printf(s, - " gpio-%-3d %s %s %s pad-%-3d offset:0x%03x mux:%d %s%s%s\n", + " gpio-%-3d (%-20.20s) %s %s %s pad-%-3d offset:0x%03x mux:%d %s%s%s\n", i, + label, val & BYT_INPUT_EN ? " " : "in", val & BYT_OUTPUT_EN ? " " : "out", val & BYT_LEVEL ? "hi" : "lo",
Signature · 1 line
1.8.1.2
Quoted 4 lines · Mathias Nyman
The default gpiolib debug output shows pin labels.
We want baytrail custom debug output to have the same functionality.Signed-off-by Mathias Nyman <[email protected]>
Looks good to me,
Reviewed-by Mika Westerberg <[email protected]>
Quoted 4 lines · Mathias Nyman
The default gpiolib debug output shows pin labels.
We want baytrail custom debug output to have the same functionality.Signed-off-by Mathias Nyman <[email protected]>
Patch applied with Mika's tag.
Thanks!
Linus Walleij