ARM: at91: sama5d3: reduce TWI internal clock frequency
Subsystems (4)
PATCH v2 1/1 ARM: at91: sama5d3: reduce TWI internal clock frequency
From: Ludovic Desroches <[email protected]>
With some devices, transfer hangs during I2C frame transmission. This issue disappears when reducing the internal frequency of the TWI IP. Even if it is indicated that internal clock max frequency is 66MHz, it seems we have oversampling on I2C signals making TWI believe that a transfer in progress is done.
This fix has no impact on the I2C bus frequency.
---
v2: update commit message
arch/arm/mach-at91/sama5d3.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-)
arch/arm/mach-at91/sama5d3.c +3 -3
@@ -95,19 +95,19 @@ static struct clk twi0_clk = { .name = "twi0_clk", .pid = SAMA5D3_ID_TWI0, .type = CLK_TYPE_PERIPHERAL, - .div = AT91_PMC_PCR_DIV2, + .div = AT91_PMC_PCR_DIV8, };static struct clk twi1_clk = { .name ="twi1_clk" , .pid =SAMA5D3_ID_TWI1 , .type =CLK_TYPE_PERIPHERAL , - .div =AT91_PMC_PCR_DIV2 , + .div =AT91_PMC_PCR_DIV8 , };static struct clk twi2_clk = { .name ="twi2_clk" , .pid =SAMA5D3_ID_TWI2 , .type =CLK_TYPE_PERIPHERAL , - .div =AT91_PMC_PCR_DIV2 , + .div =AT91_PMC_PCR_DIV8 , };static struct clk mmc0_clk = { .name ="mci0_clk" ,
Signature · 1 line
1.7.9.5
PATCH v2 1/1 ARM: at91: sama5d3: reduce TWI internal clock frequency
Quoted 8 lines · ludovic.desroches at atmel.com
From: Ludovic Desroches <[email protected]>
With some devices, transfer hangs during I2C frame transmission. This issue disappears when reducing the internal frequency of the TWI IP. Even if it is indicated that internal clock max frequency is 66MHz, it seems we have oversampling on I2C signals making TWI believe that a transfer in progress is done.
Quoted 5 lines
This fix has no impact on the I2C bus frequency.
Cc <[email protected]> #3.10+Acked-by Nicolas Ferre <[email protected]>Signed-off-by Ludovic Desroches <[email protected]>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 836 bytes
Desc: Digital signature
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20131122/4e783c64/attachment.sig>
PATCH v2 1/1 ARM: at91: sama5d3: reduce TWI internal clock frequency
In reply to ludovic.desroches at atmel.comQuoted 7 lines · ludovic.desroches at atmel.com
From: Ludovic Desroches <[email protected]>
With some devices, transfer hangs during I2C frame transmission. This issue disappears when reducing the internal frequency of the TWI IP. Even if it is indicated that internal clock max frequency is 66MHz, it seems we have oversampling on I2C signals making TWI believe that a transfer in progress is done.
so now the IP run a 16MHz
you could also mention that now we save power too
Best Regards,
J.
Quoted 43 lines
This fix has no impact on the I2C bus frequency.
Cc <[email protected]> #3.10+Acked-by Nicolas Ferre <[email protected]>Signed-off-by Ludovic Desroches <[email protected]>---
v2: update commit message
arch/arm/mach-at91/sama5d3.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-)arch/arm/mach-at91/sama5d3.c +3
-3@@ -95,19 +95,19 @@ static struct clk twi0_clk = { .name = "twi0_clk", .pid = SAMA5D3_ID_TWI0, .type = CLK_TYPE_PERIPHERAL, - .div = AT91_PMC_PCR_DIV2, + .div = AT91_PMC_PCR_DIV8, };static struct clk twi1_clk = { .name ="twi1_clk" , .pid =SAMA5D3_ID_TWI1 , .type =CLK_TYPE_PERIPHERAL , - .div =AT91_PMC_PCR_DIV2 , + .div =AT91_PMC_PCR_DIV8 , };static struct clk twi2_clk = { .name ="twi2_clk" , .pid =SAMA5D3_ID_TWI2 , .type =CLK_TYPE_PERIPHERAL , - .div =AT91_PMC_PCR_DIV2 , + .div =AT91_PMC_PCR_DIV8 , };static struct clk mmc0_clk = { .name ="mci0_clk" ,Signature · 1 line
1.7.9.5
PATCH v2 1/1 ARM: at91: sama5d3: reduce TWI internal clock frequency
In reply to ludovic.desroches at atmel.comOn 22/11/2013 17:08, ludovic.desroches at atmel.com :
Quoted 8 lines
From: Ludovic Desroches <[email protected]>
With some devices, transfer hangs during I2C frame transmission. This issue disappears when reducing the internal frequency of the TWI IP. Even if it is indicated that internal clock max frequency is 66MHz, it seems we have oversampling on I2C signals making TWI believe that a transfer in progress is done.
Quoted 5 lines
This fix has no impact on the I2C bus frequency.
Cc <[email protected]> #3.10+Acked-by Nicolas Ferre <[email protected]>Signed-off-by Ludovic Desroches <[email protected]>
added to at91-3.14-dt branch.
thanks,
Quoted 35 lines
---
v2: update commit message
arch/arm/mach-at91/sama5d3.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-)arch/arm/mach-at91/sama5d3.c +3
-3@@ -95,19 +95,19 @@ static struct clk twi0_clk = { .name = "twi0_clk", .pid = SAMA5D3_ID_TWI0, .type = CLK_TYPE_PERIPHERAL, - .div = AT91_PMC_PCR_DIV2, + .div = AT91_PMC_PCR_DIV8, };static struct clk twi1_clk = { .name ="twi1_clk" , .pid =SAMA5D3_ID_TWI1 , .type =CLK_TYPE_PERIPHERAL , - .div =AT91_PMC_PCR_DIV2 , + .div =AT91_PMC_PCR_DIV8 , };static struct clk twi2_clk = { .name ="twi2_clk" , .pid =SAMA5D3_ID_TWI2 , .type =CLK_TYPE_PERIPHERAL , - .div =AT91_PMC_PCR_DIV2 , + .div =AT91_PMC_PCR_DIV8 , };static struct clk mmc0_clk = { .name ="mci0_clk" ,
Signature · 1 line
Nicolas Ferre
PATCH v2 1/1 ARM: at91: sama5d3: reduce TWI internal clock frequency
On 02/12/2013 09:42, Nicolas Ferre :
Quoted 9 lines
On 22/11/2013 17:08, ludovic.desroches at atmel.com :
Quoted 8 lines
From: Ludovic Desroches <[email protected]>
With some devices, transfer hangs during I2C frame transmission. This issue disappears when reducing the internal frequency of the TWI IP. Even if it is indicated that internal clock max frequency is 66MHz, it seems we have oversampling on I2C signals making TWI believe that a transfer in progress is done.
Quoted 7 lines
Quoted 5 lines
This fix has no impact on the I2C bus frequency.
Cc <[email protected]> #3.10+Acked-by Nicolas Ferre <[email protected]>Signed-off-by Ludovic Desroches <[email protected]>added to at91-3.14-dt branch.
No, sorry, it will go in at91-3.13-fixes!
Bye,
Quoted 37 lines
Quoted 35 lines
---
v2: update commit message
arch/arm/mach-at91/sama5d3.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-)arch/arm/mach-at91/sama5d3.c +3
-3@@ -95,19 +95,19 @@ static struct clk twi0_clk = { .name = "twi0_clk", .pid = SAMA5D3_ID_TWI0, .type = CLK_TYPE_PERIPHERAL, - .div = AT91_PMC_PCR_DIV2, + .div = AT91_PMC_PCR_DIV8, };static struct clk twi1_clk = { .name ="twi1_clk" , .pid =SAMA5D3_ID_TWI1 , .type =CLK_TYPE_PERIPHERAL , - .div =AT91_PMC_PCR_DIV2 , + .div =AT91_PMC_PCR_DIV8 , };static struct clk twi2_clk = { .name ="twi2_clk" , .pid =SAMA5D3_ID_TWI2 , .type =CLK_TYPE_PERIPHERAL , - .div =AT91_PMC_PCR_DIV2 , + .div =AT91_PMC_PCR_DIV8 , };static struct clk mmc0_clk = { .name ="mci0_clk" ,
Signature · 1 line
Nicolas Ferre