be2net: Avoid programming permenant MAC by BE3-R VFs
Subsystems (3)
PATCH 3/3 be2net: Avoid programming permenant MAC by BE3-R VFs
On BE3-R, the PF programs the initial MAC address for its VFs. Doing it again in VF probe, causes a FW error which although harmless generates an unnecessary error log message.
Signed-off-by Vasundhara Volam <[email protected]>
Signed-off-by Sathya Perla <[email protected]>
Signed-off-by Ajit Khaparde <[email protected]>
--- drivers/net/ethernet/emulex/benet/be.h | 1 + drivers/net/ethernet/emulex/benet/be_main.c | 10 ++++------ 2 files changed, 5 insertions(+), 6 deletions(-)
drivers/net/ethernet/emulex/benet/be.h +1 -0
@@ -503,6 +503,7 @@ struct be_adapter { };#define be_physfn (adapter) (!adapter->virtfn) +#define be_virtfn (adapter) (adapter->virtfn)#define sriov_enabled (adapter) (adapter->num_vfs > 0)#define sriov_want (adapter) (be_physfn(adapter) && \ (num_vfs || pci_num_vf(adapter->pdev)))
drivers/net/ethernet/emulex/benet/be_main.c +4 -6
@@ -3253,12 +3253,10 @@ static int be_mac_setup(struct be_adapter *adapter)memcpy (mac, adapter->netdev->dev_addr,ETH_ALEN ); } -/* On BE3 VFs this cmd may fail due to lack of privilege. -* Ignore the failure as in this case pmac_id is fetched -* in the IFACE_CREATE cmd. -*/ -be_cmd_pmac_add (adapter, mac, adapter->if_handle, - &adapter->pmac_id[0 ],0 ); +/* For BE3-R VFs, the PF programs the initial MAC address */ +if (!(BEx_chip (adapter) &&be_virtfn (adapter))) +be_cmd_pmac_add (adapter, mac, adapter->if_handle, + &adapter->pmac_id[0 ],0 );return 0 ; }
Signature · 1 line
1.8.1.2