Skip to contentSkip to conversation

configure: make --iasl option actually work

PATCH In review Michael S. Tsirkin 3 participants 3 messages Nov 24, 2013

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 configure: make --iasl option actually work

--iasl option was added to CC option parsing section by mistake, it's not effective there and attempts to use cause
an 'unknown option' error.

Fix this up.

---
 configure | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
configure +2 -2
index f6d5ccd..0592ba7 100755
@@ -272,8 +272,6 @@ for opt do
   ;;
   --cxx=*) CXX="$optarg"
   ;;
-  --iasl=*) iasl="$optarg"
-  ;;
   --source-path=*) source_path="$optarg"
   ;;
   --cpu=*) cpu="$optarg"
@@ -649,6 +647,8 @@ for opt do
   ;;
   --cxx=*)
   ;;
+  --iasl=*) iasl="$optarg"
+  ;;
   --objcc=*) objcc="$optarg"
   ;;
   --make=*) make="$optarg"
Signature · 1 line
MST
Tested-by on v1 1/1
#1 lore raw
Quoted 5 lines · Michael S. Tsirkin

--iasl option was added to CC option parsing section by mistake, it's not effective there and attempts to use cause
an 'unknown option' error.

Fix this up.

Now it works...

Quoted 28 lines
---
 configure | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
configure +2 -2
index f6d5ccd..0592ba7 100755
@@ -272,8 +272,6 @@ for opt do
   ;;
   --cxx=*) CXX="$optarg"
   ;;
-  --iasl=*) iasl="$optarg"
-  ;;
   --source-path=*) source_path="$optarg"
   ;;
   --cpu=*) cpu="$optarg"
@@ -649,6 +647,8 @@ for opt do
   ;;
   --cxx=*)
   ;;
+  --iasl=*) iasl="$optarg"
+  ;;
   --objcc=*) objcc="$optarg"
   ;;
   --make=*) make="$optarg"
Reviewed-by on v1 1/1
#2 lore raw
In reply to Michael S. Tsirkin

Am 24.11.2013 10:52, schrieb Michael S. Tsirkin:

Quoted 25 lines

--iasl option was added to CC option parsing section by mistake, it's not effective there and attempts to use cause
an 'unknown option' error.

Fix this up.

---
 configure | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
configure +0 -2
index f6d5ccd..0592ba7 100755
@@ -272,8 +272,6 @@ for opt do
   ;;
   --cxx=*) CXX="$optarg"
   ;;
-  --iasl=*) iasl="$optarg"
-  ;;
   --source-path=*) source_path="$optarg"
   ;;
   --cpu=*) cpu="$optarg"

configure for opt do · line 654

Quoted 8 lines
configure +2 -0
@@ -649,6 +647,8 @@ for opt do
   ;;
   --cxx=*)
   ;;
+  --iasl=*) iasl="$optarg"
+  ;;
   --objcc=*) objcc="$optarg"
   ;;
   --make=*) make="$optarg"

This is a trivial bug fix, so maybe it should be committed for QEMU 1.7. Therefore I changed the subject of the e-mail to include 'for 1.7'.

Regards,
Stefan