Skip to contentSkip to conversation

PPC64: Adding symbols in vmcoreinfo to facilitate dump filtering

PATCH New Hari Bathini 1 participant 1 message Nov 25, 2013 PowerPC

lore
Share & tools
lore
#0 lore raw

PATCH v2 1/1 PPC64: Adding symbols in vmcoreinfo to facilitate dump filtering

When CONFIG_SPARSEMEM_VMEMMAP option is set in kernel, makedumpfile tool fails to filter vmcore dump as it fails to do translations for vmemmap addresses that are mapped outside zone normal. For vmemmap adress translation support in this scenario, few kernel symbols are needed by dump filtering tool. This patch adds those symbols to vmcoreinfo, which a dump filtering tool can use for filtering the kernel dump. This changes are tested successfully with makedumpfile tool that supports vmemmap to physical address translation outside zone normal.

Changes from v1:
Updated patch decription and removed #ifdef around extern.

---
 arch/powerpc/include/asm/pgalloc-64.h |    2 ++
 arch/powerpc/kernel/machine_kexec.c   |   12 ++++++++++++
 2 files changed, 14 insertions(+)
arch/powerpc/include/asm/pgalloc-64.h +2 -0
index f65e27b..3973e62 100644
@@ -17,6 +17,8 @@ struct vmemmap_backing {
 	unsigned long virt_addr;
 };
 
+extern struct vmemmap_backing *vmemmap_list;
+
 /*
  * Functions that deal with pagetables that could be at any level of
  * the table need to be passed an "index_size" so they know how to
arch/powerpc/kernel/machine_kexec.c +12 -0
index e1ec57e..88a7fb4 100644
@@ -18,6 +18,7 @@
 #include <linux/ftrace.h>
 
 #include <asm/machdep.h>
+#include <asm/pgalloc.h>
 #include <asm/prom.h>
 #include <asm/sections.h>
 
@@ -75,6 +76,17 @@ void arch_crash_save_vmcoreinfo(void)
 #ifndef CONFIG_NEED_MULTIPLE_NODES
 	VMCOREINFO_SYMBOL(contig_page_data);
 #endif
+#if defined(CONFIG_PPC64) && defined(CONFIG_SPARSEMEM_VMEMMAP)
+	VMCOREINFO_SYMBOL(vmemmap_list);
+	VMCOREINFO_SYMBOL(mmu_vmemmap_psize);
+	VMCOREINFO_SYMBOL(mmu_psize_defs);
+	VMCOREINFO_STRUCT_SIZE(vmemmap_backing);
+	VMCOREINFO_OFFSET(vmemmap_backing, list);
+	VMCOREINFO_OFFSET(vmemmap_backing, phys);
+	VMCOREINFO_OFFSET(vmemmap_backing, virt_addr);
+	VMCOREINFO_STRUCT_SIZE(mmu_psize_def);
+	VMCOREINFO_OFFSET(mmu_psize_def, shift);
+#endif
 }
 
 /*