Skip to contentSkip to conversation

poco: fix sh4a fenv build failure

PATCH New Baruch Siach 3 participants 4 messages Nov 25, 2013 – Nov 26, 2013

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 poco: fix sh4a fenv build failure

Disable FP environment on sh4a. Fixes
http://autobuild.buildroot.net/results/8dc9bca5969d455cc30206fc1ae6e1d3ba6eb6ca/.

---
 package/poco/poco.mk | 5 +++++
 1 file changed, 5 insertions(+)
package/poco/poco.mk +5 -0
index a18f209..3516c04 100644
@@ -34,6 +34,11 @@ ifeq ($(LIBC),uclibc)
 POCO_CONF_OPT += --no-fpenvironment --no-wstring
 endif
 
+# sh4a is missing FE_DOWNWARD and FE_UPWARD in its fenv.h
+ifeq ($(BR2_sh4a),y)
+POCO_CONF_OPT += --no-fpenvironment
+endif
+
 define POCO_CONFIGURE_CMDS
 	(cd $(@D); ./configure \
 		--config=Linux-CrossEnv	\
Signature · 1 line
1.8.4.3
#1 lore raw

PATCH 1/1 poco: fix sh4a fenv build failure

Dear Baruch Siach,

Quoted 13 lines · Baruch Siach

Disable FP environment on sh4a. Fixes
http://autobuild.buildroot.net/results/8dc9bca5969d455cc30206fc1ae6e1d3ba6eb6ca/.

---
 package/poco/poco.mk | 5 +++++
 1 file changed, 5 insertions(+)
package/poco/poco.mk +0 -0
index a18f209..3516c04 100644

package/poco/poco.mk ifeq ($(LIBC),uclibc) · line 40

Quoted 7 lines
package/poco/poco.mk +4 -0
@@ -34,6 +34,11 @@ ifeq ($(LIBC),uclibc)
 POCO_CONF_OPT += --no-fpenvironment --no-wstring
 endif
 
+# sh4a is missing FE_DOWNWARD and FE_UPWARD in its fenv.h
+ifeq ($(BR2_sh4a),y)
+POCO_CONF_OPT += --no-fpenvironment
+endif

Just curious, is this (the fact that SH4 fenv.h lacks some definitions) something specific to uClibc, or something that is also true for glibc/eglibc?

Thanks!

Thomas

Signature · 3 lines
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
#2 lore raw

PATCH 1/1 poco: fix sh4a fenv build failure

Hi Thomas,

Quoted 19 lines · Thomas Petazzoni

Dear Baruch Siach,

Quoted 16 lines · Baruch Siach

Disable FP environment on sh4a. Fixes
http://autobuild.buildroot.net/results/8dc9bca5969d455cc30206fc1ae6e1d3ba6eb6ca/.

---
 package/poco/poco.mk | 5 +++++
 1 file changed, 5 insertions(+)
package/poco/poco.mk +0 -0
index a18f209..3516c04 100644
@@ -34,6 +34,11 @@ ifeq ($(LIBC),uclibc)
 POCO_CONF_OPT += --no-fpenvironment --no-wstring
 endif
 
Quoted 8 lines

package/poco/poco.mk ifeq ($(LIBC),uclibc) · line 40

Quoted 4 lines
package/poco/poco.mk +4 -0
+# sh4a is missing FE_DOWNWARD and FE_UPWARD in its fenv.h
+ifeq ($(BR2_sh4a),y)
+POCO_CONF_OPT += --no-fpenvironment
+endif

Just curious, is this (the fact that SH4 fenv.h lacks some definitions) something specific to uClibc, or something that is also true for glibc/eglibc?

This also affects (e)glibc. See
http://article.gmane.org/gmane.comp.lib.uclibc.buildroot/70784.

baruch

Signature · 3 lines
     http://baruch.siach.name/blog/                  ~. .~   Tk Open Systems
=}------------------------------------------------ooO--U--Ooo------------{=
   - baruch at tkos.co.il - tel: +972.2.679.5364, http://www.tkos.co.il -